Skip to contentSkip to conversation

iio: adc: gyroadc: fix uninitialized return code

PATCH Applied Arnd Bergmann 3 participants 3 messages Jul 18, 2019 – Jul 27, 2019

Subsystems (4)
Stable branch IIO Arm/RISC-V/Renesas architecture Renesas R-Car gyroadc driver
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH v2 1/1 iio: adc: gyroadc: fix uninitialized return code

gcc-9 complains about a blatant uninitialized variable use that all earlier compiler versions missed:

drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Return -EINVAL instead here and a few lines above it where we accidentally return 0 on failure.

Cc [email protected]
Fixes 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
Signed-off-by Arnd Bergmann <[email protected]>

---
v2: fix the second return code as well

---
 drivers/iio/adc/rcar-gyroadc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/rcar-gyroadc.c +2 -2
index 2d685730f867..c37f201294b2 100644
@@ -382,7 +382,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
 				dev_err(dev,
 					"Only %i channels supported with %pOFn, but reg = <%i>.\n",
 					num_channels, child, reg);
-				return ret;
+				return -EINVAL;
 			}
 		}
 

@@ -391,7 +391,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
 			dev_err(dev,
 				"Channel %i uses different ADC mode than the rest.\n",
 				reg);
-			return ret;
+			return -EINVAL;
 		}
 
 		/* Channel is valid, grab the regulator. */
Signature · 1 line
2.20.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 11 lines · Arnd Bergmann

gcc-9 complains about a blatant uninitialized variable use that all earlier compiler versions missed:

drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Return -EINVAL instead here and a few lines above it where we accidentally return 0 on failure.

Cc [email protected]
Fixes 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
Signed-off-by Arnd Bergmann <[email protected]>

Yes, I checked the other error paths, too, and they look proper to me.

Reviewed-by Wolfram Sang <[email protected]>
maintainer Applied
#2 lore raw
Quoted 9 lines · On Thu, 18 Jul 2019 16:02:27 +0200 Wolfram Sang <[email protected]> wrote:
Quoted 8 lines · Arnd Bergmann

gcc-9 complains about a blatant uninitialized variable use that all earlier compiler versions missed:

drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Return -EINVAL instead here and a few lines above it where we accidentally return 0 on failure.

Quoted 8 lines
Quoted 3 lines
Cc [email protected]
Fixes 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
Signed-off-by Arnd Bergmann <[email protected]>

Yes, I checked the other error paths, too, and they look proper to me.

Reviewed-by Wolfram Sang <[email protected]>

Thanks for sorting that second case as well.

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan