Collect all page_base_address bits for pte-further addresses
PATCH 1/1 Collect all page_base_address bits for pte-further addresses
The specification says to treat a PTE with the F bit set "like a PDE" which means that all but the lower 6 bits are part of the page base address. Indeed, in the wild a comment came back indicating that we were stripping off bits needed to properly fetch the next PTE.
Signed-off-by Tom St Denis <[email protected]>
--- src/lib/read_vram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
src/lib/read_vram.c +1 -1
@@ -654,7 +654,7 @@ pte_further:// decode PTE values pde_is_pte: - pte_fields.page_base_addr = pte_entry &0xFFFFFFFFF000ULL ; + pte_fields.page_base_addr = pte_entry &0xFFFFFFFFFFC0ULL ;// all but bottom 6 bits are PBA pte_fields.fragment = (pte_entry >>7 ) &0x1F ; pte_fields.system = (pte_entry >>1 ) &1 ; pte_fields.valid = pte_entry &1 ;
Signature · 6 lines
2.21.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx