i40e: Check if transceiver implements DDM before access
Subsystems (2)
PATCH 1/1 i40e: Check if transceiver implements DDM before access
Similar to the ixgbe issue fixed in:655c91414579 ("ixgbe: Check DDM existence in transceiver before access)
i40e has the same issue when reading eeprom from SFP's module that comply with SFF-8472 but not implement the Digital Diagnostic Monitoring (DDM) interface described in it. The existence of such area is specified by bit 6 of byte 92, set to 1 if implemented.
Without this patch, due to not checking this bit i40e fails to read SFP module's eeprom with the follow message:
ethtool -m enP51p1s0f0
Cannot get Module EEPROM data: Input/output error
Because it fails to read the additional 256 bytes in which it was assumed to exist the DDM data.
--- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++++++ drivers/net/ethernet/intel/i40e/i40e_type.h | 1 + 2 files changed, 7 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_ethtool.c +6 -0
@@ -5123,6 +5123,12 @@ static int i40e_get_module_info(struct net_device *netdev,/* Module is not SFF-8472 compliant */ modinfo->type =ETH_MODULE_SFF_8079 ; modinfo->eeprom_len =ETH_MODULE_SFF_8079_LEN ; + }else if (!(sff8472_swap &I40E_MODULE_SFF_DDM_IMPLEMENTED )) { +/* Module is SFF-8472 compliant but doesn't implemend Digital Diagnostic +* Monitoring (DDM). +*/ + modinfo->type =ETH_MODULE_SFF_8079 ; + modinfo->eeprom_len =ETH_MODULE_SFF_8079_LEN ; }else { modinfo->type =ETH_MODULE_SFF_8472 ; modinfo->eeprom_len =ETH_MODULE_SFF_8472_LEN ;
drivers/net/ethernet/intel/i40e/i40e_type.h +1 -0
@@ -443,6 +443,7 @@ struct i40e_nvm_access {#define I40E_MODULE_SFF_8472_COMP 0x5E#define I40E_MODULE_SFF_8472_SWAP 0x5C#define I40E_MODULE_SFF_ADDR_MODE 0x04 +#define I40E_MODULE_SFF_DDM_IMPLEMENTED 0x40#define I40E_MODULE_TYPE_QSFP_PLUS 0x0D#define I40E_MODULE_TYPE_QSFP28 0x11#define I40E_MODULE_QSFP_MAX_LEN 640
Signature · 1 line
2.21.0
Bowers
PATCH 1/1 i40e: Check if transceiver implements DDM before access
Quoted 24 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Mauro S. M. Rodrigues
Sent: Thursday, July 18, 2019 10:52 AM
To: intel-wired-lan at lists.osuosl.org; Kirsher, Jeffrey T <[email protected]>
Cc: wangyugui at e16-tech.com
Subject: [Intel-wired-lan] [PATCH] i40e: Check if transceiver implements DDM before accessSimilar to the ixgbe issue fixed in:
655c91414579("ixgbe: Check DDM existence in transceiver before access)i40e has the same issue when reading eeprom from SFP's module that comply with SFF-8472 but not implement the Digital Diagnostic Monitoring (DDM) interface described in it. The existence of such area is specified by bit 6 of byte 92, set to 1 if implemented.
Without this patch, due to not checking this bit i40e fails to read SFP module's eeprom with the follow message:
ethtool -m enP51p1s0f0
Cannot get Module EEPROM data: Input/output error
Quoted 8 lines
Because it fails to read the additional 256 bytes in which it was assumed to exist the DDM data.
Signed-off-by "Mauro S. M. Rodrigues" <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++++++ drivers/net/ethernet/intel/i40e/i40e_type.h | 1 + 2 files changed, 7 insertions(+)