Skip to contentSkip to conversation

mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies

PATCH Applied Vignesh Raghavendra 2 participants 3 messages Jul 19, 2019 – Aug 5, 2019

Subsystems (2)
lore
Share & tools
lore

Vignesh Raghavendra

author maintainer
#0 lore raw

PATCH 1/1 mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies

On x86_64, when CONFIG_OF is not disabled:

WARNING: unmet direct dependencies detected for MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && (OF [=n] || COMPILE_TEST [=n]) Selected by [y]:
- HBMC_AM654 [=y] && MTD [=y] && MTD_HYPERBUS [=y]

due to
config HBMC_AM654
tristate "HyperBus controller driver for AM65x SoC" select MULTIPLEXER
select MUX_MMIO

Fix this by making HBMC_AM654 imply MUX_MMIO instead of select so that dependencies are taken care of. MUX_MMIO is optional for functioning of driver.

Fixes b07079f1642c ("mtd: hyperbus: Add driver for TI's HyperBus memory controller")
---
 drivers/mtd/hyperbus/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/hyperbus/Kconfig +1 -1
index cff6bbd226f5..1c691df8eff7 100644
@@ -15,7 +15,7 @@ if MTD_HYPERBUS
 config HBMC_AM654
 	tristate "HyperBus controller driver for AM65x SoC"
 	select MULTIPLEXER
-	select MUX_MMIO
+	imply MUX_MMIO
 	help
 	 This is the driver for HyperBus controller on TI's AM65x and
 	 other SoCs
Signature · 1 line
2.22.0
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Vignesh Raghavendra

On x86_64, when CONFIG_OF is not disabled:

WARNING: unmet direct dependencies detected for MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && (OF [=n] || COMPILE_TEST [=n]) Selected by [y]:
- HBMC_AM654 [=y] && MTD [=y] && MTD_HYPERBUS [=y]

due to
config HBMC_AM654
tristate "HyperBus controller driver for AM65x SoC" select MULTIPLEXER
select MUX_MMIO

Quoted 7 lines

Fix this by making HBMC_AM654 imply MUX_MMIO instead of select so that dependencies are taken care of. MUX_MMIO is optional for functioning of driver.

Fixes b07079f1642c ("mtd: hyperbus: Add driver for TI's HyperBus memory controller")

Thanks.

Quoted 18 lines
---
 drivers/mtd/hyperbus/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/hyperbus/Kconfig +1 -1
index cff6bbd226f5..1c691df8eff7 100644
@@ -15,7 +15,7 @@ if MTD_HYPERBUS
 config HBMC_AM654
 	tristate "HyperBus controller driver for AM65x SoC"
 	select MULTIPLEXER
-	select MUX_MMIO
+	imply MUX_MMIO
 	help
 	 This is the driver for HyperBus controller on TI's AM65x and
 	 other SoCs
Signature · 5 lines
~Randy

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
author maintainer Applied
#2 lore raw
In reply to Vignesh Raghavendra
Quoted 13 lines · Vignesh Raghavendra

On x86_64, when CONFIG_OF is not disabled:

WARNING: unmet direct dependencies detected for MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && (OF [=n] || COMPILE_TEST [=n]) Selected by [y]:
- HBMC_AM654 [=y] && MTD [=y] && MTD_HYPERBUS [=y]

due to
config HBMC_AM654
tristate "HyperBus controller driver for AM65x SoC" select MULTIPLEXER
select MUX_MMIO

Quoted 7 lines

Fix this by making HBMC_AM654 imply MUX_MMIO instead of select so that dependencies are taken care of. MUX_MMIO is optional for functioning of driver.

Fixes b07079f1642c ("mtd: hyperbus: Add driver for TI's HyperBus memory controller")

Applied to mtd/fixes.

Quoted 17 lines
 drivers/mtd/hyperbus/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/hyperbus/Kconfig +1 -1
index cff6bbd226f5..1c691df8eff7 100644
@@ -15,7 +15,7 @@ if MTD_HYPERBUS
 config HBMC_AM654
 	tristate "HyperBus controller driver for AM65x SoC"
 	select MULTIPLEXER
-	select MUX_MMIO
+	imply MUX_MMIO
 	help
 	 This is the driver for HyperBus controller on TI's AM65x and
 	 other SoCs
Signature · 2 lines
Regards
Vignesh