Skip to contentSkip to conversation

extcon: sm5502: Add IRQ_ONESHOT

PATCH Applied Vasyl Gomonovych 2 participants 2 messages Jul 19, 2019 – Jul 24, 2019 External connector subsystem (extcon)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 extcon: sm5502: Add IRQ_ONESHOT

Do not fire irq again until thread done

---
Can you please look on this from false positives point of view

---
 drivers/extcon/extcon-sm5502.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon-sm5502.c +1 -1
index 98e4f616b8f1..dc43847ad2b0 100644
@@ -597,7 +597,7 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c,
 
 		ret = devm_request_threaded_irq(info->dev, virq, NULL,
 						sm5502_muic_irq_handler,
-						IRQF_NO_SUSPEND,
+						IRQF_NO_SUSPEND | IRQF_ONESHOT,
 						muic_irq->name, info);
 		if (ret) {
 			dev_err(info->dev,
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 15 lines · Vasyl Gomonovych

Do not fire irq again until thread done

---
Can you please look on this from false positives point of view

---
 drivers/extcon/extcon-sm5502.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon-sm5502.c +0 -0
index 98e4f616b8f1..dc43847ad2b0 100644

drivers/extcon/extcon-sm5502.c static int sm5022_muic_i2c_probe(struct i2c_client *i2c, · line 603

Quoted 8 lines
drivers/extcon/extcon-sm5502.c +1 -1
@@ -597,7 +597,7 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c,
 
 		ret = devm_request_threaded_irq(info->dev, virq, NULL,
 						sm5502_muic_irq_handler,
-						IRQF_NO_SUSPEND,
+						IRQF_NO_SUSPEND | IRQF_ONESHOT,
 						muic_irq->name, info);
 		if (ret) {
 			dev_err(info->dev,

Applied it. Thanks.

Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics