ARM: dts: aspeed: swift: Fix FSI GPIOs
Subsystems (2)
PATCH 1/1 ARM: dts: aspeed: swift: Fix FSI GPIOs
From: Matt Spinler <[email protected]>
Change the FSI clock and data GPIOs to match what the hardware turned out to use.
--- arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/aspeed-bmc-opp-swift.dts +2 -2
@@ -207,8 +207,8 @@ #size-cells = <0>; no-gpio-delays; - clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>; - data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>; + clock-gpios = <&gpio ASPEED_GPIO(P, 1) GPIO_ACTIVE_HIGH>; + data-gpios = <&gpio ASPEED_GPIO(P, 2) GPIO_ACTIVE_HIGH>; mux-gpios = <&gpio ASPEED_GPIO(P, 4) GPIO_ACTIVE_HIGH>; enable-gpios = <&gpio ASPEED_GPIO(P, 0) GPIO_ACTIVE_HIGH>; trans-gpios = <&gpio ASPEED_GPIO(P, 3) GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.22.0
PATCH 1/1 ARM: dts: aspeed: swift: Fix FSI GPIOs
Quoted 7 lines · Matt Spinler
From: Matt Spinler <[email protected]>
Change the FSI clock and data GPIOs to match what the hardware turned out to use.
Signed-off-by Matt Spinler <[email protected]>
Hi,
This is not a comment on this patch specifically, just an overall request for people to adjust how they post patches:
When running get_maintainer.pl on arch/arm/boot/dts/aspeed-bmc-opp-swift.dts, I get the following:
[...]
linux-arm-kernel at lists.infradead.org (moderated list:ARM/ASPEED MACHINE SUPPORT) linux-aspeed at lists.ozlabs.org (moderated list:ARM/ASPEED MACHINE SUPPORT) [...]
Please include both of them on patches. Lots of people aren't subscribed to the aspeed-only mailing list, so coming back later to reply to a patch is hard when it hasn't made it into your mailboxes.
Thanks!
-Olof
PATCH 1/1 ARM: dts: aspeed: swift: Fix FSI GPIOs
In reply to Matt SpinlerQuoted 6 lines · Matt Spinler
From: Matt Spinler <[email protected]>
Change the FSI clock and data GPIOs to match what the hardware turned out to use.
Signed-off-by Matt Spinler <[email protected]>
And yeah, please make sure to include relevant lists in the future as Olof mentioned.
Andrew
Quoted 24 lines
--- arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/aspeed-bmc-opp-swift.dts +2
-2@@ -207,8 +207,8 @@ #size-cells = <0>; no-gpio-delays; - clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>; - data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>; + clock-gpios = <&gpio ASPEED_GPIO(P, 1) GPIO_ACTIVE_HIGH>; + data-gpios = <&gpio ASPEED_GPIO(P, 2) GPIO_ACTIVE_HIGH>; mux-gpios = <&gpio ASPEED_GPIO(P, 4) GPIO_ACTIVE_HIGH>; enable-gpios = <&gpio ASPEED_GPIO(P, 0) GPIO_ACTIVE_HIGH>; trans-gpios = <&gpio ASPEED_GPIO(P, 3) GPIO_ACTIVE_HIGH>;Signature · 1 line
2.22.0
PATCH 1/1 ARM: dts: aspeed: swift: Fix FSI GPIOs
Quoted 9 lines · Andrew Jeffery
Quoted 6 lines · Matt Spinler
From: Matt Spinler <[email protected]>
Change the FSI clock and data GPIOs to match what the hardware turned out to use.
Signed-off-by Matt Spinler <[email protected]>Reviewed-by Andrew Jeffery <[email protected]>
Schematics have been updated.
Quoted 30 lines
And yeah, please make sure to include relevant lists in the future as Olof mentioned.
Andrew
Quoted 24 lines
--- arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/aspeed-bmc-opp-swift.dts +2
-3@@ -207,8 +207,8 @@ #size-cells = <0>; no-gpio-delays; - clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>; - data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>; + clock-gpios = <&gpio ASPEED_GPIO(P, 1) GPIO_ACTIVE_HIGH>; + data-gpios = <&gpio ASPEED_GPIO(P, 2) GPIO_ACTIVE_HIGH>; mux-gpios = <&gpio ASPEED_GPIO(P, 4) GPIO_ACTIVE_HIGH>; enable-gpios = <&gpio ASPEED_GPIO(P, 0) GPIO_ACTIVE_HIGH>; trans-gpios = <&gpio ASPEED_GPIO(P, 3) GPIO_ACTIVE_HIGH>; --2.22.0