nvme-tcp: cleanup nvme_tcp_recv_pdu
Sagi Grimberg
maintainerPATCH 1/1 nvme-tcp: cleanup nvme_tcp_recv_pdu
Can return directly in the switch statement
Signed-off-by Sagi Grimberg <sagi at grimberg.me>
--- drivers/nvme/host/tcp.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/nvme/host/tcp.c +3 -8
@@ -611,23 +611,18 @@ static int nvme_tcp_recv_pdu(struct nvme_tcp_queue *queue, struct sk_buff *skb,switch (hdr->type) {case nvme_tcp_c2h_data: - ret =nvme_tcp_handle_c2h_data (queue, (void *)queue->pdu); -break ; +return nvme_tcp_handle_c2h_data (queue, (void *)queue->pdu);case nvme_tcp_rsp:nvme_tcp_init_recv_ctx (queue); - ret =nvme_tcp_handle_comp (queue, (void *)queue->pdu); -break ; +return nvme_tcp_handle_comp (queue, (void *)queue->pdu);case nvme_tcp_r2t:nvme_tcp_init_recv_ctx (queue); - ret =nvme_tcp_handle_r2t (queue, (void *)queue->pdu); -break ; +return nvme_tcp_handle_r2t (queue, (void *)queue->pdu);default :dev_err (queue->ctrl->ctrl.device,"unsupported pdu type (%d)\n" , hdr->type);return -EINVAL ; } - -return ret; }static inline void nvme_tcp_end_request (struct request *rq,u16 status)
Signature · 1 line
2.17.1
PATCH 1/1 nvme-tcp: cleanup nvme_tcp_recv_pdu
Quoted 26 lines · Sagi Grimberg
Can return directly in the switch statement
Signed-off-by Sagi Grimberg <sagi at grimberg.me>--- drivers/nvme/host/tcp.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)drivers/nvme/host/tcp.c +2
-5@@ -611,23 +611,18 @@ static int nvme_tcp_recv_pdu(struct nvme_tcp_queue *queue, struct sk_buff *skb,switch (hdr->type) {case nvme_tcp_c2h_data: - ret =nvme_tcp_handle_c2h_data (queue, (void *)queue->pdu); -break ; +return nvme_tcp_handle_c2h_data (queue, (void *)queue->pdu);case nvme_tcp_rsp:nvme_tcp_init_recv_ctx (queue); - ret =nvme_tcp_handle_comp (queue, (void *)queue->pdu); -break ; +return nvme_tcp_handle_comp (queue, (void *)queue->pdu);case nvme_tcp_r2t:nvme_tcp_init_recv_ctx (queue); - ret =nvme_tcp_handle_r2t (queue, (void *)queue->pdu);
drivers/nvme/host/tcp.c static int nvme_tcp_recv_pdu(struct nvme_tcp_queue *queue, struct sk_buff *skb, · line 626
Quoted 10 lines
drivers/nvme/host/tcp.c +1
-3-break ; +return nvme_tcp_handle_r2t (queue, (void *)queue->pdu);default :dev_err (queue->ctrl->ctrl.device,"unsupported pdu type (%d)\n" , hdr->type);return -EINVAL ; } - -return ret; }
For the non-functional changes here by early-return:
Reviewed-by Minwoo Im <minwoo.im.dev at gmail.com>