clk: Port Linux common clock framework [CCF] to U-boot (tag: v5.1.12)
Subsystems (3)
v5 cover clk: Port Linux common clock framework [CCF] to U-boot (tag: v5.1.12)
This patch series brings the files from Linux kernel (SHA1: 5752b50477da Linux 5.1.12 to provide clocks support as it is used on the Linux kernel with Common Clock Framework [CCF] setup.
This series also fixes several problems with current clocks and provides sandbox tests for functions added to clk-uclass.c file.
CCF impact to U-Boot size:
--------------------------
SPL U-Boot.img
Without CCF: 51 KiB 358 KiB
With CCF: 55 KiB 363 KiB
Size increase: 1.3% 7.2%
The SPL implementation is not yet optimized (no OF_PLATDATA, etc).
Repository:
https://github.com/lmajewski/u-boot-dfu/commits/CCF-v5
Applicable on top of u-boot/master:
SHA1: 77f6e2dd0551d8a825bab391a1bd6b838874bcd4
Travis-CI:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/549603356
Changes in v6:
- Use dev->uclass_priv pointer to store pointer to clk
Changes in v5:
- s/U-boot/U-Boot/g
- Update Linux version to 5.1.12
- Add paragraph regarding sandbox CCF testing (common uclass code)
- Use long long to store rate value (to avoid int overflow and also return errors correctly)
- Use u32 to avoid checkpatch warning
- s/U-boot/U-Boot/g
- Replace dev->driver_data with dev_get_clk_ptr() wrapper on uclass_priv
- Replace ulong with long long (to accommodate large freqs and return errors)
- s/U-boot/U-Boot/g
- Check if the relevant code has changed between Linux tag v5.0-rc3 and v5.1.12 (no changes - the version can be safely updated).
- Use imply CLK_IMX6Q in Kconfig for (SPL_)CCF
- Fix clk-fixed-factor implementation (kzalloc needed for correct Sandbox operation)
- Fix gate2 implementation
- Use dev->uclass_priv instead of dev->driver_data to store back pointer to the struct clk.
- Split and introduce earlier the clk-provider.h header file
Changes in v4:
- New patch
- Port some more Linux code to facilitate imx8 code porting (most notably flags)
- Explicitly use container_of() based macro to provide struct clk in various places (e.g. gate2, mux, etc)
Following patches has been squashed:
http://patchwork.ozlabs.org/patch/1093141/
http://patchwork.ozlabs.org/patch/1093142/
http://patchwork.ozlabs.org/patch/1093146/
Changes in v3:
- New patch
- The rate information is now cached into struct clk field
- The clk_get_parent() is used to get pointer to the parent struct clk
- Replace -ENODEV with -ENOENT
- Use **clkp instead of **c
- Replace dev->driver_data with dev_get_clk_ptr() wrapper on uclas_priv
Lukasz Majewski (18):
clk: doc: Add documentation entry for Common Clock Framework [CCF]
(i.MX)
dm: Fix documentation entry as there is no UCLASS_CLOCK uclass
clk: Remove clock ID check in .get_rate() of clk_fixed_*
clk: Extend struct clk to provide information regarding clock rate
clk: Extend struct clk to provide clock type agnostic flags
clk: Provide struct clk for fixed rate clock (clk_fixed_rate.c)
clk: Introduce clk-provider.h to store Common Clock Framework's
internals
dm: clk: Define clk_get_parent() for clk operations
dm: clk: Define clk_get_parent_rate() for clk operations
dm: clk: Define clk_get_by_id() for clk operations
clk: Port Linux common clock framework [CCF] for imx6q to U-boot (tag:
v5.1.12) dm: clk: Extend clk_get_parent_rate() to support CLK_GET_RATE_NOCACHE
flag
dts: sandbox: Add 'osc' clock for Common Clock Framework [CCF] testing
clk: sandbox: Adjust clk-divider to emulate reading its value from HW
clk: sandbox: Adjust clk-mux.c to emulate reading divider value from
HW
clk: sandbox: Add sandbox test code for Common Clock Framework [CCF]
defconfig: sandbox: Enable SANDBOX_CLK_CCF to reuse generic CCF code
clk: Add MAINTAINERS entry for clocks (./drivers/clk/)
MAINTAINERS | 7 ++ arch/sandbox/dts/test.dts | 10 ++ configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 1 + doc/imx/clk/ccf.txt | 101 ++++++++++++++++++++ drivers/clk/Kconfig | 22 +++++ drivers/clk/Makefile | 3 + drivers/clk/clk-divider.c | 155 +++++++++++++++++++++++++++++++ drivers/clk/clk-fixed-factor.c | 80 ++++++++++++++++ drivers/clk/clk-mux.c | 172 ++++++++++++++++++++++++++++++++++ drivers/clk/clk-uclass.c | 60 ++++++++++++ drivers/clk/clk.c | 57 ++++++++++++ drivers/clk/clk_fixed_factor.c | 3 - drivers/clk/clk_fixed_rate.c | 8 +- drivers/clk/clk_sandbox_ccf.c | 185 +++++++++++++++++++++++++++++++++++++ drivers/clk/imx/Kconfig | 16 ++++ drivers/clk/imx/Makefile | 2 + drivers/clk/imx/clk-gate2.c | 103 +++++++++++++++++++++ drivers/clk/imx/clk-imx6q.c | 179 +++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk-pfd.c | 90 ++++++++++++++++++ drivers/clk/imx/clk-pllv3.c | 82 ++++++++++++++++ drivers/clk/imx/clk.h | 69 ++++++++++++++ include/clk.h | 37 +++++++- include/linux/clk-provider.h | 132 ++++++++++++++++++++++++++ include/sandbox-clk.h | 76 +++++++++++++++ test/dm/Makefile | 2 +- test/dm/clk_ccf.c | 62 +++++++++++++ 27 files changed, 1707 insertions(+), 8 deletions(-) create mode 100644 doc/imx/clk/ccf.txt create mode 100644 drivers/clk/clk-divider.c create mode 100644 drivers/clk/clk-fixed-factor.c create mode 100644 drivers/clk/clk-mux.c create mode 100644 drivers/clk/clk.c create mode 100644 drivers/clk/clk_sandbox_ccf.c create mode 100644 drivers/clk/imx/clk-gate2.c create mode 100644 drivers/clk/imx/clk-imx6q.c create mode 100644 drivers/clk/imx/clk-pfd.c create mode 100644 drivers/clk/imx/clk-pllv3.c create mode 100644 drivers/clk/imx/clk.h create mode 100644 include/linux/clk-provider.h create mode 100644 include/sandbox-clk.h create mode 100644 test/dm/clk_ccf.c
Signature · 1 line
2.11.0
PATCH v5 1/18 clk: doc: Add documentation entry for Common Clock Framework [CCF] (i.MX)
This patch describes the design decisions considerations and taken approach for porting in a separate documentation entry.
---
Changes in v6: None
Changes in v5:
- s/U-boot/U-Boot/g
- Update Linux version to 5.1.12
- Add paragraph regarding sandbox CCF testing (common uclass code)
Changes in v4:
- New patch
Changes in v3: None
doc/imx/clk/ccf.txt | 101 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+) create mode 100644 doc/imx/clk/ccf.txt
doc/imx/clk/ccf.txt new file +101 -0
@@ -0,0 +1,101 @@ +Introduction: +============= + +This documentation entry describes the Common Clock Framework [CCF] +port from Linux kernel (v5.1.12) to U-Boot. + +This code is supposed to bring CCF to IMX based devices (imx6q, imx7 +imx8). Moreover, it also provides some common clock code, which would +allow easy porting of CCF Linux code to other platforms. + +Design decisions: +================= + +* U-Boot's driver model [DM] for clk differs from Linux CCF. The most + notably difference is the lack of support for hierarchical clocks and + "clock as a manager driver" (single clock DTS node acts as a starting + point for all other clocks). + +* The clk_get_rate() caches the previously read data if CLK_GET_RATE_NOCACHE + is not set (no need for recursive access). + +* On purpose the "manager" clk driver (clk-imx6q.c) is not using large + table to store pointers to clocks - e.g. clk[IMX6QDL_CLK_USDHC2_SEL] = .... + Instead we use udevice's linked list for the same class (UCLASS_CLK). + + Rationale: + ---------- + When porting the code as is from Linux, one would need ~1KiB of RAM to + store it. This is way too much if we do plan to use this driver in SPL. + +* The "central" structure of this patch series is struct udevice and its + uclass_priv field contains the struct clk pointer (to the originally created + one). + +* Up till now U-Boot's driver model (DM) CLK operates on udevice (main + access to clock is by udevice ops) + In the CCF the access to struct clk (embodying pointer to *dev) is + possible via dev_get_clk_ptr() (it is a wrapper on dev_get_uclass_priv()). + +* To keep things simple the struct udevice's uclass_priv pointer is used to + store back pointer to corresponding struct clk. However, it is possible to + modify clk-uclass.c file and add there struct uc_clk_priv, which would have + clock related members (like pointer to clk). As of this writing there is no + such need, so to avoid extra allocations (as it can be auto allocated by + setting .per_device_auto_alloc_size = sizeof(struct uc_clk_priv)) the + uclass_priv stores the pointer to struct clk. + +* It is advised to add common clock code (like already added rate and flags) to + the struct clk, which is a top level description of the clock. + +* U-Boot's driver model already provides the facility to automatically allocate + (via private_alloc_size) device private data (accessible via dev->priv). + It may look appealing to use this feature to allocate private structures for + CCF clk devices e.g. divider (struct clk_divider *divider) for IMX6Q clock. + + The above feature had not been used for following reasons: + - The original CCF Linux kernel driver is the "manager" for clocks - it + decides when clock is instantiated (and when memory for it is allocated). + + - Using it would change the original structure of the CCF code. + + - To bind (via clk_register()) the clock device with U-Boot driver model we + first need udevice for it (the "chicken and egg problem"). + +* I've added the clk_get_parent(), which reads parent's dev->uclass_priv to + provide parent's struct clk pointer. This seems the easiest way to get + child/parent relationship for struct clk in U-Boot's udevice based clocks. + +* Linux's CCF 'struct clk_core' corresponds to U-Boot's udevice in 'struct clk'. + Clock IP block agnostic flags from 'struct clk_core' (e.g. NOCACHE) have been + moved from this struct one level up to 'struct clk'. + +* For tests the new ./test/dm/clk_ccf.c and ./drivers/clk/clk_sandbox_ccf.c + files have been introduced. The latter setups the CCF clock structure for + sandbox by reusing, if possible, generic clock primitives - like divier + and mux. The former file provides code to tests this setup. + + For sandbox new CONFIG_SANDBOX_CLK_CCF Kconfig define has been introduced. + All new primitives added for new architectures must have corresponding test + in the two aforementioned files. + + +Testing (sandbox): +================== + +make mrproper; make sandbox_defconfig; make -j4 +./u-boot -i -d arch/sandbox/dts/test.dtb +=> ut dm clk + +or in a more "scriptable" way (with -v to print debug output): +./u-boot --fdt arch/sandbox/dts/test.dtb --command "ut dm clk_ccf" -v + +To do: +------ + +* Use of OF_PLATDATA in the SPL setup for CCF - as it is now - the SPL grows + considerably and using CCF in boards with tiny resources (OCRAM) is + problematic. + +* On demand port other parts of CCF to U-Boot - as now only features _really_ + needed by DM/DTS converted drivers are used.
Signature · 1 line
2.11.0
PATCH v5 1/18 clk: doc: Add documentation entry for Common Clock Framework [CCF] (i.MX)
Quoted 3 lines
This patch describes the design decisions considerations and taken approach for porting in a separate documentation entry.
Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 2/18 dm: Fix documentation entry as there is no UCLASS_CLOCK uclass
In reply to Lukasz MajewskiThere is no UCLASS_CLOCK uclass defined. Instead we do use the UCLASS_CLK.
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
include/clk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/clk.h +1 -1
@@ -20,7 +20,7 @@* clock provider. This API provides a standard means for drivers to enable and * disable clocks, and to set the rate at which they oscillate. * -* A driver that implements UCLASS_CLOCK is a clock provider. A provider will +* A driver that implements UCLASS_CLK is a clock provider. A provider will * often implement multiple separate clocks, since the hardware it manages * often has this capability. clk-uclass.h describes the interface which * clock providers must implement.
Signature · 1 line
2.11.0
PATCH v5 2/18 dm: Fix documentation entry as there is no UCLASS_CLOCK uclass
Quoted 4 lines
There is no
UCLASS_CLOCKuclass defined. Instead we do use theUCLASS_CLK.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Simon Glass <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 3/18 clk: Remove clock ID check in .get_rate() of clk_fixed_*
In reply to Lukasz MajewskiThis check requires the struct clk passed to .get_rate() to be always cleared out as any clock with valid ID causes -EINVAL return value.
The return code of fixed clocks shall always be returned.
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/clk/clk_fixed_factor.c | 3 --- drivers/clk/clk_fixed_rate.c | 3 --- 2 files changed, 6 deletions(-)
drivers/clk/clk_fixed_factor.c +0 -3
@@ -24,9 +24,6 @@ static ulong clk_fixed_factor_get_rate(struct clk *clk)uint64_t rate;struct clk_fixed_factor *ff =to_clk_fixed_factor (clk->dev); -if (clk->id !=0 ) -return -EINVAL ; - rate =clk_get_rate (&ff->parent);if (IS_ERR_VALUE (rate))return rate;
drivers/clk/clk_fixed_rate.c +0 -3
@@ -15,9 +15,6 @@ struct clk_fixed_rate {static ulong clk_fixed_rate_get_rate (struct clk *clk) { -if (clk->id !=0 ) -return -EINVAL ; -return to_clk_fixed_rate (clk->dev)->fixed_rate; }
Signature · 1 line
2.11.0
PATCH v5 3/18 clk: Remove clock ID check in .get_rate() of clk_fixed_*
Quoted 5 lines
This check requires the struct clk passed to .get_rate() to be always cleared out as any clock with valid ID causes
-EINVALreturn value. The return code of fixed clocks shall always be returned.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 4/18 clk: Extend struct clk to provide information regarding clock rate
In reply to Lukasz MajewskiThis commit extends the struct clk to provide information regarding the clock rate.
As a result the clock tree traversal is performed at most once, and further reads are using the cached value.
---
Changes in v6: None
Changes in v5:
- Use long long to store rate value (to avoid int overflow and also return errors correctly)
Changes in v4: None
Changes in v3: None
include/clk.h | 2 ++ 1 file changed, 2 insertions(+)
include/clk.h +2 -0
@@ -40,6 +40,7 @@ struct udevice;* other clock APIs to identify which clock signal to operate upon. * * @dev: The device which implements the clock signal. +* @rate: The clock rate (in HZ). * @id: The clock signal ID within the provider. * @data: An optional data field for scenarios where a single integer ID is not * sufficient. If used, it can be populated through an .of_xlate op and
@@ -55,6 +56,7 @@ struct udevice;*/ struct clk {struct udevice *dev; +long long rate;/* in HZ */ /* * Written by of_xlate. In the future, we might add more fields here. */
Signature · 1 line
2.11.0
PATCH v5 4/18 clk: Extend struct clk to provide information regarding clock rate
Quoted 5 lines
This commit extends the struct clk to provide information regarding the clock rate.
As a result the clock tree traversal is performed at most once, and further reads are using the cached value.Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 5/18 clk: Extend struct clk to provide clock type agnostic flags
In reply to Lukasz MajewskiThis commit extends the struct clk to provide information regarding the flags related to this devices.
Those flags are clk device agnostic and indicate generic features (like e.g. CLK_GET_RATE_NOCACHE - the need to always recalculate the rate).
---
Changes in v6: None
Changes in v5:
- Use u32 to avoid checkpatch warning
Changes in v4: None
Changes in v3: None
include/clk.h | 4 ++++ 1 file changed, 4 insertions(+)
include/clk.h +4 -0
@@ -41,6 +41,9 @@ struct udevice;* * @dev: The device which implements the clock signal. * @rate: The clock rate (in HZ). +* @flags: Flags used across common clock structure (e.g. CLK_) +* Clock IP blocks specific flags (i.e. mux, div, gate, etc) are defined +* in struct's for those devices (e.g. struct clk_mux). * @id: The clock signal ID within the provider. * @data: An optional data field for scenarios where a single integer ID is not * sufficient. If used, it can be populated through an .of_xlate op and
@@ -57,6 +60,7 @@ struct udevice;struct clk {struct udevice *dev;long long rate;/* in HZ */ +u32 flags;/* * Written by of_xlate. In the future, we might add more fields here. */
Signature · 1 line
2.11.0
PATCH v5 5/18 clk: Extend struct clk to provide clock type agnostic flags
Quoted 6 lines
This commit extends the struct clk to provide information regarding the flags related to this devices.
Those flags are clk device agnostic and indicate generic features (like e.g.CLK_GET_RATE_NOCACHE- the need to always recalculate the rate).Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 6/18 clk: Provide struct clk for fixed rate clock (clk_fixed_rate.c)
In reply to Lukasz MajewskiUp till now the fixed rate clock ('osc') has been added to UCLASS_CLK without declaring struct clk. As a result it was only accessible by iterating the udevice's uclass list.
This is a problem for clock code, which operates on pointers to struct clk (like clk_get_rate()), not udevices.
After this change struct clk is accessible from udevice and udevice from struct clk.
---
Changes in v6:
- Use dev->uclass_priv pointer to store pointer to clk
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/clk/clk_fixed_rate.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/clk/clk_fixed_rate.c +5 -0
@@ -8,6 +8,7 @@#include <dm.h> struct clk_fixed_rate { +struct clk clk;unsigned long fixed_rate; };
@@ -24,10 +25,14 @@ const struct clk_ops clk_fixed_rate_ops = {static int clk_fixed_rate_ofdata_to_platdata (struct udevice *dev) { +struct clk *clk = &to_clk_fixed_rate (dev)->clk;#if !CONFIG_IS_ENABLED (OF_PLATDATA )to_clk_fixed_rate (dev)->fixed_rate =dev_read_u32_default (dev,"clock-frequency" ,0 );#endif +/* Make fixed rate clock accessible from higher level struct clk */ + dev->uclass_priv = clk; + clk->dev = dev;return 0 ; }
Signature · 1 line
2.11.0
PATCH v5 6/18 clk: Provide struct clk for fixed rate clock (clk_fixed_rate.c)
Quoted 9 lines
Up till now the fixed rate clock ('osc') has been added to
UCLASS_CLKwithout declaring struct clk. As a result it was only accessible by iterating the udevice's uclass list.
This is a problem for clock code, which operates on pointers to struct clk (likeclk_get_rate()), not udevices.
After this change struct clk is accessible from udevice and udevice from struct clk.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 7/18 clk: Introduce clk-provider.h to store Common Clock Framework's internals
In reply to Lukasz MajewskiThis file now stores the dev_get_clk_ptr() wrapper on the dev_get_uclass_priv() function.
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
include/linux/clk-provider.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 include/linux/clk-provider.h
include/linux/clk-provider.h new file +16 -0
@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright (C) 2019 DENX Software Engineering +* Lukasz Majewski, DENX Software Engineering, lukma at denx.de +* +* Copyright (c) 2010-2011 Jeremy Kerr <[email protected]> +* Copyright (C) 2011-2012 Linaro Ltd <[email protected]> +*/ +#ifndef __LINUX_CLK_PROVIDER_H +#define __LINUX_CLK_PROVIDER_H + +static inline struct clk *dev_get_clk_ptr (struct udevice *dev) +{ +return (struct clk *)dev_get_uclass_priv (dev); +} +#endif /* __LINUX_CLK_PROVIDER_H */
Signature · 1 line
2.11.0
PATCH v5 7/18 clk: Introduce clk-provider.h to store Common Clock Framework's internals
Quoted 3 lines
This file now stores the
dev_get_clk_ptr()wrapper on thedev_get_uclass_priv()function.Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 8/18 dm: clk: Define clk_get_parent() for clk operations
In reply to Lukasz MajewskiThis commit adds the clk_get_parent() function, which is responsible for getting the parent's struct clock pointer.
U-Boot's DM support for getting parent is different (the parent relationship is in udevice) than the one in Common Clock Framework [CCF] in Linux. To obtain the pointer to struct clk of parent the pdev->uclass_priv field is read via dev_get_clk_ptr() wrapper.
---
Changes in v6: None
Changes in v5:
- s/U-boot/U-Boot/g
- Replace dev->driver_data with dev_get_clk_ptr() wrapper on uclass_priv
Changes in v4: None
Changes in v3:
- New patch
drivers/clk/clk-uclass.c | 16 ++++++++++++++++ include/clk.h | 9 +++++++++ 2 files changed, 25 insertions(+)
drivers/clk/clk-uclass.c +16 -0
@@ -13,6 +13,7 @@#include <dm/read.h> #include <dt-structs.h> #include <errno.h> +#include <linux/clk-provider.h> static inline const struct clk_ops *clk_dev_ops (struct udevice *dev) {
@@ -379,6 +380,21 @@ ulong clk_get_rate(struct clk *clk)return ops->get_rate (clk); } +struct clk *clk_get_parent (struct clk *clk) +{ +struct udevice *pdev; +struct clk *pclk; + +debug ("%s(clk=%p)\n" , __func__, clk); + + pdev =dev_get_parent (clk->dev); + pclk =dev_get_clk_ptr (pdev); +if (!pclk) +return ERR_PTR (-ENODEV ); + +return pclk; +} +ulong clk_set_rate (struct clk *clk,ulong rate) {const struct clk_ops *ops =clk_dev_ops (clk->dev);
include/clk.h +9 -0
@@ -259,6 +259,15 @@ int clk_free(struct clk *clk);ulong clk_get_rate (struct clk *clk);/** +* clk_get_parent() - Get current clock's parent. +* +* @clk: A clock struct that was previously successfully requested by +* clk_request/get_by_*(). +* @return pointer to parent's struct clk, or error code passed as pointer +*/ +struct clk *clk_get_parent (struct clk *clk); + +/** * clk_set_rate() - Set current clock rate. * * @clk: A clock struct that was previously successfully requested by
Signature · 1 line
2.11.0
PATCH v5 8/18 dm: clk: Define clk_get_parent() for clk operations
Quoted 8 lines
This commit adds the
clk_get_parent()function, which is responsible for getting the parent's struct clock pointer.
U-Boot's DM support for getting parent is different (the parent relationship is in udevice) than the one in Common Clock Framework [CCF] in Linux. To obtain the pointer to struct clk of parent thepdev->uclass_privfield is read viadev_get_clk_ptr()wrapper.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 9/18 dm: clk: Define clk_get_parent_rate() for clk operations
In reply to Lukasz MajewskiThis commit adds the clk_get_parent_rate() function, which is responsible for getting the rate of parent clock.
Unfortunately, u-boot's DM support for getting parent is different (the parent relationship is in udevice) than the one in Common Clock Framework [CCF] in Linux.
To alleviate this problem - the clk_get_parent_rate() function has been introduced to clk-uclass.c.
---
Changes in v6: None
Changes in v5:
- Replace ulong with long long (to accommodate large freqs and return errors)
Changes in v4: None
Changes in v3:
- The rate information is now cached into struct clk field
- The clk_get_parent() is used to get pointer to the parent struct clk
drivers/clk/clk-uclass.c | 22 ++++++++++++++++++++++ include/clk.h | 9 +++++++++ 2 files changed, 31 insertions(+)
drivers/clk/clk-uclass.c +22 -0
@@ -395,6 +395,28 @@ struct clk *clk_get_parent(struct clk *clk)return pclk; } +long long clk_get_parent_rate (struct clk *clk) +{ +const struct clk_ops *ops; +struct clk *pclk; + +debug ("%s(clk=%p)\n" , __func__, clk); + + pclk =clk_get_parent (clk); +if (IS_ERR (pclk)) +return -ENODEV ; + + ops =clk_dev_ops (pclk->dev); +if (!ops->get_rate) +return -ENOSYS ; + +/* Read the 'rate' if not already set */ +if (!pclk->rate) + pclk->rate =clk_get_rate (pclk); + +return pclk->rate; +} +ulong clk_set_rate (struct clk *clk,ulong rate) {const struct clk_ops *ops =clk_dev_ops (clk->dev);
include/clk.h +9 -0
@@ -268,6 +268,15 @@ ulong clk_get_rate(struct clk *clk);struct clk *clk_get_parent (struct clk *clk);/** +* clk_get_parent_rate() - Get parent of current clock rate. +* +* @clk: A clock struct that was previously successfully requested by +* clk_request/get_by_*(). +* @return clock rate in Hz, or -ve error code. +*/ +long long clk_get_parent_rate (struct clk *clk); + +/** * clk_set_rate() - Set current clock rate. * * @clk: A clock struct that was previously successfully requested by
Signature · 1 line
2.11.0
PATCH v5 9/18 dm: clk: Define clk_get_parent_rate() for clk operations
Quoted 9 lines
This commit adds the
clk_get_parent_rate()function, which is responsible for getting the rate of parent clock.
Unfortunately, u-boot's DM support for getting parent is different (the parent relationship is in udevice) than the one in Common Clock Framework [CCF] in Linux.
To alleviate this problem - theclk_get_parent_rate()function has been introduced toclk-uclass.c.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 10/18 dm: clk: Define clk_get_by_id() for clk operations
In reply to Lukasz MajewskiThis commit adds the clk_get_by_id() function, which is responsible for getting the udevice with matching clk->id. Such approach allows re-usage of inherit DM list relationship for the same class (UCLASS_CLK). As a result - we don't need any other external list - it is just enough to look for UCLASS_CLK related udevices.
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3:
- Replace -ENODEV with -ENOENT
- Use **clkp instead of **c
- Replace dev->driver_data with dev_get_clk_ptr() wrapper on uclas_priv
drivers/clk/clk-uclass.c | 22 ++++++++++++++++++++++ include/clk.h | 11 +++++++++++ 2 files changed, 33 insertions(+)
drivers/clk/clk-uclass.c +22 -0
@@ -491,6 +491,28 @@ int clk_disable_bulk(struct clk_bulk *bulk)return 0 ; } +int clk_get_by_id (ulong id,struct clk **clkp) +{ +struct udevice *dev; +struct uclass *uc; +int ret; + + ret =uclass_get (UCLASS_CLK , &uc); +if (ret) +return ret; + + uclass_foreach_dev(dev, uc) { +struct clk *clk =dev_get_clk_ptr (dev); + +if (clk && clk->id == id) { + *clkp = clk; +return 0 ; + } + } + +return -ENOENT ; +} +UCLASS_DRIVER (clk) = { .id =UCLASS_CLK , .name ="clk" ,
include/clk.h +11 -0
@@ -345,4 +345,15 @@ static inline bool clk_valid(struct clk *clk) {return !!clk->dev; } + +/** +* clk_get_by_id() - Get the clock by its ID +* +* @id: The clock ID to search for +* +* @clkp: A pointer to clock struct that has been found among added clocks +* to UCLASS_CLK +* @return zero on success, or -ENOENT on error +*/ +int clk_get_by_id (ulong id,struct clk **clkp);#endif
Signature · 1 line
2.11.0
PATCH v5 10/18 dm: clk: Define clk_get_by_id() for clk operations
Quoted 7 lines
This commit adds the
clk_get_by_id()function, which is responsible for getting the udevice with matchingclk->id. Such approach allows re-usage of inherit DM list relationship for the same class (UCLASS_CLK). As a result - we don't need any other external list - it is just enough to look forUCLASS_CLKrelated udevices.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 11/18 clk: Port Linux common clock framework [CCF] for imx6q to U-boot (tag: v5.1.12)
In reply to Lukasz MajewskiThis patch brings the files from Linux kernel (linux-stable/linux-5.1.y
SHA1: 5752b50477da)to provide clocks support as it is used on the Linux kernel with Common Clock Framework [CCF] setup.
The directory structure has been preserved. The ported code only supports reading information from PLL, MUX, Divider, etc and enabling/disabling the clocks USDHCx/ECSPIx depending on used bus. Moreover, it is agnostic to the alias numbering as the information about the clock is read from the device tree.
One needs to pay attention to the comments indicating necessary for U-Boot's driver model changes.
If needed, the code can be extended to support the "set" part of the clock management.
---
Changes in v6: None
Changes in v5:
- s/U-boot/U-Boot/g
- Check if the relevant code has changed between Linux tag v5.0-rc3 and v5.1.12 (no changes - the version can be safely updated).
- Use imply CLK_IMX6Q in Kconfig for (SPL_)CCF
- Fix clk-fixed-factor implementation (kzalloc needed for correct Sandbox operation)
- Fix gate2 implementation
- Use dev->uclass_priv instead of dev->driver_data to store back pointer to the struct clk.
- Split and introduce earlier the clk-provider.h header file
Changes in v4:
- Port some more Linux code to facilitate imx8 code porting (most notably flags)
- Explicitly use container_of() based macro to provide struct clk in various places (e.g. gate2, mux, etc)
Following patches has been squashed:
http://patchwork.ozlabs.org/patch/1093141/
http://patchwork.ozlabs.org/patch/1093142/
http://patchwork.ozlabs.org/patch/1093146/
Changes in v3: None
drivers/clk/Kconfig | 14 ++++ drivers/clk/Makefile | 2 + drivers/clk/clk-divider.c | 147 +++++++++++++++++++++++++++++++++ drivers/clk/clk-fixed-factor.c | 80 ++++++++++++++++++ drivers/clk/clk-mux.c | 164 +++++++++++++++++++++++++++++++++++++ drivers/clk/clk.c | 57 +++++++++++++ drivers/clk/imx/Kconfig | 16 ++++ drivers/clk/imx/Makefile | 2 + drivers/clk/imx/clk-gate2.c | 103 ++++++++++++++++++++++++ drivers/clk/imx/clk-imx6q.c | 179 +++++++++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk-pfd.c | 90 +++++++++++++++++++++ drivers/clk/imx/clk-pllv3.c | 82 +++++++++++++++++++ drivers/clk/imx/clk.h | 69 ++++++++++++++++ include/linux/clk-provider.h | 109 +++++++++++++++++++++++++ 14 files changed, 1114 insertions(+) create mode 100644 drivers/clk/clk-divider.c create mode 100644 drivers/clk/clk-fixed-factor.c create mode 100644 drivers/clk/clk-mux.c create mode 100644 drivers/clk/clk.c create mode 100644 drivers/clk/imx/clk-gate2.c create mode 100644 drivers/clk/imx/clk-imx6q.c create mode 100644 drivers/clk/imx/clk-pfd.c create mode 100644 drivers/clk/imx/clk-pllv3.c create mode 100644 drivers/clk/imx/clk.h
drivers/clk/Kconfig +14 -0
@@ -46,6 +46,20 @@ config CLK_BOSTON help Enable this to support the clocks +config SPL_CLK_CCF + bool "SPL Common Clock Framework [CCF] support " + depends on SPL_CLK_IMX6Q + help + Enable this option if you want to (re-)use the Linux kernel's Common + Clock Framework [CCF] code in U-Boot's SPL. + +config CLK_CCF + bool "Common Clock Framework [CCF] support " + depends on CLK_IMX6Q + help + Enable this option if you want to (re-)use the Linux kernel's Common + Clock Framework [CCF] code in U-Boot's clock driver. + config CLK_STM32F bool "Enable clock driver support for STM32F family" depends on CLK && (STM32F7 || STM32F4)
drivers/clk/Makefile +2 -0
@@ -7,6 +7,8 @@ obj-$(CONFIG_$(SPL_TPL_)CLK) += clk-uclass.o obj-$(CONFIG_$(SPL_TPL_)CLK) += clk_fixed_rate.o obj-$(CONFIG_$(SPL_TPL_)CLK) += clk_fixed_factor.o +obj-$(CONFIG_$(SPL_TPL_)CLK_CCF) += clk.o clk-divider.o clk-mux.o +obj-$(CONFIG_$(SPL_TPL_)CLK_CCF) += clk-fixed-factor.o obj-y += imx/ obj-y += tegra/
drivers/clk/clk-divider.c new file +147 -0
147 lines not on this page · raw message
drivers/clk/clk-fixed-factor.c new file +80 -0
80 lines not on this page · raw message
drivers/clk/clk-mux.c new file +164 -0
164 lines not on this page · raw message
drivers/clk/clk.c new file +57 -0
57 lines not on this page · raw message
drivers/clk/imx/Kconfig +16 -0
@@ -1,3 +1,19 @@ +config SPL_CLK_IMX6Q + bool "SPL clock support for i.MX6Q" + depends on ARCH_MX6 && SPL + select SPL_CLK + select SPL_CLK_CCF + help + This enables SPL DM/DTS support for clock driver in i.MX6Q platforms. + +config CLK_IMX6Q + bool "Clock support for i.MX6Q" + depends on ARCH_MX6 + select CLK + select CLK_CCF + help + This enables DM/DTS support for clock driver in i.MX6Q platforms. + config CLK_IMX8 bool "Clock support for i.MX8" depends on ARCH_IMX8
drivers/clk/imx/Makefile +2 -0
@@ -2,6 +2,8 @@ # # SPDX-License-Identifier: GPL-2.0 +obj-$(CONFIG_$(SPL_TPL_)CLK_CCF) += clk-gate2.o clk-pllv3.o clk-pfd.o +obj-$(CONFIG_$(SPL_TPL_)CLK_IMX6Q) += clk-imx6q.o obj-$(CONFIG_CLK_IMX8) += clk-imx8.o ifdef CONFIG_CLK_IMX8
drivers/clk/imx/clk-gate2.c new file +103 -0
103 lines not on this page · raw message
drivers/clk/imx/clk-imx6q.c new file +179 -0
179 lines not on this page · raw message
drivers/clk/imx/clk-pfd.c new file +90 -0
90 lines not on this page · raw message
drivers/clk/imx/clk-pllv3.c new file +82 -0
82 lines not on this page · raw message
drivers/clk/imx/clk.h new file +69 -0
69 lines not on this page · raw message
include/linux/clk-provider.h +109 -0
115 lines not on this page · raw message
Signature · 1 line
2.11.0
PATCH v5 11/18 clk: Port Linux common clock framework [CCF] for imx6q to U-boot (tag: v5.1.12)
Quoted 12 lines
This patch brings the files from Linux kernel (linux-stable/linux-5.1.y
SHA1: 5752b50477da)to provide clocks support as it is used on the Linux kernel with Common Clock Framework [CCF] setup.
The directory structure has been preserved. The ported code only supports reading information from PLL, MUX, Divider, etc and enabling/disabling the clocks USDHCx/ECSPIx depending on used bus. Moreover, it is agnostic to the alias numbering as the information about the clock is read from the device tree.
One needs to pay attention to the comments indicating necessary for U-Boot's driver model changes.
If needed, the code can be extended to support the "set" part of the clock management.
Quoted 1 line
Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 12/18 dm: clk: Extend clk_get_parent_rate() to support CLK_GET_RATE_NOCACHE flag
In reply to Lukasz MajewskiIf the CLK_GET_RATE_NOCACHE flag is set - the clk_get_parent_rate() provides recalculated clock value without considering the cache setting.
This may be necessary for some clocks tightly coupled with power domains (i.e. imx8), and prevents from reading invalid cached values.
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/clk/clk-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/clk-uclass.c +2 -2
@@ -410,8 +410,8 @@ long long clk_get_parent_rate(struct clk *clk)if (!ops->get_rate)return -ENOSYS ; -/* Read the 'rate' if not already set */ -if (!pclk->rate) +/* Read the 'rate' if not already set or if proper flag set*/ +if (!pclk->rate || pclk->flags &CLK_GET_RATE_NOCACHE ) pclk->rate =clk_get_rate (pclk);return pclk->rate;
Signature · 1 line
2.11.0
PATCH v5 12/18 dm: clk: Extend clk_get_parent_rate() to support CLK_GET_RATE_NOCACHE flag
Quoted 6 lines
If the
CLK_GET_RATE_NOCACHEflag is set - theclk_get_parent_rate()provides recalculated clock value without considering the cache setting. This may be necessary for some clocks tightly coupled with power domains (i.e. imx8), and prevents from reading invalid cached values.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 13/18 dts: sandbox: Add 'osc' clock for Common Clock Framework [CCF] testing
In reply to Lukasz MajewskiThis patch adds the 'osc' fixed clock to facilitate the CCF testing in the sandbox U-Boot. It is a starting point for building CCF hierarchy of clocks.
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
arch/sandbox/dts/test.dts | 6 ++++++ 1 file changed, 6 insertions(+)
arch/sandbox/dts/test.dts +6 -0
@@ -211,6 +211,12 @@ clock-mult = <2>; clocks = <&clk_fixed>; }; + + osc { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <20000000>; + }; }; clk_sandbox: clk-sbox {
Signature · 1 line
2.11.0
PATCH v5 13/18 dts: sandbox: Add 'osc' clock for Common Clock Framework [CCF] testing
Quoted 4 lines
This patch adds the 'osc' fixed clock to facilitate the CCF testing in the sandbox U-Boot. It is a starting point for building CCF hierarchy of clocks.
Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 14/18 clk: sandbox: Adjust clk-divider to emulate reading its value from HW
In reply to Lukasz MajewskiThe generic divider clock code for CCF requires reading the divider value from HW registers. As sandbox by design has readl() as no-op it was necessary to provide this value in the other way.
The new field in the divider structure (accessible only when sandbox is run) has been introduced for this purpose.
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/clk/clk-divider.c | 10 +++++++++- include/linux/clk-provider.h | 3 +++ 2 files changed, 12 insertions(+), 1 deletion(-)
drivers/clk/clk-divider.c +9 -1
@@ -74,7 +74,12 @@ static ulong clk_divider_recalc_rate(struct clk *clk)unsigned long parent_rate =clk_get_parent_rate (clk);unsigned int val; - val =readl (divider->reg) >> divider->shift; +#if CONFIG_IS_ENABLED (SANDBOX_CLK_CCF ) + val = divider->io_divider_val; +#else + val =readl (divider->reg); +#endif + val >>= divider->shift; val &=clk_div_mask (divider->width); return divider_recalc_rate(clk, parent_rate, val, divider->table,
@@ -112,6 +117,9 @@ static struct clk *_register_divider(struct device *dev, const char *name, div->width = width; div->flags = clk_divider_flags; div->table = table; +#if CONFIG_IS_ENABLED (SANDBOX_CLK_CCF ) + div->io_divider_val = *(u32 *)reg; +#endif /* register the clock */ clk = &div->clk;
include/linux/clk-provider.h +3 -0
@@ -75,6 +75,9 @@ struct clk_divider {u8 width;u8 flags;const struct clk_div_table *table; +#if CONFIG_IS_ENABLED (SANDBOX_CLK_CCF ) +u32 io_divider_val; +#endif };#define clk_div_mask (width) ((1 << (width)) - 1)
Signature · 1 line
2.11.0
PATCH v5 14/18 clk: sandbox: Adjust clk-divider to emulate reading its value from HW
Quoted 6 lines
The generic divider clock code for CCF requires reading the divider value from HW registers. As sandbox by design has
readl()as no-op it was necessary to provide this value in the other way.
The new field in the divider structure (accessible only when sandbox is run) has been introduced for this purpose.Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 15/18 clk: sandbox: Adjust clk-mux.c to emulate reading divider value from HW
In reply to Lukasz MajewskiThe generic mux clock code for CCF requires reading the clock multiplexer value from HW registers. As sandbox by design has readl() as no-op it was necessary to provide this value in the other way.
The new field in the mux structure (accessible only when sandbox is run) has been introduced for this purpose.
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/clk/clk-mux.c | 10 +++++++++- include/linux/clk-provider.h | 4 ++++ 2 files changed, 13 insertions(+), 1 deletion(-)
drivers/clk/clk-mux.c +9 -1
@@ -64,7 +64,12 @@ static u8 clk_mux_get_parent(struct clk *clk)struct clk_mux *mux =to_clk_mux (clk);u32 val; - val =readl (mux->reg) >> mux->shift; +#if CONFIG_IS_ENABLED (SANDBOX_CLK_CCF ) + val = mux->io_mux_val; +#else + val =readl (mux->reg); +#endif + val >>= mux->shift; val &= mux->mask;return clk_mux_val_to_index (clk, mux->table, mux->flags, val);
@@ -108,6 +113,9 @@ struct clk *clk_hw_register_mux_table(struct device *dev, const char *name, mux->mask = mask; mux->flags = clk_mux_flags; mux->table = table; +#if CONFIG_IS_ENABLED (SANDBOX_CLK_CCF ) + mux->io_mux_val = *(u32 *)reg; +#endif clk = &mux->clk;
include/linux/clk-provider.h +4 -0
@@ -59,6 +59,10 @@ struct clk_mux {*/ const char *const *parent_names;u8 num_parents; +#if CONFIG_IS_ENABLED (SANDBOX_CLK_CCF ) +u32 io_mux_val; +#endif + };#define to_clk_mux (_clk) container_of(_clk, struct clk_mux, clk)
Signature · 1 line
2.11.0
PATCH v5 15/18 clk: sandbox: Adjust clk-mux.c to emulate reading divider value from HW
Quoted 6 lines
The generic mux clock code for CCF requires reading the clock multiplexer value from HW registers. As sandbox by design has
readl()as no-op it was necessary to provide this value in the other way.
The new field in the mux structure (accessible only when sandbox is run) has been introduced for this purpose.Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 16/18 clk: sandbox: Add sandbox test code for Common Clock Framework [CCF]
In reply to Lukasz MajewskiThis patch provides code to implement the CCF clock tree in sandbox. It uses all the introduced primitives; some generic ones are reused, some sandbox specific were developed.
In that way (after introducing the real CCF tree in sandbox) the recently added to clk-uclass.c: clk_get_by_id() and clk_get_parent_rate() are tested in their natural work environment.
Usage (sandbox_defconfig and sandbox_flattree_defconfig):
./u-boot --fdt arch/sandbox/dts/test.dtb --command "ut dm clk_ccf"
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
arch/sandbox/dts/test.dts | 4 + drivers/clk/Kconfig | 10 ++- drivers/clk/Makefile | 1 + drivers/clk/clk_sandbox_ccf.c | 185 ++++++++++++++++++++++++++++++++++++++++++ include/sandbox-clk.h | 76 +++++++++++++++++ test/dm/Makefile | 2 +- test/dm/clk_ccf.c | 62 ++++++++++++++ 7 files changed, 338 insertions(+), 2 deletions(-) create mode 100644 drivers/clk/clk_sandbox_ccf.c create mode 100644 include/sandbox-clk.h create mode 100644 test/dm/clk_ccf.c
arch/sandbox/dts/test.dts +4 -0
@@ -232,6 +232,10 @@ clock-names = "fixed", "i2c", "spi"; }; + ccf: clk-ccf { + compatible = "sandbox,clk-ccf"; + }; + eth at 10002000 { compatible = "sandbox,eth"; reg = <0x10002000 0x1000>;
drivers/clk/Kconfig +9 -1
@@ -55,7 +55,7 @@ config SPL_CLK_CCF config CLK_CCF bool "Common Clock Framework [CCF] support " - depends on CLK_IMX6Q + depends on CLK_IMX6Q || SANDBOX_CLK_CCF help Enable this option if you want to (re-)use the Linux kernel's Common Clock Framework [CCF] code in U-Boot's clock driver.
@@ -138,4 +138,12 @@ config CLK_MPC83XX help Support for the clock driver of the MPC83xx series of SoCs. +config SANDBOX_CLK_CCF + bool "Sandbox Common Clock Framework [CCF] support " + depends on SANDBOX + select CLK_CCF + help + Enable this option if you want to test the Linux kernel's Common + Clock Framework [CCF] code in U-Boot's Sandbox clock driver. + endmenu
drivers/clk/Makefile +1 -0
@@ -38,5 +38,6 @@ obj-$(CONFIG_ICS8N3QV01) += ics8n3qv01.o obj-$(CONFIG_MACH_PIC32) += clk_pic32.o obj-$(CONFIG_SANDBOX) += clk_sandbox.o obj-$(CONFIG_SANDBOX) += clk_sandbox_test.o +obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o obj-$(CONFIG_STM32H7) += clk_stm32h7.o obj-$(CONFIG_CLK_TI_SCI) += clk-ti-sci.o
drivers/clk/clk_sandbox_ccf.c new file +185 -0
185 lines not on this page · raw message
include/sandbox-clk.h new file +76 -0
76 lines not on this page · raw message
test/dm/Makefile +1 -1
@@ -16,7 +16,7 @@ obj-$(CONFIG_SOUND) += audio.o obj-$(CONFIG_BLK) += blk.o obj-$(CONFIG_BOARD) += board.o obj-$(CONFIG_DM_BOOTCOUNT) += bootcount.o -obj-$(CONFIG_CLK) += clk.o +obj-$(CONFIG_CLK) += clk.o clk_ccf.o obj-$(CONFIG_DM_ETH) += eth.o obj-$(CONFIG_FIRMWARE) += firmware.o obj-$(CONFIG_DM_GPIO) += gpio.o
test/dm/clk_ccf.c new file +62 -0
62 lines not on this page · raw message
Signature · 1 line
2.11.0
PATCH v5 16/18 clk: sandbox: Add sandbox test code for Common Clock Framework [CCF]
Quoted 9 lines
This patch provides code to implement the CCF clock tree in sandbox. It uses all the introduced primitives; some generic ones are reused, some sandbox specific were developed.
In that way (after introducing the real CCF tree in sandbox) the recently added toclk-uclass.c:clk_get_by_id()andclk_get_parent_rate()are tested in their natural work environment.
Usage (sandbox_defconfigandsandbox_flattree_defconfig):
./u-boot --fdtarch/sandbox/dts/test.dtb--command "ut dmclk_ccf"Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 17/18 defconfig: sandbox: Enable SANDBOX_CLK_CCF to reuse generic CCF code
In reply to Lukasz MajewskiEnable by default the Common Clock Framework [CCF] clock code for sandbox.
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 1 + 2 files changed, 2 insertions(+)
configs/sandbox_defconfig +1 -0
@@ -92,6 +92,7 @@ CONFIG_BOOTCOUNT_LIMIT=y CONFIG_DM_BOOTCOUNT=y CONFIG_DM_BOOTCOUNT_RTC=y CONFIG_CLK=y +CONFIG_SANDBOX_CLK_CCF=y CONFIG_CPU=y CONFIG_DM_DEMO=y CONFIG_DM_DEMO_SIMPLE=y
configs/sandbox_flattree_defconfig +1 -0
@@ -67,6 +67,7 @@ CONFIG_DEBUG_DEVRES=y CONFIG_ADC=y CONFIG_ADC_SANDBOX=y CONFIG_CLK=y +CONFIG_SANDBOX_CLK_CCF=y CONFIG_CPU=y CONFIG_DM_DEMO=y CONFIG_DM_DEMO_SIMPLE=y
Signature · 1 line
2.11.0
PATCH v5 17/18 defconfig: sandbox: Enable SANDBOX_CLK_CCF to reuse generic CCF code
Quoted 2 lines
Enable by default the Common Clock Framework [CCF] clock code for sandbox.
Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 18/18 clk: Add MAINTAINERS entry for clocks (./drivers/clk/)
In reply to Lukasz MajewskiThe clock subsystem needs active maintenance as it steadily grows. I do offer my help for this task.
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+)
MAINTAINERS +7 -0
@@ -443,6 +443,13 @@ T: git git://git.denx.de/u-boot-cfi-flash.git F: drivers/mtd/cfi_flash.c F: drivers/mtd/jedec_flash.c +CLOCK +M: Lukasz Majewski <[email protected]> +S: Maintained +T: git git://git.denx.de/u-boot-dfu.git +F: drivers/clk/ +F: drivers/clk/imx/ + COLDFIRE M: Huan Wang <[email protected]> M: Angelo Dureghello <[email protected]>
Signature · 1 line
2.11.0
PATCH v5 18/18 clk: Add MAINTAINERS entry for clocks (./drivers/clk/)
Quoted 3 lines
The clock subsystem needs active maintenance as it steadily grows. I do offer my help for this task.
Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
v5 cover clk: Port Linux common clock framework [CCF] to U-boot (tag: v5.1.12)
In reply to Lukasz MajewskiHi Lukasz,
Quoted 7 lines · Lukasz Majewski
This patch series brings the files from Linux kernel (SHA1:
5752b50477daLinux 5.1.12 to provide clocks support as it is used on the Linux kernel with Common Clock Framework [CCF] setup.This series also fixes several problems with current clocks and provides sandbox tests for functions added to
clk-uclass.cfile.
Quoted 6 lines
CCF impact to U-Boot size:
--------------------------SPL U-Boot.imgWithout CCF: 51 KiB 358 KiB
With CCF: 55 KiB 363 KiB
Size increase: 1.3% 7.2%
The size increase numbers seem to be a bit off. It's 7.8% for SPL (which is quite a lot) and 1.4% for U-Boot proper from your size values.
By the way: Thanks for the new version. I'm currently still experimenting with your v3 and Peng's patches for i.MX8MM on top of 2019.04. I hope I have time to rebase on master and v5 soon.
Thanks,
Frieder
Quoted 125 lines
The SPL implementation is not yet optimized (no
OF_PLATDATA, etc).Repository:
https://github.com/lmajewski/u-boot-dfu/commits/CCF-v5Applicable on top of u-boot/master:
SHA1:77f6e2dd0551d8a825bab391a1bd6b838874bcd4Travis-CI:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/549603356Changes in v6:
- Usedev->uclass_privpointer to store pointer to clkChanges in v5:
- s/U-boot/U-Boot/g
- Update Linux version to 5.1.12
- Add paragraph regarding sandbox CCF testing (common uclass code)
- Use long long to store rate value (to avoid int overflow and also return errors correctly)
- Use u32 to avoid checkpatch warning
- s/U-boot/U-Boot/g
- Replacedev->driver_datawithdev_get_clk_ptr()wrapper onuclass_priv
- Replace ulong with long long (to accommodate large freqs and return errors)
- s/U-boot/U-Boot/g
- Check if the relevant code has changed between Linux tag v5.0-rc3 and v5.1.12 (no changes - the version can be safely updated).
- Use implyCLK_IMX6QinKconfigfor (SPL_)CCF
- Fix clk-fixed-factor implementation (kzalloc needed for correct Sandbox operation)
- Fix gate2 implementation
- Usedev->uclass_privinstead ofdev->driver_datato store back pointer to the struct clk.
- Split and introduce earlier theclk-provider.hheader fileChanges in v4:
- New patch
- Port some more Linux code to facilitate imx8 code porting (most notably flags)
- Explicitly usecontainer_of()based macro to provide struct clk in various places (e.g. gate2, mux, etc)
Following patches has been squashed:http://patchwork.ozlabs.org/patch/1093141/ http://patchwork.ozlabs.org/patch/1093142/ http://patchwork.ozlabs.org/patch/1093146/Changes in v3:
- New patch
- The rate information is now cached into struct clk field
- Theclk_get_parent()is used to get pointer to the parent struct clk
- Replace-ENODEVwith-ENOENT
- Use **clkp instead of **c
- Replacedev->driver_datawithdev_get_clk_ptr()wrapper onuclas_privLukasz Majewski (18):
clk: doc: Add documentation entry for Common Clock Framework [CCF](i.MX) dm: Fix documentation entry as there is no UCLASS_CLOCK uclass clk: Remove clock ID check in .get_rate() of clk_fixed_* clk: Extend struct clk to provide information regarding clock rate clk: Extend struct clk to provide clock type agnostic flags clk: Provide struct clk for fixed rate clock (clk_fixed_rate.c) clk: Introduce clk-provider.h to store Common Clock Framework's internals dm: clk: Define clk_get_parent() for clk operations dm: clk: Define clk_get_parent_rate() for clk operations dm: clk: Define clk_get_by_id() for clk operations clk: Port Linux common clock framework [CCF] for imx6q to U-boot (tag: v5.1.12)dm: clk: Extend
clk_get_parent_rate()to supportCLK_GET_RATE_NOCACHE
flag
dts: sandbox: Add 'osc' clock for Common Clock Framework [CCF] testing
clk: sandbox: Adjust clk-divider to emulate reading its value from HW
clk: sandbox: Adjustclk-mux.cto emulate reading divider value from
HW
clk: sandbox: Add sandbox test code for Common Clock Framework [CCF]
defconfig: sandbox: EnableSANDBOX_CLK_CCFto reuse generic CCF code
clk: AddMAINTAINERSentry for clocks (./drivers/clk/)MAINTAINERS | 7 ++ arch/sandbox/dts/test.dts | 10 ++ configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 1 + doc/imx/clk/ccf.txt | 101 ++++++++++++++++++++ drivers/clk/Kconfig | 22 +++++ drivers/clk/Makefile | 3 + drivers/clk/clk-divider.c | 155 +++++++++++++++++++++++++++++++ drivers/clk/clk-fixed-factor.c | 80 ++++++++++++++++ drivers/clk/clk-mux.c | 172 ++++++++++++++++++++++++++++++++++ drivers/clk/clk-uclass.c | 60 ++++++++++++ drivers/clk/clk.c | 57 ++++++++++++ drivers/clk/clk_fixed_factor.c | 3 - drivers/clk/clk_fixed_rate.c | 8 +- drivers/clk/clk_sandbox_ccf.c | 185 +++++++++++++++++++++++++++++++++++++ drivers/clk/imx/Kconfig | 16 ++++ drivers/clk/imx/Makefile | 2 + drivers/clk/imx/clk-gate2.c | 103 +++++++++++++++++++++ drivers/clk/imx/clk-imx6q.c | 179 +++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk-pfd.c | 90 ++++++++++++++++++ drivers/clk/imx/clk-pllv3.c | 82 ++++++++++++++++ drivers/clk/imx/clk.h | 69 ++++++++++++++ include/clk.h | 37 +++++++- include/linux/clk-provider.h | 132 ++++++++++++++++++++++++++ include/sandbox-clk.h | 76 +++++++++++++++ test/dm/Makefile | 2 +- test/dm/clk_ccf.c | 62 +++++++++++++ 27 files changed, 1707 insertions(+), 8 deletions(-)create mode 100644
doc/imx/clk/ccf.txtcreate mode 100644drivers/clk/clk-divider.ccreate mode 100644drivers/clk/clk-fixed-factor.ccreate mode 100644drivers/clk/clk-mux.ccreate mode 100644drivers/clk/clk.ccreate mode 100644drivers/clk/clk_sandbox_ccf.ccreate mode 100644drivers/clk/imx/clk-gate2.ccreate mode 100644drivers/clk/imx/clk-imx6q.ccreate mode 100644drivers/clk/imx/clk-pfd.ccreate mode 100644drivers/clk/imx/clk-pllv3.ccreate mode 100644drivers/clk/imx/clk.hcreate mode 100644include/linux/clk-provider.hcreate mode 100644include/sandbox-clk.hcreate mode 100644test/dm/clk_ccf.c
v5 cover clk: Port Linux common clock framework [CCF] to U-boot (tag: v5.1.12)
Hi Frieder,
Quoted 17 lines
Hi Lukasz,
Quoted 7 lines · Lukasz Majewski
This patch series brings the files from Linux kernel (SHA1:
5752b50477daLinux 5.1.12 to provide clocks support as it is used on the Linux kernel with Common Clock Framework [CCF] setup.This series also fixes several problems with current clocks and provides sandbox tests for functions added to
clk-uclass.cfile.Quoted 6 lines
CCF impact to U-Boot size:
--------------------------SPL U-Boot.imgWithout CCF: 51 KiB 358 KiB
With CCF: 55 KiB 363 KiB
Size increase: 1.3% 7.2%
Quoted 3 lines
The size increase numbers seem to be a bit off. It's 7.8% for SPL (which is quite a lot) and 1.4% for U-Boot proper from your size values.
The size increase for U-Boot proper is IMHO acceptable. The problem is with SPL. I do think that the next step for SPL (when the code gets accepted) would be to convert it to OF_PLATDATA (no need for DTS parsing code as well as the description iself) and try to keep number of necessary clocks low.
One issue with clocks is that we currently in u-boot by default strip the clock properties. For CCF we need them, and as a result the DTS is bigger.
Quoted 4 lines
By the way: Thanks for the new version. I'm currently still experimenting with your v3 and Peng's patches for i.MX8MM on top of 2019.04. I hope I have time to rebase on master and v5 soon.
v5 has several improvements/changes.
Quoted 132 lines
Thanks,
FriederQuoted 128 lines
The SPL implementation is not yet optimized (no
OF_PLATDATA, etc).Repository:
https://github.com/lmajewski/u-boot-dfu/commits/CCF-v5Applicable on top of u-boot/master:
SHA1:77f6e2dd0551d8a825bab391a1bd6b838874bcd4Travis-CI:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/549603356Changes in v6:
- Usedev->uclass_privpointer to store pointer to clkChanges in v5:
- s/U-boot/U-Boot/g
- Update Linux version to 5.1.12
- Add paragraph regarding sandbox CCF testing (common uclass code)
- Use long long to store rate value (to avoid int overflow and also return errors correctly)
- Use u32 to avoid checkpatch warning
- s/U-boot/U-Boot/g
- Replacedev->driver_datawithdev_get_clk_ptr()wrapper onuclass_priv
- Replace ulong with long long (to accommodate large freqs and return errors)
- s/U-boot/U-Boot/g
- Check if the relevant code has changed between Linux tag v5.0-rc3 and v5.1.12 (no changes - the version can be safely updated).
- Use implyCLK_IMX6QinKconfigfor (SPL_)CCF
- Fix clk-fixed-factor implementation (kzalloc needed for correct Sandbox operation)
- Fix gate2 implementation
- Usedev->uclass_privinstead ofdev->driver_datato store back pointer to the struct clk.
- Split and introduce earlier theclk-provider.hheader fileChanges in v4:
- New patch
- Port some more Linux code to facilitate imx8 code porting (most notably flags)
- Explicitly usecontainer_of()based macro to provide struct clk in various places (e.g. gate2, mux, etc)
Following patches has been squashed:http://patchwork.ozlabs.org/patch/1093141/ http://patchwork.ozlabs.org/patch/1093142/ http://patchwork.ozlabs.org/patch/1093146/Changes in v3:
- New patch
- The rate information is now cached into struct clk field
- Theclk_get_parent()is used to get pointer to the parent struct clk
- Replace-ENODEVwith-ENOENT
- Use **clkp instead of **c
- Replacedev->driver_datawithdev_get_clk_ptr()wrapper onuclas_privLukasz Majewski (18):
clk: doc: Add documentation entry for Common Clock Framework
[CCF] (i.MX)
dm: Fix documentation entry as there is noUCLASS_CLOCKuclass
clk: Remove clock ID check in .get_rate() of clk_fixed_*
clk: Extend struct clk to provide information regarding clock
rate clk: Extend struct clk to provide clock type agnostic flags
clk: Provide struct clk for fixed rate clock (clk_fixed_rate.c)
clk: Introduceclk-provider.hto store Common Clock Framework's
internals
dm: clk: Defineclk_get_parent()for clk operations
dm: clk: Defineclk_get_parent_rate()for clk operations
dm: clk: Defineclk_get_by_id()for clk operations
clk: Port Linux common clock framework [CCF] for imx6q to U-boot
(tag: v5.1.12)
dm: clk: Extendclk_get_parent_rate()to supportCLK_GET_RATE_NOCACHEflag
dts: sandbox: Add 'osc' clock for Common Clock Framework [CCF]
testing clk: sandbox: Adjust clk-divider to emulate reading its value from HW clk: sandbox: Adjustclk-mux.cto emulate reading divider value from HW
clk: sandbox: Add sandbox test code for Common Clock Framework
[CCF] defconfig: sandbox: EnableSANDBOX_CLK_CCFto reuse generic CCF code clk: AddMAINTAINERSentry for clocks (./drivers/clk/)MAINTAINERS | 7 ++ arch/sandbox/dts/test.dts | 10 ++ configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 1 + doc/imx/clk/ccf.txt | 101 ++++++++++++++++++++ drivers/clk/Kconfig | 22 +++++ drivers/clk/Makefile | 3 + drivers/clk/clk-divider.c | 155 +++++++++++++++++++++++++++++++ drivers/clk/clk-fixed-factor.c | 80 ++++++++++++++++ drivers/clk/clk-mux.c | 172 ++++++++++++++++++++++++++++++++++ drivers/clk/clk-uclass.c | 60 ++++++++++++ drivers/clk/clk.c | 57 ++++++++++++ drivers/clk/clk_fixed_factor.c | 3 - drivers/clk/clk_fixed_rate.c | 8 +- drivers/clk/clk_sandbox_ccf.c | 185 +++++++++++++++++++++++++++++++++++++ drivers/clk/imx/Kconfig | 16 ++++ drivers/clk/imx/Makefile | 2 + drivers/clk/imx/clk-gate2.c | 103 +++++++++++++++++++++ drivers/clk/imx/clk-imx6q.c | 179 +++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk-pfd.c | 90 ++++++++++++++++++ drivers/clk/imx/clk-pllv3.c | 82 ++++++++++++++++ drivers/clk/imx/clk.h | 69 ++++++++++++++ include/clk.h | 37 +++++++- include/linux/clk-provider.h | 132 ++++++++++++++++++++++++++ include/sandbox-clk.h | 76 +++++++++++++++ test/dm/Makefile | 2 +- test/dm/clk_ccf.c | 62 +++++++++++++ 27 fileschanged, 1707 insertions(+), 8 deletions(-) create mode 100644
doc/imx/clk/ccf.txtcreate mode 100644drivers/clk/clk-divider.ccreate mode 100644drivers/clk/clk-fixed-factor.ccreate mode 100644drivers/clk/clk-mux.ccreate mode 100644drivers/clk/clk.ccreate mode 100644drivers/clk/clk_sandbox_ccf.ccreate mode 100644drivers/clk/imx/clk-gate2.ccreate mode 100644drivers/clk/imx/clk-imx6q.ccreate mode 100644drivers/clk/imx/clk-pfd.ccreate mode 100644drivers/clk/imx/clk-pllv3.ccreate mode 100644drivers/clk/imx/clk.h
create mode 100644include/linux/clk-provider.h
create mode 100644include/sandbox-clk.h
create mode 100644test/dm/clk_ccf.c
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190625/3a7647bc/attachment.sig>
v5 cover clk: Port Linux common clock framework [CCF] to U-boot (tag: v5.1.12)
In reply to Schrempf FriederHi Simon,
Would you find time to review the v5 of CCF?
https://patchwork.ozlabs.org/cover/1121348/
Thanks in advance,
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190710/b9779ebe/attachment.sig>