Skip to contentSkip to conversation

Kconfig: Make CMD_SPL_NAND_OFS only available when proper memory is used

PATCH New Lukasz Majewski 2 participants 8 messages May 16, 2019 – Jul 20, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/4 Kconfig: Make CMD_SPL_NAND_OFS only available when proper memory is used

This commit makes the CMD_SPL_NAND_OFS only visible when we use NAND memory.
Before this change it was present when only CMD_SPL was enabled (and would stay when board with other falcon boot medium is used).

---

Changes in v2: None

 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
cmd/Kconfig +1 -0
index 0d36da2a5c..7bc275f135 100644
@@ -327,6 +327,7 @@ config CMD_SPL
 config CMD_SPL_NAND_OFS
 	hex "Offset of OS command line args for Falcon-mode NAND boot"
 	depends on CMD_SPL
+	depends on CMD_SPL && (TPL_NAND_SUPPORT || SPL_NAND_SUPPORT)
 	default 0
 	help
 	  This provides the offset of the command line arguments for Linux
Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 2/4 Kconfig: cosmetic: Update description of CMD_SPL_NAND_OFS

The CMD_SPL_NAND_OFS description was a bit misleading, has been updated.

---

Changes in v2: None

 cmd/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
cmd/Kconfig +1 -2
index 7bc275f135..4dec190a38 100644
@@ -325,8 +325,7 @@ config CMD_SPL
 	  command.
 
 config CMD_SPL_NAND_OFS
-	hex "Offset of OS command line args for Falcon-mode NAND boot"
-	depends on CMD_SPL
+	hex "Offset of OS args or dtb for Falcon-mode NAND boot"
 	depends on CMD_SPL && (TPL_NAND_SUPPORT || SPL_NAND_SUPPORT)
 	default 0
 	help
Signature · 1 line
2.11.0
#2 lore raw

PATCH v2 2/4 Kconfig: cosmetic: Update description of CMD_SPL_NAND_OFS

Quoted 3 lines

The CMD_SPL_NAND_OFS description was a bit misleading, has been updated.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH v2 3/4 Kconfig: Add CMD_SPL_NOR_OFS config for falcon boot argument offset

In reply to Lukasz Majewski

This option will provide the offset in the parallel NOR flash memory to, which the falcon boot data is stored.

---

Changes in v2: None

 cmd/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)
cmd/Kconfig +8 -0
index 4dec190a38..b4b10cce00 100644
@@ -334,6 +334,14 @@ config CMD_SPL_NAND_OFS
 	  for full information about how to use this option (and also see
 	  board/gateworks/gw_ventana/README for an example).
 
+config CMD_SPL_NOR_OFS
+	hex "Offset of OS args or dtb for Falcon-mode NOR boot"
+	depends on CMD_SPL && SPL_NOR_SUPPORT
+	default 0
+	help
+	  This provides the offset of the command line arguments or dtb for
+	  Linux when booting from NOR in Falcon mode.
+
 config CMD_SPL_WRITE_SIZE
 	hex "Size of argument area"
 	depends on CMD_SPL
Signature · 1 line
2.11.0
#4 lore raw

PATCH v2 3/4 Kconfig: Add CMD_SPL_NOR_OFS config for falcon boot argument offset

Quoted 3 lines

This option will provide the offset in the parallel NOR flash memory to, which the falcon boot data is stored.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#5 lore raw

PATCH v2 4/4 doc: Update parallel NOR flash related information in README.falcon

In reply to Lukasz Majewski

This commit updates the doc/README.falcon regarding Falcon boot on NOR flash memories.

This code is used by MCCMON6 board - so for more details please refer to configs/mccmon6_nor_defconfig.

---

Changes in v2:
- Fix the description
- Update the comit message

 doc/README.falcon | 2 ++
 1 file changed, 2 insertions(+)
doc/README.falcon +2 -0
index 9a7f0bc235..713d7063a1 100644
@@ -67,6 +67,8 @@ CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
 
 CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.
 
+CONFIG_CMD_SPL_NOR_OFS	Offset in NOR where the parameters area was saved.
+
 CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
 
 CONFIG_SPL_OS_BOOT	Activate Falcon Mode.
Signature · 1 line
2.11.0
#6 lore raw

PATCH v2 4/4 doc: Update parallel NOR flash related information in README.falcon

Quoted 5 lines

This commit updates the doc/README.falcon regarding Falcon boot on NOR flash memories.
This code is used by MCCMON6 board - so for more details please refer to configs/mccmon6_nor_defconfig.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#7 lore raw

PATCH v2 1/4 Kconfig: Make CMD_SPL_NAND_OFS only available when proper memory is used

In reply to Lukasz Majewski
Quoted 5 lines

This commit makes the CMD_SPL_NAND_OFS only visible when we use NAND memory.
Before this change it was present when only CMD_SPL was enabled (and would stay when board with other falcon boot medium is used).

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================