Skip to contentSkip to conversation

pam_systemd: Include missing.h for secure_getenv

PATCH In review Khem Raj 3 participants 9 messages Jul 20, 2019 – Jul 24, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH v4 1/4 pam_systemd: Include missing.h for secure_getenv

'secure_getenv' api is not uniformly implemented across all C libraries therefore its good to include missing.h so it can use the alternative implementation where its not awvailable

Fixes
../git/src/login/pam_systemd.c:344:13: error: implicit declaration of function 'secure_getenv' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

        v = secure_getenv(key);
Signed-off-by Khem Raj <[email protected]>
---
 ...missing.h-check-for-missing-strndupa.patch | 71 +++----------------
 1 file changed, 10 insertions(+), 61 deletions(-)
meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch +10 -61
index a2e25a97df..df1043b27d 100644
@@ -43,8 +43,6 @@ Signed-off-by: Andrej Valek <[email protected]>
  src/udev/udev-rules.c                      |  1 +
  29 files changed, 40 insertions(+)
 
-diff --git a/meson.build b/meson.build
-index 79195c9..80d9564 100644
 --- a/meson.build
 +++ b/meson.build
 @@ -572,6 +572,7 @@ foreach ident : [

@@ -55,8 +53,6 @@ index 79195c9..80d9564 100644
  ]
  
          have = cc.has_function(ident[0], prefix : ident[1], args : '-D_GNU_SOURCE')
-diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c
-index dfd6805..c2b2ace 100644
 --- a/src/backlight/backlight.c
 +++ b/src/backlight/backlight.c
 @@ -17,6 +17,7 @@

@@ -67,8 +63,6 @@ index dfd6805..c2b2ace 100644
  
  static int find_pci_or_platform_parent(sd_device *device, sd_device **ret) {
          const char *subsystem, *sysname, *value;
-diff --git a/src/basic/env-util.c b/src/basic/env-util.c
-index fd449dc..e2b0722 100644
 --- a/src/basic/env-util.c
 +++ b/src/basic/env-util.c
 @@ -16,6 +16,7 @@

@@ -79,8 +73,6 @@ index fd449dc..e2b0722 100644
  
  #define VALID_CHARS_ENV_NAME                    \
          DIGITS LETTERS                          \
-diff --git a/src/basic/missing_stdlib.h b/src/basic/missing_stdlib.h
-index 188a8d4..1e16ec2 100644
 --- a/src/basic/missing_stdlib.h
 +++ b/src/basic/missing_stdlib.h
 @@ -11,3 +11,15 @@

@@ -99,8 +91,6 @@ index 188a8d4..1e16ec2 100644
 +    (char *)memcpy(__new, __old, __len); \
 +  })
 +#endif
-diff --git a/src/basic/mkdir.c b/src/basic/mkdir.c
-index 6b82eab..51c6b78 100644
 --- a/src/basic/mkdir.c
 +++ b/src/basic/mkdir.c
 @@ -14,6 +14,7 @@

@@ -111,8 +101,6 @@ index 6b82eab..51c6b78 100644
  
  int mkdir_safe_internal(const char *path, mode_t mode, uid_t uid, gid_t gid, MkdirFlags flags, mkdir_func_t _mkdir) {
          struct stat st;
-diff --git a/src/basic/parse-util.c b/src/basic/parse-util.c
-index 87724af..d9c53bc 100644
 --- a/src/basic/parse-util.c
 +++ b/src/basic/parse-util.c
 @@ -19,6 +19,7 @@

@@ -123,8 +111,6 @@ index 87724af..d9c53bc 100644
  
  int parse_boolean(const char *v) {
          if (!v)
-diff --git a/src/basic/proc-cmdline.c b/src/basic/proc-cmdline.c
-index 1670001..b51feaa 100644
 --- a/src/basic/proc-cmdline.c
 +++ b/src/basic/proc-cmdline.c
 @@ -15,6 +15,7 @@

@@ -135,8 +121,6 @@ index 1670001..b51feaa 100644
  
  int proc_cmdline(char **ret) {
          const char *e;
-diff --git a/src/basic/procfs-util.c b/src/basic/procfs-util.c
-index 7aaf95b..42ce53d 100644
 --- a/src/basic/procfs-util.c
 +++ b/src/basic/procfs-util.c
 @@ -11,6 +11,7 @@

@@ -147,8 +131,6 @@ index 7aaf95b..42ce53d 100644
  
  int procfs_tasks_get_limit(uint64_t *ret) {
          _cleanup_free_ char *value = NULL;
-diff --git a/src/basic/time-util.c b/src/basic/time-util.c
-index daf952b..374b97f 100644
 --- a/src/basic/time-util.c
 +++ b/src/basic/time-util.c
 @@ -28,6 +28,7 @@

@@ -159,8 +141,6 @@ index daf952b..374b97f 100644
  
  static clockid_t map_clock_id(clockid_t c) {
  
-diff --git a/src/core/dbus-cgroup.c b/src/core/dbus-cgroup.c
-index 4615aea..bc1364f 100644
 --- a/src/core/dbus-cgroup.c
 +++ b/src/core/dbus-cgroup.c
 @@ -15,6 +15,7 @@

@@ -171,8 +151,6 @@ index 4615aea..bc1364f 100644
  
  static BUS_DEFINE_PROPERTY_GET_ENUM(property_get_cgroup_device_policy, cgroup_device_policy, CGroupDevicePolicy);
  
-diff --git a/src/core/dbus-util.c b/src/core/dbus-util.c
-index f4fbb72..0a1e3b5 100644
 --- a/src/core/dbus-util.c
 +++ b/src/core/dbus-util.c
 @@ -7,6 +7,7 @@

@@ -183,8 +161,6 @@ index f4fbb72..0a1e3b5 100644
  
  int bus_property_get_triggered_unit(
                  sd_bus *bus,
-diff --git a/src/core/kmod-setup.c b/src/core/kmod-setup.c
-index a91cfeb..a459610 100644
 --- a/src/core/kmod-setup.c
 +++ b/src/core/kmod-setup.c
 @@ -11,6 +11,7 @@

@@ -195,8 +171,6 @@ index a91cfeb..a459610 100644
  
  #if HAVE_KMOD
  #include <libkmod.h>
-diff --git a/src/core/service.c b/src/core/service.c
-index 0289990..0e725b5 100644
 --- a/src/core/service.c
 +++ b/src/core/service.c
 @@ -42,6 +42,7 @@

@@ -207,8 +181,6 @@ index 0289990..0e725b5 100644
  
  static const UnitActiveState state_translation_table[_SERVICE_STATE_MAX] = {
          [SERVICE_DEAD] = UNIT_INACTIVE,
-diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c
-index 0048909..0e85eb7 100644
 --- a/src/journal/journalctl.c
 +++ b/src/journal/journalctl.c
 @@ -67,6 +67,7 @@

@@ -219,8 +191,6 @@ index 0048909..0e85eb7 100644
  
  #define DEFAULT_FSS_INTERVAL_USEC (15*USEC_PER_MINUTE)
  
-diff --git a/src/libsystemd/sd-bus/bus-message.c b/src/libsystemd/sd-bus/bus-message.c
-index 427d42f..b050568 100644
 --- a/src/libsystemd/sd-bus/bus-message.c
 +++ b/src/libsystemd/sd-bus/bus-message.c
 @@ -21,6 +21,7 @@

@@ -231,8 +201,6 @@ index 427d42f..b050568 100644
  
  static int message_append_basic(sd_bus_message *m, char type, const void *p, const void **stored);
  
-diff --git a/src/libsystemd/sd-bus/bus-objects.c b/src/libsystemd/sd-bus/bus-objects.c
-index d9fc256..e9c6932 100644
 --- a/src/libsystemd/sd-bus/bus-objects.c
 +++ b/src/libsystemd/sd-bus/bus-objects.c
 @@ -13,6 +13,7 @@

@@ -243,8 +211,6 @@ index d9fc256..e9c6932 100644
  
  static int node_vtable_get_userdata(
                  sd_bus *bus,
-diff --git a/src/libsystemd/sd-bus/test-bus-benchmark.c b/src/libsystemd/sd-bus/test-bus-benchmark.c
-index 8de0a85..4fd0a2e 100644
 --- a/src/libsystemd/sd-bus/test-bus-benchmark.c
 +++ b/src/libsystemd/sd-bus/test-bus-benchmark.c
 @@ -14,6 +14,7 @@

@@ -255,8 +221,6 @@ index 8de0a85..4fd0a2e 100644
  
  #define MAX_SIZE (2*1024*1024)
  
-diff --git a/src/locale/keymap-util.c b/src/locale/keymap-util.c
-index b8bd181..fe0cae0 100644
 --- a/src/locale/keymap-util.c
 +++ b/src/locale/keymap-util.c
 @@ -23,6 +23,7 @@

@@ -267,8 +231,6 @@ index b8bd181..fe0cae0 100644
  
  static bool startswith_comma(const char *s, const char *prefix) {
          s = startswith(s, prefix);
-diff --git a/src/nspawn/nspawn-settings.c b/src/nspawn/nspawn-settings.c
-index 476cb07..91e28de 100644
 --- a/src/nspawn/nspawn-settings.c
 +++ b/src/nspawn/nspawn-settings.c
 @@ -16,6 +16,7 @@

@@ -279,8 +241,6 @@ index 476cb07..91e28de 100644
  
  Settings *settings_new(void) {
          Settings *s;
-diff --git a/src/shared/dns-domain.c b/src/shared/dns-domain.c
-index 4b31cb3..989ebf3 100644
 --- a/src/shared/dns-domain.c
 +++ b/src/shared/dns-domain.c
 @@ -24,6 +24,7 @@

@@ -291,8 +251,6 @@ index 4b31cb3..989ebf3 100644
  
  int dns_label_unescape(const char **name, char *dest, size_t sz, DNSLabelFlags flags) {
          const char *n;
-diff --git a/src/shared/journal-importer.c b/src/shared/journal-importer.c
-index 8638cd3..d03774a 100644
 --- a/src/shared/journal-importer.c
 +++ b/src/shared/journal-importer.c
 @@ -13,6 +13,7 @@

@@ -303,8 +261,6 @@ index 8638cd3..d03774a 100644
  
  enum {
          IMPORTER_STATE_LINE = 0,    /* waiting to read, or reading line */
-diff --git a/src/shared/logs-show.c b/src/shared/logs-show.c
-index 5fb736f..19cb165 100644
 --- a/src/shared/logs-show.c
 +++ b/src/shared/logs-show.c
 @@ -38,6 +38,7 @@

@@ -315,8 +271,6 @@ index 5fb736f..19cb165 100644
  
  /* up to three lines (each up to 100 characters) or 300 characters, whichever is less */
  #define PRINT_LINE_THRESHOLD 3
-diff --git a/src/shared/pager.c b/src/shared/pager.c
-index 2abb0f6..a00c95f 100644
 --- a/src/shared/pager.c
 +++ b/src/shared/pager.c
 @@ -25,6 +25,7 @@

@@ -327,8 +281,6 @@ index 2abb0f6..a00c95f 100644
  
  static pid_t pager_pid = 0;
  
-diff --git a/src/shared/path-lookup.c b/src/shared/path-lookup.c
-index 442fde7..0eb1188 100644
 --- a/src/shared/path-lookup.c
 +++ b/src/shared/path-lookup.c
 @@ -20,6 +20,7 @@

@@ -339,8 +291,6 @@ index 442fde7..0eb1188 100644
  
  int xdg_user_runtime_dir(char **ret, const char *suffix) {
          const char *e;
-diff --git a/src/shared/uid-range.c b/src/shared/uid-range.c
-index 7cb7d8a..8b12b91 100644
 --- a/src/shared/uid-range.c
 +++ b/src/shared/uid-range.c
 @@ -9,6 +9,7 @@

@@ -351,8 +301,6 @@ index 7cb7d8a..8b12b91 100644
  
  static bool uid_range_intersect(UidRange *range, uid_t start, uid_t nr) {
          assert(range);
-diff --git a/src/socket-proxy/socket-proxyd.c b/src/socket-proxy/socket-proxyd.c
-index abbbc9f..6179b58 100644
 --- a/src/socket-proxy/socket-proxyd.c
 +++ b/src/socket-proxy/socket-proxyd.c
 @@ -28,6 +28,7 @@

@@ -363,8 +311,6 @@ index abbbc9f..6179b58 100644
  
  #define BUFFER_SIZE (256 * 1024)
  
-diff --git a/src/test/test-hexdecoct.c b/src/test/test-hexdecoct.c
-index 5221742..a05e778 100644
 --- a/src/test/test-hexdecoct.c
 +++ b/src/test/test-hexdecoct.c
 @@ -6,6 +6,7 @@

@@ -375,8 +321,6 @@ index 5221742..a05e778 100644
  
  static void test_hexchar(void) {
          assert_se(hexchar(0xa) == 'a');
-diff --git a/src/udev/udev-builtin-path_id.c b/src/udev/udev-builtin-path_id.c
-index 7ce1c56..cc19b8e 100644
 --- a/src/udev/udev-builtin-path_id.c
 +++ b/src/udev/udev-builtin-path_id.c
 @@ -23,6 +23,7 @@

@@ -387,8 +331,6 @@ index 7ce1c56..cc19b8e 100644
  
  _printf_(2,3)
  static void path_prepend(char **path, const char *fmt, ...) {
-diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c
-index ee87d7c..9aced10 100644
 --- a/src/udev/udev-rules.c
 +++ b/src/udev/udev-rules.c
 @@ -40,6 +40,7 @@

@@ -399,6 +341,13 @@ index ee87d7c..9aced10 100644
  
  #define PREALLOC_TOKEN          2048
  #define RULES_DIRS (const char* const*) CONF_PATHS_STRV("udev/rules.d")
--- 
-2.11.0
-
+--- a/src/login/pam_systemd.c
++++ b/src/login/pam_systemd.c
+@@ -27,6 +27,7 @@
+ #include "hostname-util.h"
+ #include "login-util.h"
+ #include "macro.h"
++#include "missing.h"
+ #include "parse-util.h"
+ #include "path-util.h"
+ #include "process-util.h"
Signature · 1 line
2.22.0
author
#1 lore raw

PATCH v4 2/4 musl-obstack: Add recipe

obstacks from GNUlib is used in some OE-Core packages e.g. elfutils and other packages outside OE-Core, this recipe helps provide this functionality standalone on musl systems, and helps in getting full versions of dependent packages

Signed-off-by Khem Raj <[email protected]>
---
 meta/recipes-core/musl/musl-obstack.bb | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 meta/recipes-core/musl/musl-obstack.bb
meta/recipes-core/musl/musl-obstack.bb new file +22 -0
new file mode 100644
index 0000000000..3003935fe5
@@ -0,0 +1,22 @@
+# Copyright (C) 2019 Khem Raj <[email protected]>
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+SUMMARY = "A standalone library to implement GNU libc's obstack"
+DESCRIPTION = "copy + paste of the obstack functions and macros found in GNU gcc libiberty library for use with musl libc"
+HOMEPAGE = "https://github.com/pullmoll/musl-obstack"
+LICENSE = "GPL-2.0+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=3d23e4eef8243efcaab6f0a438078932"
+SECTION = "libs"
+
+PV = "1.1"
+SRCREV = "d2ad66b0df44a4b784956f7f7f2717131ddc05f4"
+SRC_URI = "git://github.com/pullmoll/musl-obstack"
+
+UPSTREAM_CHECK_COMMITS = "1"
+
+inherit autotools pkgconfig
+
+S = "${WORKDIR}/git"
+
+COMPATIBLE_HOST = ".*-musl.*"
+
Signature · 1 line
2.22.0
author
#2 lore raw

PATCH v4 3/4 elfutils: Fix eu-* utils builds for musl

In reply to Khem Raj

Re-organize the musl patches in three different areas namely libs, utils and tests, this will help maintain them in future version bumps

Add obstack dependency on musl targets which is needed for eu-*

PN and PN-binutils is not empty anymore on musl

Signed-off-by Khem Raj <[email protected]>
Signed-off-by Richard Purdie <[email protected]>
---
 .../elfutils/elfutils_0.176.bb                |  15 +-
 ...-err-variable-and-function-conflicts.patch |  91 --------
 ...ternatives-for-glibc-assumptions-hel.patch | 196 ------------------
 .../elfutils/files/musl-libs.patch            | 111 ++++++++++
 .../elfutils/files/musl-obstack-fts.patch     | 105 ++++++++++
 .../files/{musl.patch => musl-tests.patch}    |   0
 .../elfutils/files/musl-utils.patch           | 136 ++++++++++++
 7 files changed, 359 insertions(+), 295 deletions(-)
 delete mode 100644 meta/recipes-devtools/elfutils/files/0001-fix-err-variable-and-function-conflicts.patch
 delete mode 100644 meta/recipes-devtools/elfutils/files/0008-build-Provide-alternatives-for-glibc-assumptions-hel.patch
 create mode 100644 meta/recipes-devtools/elfutils/files/musl-libs.patch
 create mode 100644 meta/recipes-devtools/elfutils/files/musl-obstack-fts.patch
 rename meta/recipes-devtools/elfutils/files/{musl.patch => musl-tests.patch} (100%)
 create mode 100644 meta/recipes-devtools/elfutils/files/musl-utils.patch
meta/recipes-devtools/elfutils/elfutils_0.176.bb +7 -8
index 5b8049f531..75acf59d26 100644
@@ -4,7 +4,7 @@ SECTION = "base"
 LICENSE = "GPLv2 & LGPLv3+ & GPLv3+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 DEPENDS = "libtool bzip2 zlib virtual/libintl"
-DEPENDS_append_libc-musl = " argp-standalone fts "
+DEPENDS_append_libc-musl = " argp-standalone fts musl-obstack "
 # The Debian patches below are from:
 # http://ftp.de.debian.org/debian/pool/main/e/elfutils/elfutils_0.175-1.debian.tar.xz
 SRC_URI = "https://sourceware.org/elfutils/ftp/${PV}/${BP}.tar.bz2 \

@@ -31,12 +31,13 @@ SRC_URI = "https://sourceware.org/elfutils/ftp/${PV}/${BP}.tar.bz2 \
            file://0001-skip-the-test-when-gcc-not-deployed.patch \
            file://run-ptest \
            file://ptest.patch \
-           file://musl.patch \
            "
-SRC_URI_append_libc-musl = " file://0008-build-Provide-alternatives-for-glibc-assumptions-hel.patch \
-                             file://0001-fix-err-variable-and-function-conflicts.patch \
-"
-
+SRC_URI_append_libc-musl = " \
+           file://musl-obstack-fts.patch \
+           file://musl-libs.patch \
+           file://musl-utils.patch \
+           file://musl-tests.patch \
+           "
 SRC_URI[md5sum] = "077e4f49320cad82bf17a997068b1db9"
 SRC_URI[sha256sum] = "eb5747c371b0af0f71e86215a5ebb88728533c3a104a43d4231963f308cd1023"
 

@@ -85,8 +86,6 @@ do_install_ptest() {
 EXTRA_OEMAKE_class-native = ""
 EXTRA_OEMAKE_class-nativesdk = ""
 
-ALLOW_EMPTY_${PN}_libc-musl = "1"
-
 BBCLASSEXTEND = "native nativesdk"
 
 # Package utilities separately
meta/recipes-devtools/elfutils/files/0001-fix-err-variable-and-function-conflicts.patch deleted +0 -91

91 lines not on this page · raw message

meta/recipes-devtools/elfutils/files/0008-build-Provide-alternatives-for-glibc-assumptions-hel.patch deleted +0 -196

196 lines not on this page · raw message

meta/recipes-devtools/elfutils/files/musl-libs.patch new file +111 -0

111 lines not on this page · raw message

meta/recipes-devtools/elfutils/files/musl-obstack-fts.patch new file +105 -0

105 lines not on this page · raw message

meta/recipes-devtools/elfutils/files/musl-tests.patch renamed from meta/recipes-devtools/elfutils/files/musl.patch +0 -0
similarity index 100%
rename from meta/recipes-devtools/elfutils/files/musl.patch
rename to meta/recipes-devtools/elfutils/files/musl-tests.patch
meta/recipes-devtools/elfutils/files/musl-utils.patch new file +136 -0

136 lines not on this page · raw message

Signature · 1 line
2.22.0
#3 lore raw

Re: [PATCH V4 3/4] elfutils: Fix eu-* utils builds for musl

Quoted 5 lines · Khem Raj

...
++#if !defined(FNM_EXTMATCH)
++# define FNM_EXTMATCH (0)
++#endif
...

As already said in [1] this is expected to result in broken code, and the upstream testsuite also confirms this.

cu
Adrian

[1]
http://lists.openembedded.org/pipermail/openembedded-core/2019-May/282787.html

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw

Re: [PATCH V4 3/4] elfutils: Fix eu-* utils builds for musl

Quoted 9 lines · Adrian Bunk
Quoted 5 lines · Khem Raj

...
++#if !defined(FNM_EXTMATCH)
++# define FNM_EXTMATCH (0)
++#endif
...

As already said in [1] this is expected to result in broken code, and the upstream testsuite also confirms this.

I've taken the patches as they don't make things worse. I am a bit concerned about a few places musl is building up problematic patches though (systemd, elfutils, ltp come to mind).

Cheers,

Richard

author
#5 lore raw

Re: [PATCH V4 3/4] elfutils: Fix eu-* utils builds for musl

Quoted 8 lines · Richard Purdie
Quoted 7 lines · Adrian Bunk
Quoted 5 lines · Khem Raj

...
++#if !defined(FNM_EXTMATCH)
++# define FNM_EXTMATCH (0)
++#endif
...

Quoted 7 lines
Quoted 2 lines

As already said in [1] this is expected to result in broken code, and the upstream testsuite also confirms this.

I've taken the patches as they don't make things worse. I am a bit concerned about a few places musl is building up problematic patches though (systemd, elfutils, ltp come to mind).

Yes I am aware of this I think LTP we are upstreaming and I hope this will be better in future
Systemd we might have to re-evaluate but I think few patches are worthy of upstreaming elfutils I don’t know yet

Quoted 6 lines

Cheers,

Richard

#6 lore raw

Re: [PATCH V4 3/4] elfutils: Fix eu-* utils builds for musl

Quoted 19 lines · Khem Raj
Quoted 8 lines · Richard Purdie
Quoted 7 lines · Adrian Bunk
Quoted 5 lines · Khem Raj

...
++#if !defined(FNM_EXTMATCH)
++# define FNM_EXTMATCH (0)
++#endif
...

Quoted 7 lines
Quoted 2 lines

As already said in [1] this is expected to result in broken code, and the upstream testsuite also confirms this.

I've taken the patches as they don't make things worse. I am a bit concerned about a few places musl is building up problematic patches though (systemd, elfutils, ltp come to mind).

Quoted 4 lines

Yes I am aware of this I think LTP we are upstreaming and I hope this will be better in future
Systemd we might have to re-evaluate but I think few patches are worthy of upstreaming elfutils I don’t know yet

elfutils and the same bogus change in ifupdown might need the implementation from glibc added as an own package, similar to what you've already done for argp and obstack.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#7 lore raw

Re: [PATCH V4 3/4] elfutils: Fix eu-* utils builds for musl

Quoted 21 lines · Adrian Bunk
Quoted 19 lines · Khem Raj
Quoted 15 lines · Richard Purdie
Quoted 9 lines · Adrian Bunk
Quoted 5 lines · Khem Raj

...
++#if !defined(FNM_EXTMATCH)
++# define FNM_EXTMATCH (0)
++#endif
...

As already said in [1] this is expected to result in broken code, and the upstream testsuite also confirms this.

I've taken the patches as they don't make things worse. I am a bit concerned about a few places musl is building up problematic patches though (systemd, elfutils, ltp come to mind).

Quoted 9 lines
Quoted 4 lines

Yes I am aware of this I think LTP we are upstreaming and I hope this will be better in future
Systemd we might have to re-evaluate but I think few patches are worthy of upstreaming elfutils I don’t know yet

elfutils and the same bogus change in ifupdown might need the implementation from glibc added as an own package, similar to what you've already done for argp and obstack.

yes FNM_EXTMATCH change needs to be done logically at app level, instead of defining it
sometimes apps just use it because its available and covers vast set that maybe otherwise not
needed.

Quoted 10 lines

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

author
#8 lore raw

PATCH v4 4/4 maintainers: Account for musl-obstack and libssp-nonshared

In reply to Khem Raj
Signed-off-by Khem Raj <[email protected]>
Signed-off-by Richard Purdie <[email protected]>
---
 meta/conf/distro/include/maintainers.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/conf/distro/include/maintainers.inc +2 -0
index d403ed7938..77a753a5bf 100644
@@ -387,6 +387,7 @@ RECIPE_MAINTAINER_pn-libsm = "Armin Kuster <[email protected]>"
 RECIPE_MAINTAINER_pn-libsndfile1 = "Tanu Kaskinen <[email protected]>"
 RECIPE_MAINTAINER_pn-libsolv = "Anuj Mittal <[email protected]>"
 RECIPE_MAINTAINER_pn-libsoup-2.4 = "Anuj Mittal <[email protected]>"
+RECIPE_MAINTAINER_pn-libssp-nonshared = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-libtasn1 = "Anuj Mittal <[email protected]>"
 RECIPE_MAINTAINER_pn-libtest-needs-perl = "Tim Orling <[email protected]>"
 RECIPE_MAINTAINER_pn-libtheora = "Alexander Kanavin <[email protected]>"

@@ -517,6 +518,7 @@ RECIPE_MAINTAINER_pn-mtd-utils = "Denys Dmytriyenko <[email protected]>"
 RECIPE_MAINTAINER_pn-mtdev = "Anuj Mittal <[email protected]>"
 RECIPE_MAINTAINER_pn-mtools = "Anuj Mittal <[email protected]>"
 RECIPE_MAINTAINER_pn-musl = "Khem Raj <[email protected]>"
+RECIPE_MAINTAINER_pn-musl-obstack = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-musl-utils = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-mx-1.0 = "Anuj Mittal <[email protected]>"
 RECIPE_MAINTAINER_pn-nasm = "Richard Purdie <[email protected]>"
Signature · 1 line
2.22.0