Skip to contentSkip to conversation

package/gstreamer1: fix build with NLS

PATCH New Fabrice Fontaine 3 participants 3 messages Jul 11, 2019 – Jul 20, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gstreamer1: fix build with NLS

Fixes:
- http://autobuild.buildroot.org/results/6d3be9feb301495b079eff6283f1cbed9603dc42

---
 package/gstreamer1/gstreamer1/gstreamer1.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/gstreamer1/gstreamer1/gstreamer1.mk +4 -1
index cea933be84..023cf4e85e 100644
@@ -33,6 +33,9 @@ GSTREAMER1_DEPENDENCIES = \
 	host-pkgconf \
 	libglib2 \
 	$(if $(BR2_PACKAGE_LIBUNWIND),libunwind) \
-	$(if $(BR2_PACKAGE_VALGRIND),valgrind)
+	$(if $(BR2_PACKAGE_VALGRIND),valgrind) \
+	$(TARGET_NLS_DEPENDENCIES)
+
+GSTREAMER1_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
 
 $(eval $(meson-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/gstreamer1: fix build with NLS

Quoted 13 lines · Fabrice Fontaine

Fixes:
- http://autobuild.buildroot.org/results/6d3be9feb301495b079eff6283f1cbed9603dc42

---
 package/gstreamer1/gstreamer1/gstreamer1.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/gstreamer1/gstreamer1/gstreamer1.mk +0 -0
index cea933be84..023cf4e85e 100644

package/gstreamer1/gstreamer1/gstreamer1.mk GSTREAMER1_DEPENDENCIES = \ · line 39

Quoted 8 lines
package/gstreamer1/gstreamer1/gstreamer1.mk +4 -1
@@ -33,6 +33,9 @@ GSTREAMER1_DEPENDENCIES = \
 	host-pkgconf \
 	libglib2 \
 	$(if $(BR2_PACKAGE_LIBUNWIND),libunwind) \
-	$(if $(BR2_PACKAGE_VALGRIND),valgrind)
+	$(if $(BR2_PACKAGE_VALGRIND),valgrind) \
+	$(TARGET_NLS_DEPENDENCIES)
+
+GSTREAMER1_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)

Adam, can you respin the rest of the gst -> meson series taking this into account?

Regards,
Arnout

Quoted 3 lines
package/gstreamer1/gstreamer1/gstreamer1.mk +0 -0
 $(eval $(meson-package))
 
#2 lore raw

PATCH 1/1 package/gstreamer1: fix build with NLS

In reply to Fabrice Fontaine
Quoted 7 lines · On Thu, 11 Jul 2019 18:56:55 +0200 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/6d3be9feb301495b079eff6283f1cbed9603dc42

---
 package/gstreamer1/gstreamer1/gstreamer1.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com