Skip to contentSkip to conversation

fs/omfs: make use of kmemdup

PATCH In review Hariprasad Kelam 2 participants 2 messages Jul 21, 2019 – Jul 22, 2019 Omfs filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/omfs: make use of kmemdup

kmalloc + memcpy can be replaced with kmemdup.

fix below issue reported by coccicheck ./fs/omfs/inode.c:366:9-16: WARNING opportunity for kmemdup

---
 fs/omfs/inode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/omfs/inode.c +1 -2
index 08226a8..bc5a072 100644
@@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb)
 		bh = sb_bread(sb, block++);
 		if (!bh)
 			goto nomem_free;
-		*ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
+		*ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
 		if (!*ptr) {
 			brelse(bh);
 			goto nomem_free;
 		}
-		memcpy(*ptr, bh->b_data, sb->s_blocksize);
 		if (count < sb->s_blocksize)
 			memset((void *)*ptr + count, 0xff,
 				sb->s_blocksize - count);
Signature · 1 line
2.7.4