Skip to contentSkip to conversation

package/glib-networking: needs dynamic library

PATCH Superseded Fabrice Fontaine 2 participants 2 messages Jul 18, 2019 – Jul 21, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/glib-networking: needs dynamic library

glib-networking uses the meson's shared_module function

Fixes:
- http://autobuild.buildroot.org/results/60037e37e020404485df9814f3f3ad4e3b2abdb3

---
 package/glib-networking/Config.in | 6 ++++--
 package/libsoup/Config.in         | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)
package/glib-networking/Config.in +4 -2
index ec2962392c..339eee1139 100644
@@ -3,10 +3,12 @@ config BR2_PACKAGE_GLIB_NETWORKING
 	depends on BR2_USE_WCHAR # glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	depends on BR2_USE_MMU # glib2
+	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_LIBGLIB2
 	help
 	  Network-related GIO modules for glib.
 
-comment "glib-networking needs a toolchain w/ wchar, threads"
+comment "glib-networking needs a toolchain w/ wchar, threads, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_STATIC_LIBS
package/libsoup/Config.in +1 -1
index 599f9594d9..f6f8fde968 100644
@@ -22,7 +22,7 @@ config BR2_PACKAGE_LIBSOUP_GNOME
 
 config BR2_PACKAGE_LIBSOUP_SSL
 	bool "https support"
-	depends on !BR2_STATIC_LIBS # gnutls
+	depends on !BR2_STATIC_LIBS # glib-networking, gnutls
 	select BR2_PACKAGE_GLIB_NETWORKING
 	select BR2_PACKAGE_GNUTLS
 	help
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/glib-networking: needs dynamic library

Hello Fabrice,

Quoted 20 lines · Fabrice Fontaine

glib-networking uses the meson's shared_module function

Fixes:
- http://autobuild.buildroot.org/results/60037e37e020404485df9814f3f3ad4e3b2abdb3

---
 package/glib-networking/Config.in | 6 ++++--
 package/libsoup/Config.in         | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)
package/glib-networking/Config.in +1 -0
index ec2962392c..339eee1139 100644
@@ -3,10 +3,12 @@ config BR2_PACKAGE_GLIB_NETWORKING
 	depends on BR2_USE_WCHAR # glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	depends on BR2_USE_MMU # glib2
+	depends on !BR2_STATIC_LIBS

package/glib-networking/Config.in config BR2_PACKAGE_GLIB_NETWORKING · line 14

Quoted 10 lines
package/glib-networking/Config.in +3 -2
 	select BR2_PACKAGE_LIBGLIB2
 	help
 	  Network-related GIO modules for glib.
 
-comment "glib-networking needs a toolchain w/ wchar, threads"
+comment "glib-networking needs a toolchain w/ wchar, threads, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_STATIC_LIBS

Please mention in the commit log that this is a partly revert of commit ed3eef6bb49270de619e5a86a249fdd8724c40cd 'package/glib-networking: bump to version 2.61.1' re-adding the dynamic library dependency but from a different demand...

package/libsoup/Config.in config BR2_PACKAGE_LIBSOUP_GNOME · line 28

Quoted 13 lines
package/libsoup/Config.in +1 -1
index 599f9594d9..f6f8fde968 100644
@@ -22,7 +22,7 @@ config BR2_PACKAGE_LIBSOUP_GNOME
 
 config BR2_PACKAGE_LIBSOUP_SSL
 	bool "https support"
-	depends on !BR2_STATIC_LIBS # gnutls
+	depends on !BR2_STATIC_LIBS # glib-networking, gnutls
 	select BR2_PACKAGE_GLIB_NETWORKING
 	select BR2_PACKAGE_GNUTLS
 	help

And mention that the only direct user of BR2_PACKAGE_LIBSOUP_SSL is package/webkitgtk for the option BR2_PACKAGE_WEBKITGTK_HTTPS which already has (from lagacy) the dependency on !BR2_STATIC_LIBS and/or update the comment in package/webkitgtk/Config.in...

With this changes you can add my

Regards,
Peter