hexagon: switch to generic version of pte allocation
Subsystems (2)
PATCH RESEND v2 6/14 hexagon: switch to generic version of pte allocation
Hi,
The patch below was a part of of the series that switched a couple of arches to use generic versions of pte_{alloc,free}_one.
Unfortunately, it fell between the cracks and I've noticed this only today :(
I understand that merge window is going to close in couple of hours, but maybe this may still go in?
Signature · 18 lines
Sincerely yours, Mike. From e298accfb0b023de70e255adf3f9a8d1b2c01063 Mon Sep 17 00:00:00 2001 From: Mike Rapoport <[email protected]> Date: Tue, 30 Apr 2019 17:27:50 +0300 Subject: [PATCH v2 06/14] hexagon: switch to generic version of pte allocation The hexagon implementation pte_alloc_one(), pte_alloc_one_kernel(), pte_free_kernel() and pte_free() is identical to the generic except of lack of __GFP_ACCOUNT for the user PTEs allocation. Switch hexagon to use generic version of these functions. Signed-off-by: Mike Rapoport <[email protected]> --- arch/hexagon/include/asm/pgalloc.h | 34 ++-------------------------------- 1 file changed, 2 insertions(+), 32 deletions(-)
arch/hexagon/include/asm/pgalloc.h +2 -32
@@ -24,6 +24,8 @@#include <asm/mem-layout.h> #include <asm/atomic.h> +#include <asm-generic/pgalloc.h> /* for pte_{alloc,free}_one */ +#define check_pgt_cache () do {} while (0)extern unsigned long long kmap_generation;
@@ -59,38 +61,6 @@ static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd)free_page ((unsigned long ) pgd); } -static inline struct page *pte_alloc_one (struct mm_struct *mm) -{ -struct page *pte; - - pte =alloc_page (GFP_KERNEL | __GFP_ZERO); -if (!pte) -return NULL ; -if (!pgtable_page_ctor (pte)) { -__free_page (pte); -return NULL ; - } -return pte; -} - -/* _kernel variant gets to use a different allocator */ -static inline pte_t *pte_alloc_one_kernel (struct mm_struct *mm) -{ -gfp_t flags =GFP_KERNEL | __GFP_ZERO; -return (pte_t *)__get_free_page (flags); -} - -static inline void pte_free (struct mm_struct *mm,struct page *pte) -{ -pgtable_page_dtor (pte); -__free_page (pte); -} - -static inline void pte_free_kernel (struct mm_struct *mm,pte_t *pte) -{ -free_page ((unsigned long )pte); -} -static inline void pmd_populate (struct mm_struct *mm,pmd_t *pmd,pgtable_t pte) {
Signature · 1 line
2.7.4
Linus Torvalds
AppliedQuoted 3 lines · Mike Rapoport
I understand that merge window is going to close in couple of hours, but maybe this may still go in?
Applied.
Linus