drm/fb: remove unused function: drm_gem_fbdev_fb_create()
Subsystems (2)
PATCH 1/1 drm/fb: remove unused function: drm_gem_fbdev_fb_create()
After migrating several drivers to the generic fbdev there are no users left. Delete the function.
Noticed that there was no callers while browsing
around in the drm_fb* code.
Last user was removed with:
commit 13aff184ed9f ("drm/qxl: remove dead qxl fbdev emulation code") commit 26d4707d445d ("drm/qxl: use generic fbdev emulation")
---
git grep showed no users, and drm was build
tested after removal for good measure.
Sam
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 43 -------------------- include/drm/drm_gem_framebuffer_helper.h | 7 ---- 2 files changed, 50 deletions(-)
drivers/gpu/drm/drm_gem_framebuffer_helper.c +0 -43
@@ -322,46 +322,3 @@ int drm_gem_fb_simple_display_pipe_prepare_fb(struct drm_simple_display_pipe *pireturn drm_gem_fb_prepare_fb (&pipe->plane, plane_state); }EXPORT_SYMBOL (drm_gem_fb_simple_display_pipe_prepare_fb); - -/** -* drm_gem_fbdev_fb_create - Create a GEM backed &drm_framebuffer for fbdev -* emulation -* @dev: DRM device -* @sizes: fbdev size description -* @pitch_align: Optional pitch alignment -* @obj: GEM object backing the framebuffer -* @funcs: Optional vtable to be used for the new framebuffer object when the -* dirty callback is needed. -* -* This function creates a framebuffer from a &drm_fb_helper_surface_size -* description for use in the &drm_fb_helper_funcs.fb_probe callback. -* -* Returns: -* Pointer to a &drm_framebuffer on success or an error pointer on failure. -*/ -struct drm_framebuffer * -drm_gem_fbdev_fb_create (struct drm_device *dev, -struct drm_fb_helper_surface_size *sizes, -unsigned int pitch_align,struct drm_gem_object *obj, -const struct drm_framebuffer_funcs *funcs) -{ -struct drm_mode_fb_cmd2 mode_cmd = {0 }; - - mode_cmd.width = sizes->surface_width; - mode_cmd.height = sizes->surface_height; - mode_cmd.pitches[0 ] = sizes->surface_width * -DIV_ROUND_UP (sizes->surface_bpp,8 ); -if (pitch_align) - mode_cmd.pitches[0 ] =roundup (mode_cmd.pitches[0 ], - pitch_align); - mode_cmd.pixel_format =drm_driver_legacy_fb_format (dev, sizes->surface_bpp, - sizes->surface_depth); -if (obj->size < mode_cmd.pitches[0 ] * mode_cmd.height) -return ERR_PTR (-EINVAL ); - -if (!funcs) - funcs = &drm_gem_fb_funcs; - -return drm_gem_fb_alloc (dev, &mode_cmd, &obj,1 , funcs); -} -EXPORT_SYMBOL (drm_gem_fbdev_fb_create);
include/drm/drm_gem_framebuffer_helper.h +0 -7
@@ -33,11 +33,4 @@ int drm_gem_fb_prepare_fb(struct drm_plane *plane, struct drm_plane_state *state);int drm_gem_fb_simple_display_pipe_prepare_fb (struct drm_simple_display_pipe *pipe,struct drm_plane_state *plane_state); - -struct drm_framebuffer * -drm_gem_fbdev_fb_create (struct drm_device *dev, -struct drm_fb_helper_surface_size *sizes, -unsigned int pitch_align,struct drm_gem_object *obj, -const struct drm_framebuffer_funcs *funcs); -#endif
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Den 21.07.2019 16.06, skrev Sam Ravnborg:
Quoted 9 lines
After migrating several drivers to the generic fbdev there are no users left. Delete the function.
Noticed that there was no callers while browsing
around in the drm_fb* code.Last user was removed with:
commit13aff184ed9f("drm/qxl: remove dead qxl fbdev emulation code") commit26d4707d445d("drm/qxl: use generic fbdev emulation")
Listing 2 commits for the same driver was confusing. I think you can drop the second one since it's the first that contained the function call.
Quoted 6 lines
Signed-off-by Sam Ravnborg <[email protected]>Cc Noralf Trønnes <[email protected]>Cc Gerd Hoffmann <[email protected]>Cc Daniel Vetter <[email protected]>---
Thanks for cleaning up.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sam Ravnborg
Reviewed-by Noralf TrønnesHi Noralf.
Quoted 9 lines · Noralf Trønnes
Den 21.07.2019 16.06, skrev Sam Ravnborg:
Quoted 6 lines
After migrating several drivers to the generic fbdev there are no users left. Delete the function.
Noticed that there was no callers while browsing
around in the drm_fb* code.
Quoted 6 lines
Quoted 3 lines
Last user was removed with:
commit13aff184ed9f("drm/qxl: remove dead qxl fbdev emulation code") commit26d4707d445d("drm/qxl: use generic fbdev emulation")Listing 2 commits for the same driver was confusing. I think you can drop the second one since it's the first that contained the function call.
I updated the changelog like this and applied and pushed out.
Thanks,
Sam
Changelog:
After migrating several drivers to the generic fbdev emulation there are no users left of drm_gem_fbdev_fb_create. Delete the function.
Noticed that there was no callers while browsing around in the drm_fb* code.
The code that referenced the function was removed by:
commit 13aff184ed9f ("drm/qxl: remove dead qxl fbdev emulation code")
The actual use was removed by:
commit 26d4707d445d ("drm/qxl: use generic fbdev emulation")
v2:
- Updated changelog based on feedback from Noralf
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel