Skip to contentSkip to conversation

ARM: check stmfd instruction using right shift

PATCH New Chunyan Zhang 2 participants 5 messages Jul 22, 2019 – Jul 31, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: check stmfd instruction using right shift

From: Lvqiang Huang <[email protected]>

In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),

-               .word   0xe92d0000 >> 10        @ stmfd sp!, {}
+               .word   0xe92d0000 >> 11        @ stmfd sp!, {}

then the shift need to change to 11.

---
 arch/arm/lib/backtrace.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/lib/backtrace.S +1 -1
index 7d7952e..926851b 100644
@@ -70,7 +70,7 @@ for_each_frame:	tst	frame, mask		@ Check for address exceptions
 
 1003:		ldr	r2, [sv_pc, #-4]	@ if stmfd sp!, {args} exists,
 		ldr	r3, .Ldsi+4		@ adjust saved 'pc' back one
-		teq	r3, r2, lsr #10		@ instruction
+		teq	r3, r2, lsr #11		@ instruction
 		subne	r0, sv_pc, #4		@ allow for mov
 		subeq	r0, sv_pc, #8		@ allow for mov + stmia
 
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: check stmfd instruction using right shift

From: Lvqiang Huang <[email protected]>

In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),

-               .word   0xe92d0000 >> 10        @ stmfd sp!, {}
+               .word   0xe92d0000 >> 11        @ stmfd sp!, {}

then the shift need to change to 11.

Fixes ef41b5c92498 ("ARM: make kernel oops easier to read")
---
 arch/arm/lib/backtrace.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/lib/backtrace.S +1 -1
index 7d7952e..926851b 100644
@@ -70,7 +70,7 @@ for_each_frame:	tst	frame, mask		@ Check for address exceptions
 
 1003:		ldr	r2, [sv_pc, #-4]	@ if stmfd sp!, {args} exists,
 		ldr	r3, .Ldsi+4		@ adjust saved 'pc' back one
-		teq	r3, r2, lsr #10		@ instruction
+		teq	r3, r2, lsr #11		@ instruction
 		subne	r0, sv_pc, #4		@ allow for mov
 		subeq	r0, sv_pc, #8		@ allow for mov + stmia
 
Signature · 7 lines
1.7.9.5


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

Gentle ping

probably this patch was missed or entered into spam?

Quoted 31 lines · Chunyan Zhang

From: Lvqiang Huang <[email protected]>

In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),

(quoted diff) +1 -1
-               .word   0xe92d0000 >> 10        @ stmfd sp!, {}
+               .word   0xe92d0000 >> 11        @ stmfd sp!, {}

then the shift need to change to 11.

Fixes ef41b5c92498 ("ARM: make kernel oops easier to read")
---
 arch/arm/lib/backtrace.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/lib/backtrace.S +1 -2
index 7d7952e..926851b 100644
@@ -70,7 +70,7 @@ for_each_frame:       tst     frame, mask             @ Check for address exceptions
 
 1003:          ldr     r2, [sv_pc, #-4]        @ if stmfd sp!, {args} exists,
                ldr     r3, .Ldsi+4             @ adjust saved 'pc' back one
-               teq     r3, r2, lsr #10         @ instruction
+               teq     r3, r2, lsr #11         @ instruction
                subne   r0, sv_pc, #4           @ allow for mov
                subeq   r0, sv_pc, #8           @ allow for mov + stmia
 
--

1.7.9.5

#3 lore raw
Quoted 3 lines · Chunyan Zhang

Gentle ping

probably this patch was missed or entered into spam?

Please submit it to the patch system, thanks.

Quoted 34 lines · Chunyan Zhang
Quoted 31 lines

From: Lvqiang Huang <[email protected]>

In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),

(quoted diff) +1 -1
-               .word   0xe92d0000 >> 10        @ stmfd sp!, {}
+               .word   0xe92d0000 >> 11        @ stmfd sp!, {}

then the shift need to change to 11.

Fixes ef41b5c92498 ("ARM: make kernel oops easier to read")
---
 arch/arm/lib/backtrace.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/lib/backtrace.S +1 -2
index 7d7952e..926851b 100644
@@ -70,7 +70,7 @@ for_each_frame:       tst     frame, mask             @ Check for address exceptions
 
 1003:          ldr     r2, [sv_pc, #-4]        @ if stmfd sp!, {args} exists,
                ldr     r3, .Ldsi+4             @ adjust saved 'pc' back one
-               teq     r3, r2, lsr #10         @ instruction
+               teq     r3, r2, lsr #11         @ instruction
                subne   r0, sv_pc, #4           @ allow for mov
                subeq   r0, sv_pc, #8           @ allow for mov + stmia
 
--

1.7.9.5

Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#4 lore raw
Quoted 7 lines · Russell King - ARM Linux admin
Quoted 3 lines · Chunyan Zhang

Gentle ping

probably this patch was missed or entered into spam?

Please submit it to the patch system, thanks.

Ok, thanks.

Quoted 40 lines
Quoted 31 lines · Chunyan Zhang
Quoted 28 lines

From: Lvqiang Huang <[email protected]>

In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),

(quoted diff) +1 -1
-               .word   0xe92d0000 >> 10        @ stmfd sp!, {}
+               .word   0xe92d0000 >> 11        @ stmfd sp!, {}

then the shift need to change to 11.

Fixes ef41b5c92498 ("ARM: make kernel oops easier to read")
---
 arch/arm/lib/backtrace.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/lib/backtrace.S +1 -1
index 7d7952e..926851b 100644
@@ -70,7 +70,7 @@ for_each_frame:       tst     frame, mask             @ Check for address exceptions
 
 1003:          ldr     r2, [sv_pc, #-4]        @ if stmfd sp!, {args} exists,
                ldr     r3, .Ldsi+4             @ adjust saved 'pc' back one
-               teq     r3, r2, lsr #10         @ instruction
+               teq     r3, r2, lsr #11         @ instruction
                subne   r0, sv_pc, #4           @ allow for mov
                subeq   r0, sv_pc, #8           @ allow for mov + stmia
 
Quoted 4 lines
Quoted 3 lines

--
1.7.9.5

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up