drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500
Subsystems (3)
PATCH v2 1/3 drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS file.
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the 4k resolution flicker issue on the LS1028A platform.
---
change in v2:
- modify some content based on feedback from maintainers
drivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)
drivers/gpu/drm/arm/malidp_drv.c +6 -0
@@ -818,6 +818,12 @@ static int malidp_bind(struct device *dev) malidp->core_id = version; + ret =of_property_read_u32 (dev->of_node, +"arm,malidp-arqos-value" , + &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ; +/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node, "arm,malidp-output-port-lines",
drivers/gpu/drm/arm/malidp_hw.c +13 -0
@@ -374,6 +374,19 @@ static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *malidp_hw_setbits (hwdev,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); elsemalidp_hw_clearbits (hwdev ,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); + +/* +* Program the RQoS register to avoid 4k resolution flicker +* on the LS1028A. +*/ +if (hwdev->arqos_value) { + val = hwdev->arqos_value; + +if (mode->pixelclock ==594000000 ) +malidp_hw_setbits (hwdev, val,MALIDP500_RQOS_QUALITY ); +else +malidp_hw_clearbits (hwdev, val,MALIDP500_RQOS_QUALITY ); + } }int malidp_format_get_bpp (u32 fmt)
drivers/gpu/drm/arm/malidp_hw.h +3 -0
@@ -251,6 +251,9 @@ struct malidp_hw_device {/* size of memory used for rotating layers, up to two banks available */ u32 rotation_memory[2 ]; + +/* priority level of RQOS register used for driven the ARQOS signal */ +u32 arqos_value; };static inline u32 malidp_hw_read (struct malidp_hw_device *hwdev,u32 reg)
drivers/gpu/drm/arm/malidp_regs.h +10 -0
@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS register values +* are driven by the ARQOS signal, using AXI transacations, dependent on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions +* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010
Signature · 1 line
2.17.1
Liviu Dudau
maintainerQuoted 23 lines · Wen He
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS file.
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the 4k resolution flicker issue on the LS1028A platform.
Signed-off-by Wen He <[email protected]>---
change in v2:
- modify some content based on feedback from maintainersdrivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)drivers/gpu/drm/arm/malidp_drv.c +0
-0
drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 825
Quoted 8 lines
drivers/gpu/drm/arm/malidp_drv.c +5
-0@@ -818,6 +818,12 @@ static int malidp_bind(struct device *dev) malidp->core_id = version; + ret =of_property_read_u32 (dev->of_node, +"arm,malidp-arqos-value" , + &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ;
Is zero the default value that you want? I thought it was 0x00010001.
Quoted 11 lines
drivers/gpu/drm/arm/malidp_drv.c +1
-0+/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node, "arm,malidp-output-port-lines",drivers/gpu/drm/arm/malidp_hw.c +0
-0@@ -374,6 +374,19 @@ static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *malidp_hw_setbits (hwdev,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); else
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode * · line 385
Quoted 10 lines
drivers/gpu/drm/arm/malidp_hw.c +9
-0malidp_hw_clearbits (hwdev,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); + +/* +* Program the RQoS register to avoid 4k resolution flicker +* on the LS1028A. +*/ +if (hwdev->arqos_value) { + val = hwdev->arqos_value; + +if (mode->pixelclock ==594000000 )
If I remember correctly, you declare the pixelclocks in the device tree, so I wonder if this is needed here. We should just set what value was in the DT regardless of the pixelclock, and then you manipulate the DT to choose one of your fixed resolutions and also set the QoS value.
Best regards,
Liviu
Quoted 45 lines
drivers/gpu/drm/arm/malidp_hw.c +4
-0+malidp_hw_setbits (hwdev, val,MALIDP500_RQOS_QUALITY ); + else +malidp_hw_clearbits (hwdev ,val ,MALIDP500_RQOS_QUALITY ); + } }int malidp_format_get_bpp (u32 fmt)drivers/gpu/drm/arm/malidp_hw.h +3
-0@@ -251,6 +251,9 @@ struct malidp_hw_device {/* size of memory used for rotating layers, up to two banks available */ u32 rotation_memory[2 ]; + +/* priority level of RQOS register used for driven the ARQOS signal */ +u32 arqos_value; };static inline u32 malidp_hw_read (struct malidp_hw_device *hwdev,u32 reg)drivers/gpu/drm/arm/malidp_regs.h +10
-0@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS register values +* are driven by the ARQOS signal, using AXI transacations, dependent on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions +* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010Signature · 1 line
2.17.1
Signature · 8 lines
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯Quoted 42 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月19日 19:46
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Caution: EXT Email
Quoted 27 lines · Wen He
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS file.
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the 4k resolution flicker issue on the LS1028A platform.
Signed-off-by Wen He <[email protected]>---
change in v2:
- modify some content based on feedback from maintainersdrivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)drivers/gpu/drm/arm/malidp_drv.c +0
-0@@ -818,6 +818,12 @@ static int malidp_bind(struct device *dev) malidp->core_id = version;
Quoted 7 lines
drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 825
Quoted 5 lines
drivers/gpu/drm/arm/malidp_drv.c +5
-0+ ret =of_property_read_u32 (dev->of_node, +"arm,malidp-arqos-value" , + &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ;Is zero the default value that you want? I thought it was
0x00010001.
Actually, the register default value always is 0x00010001(can be found in RM document).
Quoted 23 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct
Quoted 11 lines
drivers/gpu/drm/arm/malidp_drv.c +1
-0+/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node, "arm,malidp-output-port-lines",(quoted diff) +0
-0
b/drivers/gpu/drm/arm/malidp_hw.cindex50af399d7f6f..323683b1e9f7100644drivers/gpu/drm/arm/malidp_hw.c +0
-0@@ -374,6 +374,19 @@ static void malidp500_modeset(struct
malidp_hw_device*hwdev, struct videomode *drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 374
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +0
-0malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,
MALIDP_DE_DISPLAY_FUNC);Quoted 9 lines
drivers/gpu/drm/arm/malidp_hw.c +6
-0else malidp_hw_clearbits (hwdev,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); + +/* +* Program the RQoS register to avoid 4k resolution flicker +* on the LS1028A. +*/ +if (hwdev->arqos_value) {
Quoted 8 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode * · line 385
Quoted 3 lines
drivers/gpu/drm/arm/malidp_hw.c +3
-0+ val = hwdev->arqos_value; + +if (mode->pixelclock ==594000000 )If I remember correctly, you declare the pixelclocks in the device tree, so I wonder if this is needed here. We should just set what value was in the DT regardless of the pixelclock, and then you manipulate the DT to choose one of your fixed resolutions and also set the QoS value.
Yes, you remember correctly, but
1. declare the pixelclocks in the device tree.
About this, I was hoping to discuss it with you. I want to implement another patch that just declare 27MHz reference clock in the device tree and add a fake clock subsystem to enable/display prepare to set PLL. I am thinking what to do next.
As I remember, I sent out a patch that "Disable checking for required pixel clock", I think should be cancel it.
2. declare the fixed resolutions list in DTS.
Yes, Although I put four resolutions for supported list in DTS file, but this just a workaround that If not enable EDID OR EDID is not available. Once EDID is enabled, these resolutions list declare will be remove in DTS. so we can't use it as a condition to set the QoS value.
Best Regards,
Wen
Quoted 67 lines
Best regards,
Liviudrivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 387
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ malidp_hw_setbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 389
Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2
-0+else + malidp_hw_clearbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.h struct malidp_hw_device { · line 252
Quoted 12 lines
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ } }int
malidp_format_get_bpp(u32 fmt)(quoted diff) +0
-0
b/drivers/gpu/drm/arm/malidp_hw.hindex968a65eed371..e4c36bc90bda100644drivers/gpu/drm/arm/malidp_hw.h +0
-0@@ -251,6 +251,9 @@ struct malidp_hw_device {/* size of memory used for rotating layers, up to two banks available */
Quoted 14 lines
drivers/gpu/drm/arm/malidp_hw.h +3
-0u32 rotation_memory[2 ]; + +/* priority level of RQOS register used for driven the ARQOS signal */ +u32 arqos_value; }; static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev, u32reg) diff --git
a/drivers/gpu/drm/arm/malidp_regs.hb/drivers/gpu/drm/arm/malidp_regs.h
index993031542fa1..514c50dcb74d100644drivers/gpu/drm/arm/malidp_regs.h +0
-0@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00drivers/gpu/drm/arm/malidp_regs.h line 220
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8
-0#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS register +values +* are driven by the ARQOS signal, using AXI transacations, dependent +on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +4
-1+* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010 --2.17.1
--
====================| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
Liviu Dudau
maintainerQuoted 50 lines · Wen He
Quoted 42 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月19日 19:46
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Caution: EXT Email
Quoted 27 lines · Wen He
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS file.
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the 4k resolution flicker issue on the LS1028A platform.
Signed-off-by Wen He <[email protected]>---
change in v2:
- modify some content based on feedback from maintainersdrivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)drivers/gpu/drm/arm/malidp_drv.c +0
-0@@ -818,6 +818,12 @@ static int malidp_bind(struct device *dev) malidp->core_id = version;Quoted 7 lines
drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 825
Quoted 5 lines
drivers/gpu/drm/arm/malidp_drv.c +5
-0+ ret =of_property_read_u32 (dev->of_node, +"arm,malidp-arqos-value" , + &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ;Is zero the default value that you want? I thought it was
0x00010001.
Quoted 1 line
Actually, the register default value always is 0x00010001(can be found in RM document).
Exactly, but with your code you are overwriting it to 0 if the DT doesn't have the arm,malidp-arqos-value property.
Quoted 41 lines
Quoted 24 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct
Quoted 12 lines
drivers/gpu/drm/arm/malidp_drv.c +1
-0+/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node, "arm,malidp-output-port-lines",(quoted diff) +0
-0
b/drivers/gpu/drm/arm/malidp_hw.cindex50af399d7f6f..323683b1e9f7100644drivers/gpu/drm/arm/malidp_hw.c +0
-0@@ -374,6 +374,19 @@ static void malidp500_modeset(struct
malidp_hw_device*hwdev, struct videomode *drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 374
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +0
-0malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,
MALIDP_DE_DISPLAY_FUNC);Quoted 9 lines
drivers/gpu/drm/arm/malidp_hw.c +6
-0else malidp_hw_clearbits (hwdev,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); + +/* +* Program the RQoS register to avoid 4k resolution flicker +* on the LS1028A. +*/ +if (hwdev->arqos_value) {Quoted 8 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode * · line 385
Quoted 3 lines
drivers/gpu/drm/arm/malidp_hw.c +3
-0+ val = hwdev->arqos_value; + +if (mode->pixelclock ==594000000 )If I remember correctly, you declare the pixelclocks in the device tree, so I wonder if this is needed here. We should just set what value was in the DT regardless of the pixelclock, and then you manipulate the DT to choose one of your fixed resolutions and also set the QoS value.
Yes, you remember correctly, but
1. declare the pixelclocks in the device tree.
About this, I was hoping to discuss it with you. I want to implement another patch that just declare 27MHz reference clock in the device tree and add a fake clock subsystem to enable/display prepare to set PLL. I am thinking what to do next.
As I remember, I sent out a patch that "Disable checking for required pixel clock", I think should be cancel it.
Quoted 5 lines
2. declare the fixed resolutions list in DTS.
Yes, Although I put four resolutions for supported list in DTS file, but this just a workaround that If not enable EDID OR EDID is not available. Once EDID is enabled, these resolutions list declare will be remove in DTS. so we can't use it as a condition to set the QoS value.
3. Actually enable the clock provider. I've had a look at the public documentation and it looks like the the pixelclock is provided by an IDT VersaClock 5 generator, for which there is a kernel driver. I've started playing with it but got pulled back by other more immediate tasks.
Anyway, what I was trying to hint was that putting in the code the exact pixelclock value might not be the best thing. In my view, pixelclock reflects the need for a certain bandwidth, with is usually a product of output (number of pixels) and refresh frequency. I'm guessing going above 4k@60 will also trigger the flicker, but with your patch we will not react correctly.
Best regards,
Liviu
Quoted 71 lines
Best Regards,
WenQuoted 67 lines
Best regards,
Liviudrivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 387
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ malidp_hw_setbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 389
Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2
-0+else + malidp_hw_clearbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.h struct malidp_hw_device { · line 252
Quoted 12 lines
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ } }int
malidp_format_get_bpp(u32 fmt)(quoted diff) +0
-0
b/drivers/gpu/drm/arm/malidp_hw.hindex968a65eed371..e4c36bc90bda100644drivers/gpu/drm/arm/malidp_hw.h +0
-0@@ -251,6 +251,9 @@ struct malidp_hw_device {/* size of memory used for rotating layers, up to two banks available */
Quoted 14 lines
drivers/gpu/drm/arm/malidp_hw.h +3
-0u32 rotation_memory[2 ]; + +/* priority level of RQOS register used for driven the ARQOS signal */ +u32 arqos_value; }; static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev, u32reg) diff --git
a/drivers/gpu/drm/arm/malidp_regs.hb/drivers/gpu/drm/arm/malidp_regs.h
index993031542fa1..514c50dcb74d100644drivers/gpu/drm/arm/malidp_regs.h +0
-0@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00drivers/gpu/drm/arm/malidp_regs.h line 220
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8
-0#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS register +values +* are driven by the ARQOS signal, using AXI transacations, dependent +on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +4
-1+* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010 --2.17.1
--
====================| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
Signature · 8 lines
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯Quoted 67 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月22日 17:33
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: Re: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Caution: EXT Email
Quoted 12 lines · Wen He
Quoted 12 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月19日 19:46
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Quoted 5 lines
Quoted 5 lines
Caution: EXT Email
Quoted 2 lines · Wen He
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS
file.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the 4k resolution flicker issue on the LS1028A
platform.
Quoted 29 lines
Quoted 28 lines
Quoted 18 lines
Signed-off-by Wen He <[email protected]>---
change in v2:
- modify some content based on feedback from maintainersdrivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)drivers/gpu/drm/arm/malidp_drv.c +0
-0drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 825
Quoted 8 lines
drivers/gpu/drm/arm/malidp_drv.c +5
-0@@ -818,6 +818,12 @@ static int malidp_bind(struct device *dev) malidp->core_id = version; + ret =of_property_read_u32 (dev->of_node, +"arm,malidp-arqos-value" , + &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ;Is zero the default value that you want? I thought it was
0x00010001.
Quoted 5 lines
Quoted 1 line
Actually, the register default value always is 0x00010001(can be found in RM
document).
Exactly, but with your code you are overwriting it to 0 if the DT doesn't have the arm,malidp-arqos-value property.
Impossible, I've always block the overwrite action with following condition in code.
if (hwdev->arqos_value) {
}
Quoted 52 lines
Quoted 15 lines
Quoted 15 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct
Quoted 14 lines
drivers/gpu/drm/arm/malidp_drv.c +1
-0+/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node,"arm,malidp-output-port-lines", diff --git
a/drivers/gpu/drm/arm/malidp_hw.cb/drivers/gpu/drm/arm/malidp_hw.cindex50af399d7f6f..323683b1e9f7100644drivers/gpu/drm/arm/malidp_hw.c +0
-0@@ -374,6 +374,19 @@ static void malidp500_modeset(struct
malidp_hw_device*hwdev, struct videomode *Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 374
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +0
-0malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,
MALIDP_DE_DISPLAY_FUNC);Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +0
-0else malidp_hw_clearbits(hwdev,
MALIDP_DISP_FUNC_ILACED,Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/arm/malidp_hw.c +6
-0MALIDP_DE_DISPLAY_FUNC); + +/* +* Program the RQoS register to avoid 4k resolution flicker +* on the LS1028A. +*/ +if (hwdev->arqos_value) {Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode * · line 385
Quoted 3 lines
drivers/gpu/drm/arm/malidp_hw.c +3
-0+ val = hwdev->arqos_value; + +if (mode->pixelclock ==594000000 )If I remember correctly, you declare the pixelclocks in the device tree, so I wonder if this is needed here. We should just set what value was in the DT regardless of the pixelclock, and then you manipulate the DT to choose one of your fixed resolutions and also set the
QoS value.
Quoted 6 lines
Yes, you remember correctly, but
1. declare the pixelclocks in the device tree.
About this, I was hoping to discuss it with you. I want to implement another patch that just declare 27MHz reference clock in the device tree and add a fake clock subsystem to enable/display prepare to set PLL. Iam thinking what to do next.
Quoted 8 lines
As I remember, I sent out a patch that "Disable checking for required pixel clock", I think should be cancel it.
2. declare the fixed resolutions list in DTS.
Yes, Although I put four resolutions for supported list in DTS file, but this just a workaround that If not enable EDID OR EDID is not available. Once EDID is enabled, these resolutions list declare will be remove in DTS. so we can't use it as a condition to set the QoS value.
Quoted 4 lines
3. Actually enable the clock provider. I've had a look at the public documentation and it looks like the the pixelclock is provided by an IDT VersaClock 5 generator, for which there is a kernel driver. I've started playing with it but got pulled back by other more immediate tasks.
Haa, all right, I think maybe I can trying to investigate it.
Quoted 7 lines
Anyway, what I was trying to hint was that putting in the code the exact pixelclock value might not be the best thing. In my view, pixelclock reflects the need for a certain bandwidth, with is usually a product of output (number of pixels) and refresh frequency. I'm guessing going above 4k@60 will also trigger the flicker, but with your patch we will not react correctly.
Yes, I understand your hint, but here I just change QoS for 4k@60 , and other > 4k@60 pixel clock are not be supported on LS1028A. so is there other better ways ?
Anyway, thank you for the detailed review again.
Best Regards,
Wen
Quoted 89 lines
Best regards,
LiviuQuoted 19 lines
Best Regards,
WenQuoted 15 lines
Best regards,
Liviudrivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 387
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ malidp_hw_setbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 389
Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2
-0+else + malidp_hw_clearbits(hwdev, val,
MALIDP500_RQOS_QUALITY);Quoted 6 lines
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ } }int
malidp_format_get_bpp(u32 fmt)diff --gita/drivers/gpu/drm/arm/malidp_hw.hb/drivers/gpu/drm/arm/malidp_hw.hindex
968a65eed371..e4c36bc90bdaQuoted 11 lines
Quoted 11 lines
Quoted 7 lines
100644
drivers/gpu/drm/arm/malidp_hw.h +0
-0@@ -251,6 +251,9 @@ struct malidp_hw_device {/* size of memory used for rotating layers, up to two banks available
*/
Quoted 3 lines
u32 rotation_memory[2];drivers/gpu/drm/arm/malidp_hw.h +2
-0+ +/* priority level of RQOS register used for driven the ARQOS signal */
Quoted 35 lines
Quoted 35 lines
Quoted 12 lines
+ u32
arqos_value;
};static inline u32 malidp_hw_read(struct
malidp_hw_device*hwdev,
u32
reg) diff --gita/drivers/gpu/drm/arm/malidp_regs.hb/drivers/gpu/drm/arm/malidp_regs.h
index993031542fa1..514c50dcb74d100644drivers/gpu/drm/arm/malidp_regs.h +0
-0@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00drivers/gpu/drm/arm/malidp_regs.h line 220
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8
-0#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS +register values +* are driven by the ARQOS signal, using AXI transacations, +dependent on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +4
-1+* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010 --2.17.1
--
Quoted 8 lines
Quoted 8 lines
====================
| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯--
====================| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
Quoted 129 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月22日 17:33
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: Re: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Caution: EXT Email
Quoted 12 lines · Wen He
Quoted 12 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月19日 19:46
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Quoted 5 lines
Quoted 5 lines
Caution: EXT Email
Quoted 2 lines · Wen He
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS
file.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the 4k resolution flicker issue on the LS1028A
platform.
Quoted 29 lines
Quoted 21 lines
Quoted 21 lines
Signed-off-by Wen He <[email protected]>---
change in v2:
- modify some content based on feedback from maintainersdrivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)drivers/gpu/drm/arm/malidp_drv.c +0
-0@@ -818,6 +818,12 @@ static int malidp_bind(struct device *dev) malidp->core_id = version;Quoted 7 lines
drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 825
Quoted 5 lines
drivers/gpu/drm/arm/malidp_drv.c +5
-0+ ret =of_property_read_u32 (dev->of_node, +"arm,malidp-arqos-value" , + &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ;Is zero the default value that you want? I thought it was
0x00010001.Quoted 1 line
Actually, the register default value always is 0x00010001(can be found in RM
document).
Exactly, but with your code you are overwriting it to 0 if the DT doesn't have the arm,malidp-arqos-value property.
Quoted 14 lines
Quoted 14 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct
Quoted 13 lines
drivers/gpu/drm/arm/malidp_drv.c +1
-0+/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node,"arm,malidp-output-port-lines", diff --git
a/drivers/gpu/drm/arm/malidp_hw.cb/drivers/gpu/drm/arm/malidp_hw.cindex50af399d7f6f..323683b1e9f7100644drivers/gpu/drm/arm/malidp_hw.c +0
-0@@ -374,6 +374,19 @@ static void malidp500_modeset(struct
malidp_hw_device*hwdev, struct videomode *Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 374
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +0
-0malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,
MALIDP_DE_DISPLAY_FUNC);Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +0
-0else malidp_hw_clearbits(hwdev,
MALIDP_DISP_FUNC_ILACED,Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/arm/malidp_hw.c +6
-0MALIDP_DE_DISPLAY_FUNC); + +/* +* Program the RQoS register to avoid 4k resolution flicker +* on the LS1028A. +*/ +if (hwdev->arqos_value) {Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode * · line 385
Quoted 3 lines
drivers/gpu/drm/arm/malidp_hw.c +3
-0+ val = hwdev->arqos_value; + +if (mode->pixelclock ==594000000 )If I remember correctly, you declare the pixelclocks in the device tree, so I wonder if this is needed here. We should just set what value was in the DT regardless of the pixelclock, and then you manipulate the DT to choose one of your fixed resolutions and also set the
QoS value.
Quoted 6 lines
Yes, you remember correctly, but
1. declare the pixelclocks in the device tree.
About this, I was hoping to discuss it with you. I want to implement another patch that just declare 27MHz reference clock in the device tree and add a fake clock subsystem to enable/display prepare to set PLL. Iam thinking what to do next.
Quoted 8 lines
As I remember, I sent out a patch that "Disable checking for required pixel clock", I think should be cancel it.
2. declare the fixed resolutions list in DTS.
Yes, Although I put four resolutions for supported list in DTS file, but this just a workaround that If not enable EDID OR EDID is not available. Once EDID is enabled, these resolutions list declare will be remove in DTS. so we can't use it as a condition to set the QoS value.3. Actually enable the clock provider. I've had a look at the public documentation and it looks like the the pixelclock is provided by an IDT VersaClock 5 generator, for which there is a kernel driver. I've started playing with it but got pulled back by other more immediate tasks.
Quoted 9 lines
Anyway, what I was trying to hint was that putting in the code the exact pixelclock value might not be the best thing. In my view, pixelclock reflects the need for a certain bandwidth, with is usually a product of output (number of pixels) and refresh frequency. I'm guessing going above 4k@60 will also trigger the flicker, but with your patch we will not react correctly.
Best regards,
Liviu
Hmm.. I've already written the pixel clock provider driver of the LS1028A and upstreamed.. So more resolutions will be support on LS1028A.
Thank you for the comments that which made me determined to get this done.
For this change, I would be remove this condition "if (mode->pixelclock == 594000000)" And apply this change for all resolutions on LS1028A.
How do you think?
Best Regards,
Wen
Quoted 86 lines
Quoted 20 lines
Best Regards,
WenQuoted 15 lines
Best regards,
Liviudrivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 387
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ malidp_hw_setbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 389
Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2
-0+else + malidp_hw_clearbits(hwdev, val,
MALIDP500_RQOS_QUALITY);Quoted 6 lines
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ } }int
malidp_format_get_bpp(u32 fmt)diff --gita/drivers/gpu/drm/arm/malidp_hw.hb/drivers/gpu/drm/arm/malidp_hw.hindex
968a65eed371..e4c36bc90bdaQuoted 11 lines
Quoted 11 lines
Quoted 7 lines
100644
drivers/gpu/drm/arm/malidp_hw.h +0
-0@@ -251,6 +251,9 @@ struct malidp_hw_device {/* size of memory used for rotating layers, up to two banks available
*/
Quoted 3 lines
u32 rotation_memory[2];drivers/gpu/drm/arm/malidp_hw.h +2
-0+ +/* priority level of RQOS register used for driven the ARQOS signal */
Quoted 35 lines
Quoted 35 lines
Quoted 12 lines
+ u32
arqos_value;
};static inline u32 malidp_hw_read(struct
malidp_hw_device*hwdev,
u32
reg) diff --gita/drivers/gpu/drm/arm/malidp_regs.hb/drivers/gpu/drm/arm/malidp_regs.h
index993031542fa1..514c50dcb74d100644drivers/gpu/drm/arm/malidp_regs.h +0
-0@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00drivers/gpu/drm/arm/malidp_regs.h line 220
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8
-0#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS +register values +* are driven by the ARQOS signal, using AXI transacations, +dependent on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +4
-1+* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010 --2.17.1
--
Quoted 8 lines
Quoted 8 lines
====================
| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯--
====================| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
Liviu Dudau
maintainerQuoted 139 lines · Wen He
Quoted 129 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月22日 17:33
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: Re: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Caution: EXT Email
Quoted 12 lines · Wen He
Quoted 12 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月19日 19:46
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Quoted 5 lines
Quoted 5 lines
Caution: EXT Email
Quoted 2 lines · Wen He
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS
file.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the 4k resolution flicker issue on the LS1028A
platform.
Quoted 29 lines
Quoted 21 lines
Quoted 21 lines
Signed-off-by Wen He <[email protected]>---
change in v2:
- modify some content based on feedback from maintainersdrivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)drivers/gpu/drm/arm/malidp_drv.c +0
-0@@ -818,6 +818,12 @@ static int malidp_bind(struct device *dev) malidp->core_id = version;Quoted 7 lines
drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 825
Quoted 5 lines
drivers/gpu/drm/arm/malidp_drv.c +5
-0+ ret =of_property_read_u32 (dev->of_node, +"arm,malidp-arqos-value" , + &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ;Is zero the default value that you want? I thought it was
0x00010001.Quoted 1 line
Actually, the register default value always is 0x00010001(can be found in RM
document).
Exactly, but with your code you are overwriting it to 0 if the DT doesn't have the arm,malidp-arqos-value property.
Quoted 14 lines
Quoted 14 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct
Quoted 13 lines
drivers/gpu/drm/arm/malidp_drv.c +1
-0+/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node,"arm,malidp-output-port-lines", diff --git
a/drivers/gpu/drm/arm/malidp_hw.cb/drivers/gpu/drm/arm/malidp_hw.cindex50af399d7f6f..323683b1e9f7100644drivers/gpu/drm/arm/malidp_hw.c +0
-0@@ -374,6 +374,19 @@ static void malidp500_modeset(struct
malidp_hw_device*hwdev, struct videomode *Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 374
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +0
-0malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,
MALIDP_DE_DISPLAY_FUNC);Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +0
-0else malidp_hw_clearbits(hwdev,
MALIDP_DISP_FUNC_ILACED,Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/arm/malidp_hw.c +6
-0MALIDP_DE_DISPLAY_FUNC); + +/* +* Program the RQoS register to avoid 4k resolution flicker +* on the LS1028A. +*/ +if (hwdev->arqos_value) {Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode * · line 385
Quoted 3 lines
drivers/gpu/drm/arm/malidp_hw.c +3
-0+ val = hwdev->arqos_value; + +if (mode->pixelclock ==594000000 )If I remember correctly, you declare the pixelclocks in the device tree, so I wonder if this is needed here. We should just set what value was in the DT regardless of the pixelclock, and then you manipulate the DT to choose one of your fixed resolutions and also set the
QoS value.
Quoted 6 lines
Yes, you remember correctly, but
1. declare the pixelclocks in the device tree.
About this, I was hoping to discuss it with you. I want to implement another patch that just declare 27MHz reference clock in the device tree and add a fake clock subsystem to enable/display prepare to set PLL. Iam thinking what to do next.
Quoted 8 lines
As I remember, I sent out a patch that "Disable checking for required pixel clock", I think should be cancel it.
2. declare the fixed resolutions list in DTS.
Yes, Although I put four resolutions for supported list in DTS file, but this just a workaround that If not enable EDID OR EDID is not available. Once EDID is enabled, these resolutions list declare will be remove in DTS. so we can't use it as a condition to set the QoS value.3. Actually enable the clock provider. I've had a look at the public documentation and it looks like the the pixelclock is provided by an IDT VersaClock 5 generator, for which there is a kernel driver. I've started playing with it but got pulled back by other more immediate tasks.
Quoted 9 lines
Anyway, what I was trying to hint was that putting in the code the exact pixelclock value might not be the best thing. In my view, pixelclock reflects the need for a certain bandwidth, with is usually a product of output (number of pixels) and refresh frequency. I'm guessing going above 4k@60 will also trigger the flicker, but with your patch we will not react correctly.
Best regards,
Liviu
Quoted 8 lines
Hmm.. I've already written the pixel clock provider driver of the LS1028A and upstreamed.. So more resolutions will be support on LS1028A.
Thank you for the comments that which made me determined to get this done.For this change, I would be remove this condition "if (
mode->pixelclock== 594000000)" And apply this change for all resolutions on LS1028A.How do you think?
Hi Wen,
Sorry, I was away on sabbatical until now.
Not sure if I got your message right: do you want to apply the RQOS value regardless of the resolution (but only if defined to a non-zero value in the DTS)? If so, then I'm fine with that idea. Can you send a refreshed patch?
Best regards,
Liviu
Quoted 89 lines
Best Regards,
WenQuoted 86 lines
Quoted 20 lines
Best Regards,
WenQuoted 15 lines
Best regards,
Liviudrivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 387
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ malidp_hw_setbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 389
Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2
-0+else + malidp_hw_clearbits(hwdev, val,
MALIDP500_RQOS_QUALITY);Quoted 6 lines
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ } }int
malidp_format_get_bpp(u32 fmt)diff --gita/drivers/gpu/drm/arm/malidp_hw.hb/drivers/gpu/drm/arm/malidp_hw.hindex
968a65eed371..e4c36bc90bdaQuoted 11 lines
Quoted 11 lines
Quoted 7 lines
100644
drivers/gpu/drm/arm/malidp_hw.h +0
-0@@ -251,6 +251,9 @@ struct malidp_hw_device {/* size of memory used for rotating layers, up to two banks available
*/
Quoted 3 lines
u32 rotation_memory[2];drivers/gpu/drm/arm/malidp_hw.h +2
-0+ +/* priority level of RQOS register used for driven the ARQOS signal */
Quoted 35 lines
Quoted 35 lines
Quoted 12 lines
+ u32
arqos_value;
};static inline u32 malidp_hw_read(struct
malidp_hw_device*hwdev,
u32
reg) diff --gita/drivers/gpu/drm/arm/malidp_regs.hb/drivers/gpu/drm/arm/malidp_regs.h
index993031542fa1..514c50dcb74d100644drivers/gpu/drm/arm/malidp_regs.h +0
-0@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00drivers/gpu/drm/arm/malidp_regs.h line 220
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8
-0#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS +register values +* are driven by the ARQOS signal, using AXI transacations, +dependent on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +4
-1+* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010 --2.17.1
--
Quoted 8 lines
Quoted 8 lines
====================
| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯--
====================| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
Signature · 12 lines
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-develQuoted 178 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年9月5日 0:13
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: Re: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Caution: EXT Email
Quoted 61 lines · Wen He
Quoted 61 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月22日 17:33
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: Re: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Caution: EXT Email
Quoted 12 lines · Wen He
Quoted 12 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年7月19日 19:46
To: Wen He <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Quoted 6 lines
Quoted 6 lines
Caution: EXT Email
Quoted 3 lines · Wen He
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS
file.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the 4k resolution flicker issue on the LS1028A
platform.
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Signed-off-by Wen He <[email protected]>---
change in v2:
- modify some content based on feedback from
maintainersdrivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)drivers/gpu/drm/arm/malidp_drv.c +0
-0@@ -818,6 +818,12 @@ static int malidp_bind(struct device *dev)Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 826
Quoted 4 lines
drivers/gpu/drm/arm/malidp_drv.c +2
-0malidp->core_id = version; + ret = of_property_read_u32(dev->of_node, +"arm,malidp-arqos-value",
Quoted 59 lines
Quoted 59 lines
Quoted 8 lines
Quoted 5 lines
drivers/gpu/drm/arm/malidp_drv.c static int malidp_bind(struct device *dev) · line 825
Quoted 3 lines
drivers/gpu/drm/arm/malidp_drv.c +3
-0+ &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ;Is zero the default value that you want? I thought it was
0x00010001.Actually, the register default value always is 0x00010001(can be found in RM
document).
Exactly, but with your code you are overwriting it to 0 if the DT doesn't have the arm,malidp-arqos-value property.
Quoted 15 lines
Quoted 15 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct
Quoted 14 lines
drivers/gpu/drm/arm/malidp_drv.c +1
-0+/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node,"arm,malidp-output-port-lines", diff --git
a/drivers/gpu/drm/arm/malidp_hw.cb/drivers/gpu/drm/arm/malidp_hw.cindex50af399d7f6f..323683b1e9f7
100644drivers/gpu/drm/arm/malidp_hw.c +0
-0@@ -374,6 +374,19 @@ static void malidp500_modeset(struct
malidp_hw_device*hwdev, struct videomode *Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 375
Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +0
-0malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,
MALIDP_DE_DISPLAY_FUNC);Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +0
-0else malidp_hw_clearbits(hwdev,
MALIDP_DISP_FUNC_ILACED,Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/arm/malidp_hw.c +7
-0MALIDP_DE_DISPLAY_FUNC); + +/* +* Program the RQoS register to avoid 4k resolution flicker +* on the LS1028A. +*/ +if (hwdev->arqos_value) { + val = hwdev->arqos_value;Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 387
Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2
-0+ +if (mode->pixelclock ==594000000 )If I remember correctly, you declare the pixelclocks in the device tree, so I wonder if this is needed here. We should just set what value was in the DT regardless of the pixelclock, and then you manipulate the DT to choose one of your fixed resolutions and also set the
QoS value.
Quoted 7 lines
Yes, you remember correctly, but
1. declare the pixelclocks in the device tree.
About this, I was hoping to discuss it with you. I want to implement another patch that just declare 27MHz reference clock in the device tree and add a fake clock subsystem to enable/display prepare to set PLL. Iam thinking what to do next.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
As I remember, I sent out a patch that "Disable checking for required pixel clock", I think should be cancel it.
2. declare the fixed resolutions list in DTS.
Yes, Although I put four resolutions for supported list in DTS file, but this just a workaround that If not enable EDID OR EDID is not available. Once EDID is enabled, these resolutions list declare will be remove in DTS. so we can't use it as a condition to set theQoS value.
Quoted 13 lines
Quoted 13 lines
3. Actually enable the clock provider. I've had a look at the public documentation and it looks like the the pixelclock is provided by an IDT VersaClock 5 generator, for which there is a kernel driver. I've started playing with it but got pulled back by other more immediate tasks.
Anyway, what I was trying to hint was that putting in the code the exact pixelclock value might not be the best thing. In my view, pixelclock reflects the need for a certain bandwidth, with is usually a product of output (number of
pixels) and refresh frequency. I'm guessing going above 4k@60 will also trigger the flicker, but with your patch we will not react correctly.Quoted 5 lines
Quoted 3 lines
Best regards,
LiviuHmm.. I've already written the pixel clock provider driver of the LS1028A and
upstreamed..
Quoted 2 lines
So more resolutions will be support on LS1028A.
Thank you for the comments that which made me determined to get thisdone.
Quoted 2 lines
For this change, I would be remove this condition "if (
mode->pixelclock==594000000)"
Quoted 3 lines
And apply this change for all resolutions on LS1028A.
How do you think?
Quoted 8 lines
Hi Wen,
Sorry, I was away on sabbatical until now.
Not sure if I got your message right: do you want to apply the RQOS value regardless of the resolution (but only if defined to a non-zero value in the DTS)? If so, then I'm fine with that idea. Can you send a refreshed patch?
Yes, but I add one condition (if pixel clock > 148.5Mhz) in here , I already send v3 patch to mail list, please review again, Thanks a lot.
Best Regards,
Wen
Quoted 105 lines
Best regards,
LiviuQuoted 91 lines
Best Regards,
WenQuoted 88 lines
Quoted 20 lines
Best Regards,
WenQuoted 15 lines
Best regards,
Liviudrivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 388
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ malidp_hw_setbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 390
Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2
-0+else + malidp_hw_clearbits(hwdev, val,
MALIDP500_RQOS_QUALITY);Quoted 6 lines
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ } }int
malidp_format_get_bpp(u32 fmt)diff --gita/drivers/gpu/drm/arm/malidp_hw.hb/drivers/gpu/drm/arm/malidp_hw.hindex
968a65eed371..e4c36bc90bdaQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
100644
drivers/gpu/drm/arm/malidp_hw.h +0
-0@@ -251,6 +251,9 @@ struct malidp_hw_device {Quoted 7 lines
Quoted 7 lines
Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.h +0
-0/* size of memory used for rotating layers, up to two banks available
*/
Quoted 4 lines
u32 rotation_memory[2];drivers/gpu/drm/arm/malidp_hw.h +3
-0+ +/* priority level of RQOS register used for driven the +ARQOS signal */
Quoted 36 lines
Quoted 36 lines
Quoted 13 lines
+ u32
arqos_value;
};static inline u32 malidp_hw_read(struct
malidp_hw_device
*hwdev,
u32
reg) diff --gita/drivers/gpu/drm/arm/malidp_regs.hb/drivers/gpu/drm/arm/malidp_regs.h
index993031542fa1..514c50dcb74d100644drivers/gpu/drm/arm/malidp_regs.h +0
-0@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00drivers/gpu/drm/arm/malidp_regs.h line 220
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8
-0#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS +register values +* are driven by the ARQOS signal, using AXI transacations, +dependent on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +4
-1+* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010 --2.17.1
--
Quoted 8 lines
Quoted 8 lines
====================
| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯--
====================| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯--
====================| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯