Skip to contentSkip to conversation

syscalls/ioctl: bugfix for syscalls/ioctl/ioctl_ns05.c syscalls/ioctl/ioctl_ns06.c

PATCH New Song Jian 2 participants 2 messages Jul 22, 2019

lore
Share & tools
lore

Song Jian

author
#0 lore raw

PATCH 1/1 syscalls/ioctl: bugfix for syscalls/ioctl/ioctl_ns05.c syscalls/ioctl/ioctl_ns06.c

fix ioctl_ns05, ioctl_ns06 timeout.
signal() will return 0 if success, so it have no chance to equal nr_wake=1, use another api to to repalce the current api to ensure that nr_wark = 0.

---
 testcases/kernel/syscalls/ioctl/ioctl_ns05.c | 2 +-
 testcases/kernel/syscalls/ioctl/ioctl_ns06.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
testcases/kernel/syscalls/ioctl/ioctl_ns05.c +1 -1
index a8dee07..8162012 100644
@@ -80,7 +80,7 @@ static void run(void)
 	SAFE_CLOSE(my_fd);
 	SAFE_CLOSE(child_fd);
 	SAFE_CLOSE(parent_fd);
-	TST_CHECKPOINT_WAKE(0);
+	TST_CHECKPOINT_WAKE2(0, 0);
 }
 static struct tst_test test = {
testcases/kernel/syscalls/ioctl/ioctl_ns06.c +1 -1
index 805a0a0..d5010d0 100644
@@ -75,7 +75,7 @@ static void run(void)
 	SAFE_CLOSE(my_fd);
 	SAFE_CLOSE(parent_fd);
 	SAFE_CLOSE(child_fd);
-	TST_CHECKPOINT_WAKE(0);
+	TST_CHECKPOINT_WAKE2(0, 0);
 }
 static struct tst_test test = {

2.6.2

#1 lore raw

PATCH 1/1 syscalls/ioctl: bugfix for syscalls/ioctl/ioctl_ns05.c syscalls/ioctl/ioctl_ns06.c

Hi!

Quoted 4 lines

fix ioctl_ns05, ioctl_ns06 timeout.
signal() will return 0 if success, so it have no chance to equal nr_wake=1, use another api to to repalce the current api to ensure that nr_wark = 0.

I do not understand what is the problem here.

What do you mean by "signal() will return 0 if success" ?

The child has to be suspended in the futex until it's woken up so as far as I can tell the checkpoint should be able to wake the child a the end of the run() function.

Signature · 2 lines
Cyril Hrubis
[email protected]