Skip to contentSkip to conversation

drm: use correct dev node location in comment

PATCH In review Emil Velikov 2 participants 2 messages Jul 22, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: use correct dev node location in comment

From: Emil Velikov <[email protected]>

Current comment mentions /dev/drm which hasn't been a thing even before the code was merged into the kernel ;-)

---
 drivers/gpu/drm/drm_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_file.c +1 -1
index ea34bc991858..5274b40eb5e3 100644
@@ -285,7 +285,7 @@ static int drm_cpu_valid(void)
 }
 
 /*
- * Called whenever a process opens /dev/drm.
+ * Called whenever a process opens /dev/dri/[number]
  *
  * \param filp file pointer.
  * \param minor acquired minor-object.
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Emil Velikov

From: Emil Velikov <[email protected]>

Current comment mentions /dev/drm which hasn't been a thing even before the code was merged into the kernel ;-)

---
 drivers/gpu/drm/drm_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_file.c +0 -0
index ea34bc991858..5274b40eb5e3 100644

drivers/gpu/drm/drm_file.c static int drm_cpu_valid(void) · line 288

Quoted 5 lines
drivers/gpu/drm/drm_file.c +1 -1
@@ -285,7 +285,7 @@ static int drm_cpu_valid(void)
 }
 
 /*
- * Called whenever a process opens /dev/drm.
+ * Called whenever a process opens /dev/dri/[number]

Well, /dev/dri/[number] also doesn't exist. You could change to:

+ * Called whenever a process opens /dev/dri/(card|render)[number]

or don't try to specify the exact path and say:

+ * Called whenever a process opens a drm node

Either way,

Quoted 10 lines
drivers/gpu/drm/drm_file.c +0 -0
  *
  * \param filp file pointer.
  * \param minor acquired minor-object.
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel