Skip to contentSkip to conversation

firmware: Fix missing inline

PATCH In review Takashi Iwai 2 participants 2 messages Jul 23, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: Fix missing inline

I mistakenly dropped the inline while resolving the patch conflicts in the previous fix patch. Without inline, we get compiler warnings wrt unused functions.

Note that Mauro's original patch contained the correct changes; it's all my fault to submit a patch before a morning coffee.

Fixes c8917b8ff09e ("firmware: fix build errors in paged buffer handling code")
---
 drivers/base/firmware_loader/firmware.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/base/firmware_loader/firmware.h +2 -2
index 842e63f19f22..7ecd590e67fe 100644
@@ -141,8 +141,8 @@ int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed);
 int fw_map_paged_buf(struct fw_priv *fw_priv);
 #else
 static inline void fw_free_paged_buf(struct fw_priv *fw_priv) {}
-static int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed) { return -ENXIO; }
-static int fw_map_paged_buf(struct fw_priv *fw_priv) { return -ENXIO; }
+static inline int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed) { return -ENXIO; }
+static inline int fw_map_paged_buf(struct fw_priv *fw_priv) { return -ENXIO; }
 #endif
 
 #endif /* __FIRMWARE_LOADER_H */
Signature · 1 line
2.16.4
#1 lore raw
Quoted 4 lines · Takashi Iwai

I mistakenly dropped the inline while resolving the patch conflicts in the previous fix patch. Without inline, we get compiler warnings wrt unused functions.

Quoted 8 lines

Note that Mauro's original patch contained the correct changes; it's all my fault to submit a patch before a morning coffee.

Fixes c8917b8ff09e ("firmware: fix build errors in paged buffer handling code")
---
 drivers/base/firmware_loader/firmware.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, now queued up.

greg k-h