gpio: pch: Use dev_get_drvdata
Subsystems (2)
PATCH v2 1/1 gpio: pch: Use dev_get_drvdata
Instead of using to_pci_dev + pci_get_drvdata,
use dev_get_drvdata to make code simpler.
Signed-off-by Chuhong Yuan <[email protected]>
---
Changes in v2:
- Change the subject line to gpio: pch: ...
drivers/gpio/gpio-pch.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpio/gpio-pch.c +2 -4
@@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,static int __maybe_unused pch_gpio_suspend (struct device *dev) { -struct pci_dev *pdev =to_pci_dev (dev); -struct pch_gpio *chip =pci_get_drvdata (pdev); +struct pch_gpio *chip =dev_get_drvdata (dev);unsigned long flags;spin_lock_irqsave (&chip->spinlock, flags);
@@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev)static int __maybe_unused pch_gpio_resume (struct device *dev) { -struct pci_dev *pdev =to_pci_dev (dev); -struct pch_gpio *chip =pci_get_drvdata (pdev); +struct pch_gpio *chip =dev_get_drvdata (dev);unsigned long flags;spin_lock_irqsave (&chip->spinlock, flags);
Signature · 1 line
2.20.1
wt., 23 lip 2019 o 10:39 Chuhong Yuan <[email protected]> napisał(a):
Quoted 37 lines
Instead of using
to_pci_dev+pci_get_drvdata,
usedev_get_drvdatato make code simpler.Signed-off-by Chuhong Yuan <[email protected]>---
Changes in v2:
- Change the subject line to gpio: pch: ...drivers/gpio/gpio-pch.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/gpio/gpio-pch.c +2
-5@@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,static int __maybe_unused pch_gpio_suspend (struct device *dev) { -struct pci_dev *pdev =to_pci_dev (dev); -struct pch_gpio *chip =pci_get_drvdata (pdev); +struct pch_gpio *chip =dev_get_drvdata (dev);unsigned long flags;spin_lock_irqsave (&chip->spinlock, flags);@@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev)static int __maybe_unused pch_gpio_resume (struct device *dev) { -struct pci_dev *pdev =to_pci_dev (dev); -struct pch_gpio *chip =pci_get_drvdata (pdev); +struct pch_gpio *chip =dev_get_drvdata (dev);unsigned long flags;spin_lock_irqsave (&chip->spinlock, flags); --
Quoted 2 lines
2.20.1
Quoted 36 lines · Bartosz Golaszewski
wt., 23 lip 2019 o 10:39 Chuhong Yuan <[email protected]> napisał(a):
Quoted 35 lines
Instead of using
to_pci_dev+pci_get_drvdata,
usedev_get_drvdatato make code simpler.Signed-off-by Chuhong Yuan <[email protected]>---
Changes in v2:
- Change the subject line to gpio: pch: ...drivers/gpio/gpio-pch.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/gpio/gpio-pch.c +2
-4@@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,static int __maybe_unused pch_gpio_suspend (struct device *dev) { -struct pci_dev *pdev =to_pci_dev (dev); -struct pch_gpio *chip =pci_get_drvdata (pdev); +struct pch_gpio *chip =dev_get_drvdata (dev);unsigned long flags;spin_lock_irqsave (&chip->spinlock, flags);@@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev)static int __maybe_unused pch_gpio_resume (struct device *dev) { -struct pci_dev *pdev =to_pci_dev (dev); -struct pch_gpio *chip =pci_get_drvdata (pdev); +struct pch_gpio *chip =dev_get_drvdata (dev);unsigned long flags;
Quoted 6 lines
Quoted 4 lines
drivers/gpio/gpio-pch.c +0
-1spin_lock_irqsave (&chip->spinlock, flags); --2.20.1
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko