Skip to contentSkip to conversation

i3c: master: Add of_node_put() before return

PATCH New Nishka Dasgupta 1 participant 1 message Jul 23, 2019 I3C

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i3c: master: Add of_node_put() before return

Each iteration of for_each_available_childe_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before the return.
Issue found with Coccinelle.

---
 drivers/i3c/master.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/i3c/master.c +3 -1
index d6f8b038a896..116d4e7ef25c 100644
@@ -2093,8 +2093,10 @@ static int of_populate_i3c_bus(struct i3c_master_controller *master)
 
 	for_each_available_child_of_node(i3cbus_np, node) {
 		ret = of_i3c_master_add_dev(master, node);
-		if (ret)
+		if (ret) {
+			of_node_put(node);
 			return ret;
+		}
 	}
 
 	/*
Signature · 7 lines
2.19.1


_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c