drm/i915: Use dev_get_drvdata
Subsystems (2)
PATCH 1/1 drm/i915: Use dev_get_drvdata
Instead of using to_pci_dev + pci_get_drvdata,
use dev_get_drvdata to make code simpler.
--- drivers/gpu/drm/i915/i915_drv.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +4 -8
@@ -2384,8 +2384,7 @@ static int i915_resume_switcheroo(struct drm_device *dev)static int i915_pm_prepare (struct device *kdev) { -struct pci_dev *pdev =to_pci_dev (kdev); -struct drm_device *dev =pci_get_drvdata (pdev); +struct drm_device *dev =dev_get_drvdata (kdev);if (!dev) {dev_err (kdev,"DRM not initialized, aborting suspend.\n" );
@@ -2400,8 +2399,7 @@ static int i915_pm_prepare(struct device *kdev)static int i915_pm_suspend (struct device *kdev) { -struct pci_dev *pdev =to_pci_dev (kdev); -struct drm_device *dev =pci_get_drvdata (pdev); +struct drm_device *dev =dev_get_drvdata (kdev);if (!dev) {dev_err (kdev,"DRM not initialized, aborting suspend.\n" );
@@ -2895,8 +2893,7 @@ static int vlv_resume_prepare(struct drm_i915_private *dev_priv,static int intel_runtime_suspend (struct device *kdev) { -struct pci_dev *pdev =to_pci_dev (kdev); -struct drm_device *dev =pci_get_drvdata (pdev); +struct drm_device *dev =dev_get_drvdata (kdev);struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_runtime_pm *rpm = &dev_priv->runtime_pm;int ret;
@@ -2994,8 +2991,7 @@ static int intel_runtime_suspend(struct device *kdev)static int intel_runtime_resume (struct device *kdev) { -struct pci_dev *pdev =to_pci_dev (kdev); -struct drm_device *dev =pci_get_drvdata (pdev); +struct drm_device *dev =dev_get_drvdata (kdev);struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_runtime_pm *rpm = &dev_priv->runtime_pm;int ret =0 ;
Signature · 1 line
2.20.1
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: Use dev_get_drvdata
== Series Details ==
== Series Details ==
Series: drm/i915: Use dev_get_drvdata
URL : https://patchwork.freedesktop.org/series/64088/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6541 -> Patchwork_13726
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_13726 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_13726, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13726/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13726:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_execlists:
- fi-kbl-guc: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-guc/igt@i915_selftest@live_execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13726/fi-kbl-guc/igt@i915_selftest@live_execlists.html
Known issues
------------
Here are the changes found in Patchwork_13726 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_workarounds:
- fi-snb-2600: [PASS][3] -> [DMESG-WARN][4] ([fdo#111115])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-snb-2600/igt@i915_selftest@live_workarounds.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13726/fi-snb-2600/igt@i915_selftest@live_workarounds.html
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: [PASS][5] -> [SKIP][6] ([fdo#109271] / [fdo#109278]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-7567u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13726/fi-kbl-7567u/igt@[email protected]
* igt@kms_busy@basic-flip-c:
- fi-kbl-7500u: [PASS][7] -> [SKIP][8] ([fdo#109271] / [fdo#109278]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-7500u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13726/fi-kbl-7500u/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][9] -> [FAIL][10] ([fdo#109485])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-7500u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13726/fi-kbl-7500u/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: [DMESG-WARN][11] ([fdo#105128] / [fdo#107139]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-7500u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13726/fi-kbl-7500u/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: [FAIL][13] ([fdo#103167]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-icl-u3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13726/fi-icl-u3/igt@[email protected]
- fi-icl-u2: [FAIL][15] ([fdo#103167]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-icl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13726/fi-icl-u2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#105128]: https://bugs.freedesktop.org/show_bug.cgi?id=105128
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#111115]: https://bugs.freedesktop.org/show_bug.cgi?id=111115
Participating hosts (54 -> 45)
------------------------------
Additional (1): fi-icl-dsi
Missing (10): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6541 -> Patchwork_13726
CI-20190529: 20190529
CI_DRM_6541: 9f1fa88f2b89b7ee8789cd51f8762a947719d574 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5107: 1a5b48671e0863cb723e3d0239e54c828360dc99 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13726: 3378650cebb4a976ce1b1732a53834975efd5f00 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3378650cebb4 drm/i915: Use dev_get_drvdata
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13726/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Chuhong Yuan (2019-07-23 11:39:16)
Quoted 4 lines
Instead of using
to_pci_dev+pci_get_drvdata,
usedev_get_drvdatato make code simpler.Signed-off-by Chuhong Yuan <[email protected]>
That cuts out some circumlocution,
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Chris Wilson (2019-07-23 17:25:17)
Quoted 8 lines
Quoting Chuhong Yuan (2019-07-23 11:39:16)
Quoted 4 lines
Instead of using
to_pci_dev+pci_get_drvdata,
usedev_get_drvdatato make code simpler.Signed-off-by Chuhong Yuan <[email protected]>That cuts out some circumlocution,
Reviewed-by Chris Wilson <[email protected]>
And pushed to dinq, thanks.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx