Skip to contentSkip to conversation

phy: marvell: phy-armada38x-comphy: Add of_node_put() before return

PATCH New Nishka Dasgupta 1 participant 1 message Jul 23, 2019 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: marvell: phy-armada38x-comphy: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.

---
 drivers/phy/marvell/phy-armada38x-comphy.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/phy/marvell/phy-armada38x-comphy.c +3 -1
index 3e00bc679d4e..6960dfd8ad8c 100644
@@ -200,8 +200,10 @@ static int a38x_comphy_probe(struct platform_device *pdev)
 		}
 
 		phy = devm_phy_create(&pdev->dev, child, &a38x_comphy_ops);
-		if (IS_ERR(phy))
+		if (IS_ERR(phy)) {
+			of_node_put(child);
 			return PTR_ERR(phy);
+		}
 
 		priv->lane[val].base = base + 0x28 * val;
 		priv->lane[val].priv = priv;
Signature · 1 line
2.19.1