phy: marvell: phy-mvebu-a3700-comphy: Add of_node_put() before return
Subsystems (2)
PATCH 1/1 phy: marvell: phy-mvebu-a3700-comphy: Add of_node_put() before return
Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in two places.
Issue found with Coccinelle.
--- drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/phy/marvell/phy-mvebu-a3700-comphy.c +6 -2
@@ -277,13 +277,17 @@ static int mvebu_a3700_comphy_probe(struct platform_device *pdev) } lane =devm_kzalloc (&pdev->dev,sizeof (*lane),GFP_KERNEL ); -if (!lane) +if (!lane) { +of_node_put (child);return -ENOMEM ; + } phy =devm_phy_create (&pdev->dev, child, &mvebu_a3700_comphy_ops); -if (IS_ERR (phy)) +if (IS_ERR (phy)) { +of_node_put (child);return PTR_ERR (phy); + } lane->dev = &pdev->dev; lane->mode =PHY_MODE_INVALID ;
Signature · 1 line
2.19.1
Hi Nishka,
Nishka Dasgupta <[email protected]> wrote on Tue, 23 Jul 2019 16:21:08 +0530:
Quoted 25 lines
Each iteration of
for_each_available_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return in two places.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)drivers/phy/marvell/phy-mvebu-a3700-comphy.c +3
-1@@ -277,13 +277,17 @@ static int mvebu_a3700_comphy_probe(struct platform_device *pdev) } lane =devm_kzalloc (&pdev->dev,sizeof (*lane),GFP_KERNEL ); -if (!lane) +if (!lane) { +of_node_put (child);return -ENOMEM ; + }
drivers/phy/marvell/phy-mvebu-a3700-comphy.c static int mvebu_a3700_comphy_probe(struct platform_device *pdev) · line 293
Quoted 10 lines
drivers/phy/marvell/phy-mvebu-a3700-comphy.c +3
-1phy =devm_phy_create (&pdev->dev, child, &mvebu_a3700_comphy_ops); -if (IS_ERR (phy)) +if (IS_ERR (phy)) { +of_node_put (child);return PTR_ERR (phy); + } lane->dev = &pdev->dev; lane->mode =PHY_MODE_INVALID ;
Thanks,
Miquèl