Documentation: filesystem: fix "Removed Sysctls" table
Subsystems (2)
PATCH 1/1 Documentation: filesystem: fix "Removed Sysctls" table
the "Removed Sysctls" section is a table - bring it alive with ReST.
--- Documentation/admin-guide/xfs.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/admin-guide/xfs.rst +3 -2
@@ -337,11 +337,12 @@ None at present. Removed Sysctls =============== +============================= ======= Name Removed - ---- ------- +============================= ======= fs.xfs.xfsbufd_centisec v4.0 fs.xfs.age_buffer_centisecs v4.0 - +============================= ======= Error handling ==============
Signature · 1 line
2.22.0
Jonathan Corbet
maintainerQuoted 3 lines · On Tue, 23 Jul 2019 12:48:13 +0100 Sheriff Esseson <sheriffesseson at…
the "Removed Sysctls" section is a table - bring it alive with ReST.
Signed-off-by Sheriff Esseson <sheriffesseson at gmail.com>
So this appears to be identical to the patch you sent three days ago; is there a reason why you are sending it again now?
Thanks,
jon
Quoted 5 lines · Jonathan Corbet
Quoted 2 lines · On Tue, 23 Jul 2019 12:48:13 +0100 Sheriff Esseson <sheriffesseson at…
the "Removed Sysctls" section is a table - bring it alive with ReST.
Quoted 8 lines
Quoted 1 line
Signed-off-by Sheriff Esseson <sheriffesseson at gmail.com>So this appears to be identical to the patch you sent three days ago; is there a reason why you are sending it again now?
Thanks,
jon
Sorry, I was think the patch went unnoticed during the merge window - I could not find a response.
Quoted 11 lines · Sheriff Esseson
Quoted 10 lines · Jonathan Corbet
Quoted 3 lines · On Tue, 23 Jul 2019 12:48:13 +0100 Sheriff Esseson <sheriffesseson at…
the "Removed Sysctls" section is a table - bring it alive with ReST.
Signed-off-by Sheriff Esseson <sheriffesseson at gmail.com>So this appears to be identical to the patch you sent three days ago; is there a reason why you are sending it again now?
Quoted 6 lines
Quoted 3 lines
Thanks,
jon
Sorry, I was think the patch went unnoticed during the merge window - I could not find a response.
The correct thing to do in that case is to reply to the original patch and ask if it has been looked at. The usual way of doing this is quoting the commit message and replying with a "Ping?" comment to bump it back to the top of everyone's mail stacks.
But, again, 3 days is not a long time, people tend to be extremely busy and might take a few days to get to reviewing non-critical changes, and people may not even review patches during the merge window. I'd suggest waiting a week before pinging a patch you've sent if there's been no response....
Cheers,
Dave.
Signature · 2 lines
Dave Chinner david at fromorbit.com
PATCH 1/1 Documentation: filesystem: fix "Removed Sysctls" table
Quoted 24 lines · Dave Chinner
Quoted 11 lines · Sheriff Esseson
Quoted 10 lines · Jonathan Corbet
Quoted 3 lines · On Tue, 23 Jul 2019 12:48:13 +0100 Sheriff Esseson <sheriffesseson at…
the "Removed Sysctls" section is a table - bring it alive with ReST.
Signed-off-by Sheriff Esseson <sheriffesseson at gmail.com>So this appears to be identical to the patch you sent three days ago; is there a reason why you are sending it again now?
Quoted 6 lines
Quoted 3 lines
Thanks,
jon
Sorry, I was think the patch went unnoticed during the merge window - I could not find a response.
The correct thing to do in that case is to reply to the original patch and ask if it has been looked at. The usual way of doing this is quoting the commit message and replying with a "Ping?" comment to bump it back to the top of everyone's mail stacks.
Quoted 5 lines
But, again, 3 days is not a long time, people tend to be extremely busy and might take a few days to get to reviewing non-critical changes, and people may not even review patches during the merge window. I'd suggest waiting a week before pinging a patch you've sent if there's been no response....
Okay, Thanks Dave.
Quoted 7 lines
Cheers,
Dave.
Signature · 2 lines
Dave Chinner david at fromorbit.com
Quoted 13 lines · On Tue, 23 Jul 2019 12:48:13 +0100 Sheriff Esseson <sheriffesseson at…
the "Removed Sysctls" section is a table - bring it alive with ReST.
Signed-off-by Sheriff Esseson <sheriffesseson at gmail.com>--- Documentation/admin-guide/xfs.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)Documentation/admin-guide/xfs.rst +0
-0@@ -337,11 +337,12 @@ None at present. Removed Sysctls
Documentation/admin-guide/xfs.rst None at present. · line 345
Quoted 10 lines
Documentation/admin-guide/xfs.rst +3
-2=============== +============================= ======= Name Removed - ---- ------- +============================= ======= fs.xfs.xfsbufd_centisec v4.0 fs.xfs.age_buffer_centisecs v4.0 - +============================= =======
I've applied this, thanks.
jon