net: broadcom: Use dev_get_drvdata
Subsystems (5)
PATCH 1/1 net: broadcom: Use dev_get_drvdata
Instead of using to_pci_dev + pci_get_drvdata,
use dev_get_drvdata to make code simpler.
Signed-off-by Chuhong Yuan <[email protected]>
--- drivers/net/ethernet/broadcom/bnx2.c | 6 ++---- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 ++---- drivers/net/ethernet/broadcom/tg3.c | 6 ++---- 3 files changed, 6 insertions(+), 12 deletions(-)
drivers/net/ethernet/broadcom/bnx2.c +2 -4
@@ -8673,8 +8673,7 @@ bnx2_remove_one(struct pci_dev *pdev)static int bnx2_suspend (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct bnx2 *bp =netdev_priv (dev);if (netif_running (dev)) {
@@ -8693,8 +8692,7 @@ bnx2_suspend(struct device *device)static int bnx2_resume (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct bnx2 *bp =netdev_priv (dev);if (!netif_running (dev))
drivers/net/ethernet/broadcom/bnxt/bnxt.c +2 -4
@@ -10920,8 +10920,7 @@ static void bnxt_shutdown(struct pci_dev *pdev)#ifdef CONFIG_PM_SLEEP static int bnxt_suspend (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct bnxt *bp =netdev_priv (dev);int rc =0 ;
@@ -10937,8 +10936,7 @@ static int bnxt_suspend(struct device *device)static int bnxt_resume (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct bnxt *bp =netdev_priv (dev);int rc =0 ;
drivers/net/ethernet/broadcom/tg3.c +2 -4
@@ -18041,8 +18041,7 @@ static void tg3_remove_one(struct pci_dev *pdev)#ifdef CONFIG_PM_SLEEP static int tg3_suspend (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct tg3 *tp =netdev_priv (dev);int err =0 ;
@@ -18098,8 +18097,7 @@ static int tg3_suspend(struct device *device)static int tg3_resume (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct tg3 *tp =netdev_priv (dev);int err =0 ;
Signature · 1 line
2.20.1
Quoted 3 lines · Chuhong Yuan
Instead of using
to_pci_dev+pci_get_drvdata,
usedev_get_drvdatato make code simpler.
Hi Chuhong, i see that you have generated many stand alone patches that belong to the same series/patchset.
A better way to do this is to generate one patchset that includes all the patches and attach a cover letter for it:
$ git format-patch -s --cover-letter --subject-prefix="PATCH net-next"
-o ./patchset/ ${BASE_COMMIT}..${HEAD_COMMIT}and resubmit with the edited cover-letter.
Quoted 85 lines
Signed-off-by Chuhong Yuan <[email protected]>--- drivers/net/ethernet/broadcom/bnx2.c | 6 ++---- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 ++---- drivers/net/ethernet/broadcom/tg3.c | 6 ++---- 3 files changed, 6 insertions(+), 12 deletions(-)drivers/net/ethernet/broadcom/bnx2.c +2
-4@@ -8673,8 +8673,7 @@ bnx2_remove_one(struct pci_dev *pdev)static int bnx2_suspend (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct bnx2 *bp =netdev_priv (dev);if (netif_running (dev)) {@@ -8693,8 +8692,7 @@ bnx2_suspend(struct device *device)static int bnx2_resume (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct bnx2 *bp =netdev_priv (dev);if (!netif_running (dev))drivers/net/ethernet/broadcom/bnxt/bnxt.c +2
-4@@ -10920,8 +10920,7 @@ static void bnxt_shutdown(struct pci_dev *pdev)#ifdef CONFIG_PM_SLEEP static int bnxt_suspend (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct bnxt *bp =netdev_priv (dev);int rc =0 ;@@ -10937,8 +10936,7 @@ static int bnxt_suspend(struct device *device)static int bnxt_resume (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct bnxt *bp =netdev_priv (dev);int rc =0 ;drivers/net/ethernet/broadcom/tg3.c +2
-4@@ -18041,8 +18041,7 @@ static void tg3_remove_one(struct pci_dev *pdev)#ifdef CONFIG_PM_SLEEP static int tg3_suspend (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct tg3 *tp =netdev_priv (dev);int err =0 ;@@ -18098,8 +18097,7 @@ static int tg3_suspend(struct device *device)static int tg3_resume (struct device *device) { -struct pci_dev *pdev =to_pci_dev (device); -struct net_device *dev =pci_get_drvdata (pdev); +struct net_device *dev =dev_get_drvdata (device);struct tg3 *tp =netdev_priv (dev);int err =0 ;
From: Chuhong Yuan <[email protected]>
Date: Tue, 23 Jul 2019 21:19:29 +0800
Quoted 4 lines
Instead of using
to_pci_dev+pci_get_drvdata,
usedev_get_drvdatato make code simpler.Signed-off-by Chuhong Yuan <[email protected]>
Applied.