fm10k: use a local variable for the frag pointer
Subsystems (2)
PATCH 1/1 fm10k: use a local variable for the frag pointer
In the function fm10k_xmit_frame_ring, we recently switched to using the skb_frag_size accessor instead of directly using the size member of the skb fragment.
This made the for loop slightly harder to read because it created a very long line that is difficult to split up. Avoid this by using a local variable in the for loop, so that we do not have to break the line on an open parenthesis.
--- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/fm10k/fm10k_main.c +5 -3
@@ -1073,9 +1073,11 @@ netdev_tx_t fm10k_xmit_frame_ring(struct sk_buff *skb,* + 2 desc gap to keep tail from touching head * otherwise try next time */ -for (f =0 ; f <skb_shinfo (skb)->nr_frags; f++) - count +=TXD_USE_COUNT (skb_frag_size ( - &skb_shinfo (skb)->frags[f])); +for (f =0 ; f <skb_shinfo (skb)->nr_frags; f++) { +skb_frag_t *frag = &skb_shinfo (skb)->frags[f]; + + count +=TXD_USE_COUNT (skb_frag_size (frag)); + }if (fm10k_maybe_stop_tx (tx_ring, count +3 )) { tx_ring->tx_stats.tx_busy++;
Signature · 1 line
2.22.0.214.g8dca754b1e87
Bowers
PATCH 1/1 fm10k: use a local variable for the frag pointer
Quoted 12 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Jacob Keller
Sent: Tuesday, July 23, 2019 9:09 AM
To: Intel Wired LAN <[email protected]>
Subject: [Intel-wired-lan] [PATCH] fm10k: use a local variable for the frag pointerIn the function
fm10k_xmit_frame_ring, we recently switched to using theskb_frag_sizeaccessor instead of directly using the size member of the skb fragment.
Quoted 8 lines
This made the for loop slightly harder to read because it created a very long line that is difficult to split up. Avoid this by using a local variable in the for loop, so that we do not have to break the line on an open parenthesis.
Signed-off-by Jacob Keller <[email protected]>--- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)