Skip to contentSkip to conversation

raw/ioat: fix compiler warning for incorrect include

PATCH Applied Bruce Richardson 3 participants 3 messages Jul 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 raw/ioat: fix compiler warning for incorrect include

Some builds with clang report an error because '<>' rather than '""' were used for including the ioat spec header file.

Target: x86_64-native-bsdapp-clang
22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead

  #include <rte_ioat_spec.h>
           ^~~~~~~~~~~~~~~~~
           "rte_ioat_spec.h"

1 error generated.

Since this file should always be in the same directory as the main header, we can safely change the include line to fix this error.

Fixes abff4333ec20 ("raw/ioat: create device on probe and destroy on release")
---
 drivers/raw/ioat/rte_ioat_rawdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/raw/ioat/rte_ioat_rawdev.h +1 -1
index 7a89632e7..4b271f174 100644
@@ -19,7 +19,7 @@
 #include <rte_memory.h>
 #include <rte_memzone.h>
 #include <rte_prefetch.h>
-#include <rte_ioat_spec.h>
+#include "rte_ioat_spec.h"
 
 /** Name of the device driver */
 #define IOAT_PMD_RAWDEV_NAME rawdev_ioat
Signature · 1 line
2.21.0
#1 lore raw

23/07/2019 18:26, Bruce Richardson:

Quoted 8 lines

Some builds with clang report an error because '<>' rather than '""' were used for including the ioat spec header file.

Target: x86_64-native-bsdapp-clang
22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead

  #include <rte_ioat_spec.h>
           ^~~~~~~~~~~~~~~~~
           "rte_ioat_spec.h"
Quoted 8 lines

1 error generated.

Since this file should always be in the same directory as the main header, we can safely change the include line to fix this error.

Fixes abff4333ec20 ("raw/ioat: create device on probe and destroy on release")

Applied, thanks

Reviewed-by on v1 1/1
#2 lore raw
In reply to Bruce Richardson
Quoted 9 lines · Bruce Richardson

Some builds with clang report an error because '<>' rather than '""' were used for including the ioat spec header file.

Target: x86_64-native-bsdapp-clang
22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead

  #include <rte_ioat_spec.h>
           ^~~~~~~~~~~~~~~~~
           "rte_ioat_spec.h"
Quoted 8 lines

1 error generated.

Since this file should always be in the same directory as the main header, we can safely change the include line to fix this error.

Fixes abff4333ec20 ("raw/ioat: create device on probe and destroy on release")

Still a bit skeptical at why we did not see this on linux.. But this can't hurt and hopefully it fixes the issue :-)

Signature · 1 line
David Marchand