usb: typec: tcpm: Switch to use fwnode_property_count_uXX()
Subsystems (3)
PATCH 1/1 usb: typec: tcpm: Switch to use fwnode_property_count_uXX()
Use use fwnode_property_count_uXX() directly, that makes code neater.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/usb/typec/tcpm/tcpm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +2 -4
@@ -4410,8 +4410,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, goto sink;/* Get source pdos */ - ret =fwnode_property_read_u32_array (fwnode,"source-pdos" , -NULL ,0 ); + ret =fwnode_property_count_u32 (fwnode,"source-pdos" );if (ret <=0 )return -EINVAL ;
@@ -4435,8 +4434,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,return -EINVAL ; sink:/* Get sink pdos */ - ret =fwnode_property_read_u32_array (fwnode,"sink-pdos" , -NULL ,0 ); + ret =fwnode_property_count_u32 (fwnode,"sink-pdos" );if (ret <=0 )return -EINVAL ;
Signature · 1 line
2.20.1
Quoted 3 lines · Andy Shevchenko
Use use
fwnode_property_count_uXX()directly, that makes code neater.Signed-off-by Andy Shevchenko <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 31 lines
--- drivers/usb/typec/tcpm/tcpm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/usb/typec/tcpm/tcpm.c +2
-4@@ -4410,8 +4410,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, goto sink;/* Get source pdos */ - ret =fwnode_property_read_u32_array (fwnode,"source-pdos" , -NULL ,0 ); + ret =fwnode_property_count_u32 (fwnode,"source-pdos" );if (ret <=0 )return -EINVAL ;@@ -4435,8 +4434,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,return -EINVAL ; sink:/* Get sink pdos */ - ret =fwnode_property_read_u32_array (fwnode,"sink-pdos" , -NULL ,0 ); + ret =fwnode_property_count_u32 (fwnode,"sink-pdos" );if (ret <=0 )return -EINVAL ;Signature · 1 line
2.20.1
Quoted 3 lines · Andy Shevchenko
Use use
fwnode_property_count_uXX()directly, that makes code neater.Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Heikki Krogerus <[email protected]>
Quoted 30 lines
--- drivers/usb/typec/tcpm/tcpm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/usb/typec/tcpm/tcpm.c +2
-4@@ -4410,8 +4410,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, goto sink;/* Get source pdos */ - ret =fwnode_property_read_u32_array (fwnode,"source-pdos" , -NULL ,0 ); + ret =fwnode_property_count_u32 (fwnode,"source-pdos" );if (ret <=0 )return -EINVAL ;@@ -4435,8 +4434,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,return -EINVAL ; sink:/* Get sink pdos */ - ret =fwnode_property_read_u32_array (fwnode,"sink-pdos" , -NULL ,0 ); + ret =fwnode_property_count_u32 (fwnode,"sink-pdos" );if (ret <=0 )return -EINVAL ;Signature · 1 line
2.20.1
thanks,
Signature · 1 line
heikki