soc: qcom: Add SoC info driver
Subsystems (3)
v6 cover soc: qcom: Add SoC info driver
This patchset adds SoC info driver which can provide information such as Chip ID, Chip family and serial number about Qualcomm SoCs to user space via sysfs. Furthermore, it allows userspace to get information about custom attributes and various image version information via debugfs.
The patchset cleanly applies on top of v5.2-rc7.
Changes since v1:
- Align ifdefs to left, remove unnecessary debugfs dir creation check and fix function signatures in patch 3
- Fix comment for teh case when serial number is not available in patch 1
Changes since v2:
- Reorder patches [patch five -> patch two]
Changes since v3:
- Add reviewed-bys from Greg
- Fix build warning when debugfs is disabled
- Remove extra checks for dir creations in patch 5
Changes since v4:
- Added Reviewed-bys in multiple patches
- Bunch of nitpick fixes in patch 3
- Major refactoring for using core debugfs functions and eliminating duplicate code in patch 4 and 5 [detailed info can be found under --- in each patch]
Changes since v5:
- No code changes, fix diff.context setting for formatting patches. Version 4 was adding context at the bottom of the file with 'git am'.
Vaishali Thakkar (5):
base: soc: Add serial_number attribute to soc
base: soc: Export soc_device_register/unregister APIs
soc: qcom: Add socinfo driver
soc: qcom: socinfo: Expose custom attributes
soc: qcom: socinfo: Expose image information
Documentation/ABI/testing/sysfs-devices-soc | 7 + drivers/base/soc.c | 9 + drivers/soc/qcom/Kconfig | 8 + drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/smem.c | 9 + drivers/soc/qcom/socinfo.c | 468 ++++++++++++++++++++ include/linux/sys_soc.h | 1 + 7 files changed, 503 insertions(+) create mode 100644 drivers/soc/qcom/socinfo.c
Signature · 1 line
2.17.1
PATCH v6 1/5 base: soc: Add serial_number attribute to soc
From: Bjorn Andersson <[email protected]>
Add new attribute named "serial_number" as a standard interface for user space to acquire the serial number of the device.
For ST-Ericsson SoCs this is exposed by the cryptically named "soc_id" attribute, but this provides a human readable standardized name for this property.
---
Changes since v5:
- No code changes, fix diff.context setting for formatting patches. Version 5 was adding context at the bottom of the file with 'git am'.
Changes since v4:
- Add Stephen's reviewed-by
Changes since v3:
- Add Greg's Reviewed-by
Changes since v2:
- None
Changes since v1:
- Make comment more clear for the case when serial number is not available
--- Documentation/ABI/testing/sysfs-devices-soc | 7 +++++++ drivers/base/soc.c | 7 +++++++ include/linux/sys_soc.h | 1 + 3 files changed, 15 insertions(+)
Documentation/ABI/testing/sysfs-devices-soc +7 -0
@@ -26,6 +26,13 @@ Description: Read-only attribute common to all SoCs. Contains SoC family name (e.g. DB8500). +What: /sys/devices/socX/serial_number +Date: January 2019 +contact: Bjorn Andersson <[email protected]> +Description: + Read-only attribute supported by most SoCs. Contains the SoC's + serial number, if available. + What: /sys/devices/socX/soc_id Date: January 2012 contact: Lee Jones <[email protected]>
drivers/base/soc.c +7 -0
@@ -33,6 +33,7 @@ static struct bus_type soc_bus_type = { static DEVICE_ATTR(machine, S_IRUGO, soc_info_get, NULL); static DEVICE_ATTR(family, S_IRUGO, soc_info_get, NULL); +static DEVICE_ATTR(serial_number, S_IRUGO, soc_info_get, NULL); static DEVICE_ATTR(soc_id, S_IRUGO, soc_info_get, NULL); static DEVICE_ATTR(revision, S_IRUGO, soc_info_get, NULL);
@@ -57,6 +58,9 @@ static umode_t soc_attribute_mode(struct kobject *kobj,if ((attr == &dev_attr_revision.attr) && (soc_dev->attr->revision !=NULL ))return attr->mode; +if ((attr == &dev_attr_serial_number.attr) + && (soc_dev->attr->serial_number !=NULL )) +return attr->mode;if ((attr == &dev_attr_soc_id.attr) && (soc_dev->attr->soc_id !=NULL ))return attr->mode;
@@ -77,6 +81,8 @@ static ssize_t soc_info_get(struct device *dev,return sprintf (buf,"%s\n" , soc_dev->attr->family);if (attr == &dev_attr_revision)return sprintf (buf,"%s\n" , soc_dev->attr->revision); +if (attr == &dev_attr_serial_number) +return sprintf (buf,"%s\n" , soc_dev->attr->serial_number);if (attr == &dev_attr_soc_id)return sprintf (buf,"%s\n" , soc_dev->attr->soc_id);
@@ -87,6 +93,7 @@ static ssize_t soc_info_get(struct device *dev,static struct attribute *soc_attr[] = { &dev_attr_machine.attr, &dev_attr_family.attr, + &dev_attr_serial_number.attr, &dev_attr_soc_id.attr, &dev_attr_revision.attr,NULL ,
include/linux/sys_soc.h +1 -0
@@ -12,6 +12,7 @@ struct soc_device_attribute {const char *machine;const char *family;const char *revision; +const char *serial_number;const char *soc_id;const void *data; };
Signature · 1 line
2.17.1
Re: [PATCH v6 1/5] base: soc: Add serial_number attribute to soc
Quoted 8 lines · Vaishali Thakkar
From: Bjorn Andersson <[email protected]>
Add new attribute named "
serial_number" as a standard interface for user space to acquire the serial number of the device.For ST-Ericsson SoCs this is exposed by the cryptically named "
soc_id" attribute, but this provides a human readable standardized name for this property.
Signature · 1 line
~Vinod
PATCH v6 2/5 base: soc: Export soc_device_register/unregister APIs
In reply to Vaishali ThakkarFrom: Vinod Koul <[email protected]>
Qcom Socinfo driver can be built as a module, so
export these two APIs.
---
Changes since v5:
- No code changes, fix diff.context setting for formatting patches. Version 5 was adding context at the bottom of the file with 'git am'.
Changes since v4:
- Add Bjorn and Stephen's Reviewed-by
Changes since v3:
- Add Greg's Reviewed-by
Changes since v2:
- None
Changes since v1:
- Make comment more clear for the case when serial number is not available
--- drivers/base/soc.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/base/soc.c +2 -0
@@ -164,6 +164,7 @@ struct soc_device *soc_device_register(struct soc_device_attribute *soc_dev_attr out1:return ERR_PTR (ret); } +EXPORT_SYMBOL_GPL (soc_device_register);/* Ensure soc_dev->attr is freed prior to calling soc_device_unregister. */ void soc_device_unregister (struct soc_device *soc_dev)
@@ -173,6 +174,7 @@ void soc_device_unregister(struct soc_device *soc_dev)device_unregister (&soc_dev->dev); early_soc_dev_attr =NULL ; } +EXPORT_SYMBOL_GPL (soc_device_unregister);static int __init soc_bus_register (void ) {
Signature · 1 line
2.17.1
PATCH v6 3/5 soc: qcom: Add socinfo driver
In reply to Vaishali ThakkarFrom: Imran Khan <[email protected]>
The Qualcomm socinfo driver exposes information about the SoC, its version and its serial number to user space.
[Vaishali: Simplify declarations, introduce qcom_socinfo struct, Fix
memory leak, Remove extra code and Misc code refactoring]
---
Changes since v5:
-No code changes, fix diff.context setting for formatting
patches. Version 5 was adding context at the bottom of the file with 'git am'.
Changes since v4:
- Return PTR_ERR in qcom_socinfo_probe instead of error value
- Return PTR_ERR in smem probe to print proper error message when we fail to register the socinfo device
- Use dev_dbg instead of dev_err in qcom_smem_probe
- Use offset_of for exposing the value of serial_number
- Unregister the platform device in smem remove function
- Drop error message in socinfo_machine
- Misc: Add spaces between brackets and strings/numbers in soc_of_id, item ids->item id, socinfo->SoCinfo, soc_of_id->soc_id
Changes since v3:
- None
Changes since v2:
- Fix typo in the work log under signed off by s
Changes since v1:
- None
--- drivers/soc/qcom/Kconfig | 8 ++ drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/smem.c | 9 ++ drivers/soc/qcom/socinfo.c | 194 +++++++++++++++++++++++++++++++++++++ 4 files changed, 212 insertions(+) create mode 100644 drivers/soc/qcom/socinfo.c
drivers/soc/qcom/Kconfig +8 -0
@@ -175,6 +175,14 @@ config QCOM_SMSM Say yes here to support the Qualcomm Shared Memory State Machine. The state machine is represented by bits in shared memory. +config QCOM_SOCINFO + tristate "Qualcomm socinfo driver" + depends on QCOM_SMEM + select SOC_BUS + help + Say yes here to support the Qualcomm socinfo driver, providing + information about the SoC to user space. + config QCOM_WCNSS_CTRL tristate "Qualcomm WCNSS control driver" depends on ARCH_QCOM || COMPILE_TEST
drivers/soc/qcom/Makefile +1 -0
@@ -18,6 +18,7 @@ obj-$(CONFIG_QCOM_SMEM) += smem.o obj-$(CONFIG_QCOM_SMEM_STATE) += smem_state.o obj-$(CONFIG_QCOM_SMP2P) += smp2p.o obj-$(CONFIG_QCOM_SMSM) += smsm.o +obj-$(CONFIG_QCOM_SOCINFO) += socinfo.o obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o obj-$(CONFIG_QCOM_APR) += apr.o obj-$(CONFIG_QCOM_LLCC) += llcc-slice.o
drivers/soc/qcom/smem.c +9 -0
@@ -268,6 +268,7 @@ struct qcom_smem {struct smem_partition_header *partitions[SMEM_HOST_COUNT ];size_t cacheline[SMEM_HOST_COUNT ];u32 item_count; +struct platform_device *socinfo;unsigned num_regions;struct smem_region regions[];
@@ -963,11 +964,19 @@ static int qcom_smem_probe(struct platform_device *pdev) __smem = smem; + smem->socinfo =platform_device_register_data (&pdev->dev,"qcom-socinfo" , +PLATFORM_DEVID_NONE ,NULL , +0 ); +if (IS_ERR (smem->socinfo)) +dev_dbg (&pdev->dev,"failed to register socinfo device\n" ); +return 0 ; }static int qcom_smem_remove (struct platform_device *pdev) { +platform_device_unregister (__smem->socinfo); +hwspin_lock_free (__smem->hwlock); __smem =NULL ;
drivers/soc/qcom/socinfo.c new file +194 -0
194 lines not on this page · raw message
Signature · 1 line
2.17.1
Re: [PATCH v6 3/5] soc: qcom: Add socinfo driver
Quoted 4 lines · Vaishali Thakkar
From: Imran Khan <[email protected]>
The Qualcomm socinfo driver exposes information about the SoC, its version and its serial number to user space.
Signature · 1 line
~Vinod
PATCH v6 4/5 soc: qcom: socinfo: Expose custom attributes
In reply to Vaishali ThakkarThe Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality.
---
Changes since v5:
- No code changes, fix my diff.context setting for formatting patches. Version 5 was adding context at the bottom of the file with 'git am'.
Changes since v4:
- Introduce socinfo_params and use create_debugfs_{u32,x32} instead of driver specific macros
- Remove some unnecessary separate functions [qcom_show_{platform_subtype,accessory_chip}] and use debugfs core functions to expose their values
- Use switch to expose custom attributes based on the firmware version
- Misc: Drop unnecessory comments, pmic_model->pmic_models, don't pass socinfo pointer in qcom_socinfo
- Note: I didn't introduce any new debugfs core functions for printing string values because it wasn't possible to cover both cases of string arrays in this file - pmic_model and build_id by introducing a single function. Morever, I still needed QCOM_OPEN and DEBUGFS_ADD to cover the case of pmic_die_rev so introducing the 'debugfs create string array function' wasn't completely eliminating extra macro code. So, I'm just using the above mentioned macros to print string array values for now. Feel free to on this matter. Thanks!
Changes since v3:
- Fix compilation error in function signatures when debugfs is disabled
Changes since v2:
- None
Changes since v1:
- Remove unnecessary debugfs dir creation check
- Align ifdefs to left
- Fix function signatures for debugfs init/exit
--- drivers/soc/qcom/socinfo.c | 190 +++++++++++++++++++++++++++++++++++++ 1 file changed, 190 insertions(+)
drivers/soc/qcom/socinfo.c +190 -0
@@ -4,6 +4,7 @@* Copyright (c) 2017-2019, Linaro Ltd. */ +#include <linux/debugfs.h> #include <linux/err.h> #include <linux/module.h> #include <linux/platform_device.h>
@@ -20,6 +21,7 @@*/ #define SOCINFO_MAJOR (ver) (((ver) >> 16) & 0xffff)#define SOCINFO_MINOR (ver) ((ver) & 0xffff) +#define SOCINFO_VERSION (maj, min) ((((maj) & 0xffff) << 16)|((min) & 0xffff))#define SMEM_SOCINFO_BUILD_ID_LENGTH 32
@@ -29,6 +31,27 @@*/ #define SMEM_HW_SW_BUILD_ID 137 +#ifdef CONFIG_DEBUG_FS +static const char *const pmic_models[] = { + [0 ] ="Unknown PMIC model" , + [9 ] ="PM8994" , + [11 ] ="PM8916" , + [13 ] ="PM8058" , + [14 ] ="PM8028" , + [15 ] ="PM8901" , + [16 ] ="PM8027" , + [17 ] ="ISL9519" , + [18 ] ="PM8921" , + [19 ] ="PM8018" , + [20 ] ="PM8015" , + [21 ] ="PM8014" , + [22 ] ="PM8821" , + [23 ] ="PM8038" , + [24 ] ="PM8922" , + [25 ] ="PM8917" , +}; +#endif /* CONFIG_DEBUG_FS */ +/* Socinfo SMEM item structure */ struct socinfo {__le32 fmt;
@@ -67,9 +90,28 @@ struct socinfo {__le32 raw_device_num; }; +#ifdef CONFIG_DEBUG_FS +struct socinfo_params { +u32 raw_device_family; +u32 hw_plat_subtype; +u32 accessory_chip; +u32 raw_device_num; +u32 chip_family; +u32 foundry_id; +u32 plat_ver; +u32 raw_ver; +u32 hw_plat; +u32 fmt; +}; +#endif /* CONFIG_DEBUG_FS */ +struct qcom_socinfo {struct soc_device *soc_dev;struct soc_device_attribute attr; +#ifdef CONFIG_DEBUG_FS +struct dentry *dbg_root; +struct socinfo_params info; +#endif /* CONFIG_DEBUG_FS */ };struct soc_id {
@@ -130,6 +172,150 @@ static const char *socinfo_machine(struct device *dev, unsigned int id)return NULL ; } +#ifdef CONFIG_DEBUG_FS + +#define QCOM_OPEN (name, _func) \ +static int qcom_open_##name(struct inode *inode, struct file *file) \ +{ \ + return single_open(file, _func, inode->i_private); \ +} \ + \ +static const struct file_operations qcom_ ##name## _ops = { \ + .open = qcom_open_##name, \ + .read = seq_read, \ + .llseek = seq_lseek, \ + .release = single_release, \ +} + +#define DEBUGFS_ADD (info, name) \ + debugfs_create_file(__stringify(name), 0400, \ + qcom_socinfo->dbg_root, \ + info, &qcom_ ##name## _ops) + + +static int qcom_show_build_id (struct seq_file *seq,void *p) +{ +struct socinfo *socinfo = seq->private; + +seq_printf (seq,"%s\n" , socinfo->build_id); + +return 0 ; +} + +static int qcom_show_pmic_model (struct seq_file *seq,void *p) +{ +struct socinfo *socinfo = seq->private; +int model =SOCINFO_MINOR (le32_to_cpu (socinfo->pmic_model)); + +if (model <0 ) +return -EINVAL ; + +seq_printf (seq,"%s\n" , pmic_models[model]); + +return 0 ; +} + +static int qcom_show_pmic_die_revision (struct seq_file *seq,void *p) +{ +struct socinfo *socinfo = seq->private; + +seq_printf (seq,"%u.%u\n" , +SOCINFO_MAJOR (le32_to_cpu (socinfo->pmic_die_rev)), +SOCINFO_MINOR (le32_to_cpu (socinfo->pmic_die_rev))); + +return 0 ; +} + +QCOM_OPEN (build_id, qcom_show_build_id); +QCOM_OPEN (pmic_model, qcom_show_pmic_model); +QCOM_OPEN (pmic_die_rev, qcom_show_pmic_die_revision); + +static void socinfo_debugfs_init (struct qcom_socinfo *qcom_socinfo, +struct socinfo *info) +{ +size_t size; + + qcom_socinfo->dbg_root =debugfs_create_dir ("qcom_socinfo" ,NULL ); + + qcom_socinfo->info.fmt =__le32_to_cpu (info->fmt); + +switch (qcom_socinfo->info.fmt) { +case SOCINFO_VERSION (0 ,12 ): + qcom_socinfo->info.chip_family = +__le32_to_cpu (info->chip_family); + qcom_socinfo->info.raw_device_family = +__le32_to_cpu (info->raw_device_family); + qcom_socinfo->info.raw_device_num = +__le32_to_cpu (info->raw_device_num); + +debugfs_create_x32 ("chip_family" ,0400 , qcom_socinfo->dbg_root, + &qcom_socinfo->info.chip_family); +debugfs_create_x32 ("raw_device_family" ,0400 , + qcom_socinfo->dbg_root, + &qcom_socinfo->info.raw_device_family); +debugfs_create_x32 ("raw_device_number" ,0400 , + qcom_socinfo->dbg_root, + &qcom_socinfo->info.raw_device_num); +case SOCINFO_VERSION (0 ,11 ): +case SOCINFO_VERSION (0 ,10 ): +case SOCINFO_VERSION (0 ,9 ): + qcom_socinfo->info.foundry_id =__le32_to_cpu (info->foundry_id); + +debugfs_create_u32 ("foundry_id" ,0400 , qcom_socinfo->dbg_root, + &qcom_socinfo->info.foundry_id); +case SOCINFO_VERSION (0 ,8 ): +case SOCINFO_VERSION (0 ,7 ): +DEBUGFS_ADD (info, pmic_model); +DEBUGFS_ADD (info, pmic_die_rev); +case SOCINFO_VERSION (0 ,6 ): + qcom_socinfo->info.hw_plat_subtype = +__le32_to_cpu (info->hw_plat_subtype); + +debugfs_create_u32 ("hardware_platform_subtype" ,0400 , + qcom_socinfo->dbg_root, + &qcom_socinfo->info.hw_plat_subtype); +case SOCINFO_VERSION (0 ,5 ): + qcom_socinfo->info.accessory_chip = +__le32_to_cpu (info->accessory_chip); + +debugfs_create_u32 ("accessory_chip" ,0400 , + qcom_socinfo->dbg_root, + &qcom_socinfo->info.accessory_chip); +case SOCINFO_VERSION (0 ,4 ): + qcom_socinfo->info.plat_ver =__le32_to_cpu (info->plat_ver); + +debugfs_create_u32 ("platform_version" ,0400 , + qcom_socinfo->dbg_root, + &qcom_socinfo->info.plat_ver); +case SOCINFO_VERSION (0 ,3 ): + qcom_socinfo->info.hw_plat =__le32_to_cpu (info->hw_plat); + +debugfs_create_u32 ("hardware_platform" ,0400 , + qcom_socinfo->dbg_root, + &qcom_socinfo->info.hw_plat); +case SOCINFO_VERSION (0 ,2 ): + qcom_socinfo->info.raw_ver =__le32_to_cpu (info->raw_ver); + +debugfs_create_u32 ("raw_version" ,0400 , qcom_socinfo->dbg_root, + &qcom_socinfo->info.raw_ver); +case SOCINFO_VERSION (0 ,1 ): +DEBUGFS_ADD (info, build_id); +break ; + } +} + +static void socinfo_debugfs_exit (struct qcom_socinfo *qcom_socinfo) +{ +debugfs_remove_recursive (qcom_socinfo->dbg_root); +} +#else +static void socinfo_debugfs_init (struct qcom_socinfo *qcom_socinfo, +struct socinfo *info) +{ +} +static void socinfo_debugfs_exit (struct qcom_socinfo *qcom_socinfo) { } +#endif /* CONFIG_DEBUG_FS */ +static int qcom_socinfo_probe (struct platform_device *pdev) {struct qcom_socinfo *qs;
@@ -162,6 +348,8 @@ static int qcom_socinfo_probe(struct platform_device *pdev)if (IS_ERR (qs->soc_dev))return PTR_ERR (qs->soc_dev); +socinfo_debugfs_init (qs, info); +/* Feed the soc specific unique data into entropy pool */ add_device_randomness (info, item_size);
@@ -176,6 +364,8 @@ static int qcom_socinfo_remove(struct platform_device *pdev)soc_device_unregister (qs->soc_dev); +socinfo_debugfs_exit (qs); +return 0 ; }
Signature · 1 line
2.17.1
Re: [PATCH v6 4/5] soc: qcom: socinfo: Expose custom attributes
Quoted 3 lines · Vaishali Thakkar
The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality.
Signature · 1 line
~Vinod
PATCH v6 5/5 soc: qcom: socinfo: Expose image information
In reply to Vaishali ThakkarThe socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose.
---
Changes since v5:
- No code changes, fix diff.context setting for formatting patches. Version 5 was adding context at the bottom of the file with 'git am'.
Changes since v4:
- Reduce number of duplicate image macros and functions
- Introduce array for image info debugfs entries and use it instead of open coding
Changes since v3:
- Remove extra debugfs directory creation checks
Changes since v2:
- None
Changes since v1:
- None
--- drivers/soc/qcom/socinfo.c | 84 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 84 insertions(+)
drivers/soc/qcom/socinfo.c +84 -0
@@ -32,6 +32,39 @@#define SMEM_HW_SW_BUILD_ID 137#ifdef CONFIG_DEBUG_FS +#define SMEM_IMAGE_VERSION_BLOCKS_COUNT 32 +#define SMEM_IMAGE_VERSION_SIZE 4096 +#define SMEM_IMAGE_VERSION_NAME_SIZE 75 +#define SMEM_IMAGE_VERSION_VARIANT_SIZE 20 +#define SMEM_IMAGE_VERSION_OEM_SIZE 32 + +/* +* SMEM Image table indices +*/ +#define SMEM_IMAGE_TABLE_BOOT_INDEX 0 +#define SMEM_IMAGE_TABLE_TZ_INDEX 1 +#define SMEM_IMAGE_TABLE_RPM_INDEX 3 +#define SMEM_IMAGE_TABLE_APPS_INDEX 10 +#define SMEM_IMAGE_TABLE_MPSS_INDEX 11 +#define SMEM_IMAGE_TABLE_ADSP_INDEX 12 +#define SMEM_IMAGE_TABLE_CNSS_INDEX 13 +#define SMEM_IMAGE_TABLE_VIDEO_INDEX 14 +#define SMEM_IMAGE_VERSION_TABLE 469 + +/* +* SMEM Image table names +*/ +static const char *const socinfo_image_names[] = { + [SMEM_IMAGE_TABLE_ADSP_INDEX ] ="adsp" , + [SMEM_IMAGE_TABLE_APPS_INDEX ] ="apps" , + [SMEM_IMAGE_TABLE_BOOT_INDEX ] ="boot" , + [SMEM_IMAGE_TABLE_CNSS_INDEX ] ="cnss" , + [SMEM_IMAGE_TABLE_MPSS_INDEX ] ="mpss" , + [SMEM_IMAGE_TABLE_RPM_INDEX ] ="rpm" , + [SMEM_IMAGE_TABLE_TZ_INDEX ] ="tz" , + [SMEM_IMAGE_TABLE_VIDEO_INDEX ] ="video" , +}; +static const char *const pmic_models[] = { [0 ] ="Unknown PMIC model" , [9] = "PM8994",
@@ -103,6 +136,13 @@ struct socinfo_params {u32 hw_plat;u32 fmt; }; + +struct smem_image_version { +char name[SMEM_IMAGE_VERSION_NAME_SIZE ]; +char variant[SMEM_IMAGE_VERSION_VARIANT_SIZE ]; +char pad; +char oem[SMEM_IMAGE_VERSION_OEM_SIZE ]; +};#endif /* CONFIG_DEBUG_FS */ struct qcom_socinfo {
@@ -230,10 +270,37 @@ QCOM_OPEN(build_id, qcom_show_build_id);QCOM_OPEN (pmic_model, qcom_show_pmic_model);QCOM_OPEN (pmic_die_rev, qcom_show_pmic_die_revision); +#define DEFINE_IMAGE_OPS (type) \ +static int show_image_##type(struct seq_file *seq, void *p) \ +{ \ + struct smem_image_version *image_version = seq->private; \ + seq_puts(seq, image_version->type); \ + seq_puts(seq, "\n"); \ + return 0; \ +} \ +static int open_image_##type(struct inode *inode, struct file *file) \ +{ \ + return single_open(file, show_image_##type, inode->i_private); \ +} \ + \ +static const struct file_operations qcom_image_##type##_ops = { \ + .open = open_image_##type, \ + .read = seq_read, \ + .llseek = seq_lseek, \ + .release = single_release, \ +} + +DEFINE_IMAGE_OPS (name); +DEFINE_IMAGE_OPS (variant); +DEFINE_IMAGE_OPS (oem); +static void socinfo_debugfs_init (struct qcom_socinfo *qcom_socinfo,struct socinfo *info) { +struct smem_image_version *versions; +struct dentry *dentry;size_t size; +int i; qcom_socinfo->dbg_root =debugfs_create_dir ("qcom_socinfo" ,NULL );
@@ -302,6 +369,23 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,DEBUGFS_ADD (info, build_id);break ; } + + versions =qcom_smem_get (QCOM_SMEM_HOST_ANY ,SMEM_IMAGE_VERSION_TABLE , + &size); + +for (i =0 ; i <ARRAY_SIZE (socinfo_image_names); i++) { +if (!socinfo_image_names[i]) +continue ; + + dentry =debugfs_create_dir (socinfo_image_names[i], + qcom_socinfo->dbg_root); +debugfs_create_file ("name" ,0400 , dentry, &versions[i], + &qcom_image_name_ops); +debugfs_create_file ("variant" ,0400 , dentry, &versions[i], + &qcom_image_variant_ops); +debugfs_create_file ("oem" ,0400 , dentry, &versions[i], + &qcom_image_oem_ops); + } }static void socinfo_debugfs_exit (struct qcom_socinfo *qcom_socinfo)
Signature · 1 line
2.17.1
Re: [PATCH v6 5/5] soc: qcom: socinfo: Expose image information
Quoted 3 lines · Vaishali Thakkar
The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose.
Signature · 1 line
~Vinod
Quoted 7 lines · Vaishali Thakkar
This patchset adds SoC info driver which can provide information such as Chip ID, Chip family and serial number about Qualcomm SoCs to user space via sysfs. Furthermore, it allows userspace to get information about custom attributes and various image version information via debugfs.
The patchset cleanly applies on top of v5.2-rc7.
And on v5.3-rc1 :) and I have tested this on db845c, seems to work fine for me
Signature · 1 line
~Vinod