Skip to contentSkip to conversation

platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN

PATCH In review Rhys Kidd 2 participants 6 messages Jul 24, 2019 – Jul 25, 2019 x86 platform drivers

lore
Share & tools
lore

Rhys Kidd

author
#0 lore raw

PATCH 1/3 platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN

There's a wmi event generated by dell-wmi when pressing keyboard backlight toggle key:

[1224203.948894] dell_wmi: Unknown key with type 0x0011 and code 0x01e2 pressed

This event is for notification purposes, let's ignore it.

---
 drivers/platform/x86/dell-wmi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/dell-wmi.c +1 -0
index 1f565fb69098..ae331ac119a1 100644
@@ -312,6 +312,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
 
 	/* Keyboard backlight level changed */
 	{ KE_IGNORE, 0x01e1, { KEY_RESERVED } },
+	{ KE_IGNORE, 0x01e2, { KEY_RESERVED } },
 	{ KE_IGNORE, 0x02ea, { KEY_RESERVED } },
 	{ KE_IGNORE, 0x02eb, { KEY_RESERVED } },
 	{ KE_IGNORE, 0x02ec, { KEY_RESERVED } },
Signature · 1 line
2.20.1
author
#1 lore raw

PATCH 2/3 platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN

There's a wmi event generated by dell-wmi when pressing keyboard backlight toggle key:

[1224178.355650] dell_wmi: Unknown key with type 0x0011 and code 0x01e3 pressed

This event is for notification purposes, let's ignore it.

---
 drivers/platform/x86/dell-wmi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/dell-wmi.c +1 -0
index ae331ac119a1..68a8a4eba4e3 100644
@@ -313,6 +313,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
 	/* Keyboard backlight level changed */
 	{ KE_IGNORE, 0x01e1, { KEY_RESERVED } },
 	{ KE_IGNORE, 0x01e2, { KEY_RESERVED } },
+	{ KE_IGNORE, 0x01e3, { KEY_RESERVED } },
 	{ KE_IGNORE, 0x02ea, { KEY_RESERVED } },
 	{ KE_IGNORE, 0x02eb, { KEY_RESERVED } },
 	{ KE_IGNORE, 0x02ec, { KEY_RESERVED } },
Signature · 1 line
2.20.1
#2 lore raw

Re: [PATCH 2/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN

Quoted 7 lines · Rhys Kidd

There's a wmi event generated by dell-wmi when pressing keyboard backlight toggle key:

[1224178.355650] dell_wmi: Unknown key with type 0x0011 and code 0x01e3 pressed

This event is for notification purposes, let's ignore it.

Pushed to my review and testing queue, thanks!

Quoted 20 lines
---
 drivers/platform/x86/dell-wmi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/dell-wmi.c +1 -1
index ae331ac119a1..68a8a4eba4e3 100644
@@ -313,6 +313,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
        /* Keyboard backlight level changed */
        { KE_IGNORE, 0x01e1, { KEY_RESERVED } },
        { KE_IGNORE, 0x01e2, { KEY_RESERVED } },
+       { KE_IGNORE, 0x01e3, { KEY_RESERVED } },
        { KE_IGNORE, 0x02ea, { KEY_RESERVED } },
        { KE_IGNORE, 0x02eb, { KEY_RESERVED } },
        { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
--

2.20.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#3 lore raw

PATCH 3/3 platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values

In reply to Rhys Kidd

These values have already been defined in platform/x86/dell-smbios.h

---
 drivers/platform/x86/dell-wmi.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/platform/x86/dell-wmi.c +7 -7
index 68a8a4eba4e3..fc33c38f5f82 100644
@@ -311,13 +311,13 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
 	{ KE_IGNORE, 0xfff1, { KEY_RESERVED } },
 
 	/* Keyboard backlight level changed */
-	{ KE_IGNORE, 0x01e1, { KEY_RESERVED } },
-	{ KE_IGNORE, 0x01e2, { KEY_RESERVED } },
-	{ KE_IGNORE, 0x01e3, { KEY_RESERVED } },
-	{ KE_IGNORE, 0x02ea, { KEY_RESERVED } },
-	{ KE_IGNORE, 0x02eb, { KEY_RESERVED } },
-	{ KE_IGNORE, 0x02ec, { KEY_RESERVED } },
-	{ KE_IGNORE, 0x02f6, { KEY_RESERVED } },
+	{ KE_IGNORE, KBD_LED_OFF_TOKEN,      { KEY_RESERVED } },
+	{ KE_IGNORE, KBD_LED_ON_TOKEN,       { KEY_RESERVED } },
+	{ KE_IGNORE, KBD_LED_AUTO_TOKEN,     { KEY_RESERVED } },
+	{ KE_IGNORE, KBD_LED_AUTO_25_TOKEN,  { KEY_RESERVED } },
+	{ KE_IGNORE, KBD_LED_AUTO_50_TOKEN,  { KEY_RESERVED } },
+	{ KE_IGNORE, KBD_LED_AUTO_75_TOKEN,  { KEY_RESERVED } },
+	{ KE_IGNORE, KBD_LED_AUTO_100_TOKEN, { KEY_RESERVED } },
 };
 
 static void dell_wmi_process_key(struct wmi_device *wdev, int type, int code)
Signature · 1 line
2.20.1
#4 lore raw

Re: [PATCH 3/3] platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values

Quoted 3 lines · Rhys Kidd

These values have already been defined in platform/x86/dell-smbios.h

Pushed to my review and testing queue, thanks!

Quoted 33 lines
---
 drivers/platform/x86/dell-wmi.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/platform/x86/dell-wmi.c +7 -8
index 68a8a4eba4e3..fc33c38f5f82 100644
@@ -311,13 +311,13 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
        { KE_IGNORE, 0xfff1, { KEY_RESERVED } },
 
        /* Keyboard backlight level changed */
-       { KE_IGNORE, 0x01e1, { KEY_RESERVED } },
-       { KE_IGNORE, 0x01e2, { KEY_RESERVED } },
-       { KE_IGNORE, 0x01e3, { KEY_RESERVED } },
-       { KE_IGNORE, 0x02ea, { KEY_RESERVED } },
-       { KE_IGNORE, 0x02eb, { KEY_RESERVED } },
-       { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
-       { KE_IGNORE, 0x02f6, { KEY_RESERVED } },
+       { KE_IGNORE, KBD_LED_OFF_TOKEN,      { KEY_RESERVED } },
+       { KE_IGNORE, KBD_LED_ON_TOKEN,       { KEY_RESERVED } },
+       { KE_IGNORE, KBD_LED_AUTO_TOKEN,     { KEY_RESERVED } },
+       { KE_IGNORE, KBD_LED_AUTO_25_TOKEN,  { KEY_RESERVED } },
+       { KE_IGNORE, KBD_LED_AUTO_50_TOKEN,  { KEY_RESERVED } },
+       { KE_IGNORE, KBD_LED_AUTO_75_TOKEN,  { KEY_RESERVED } },
+       { KE_IGNORE, KBD_LED_AUTO_100_TOKEN, { KEY_RESERVED } },
 };
 
 static void dell_wmi_process_key(struct wmi_device *wdev, int type, int code)
--

2.20.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
In reply to Rhys Kidd
Quoted 7 lines · Rhys Kidd

There's a wmi event generated by dell-wmi when pressing keyboard backlight toggle key:

[1224203.948894] dell_wmi: Unknown key with type 0x0011 and code 0x01e2 pressed

This event is for notification purposes, let's ignore it.

Pushed to my review and testing queue, thanks!

Quoted 18 lines
---
 drivers/platform/x86/dell-wmi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/dell-wmi.c +1 -1
index 1f565fb69098..ae331ac119a1 100644
@@ -312,6 +312,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
 
        /* Keyboard backlight level changed */
        { KE_IGNORE, 0x01e1, { KEY_RESERVED } },
+       { KE_IGNORE, 0x01e2, { KEY_RESERVED } },
        { KE_IGNORE, 0x02ea, { KEY_RESERVED } },
        { KE_IGNORE, 0x02eb, { KEY_RESERVED } },
        { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
--
Quoted 2 lines

2.20.1

--
With Best Regards,
Andy Shevchenko