platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN
PATCH 1/3 platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN
There's a wmi event generated by dell-wmi when pressing keyboard backlight toggle key:
[1224203.948894] dell_wmi: Unknown key with type 0x0011 and code 0x01e2 pressed
This event is for notification purposes, let's ignore it.
--- drivers/platform/x86/dell-wmi.c | 1 + 1 file changed, 1 insertion(+)
drivers/platform/x86/dell-wmi.c +1 -0
@@ -312,6 +312,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {/* Keyboard backlight level changed */ { KE_IGNORE, 0x01e1, { KEY_RESERVED } }, + { KE_IGNORE, 0x01e2, { KEY_RESERVED } }, { KE_IGNORE, 0x02ea, { KEY_RESERVED } }, { KE_IGNORE, 0x02eb, { KEY_RESERVED } }, { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
Signature · 1 line
2.20.1
PATCH 2/3 platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN
There's a wmi event generated by dell-wmi when pressing keyboard backlight toggle key:
[1224178.355650] dell_wmi: Unknown key with type 0x0011 and code 0x01e3 pressed
This event is for notification purposes, let's ignore it.
--- drivers/platform/x86/dell-wmi.c | 1 + 1 file changed, 1 insertion(+)
drivers/platform/x86/dell-wmi.c +1 -0
@@ -313,6 +313,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {/* Keyboard backlight level changed */ { KE_IGNORE, 0x01e1, { KEY_RESERVED } }, { KE_IGNORE, 0x01e2, { KEY_RESERVED } }, + { KE_IGNORE, 0x01e3, { KEY_RESERVED } }, { KE_IGNORE, 0x02ea, { KEY_RESERVED } }, { KE_IGNORE, 0x02eb, { KEY_RESERVED } }, { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
Signature · 1 line
2.20.1
Re: [PATCH 2/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN
Quoted 7 lines · Rhys Kidd
There's a wmi event generated by dell-wmi when pressing keyboard backlight toggle key:
[1224178.355650] dell_wmi: Unknown key with type 0x0011 and code 0x01e3 pressedThis event is for notification purposes, let's ignore it.
Pushed to my review and testing queue, thanks!
Quoted 20 lines
Signed-off-by Rhys Kidd <[email protected]>--- drivers/platform/x86/dell-wmi.c | 1 + 1 file changed, 1 insertion(+)drivers/platform/x86/dell-wmi.c +1
-1@@ -313,6 +313,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {/* Keyboard backlight level changed */ { KE_IGNORE, 0x01e1, { KEY_RESERVED } }, { KE_IGNORE, 0x01e2, { KEY_RESERVED } }, + { KE_IGNORE, 0x01e3, { KEY_RESERVED } }, { KE_IGNORE, 0x02ea, { KEY_RESERVED } }, { KE_IGNORE, 0x02eb, { KEY_RESERVED } }, { KE_IGNORE, 0x02ec, { KEY_RESERVED } }, --2.20.1
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH 3/3 platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values
In reply to Rhys KiddThese values have already been defined in platform/x86/dell-smbios.h
--- drivers/platform/x86/dell-wmi.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/platform/x86/dell-wmi.c +7 -7
@@ -311,13 +311,13 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = { { KE_IGNORE, 0xfff1, { KEY_RESERVED } },/* Keyboard backlight level changed */ - { KE_IGNORE, 0x01e1, { KEY_RESERVED } }, - { KE_IGNORE, 0x01e2, { KEY_RESERVED } }, - { KE_IGNORE, 0x01e3, { KEY_RESERVED } }, - { KE_IGNORE, 0x02ea, { KEY_RESERVED } }, - { KE_IGNORE, 0x02eb, { KEY_RESERVED } }, - { KE_IGNORE, 0x02ec, { KEY_RESERVED } }, - { KE_IGNORE, 0x02f6, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_OFF_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_ON_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_AUTO_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_AUTO_25_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_AUTO_50_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_AUTO_75_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_AUTO_100_TOKEN, { KEY_RESERVED } }, };static void dell_wmi_process_key (struct wmi_device *wdev,int type,int code)
Signature · 1 line
2.20.1
Re: [PATCH 3/3] platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values
Quoted 3 lines · Rhys Kidd
These values have already been defined in
platform/x86/dell-smbios.h
Pushed to my review and testing queue, thanks!
Quoted 33 lines
Signed-off-by Rhys Kidd <[email protected]>--- drivers/platform/x86/dell-wmi.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/platform/x86/dell-wmi.c +7
-8@@ -311,13 +311,13 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = { { KE_IGNORE, 0xfff1, { KEY_RESERVED } },/* Keyboard backlight level changed */ - { KE_IGNORE, 0x01e1, { KEY_RESERVED } }, - { KE_IGNORE, 0x01e2, { KEY_RESERVED } }, - { KE_IGNORE, 0x01e3, { KEY_RESERVED } }, - { KE_IGNORE, 0x02ea, { KEY_RESERVED } }, - { KE_IGNORE, 0x02eb, { KEY_RESERVED } }, - { KE_IGNORE, 0x02ec, { KEY_RESERVED } }, - { KE_IGNORE, 0x02f6, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_OFF_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_ON_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_AUTO_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_AUTO_25_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_AUTO_50_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_AUTO_75_TOKEN, { KEY_RESERVED } }, + { KE_IGNORE, KBD_LED_AUTO_100_TOKEN, { KEY_RESERVED } }, };static void dell_wmi_process_key (struct wmi_device *wdev,int type,int code) --2.20.1
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Rhys Kidd
There's a wmi event generated by dell-wmi when pressing keyboard backlight toggle key:
[1224203.948894] dell_wmi: Unknown key with type 0x0011 and code 0x01e2 pressedThis event is for notification purposes, let's ignore it.
Pushed to my review and testing queue, thanks!
Quoted 18 lines
Signed-off-by Rhys Kidd <[email protected]>--- drivers/platform/x86/dell-wmi.c | 1 + 1 file changed, 1 insertion(+)drivers/platform/x86/dell-wmi.c +1
-1@@ -312,6 +312,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {/* Keyboard backlight level changed */ { KE_IGNORE, 0x01e1, { KEY_RESERVED } }, + { KE_IGNORE, 0x01e2, { KEY_RESERVED } }, { KE_IGNORE, 0x02ea, { KEY_RESERVED } }, { KE_IGNORE, 0x02eb, { KEY_RESERVED } }, { KE_IGNORE, 0x02ec, { KEY_RESERVED } }, --
Quoted 2 lines
2.20.1
--
With Best Regards,
Andy Shevchenko