Skip to contentSkip to conversation

perf tools: Initial libperf separation

RFC In review Jiri Olsa 9 participants 192 messages Jul 21, 2019 – Aug 23, 2019 Page 5 of 5

Subsystems (9)
lore
Share & tools
lore
#176 lore raw

[tip:perf/core] libperf: Add perf_evsel tests

In reply to Jiri Olsa
libperf: Add perf_evsel tests
Commit-ID:  bb5133ae4d404a8a08d8a94dfdea1c477c93e842
Gitweb:     https://git.kernel.org/tip/bb5133ae4d404a8a08d8a94dfdea1c477c93e842
Author:     Jiri Olsa <[email protected]>
AuthorDate: Sun, 21 Jul 2019 13:25:03 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 29 Jul 2019 18:34:47 -0300

libperf: Add perf_evsel tests

Add 2 simple perf_evsel tests to test counters reading interface through the struct evsel object.

Committer testing:

  # make -C tools/perf/lib tests
  make: Entering directory '/home/acme/git/perf/tools/perf/lib'
    LINK     test-cpumap-a
    LINK     test-threadmap-a
    LINK     test-evlist-a
    LINK     test-evsel-a
    LINK     test-cpumap-so
    LINK     test-threadmap-so
    LINK     test-evlist-so
    LINK     test-evsel-so
  running static:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK
  running dynamic:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK
  make: Leaving directory '/home/acme/git/perf/tools/perf/lib'
  #
---
 tools/perf/lib/tests/Makefile     |  2 +-
 tools/perf/lib/tests/test-evsel.c | 82 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 83 insertions(+), 1 deletion(-)
tools/perf/lib/tests/Makefile +1 -1
index e66ed090f08e..1ee4e9ba848b 100644
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
 
-TESTS = test-cpumap test-threadmap test-evlist
+TESTS = test-cpumap test-threadmap test-evlist test-evsel
 
 TESTS_SO := $(addsuffix -so,$(TESTS))
 TESTS_A  := $(addsuffix -a,$(TESTS))
tools/perf/lib/tests/test-evsel.c new file +82 -0

82 lines not on this page · raw message

author reviewer
#177 lore raw

PATCH 77/79 libperf: Add perf_evlist__enable/disable test

In reply to Jiri Olsa

Add simple perf_evlist enable/disable test together with evlist counter reading interface.

---
 tools/perf/lib/tests/test-evlist.c | 63 ++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)
tools/perf/lib/tests/test-evlist.c +63 -0
index f24c531afcb6..4e1407f20ffd 100644
@@ -111,12 +111,75 @@ static int test_stat_thread(void)
 	return 0;
 }
 
+static int test_stat_thread_enable(void)
+{
+	struct perf_counts_values counts = { .val = 0 };
+	struct perf_thread_map *threads;
+	struct perf_evlist *evlist;
+	struct perf_evsel *evsel;
+	struct perf_event_attr attr1 = {
+		.type	  = PERF_TYPE_SOFTWARE,
+		.config	  = PERF_COUNT_SW_CPU_CLOCK,
+		.disabled = 1,
+	};
+	struct perf_event_attr attr2 = {
+		.type	  = PERF_TYPE_SOFTWARE,
+		.config	  = PERF_COUNT_SW_TASK_CLOCK,
+		.disabled = 1,
+	};
+	int err;
+
+	threads = perf_thread_map__new_dummy();
+	__T("failed to create threads", threads);
+
+	perf_thread_map__set_pid(threads, 0, 0);
+
+	evlist = perf_evlist__new();
+	__T("failed to create evlist", evlist);
+
+	evsel = perf_evsel__new(&attr1);
+	__T("failed to create evsel1", evsel);
+
+	perf_evlist__add(evlist, evsel);
+
+	evsel = perf_evsel__new(&attr2);
+	__T("failed to create evsel2", evsel);
+
+	perf_evlist__add(evlist, evsel);
+
+	perf_evlist__set_maps(evlist, NULL, threads);
+
+	err = perf_evlist__open(evlist);
+	__T("failed to open evsel", err == 0);
+
+	perf_evlist__for_each_evsel(evlist, evsel) {
+		perf_evsel__read(evsel, 0, 0, &counts);
+		__T("failed to read value for evsel", counts.val == 0);
+	}
+
+	perf_evlist__enable(evlist);
+
+	perf_evlist__for_each_evsel(evlist, evsel) {
+		perf_evsel__read(evsel, 0, 0, &counts);
+		__T("failed to read value for evsel", counts.val != 0);
+	}
+
+	perf_evlist__disable(evlist);
+
+	perf_evlist__close(evlist);
+	perf_evlist__delete(evlist);
+
+	perf_thread_map__put(threads);
+	return 0;
+}
+
 int main(int argc, char **argv)
 {
 	__T_START;
 
 	test_stat_cpu();
 	test_stat_thread();
+	test_stat_thread_enable();
 
 	__T_OK;
 	return 0;
Signature · 1 line
2.21.0
#178 lore raw

[tip:perf/core] libperf: Add perf_evlist__enable/disable test

libperf: Add perf_evlist__enable/disable test
Commit-ID:  6bda376ff416cf713773d38b743953a1a9bc0603
Gitweb:     https://git.kernel.org/tip/6bda376ff416cf713773d38b743953a1a9bc0603
Author:     Jiri Olsa <[email protected]>
AuthorDate: Sun, 21 Jul 2019 13:25:04 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 29 Jul 2019 18:34:47 -0300

libperf: Add perf_evlist__enable/disable test

Add simple perf_evlist enable/disable test together with evlist counter reading interface.

Committer testing:

  # make -C tools/perf/lib tests
  make: Entering directory '/home/acme/git/perf/tools/perf/lib'
    LINK     test-cpumap-a
    LINK     test-threadmap-a
    LINK     test-evlist-a
    LINK     test-evsel-a
    LINK     test-cpumap-so
    LINK     test-threadmap-so
    LINK     test-evlist-so
    LINK     test-evsel-so
  running static:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK
  running dynamic:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK
  make: Leaving directory '/home/acme/git/perf/tools/perf/lib'
  #
---
 tools/perf/lib/tests/test-evlist.c | 63 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)
tools/perf/lib/tests/test-evlist.c +63 -0
index f24c531afcb6..4e1407f20ffd 100644
@@ -111,12 +111,75 @@ static int test_stat_thread(void)
 	return 0;
 }
 
+static int test_stat_thread_enable(void)
+{
+	struct perf_counts_values counts = { .val = 0 };
+	struct perf_thread_map *threads;
+	struct perf_evlist *evlist;
+	struct perf_evsel *evsel;
+	struct perf_event_attr attr1 = {
+		.type	  = PERF_TYPE_SOFTWARE,
+		.config	  = PERF_COUNT_SW_CPU_CLOCK,
+		.disabled = 1,
+	};
+	struct perf_event_attr attr2 = {
+		.type	  = PERF_TYPE_SOFTWARE,
+		.config	  = PERF_COUNT_SW_TASK_CLOCK,
+		.disabled = 1,
+	};
+	int err;
+
+	threads = perf_thread_map__new_dummy();
+	__T("failed to create threads", threads);
+
+	perf_thread_map__set_pid(threads, 0, 0);
+
+	evlist = perf_evlist__new();
+	__T("failed to create evlist", evlist);
+
+	evsel = perf_evsel__new(&attr1);
+	__T("failed to create evsel1", evsel);
+
+	perf_evlist__add(evlist, evsel);
+
+	evsel = perf_evsel__new(&attr2);
+	__T("failed to create evsel2", evsel);
+
+	perf_evlist__add(evlist, evsel);
+
+	perf_evlist__set_maps(evlist, NULL, threads);
+
+	err = perf_evlist__open(evlist);
+	__T("failed to open evsel", err == 0);
+
+	perf_evlist__for_each_evsel(evlist, evsel) {
+		perf_evsel__read(evsel, 0, 0, &counts);
+		__T("failed to read value for evsel", counts.val == 0);
+	}
+
+	perf_evlist__enable(evlist);
+
+	perf_evlist__for_each_evsel(evlist, evsel) {
+		perf_evsel__read(evsel, 0, 0, &counts);
+		__T("failed to read value for evsel", counts.val != 0);
+	}
+
+	perf_evlist__disable(evlist);
+
+	perf_evlist__close(evlist);
+	perf_evlist__delete(evlist);
+
+	perf_thread_map__put(threads);
+	return 0;
+}
+
 int main(int argc, char **argv)
 {
 	__T_START;
 
 	test_stat_cpu();
 	test_stat_thread();
+	test_stat_thread_enable();
 
 	__T_OK;
 	return 0;
author reviewer
#179 lore raw

PATCH 78/79 libperf: Add perf_evsel__enable/disable test

In reply to Jiri Olsa

Add simple perf_evsel enable/disable test together with evsel counter reading interface.

---
 tools/perf/lib/tests/test-evsel.c | 43 +++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
tools/perf/lib/tests/test-evsel.c +43 -0
index 268712292f60..2c648fe5617e 100644
@@ -70,12 +70,55 @@ static int test_stat_thread(void)
 	return 0;
 }
 
+static int test_stat_thread_enable(void)
+{
+	struct perf_counts_values counts = { .val = 0 };
+	struct perf_thread_map *threads;
+	struct perf_evsel *evsel;
+	struct perf_event_attr attr = {
+		.type	  = PERF_TYPE_SOFTWARE,
+		.config	  = PERF_COUNT_SW_TASK_CLOCK,
+		.disabled = 1,
+	};
+	int err;
+
+	threads = perf_thread_map__new_dummy();
+	__T("failed to create threads", threads);
+
+	perf_thread_map__set_pid(threads, 0, 0);
+
+	evsel = perf_evsel__new(&attr);
+	__T("failed to create evsel", evsel);
+
+	err = perf_evsel__open(evsel, NULL, threads);
+	__T("failed to open evsel", err == 0);
+
+	perf_evsel__read(evsel, 0, 0, &counts);
+	__T("failed to read value for evsel", counts.val == 0);
+
+	err = perf_evsel__enable(evsel);
+	__T("failed to enable evsel", err == 0);
+
+	perf_evsel__read(evsel, 0, 0, &counts);
+	__T("failed to read value for evsel", counts.val != 0);
+
+	err = perf_evsel__disable(evsel);
+	__T("failed to enable evsel", err == 0);
+
+	perf_evsel__close(evsel);
+	perf_evsel__delete(evsel);
+
+	perf_thread_map__put(threads);
+	return 0;
+}
+
 int main(int argc, char **argv)
 {
 	__T_START;
 
 	test_stat_cpu();
 	test_stat_thread();
+	test_stat_thread_enable();
 
 	__T_OK;
 	return 0;
Signature · 1 line
2.21.0
#180 lore raw

[tip:perf/core] libperf: Add perf_evsel__enable/disable test

libperf: Add perf_evsel__enable/disable test
Commit-ID:  02266a2d9cf7e04bf3d4b4457654839dc253f605
Gitweb:     https://git.kernel.org/tip/02266a2d9cf7e04bf3d4b4457654839dc253f605
Author:     Jiri Olsa <[email protected]>
AuthorDate: Sun, 21 Jul 2019 13:25:05 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 29 Jul 2019 18:34:47 -0300

libperf: Add perf_evsel__enable/disable test

Add simple perf_evsel enable/disable test together with evsel counter reading interface.

Committer testing:

  # make -C tools/perf/lib tests
  make: Entering directory '/home/acme/git/perf/tools/perf/lib'
    LINK     test-cpumap-a
    LINK     test-threadmap-a
    LINK     test-evlist-a
    LINK     test-evsel-a
    LINK     test-cpumap-so
    LINK     test-threadmap-so
    LINK     test-evlist-so
    LINK     test-evsel-so
  running static:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK
  running dynamic:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK
  make: Leaving directory '/home/acme/git/perf/tools/perf/lib'
  #
---
 tools/perf/lib/tests/test-evsel.c | 43 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
tools/perf/lib/tests/test-evsel.c +43 -0
index 268712292f60..2c648fe5617e 100644
@@ -70,12 +70,55 @@ static int test_stat_thread(void)
 	return 0;
 }
 
+static int test_stat_thread_enable(void)
+{
+	struct perf_counts_values counts = { .val = 0 };
+	struct perf_thread_map *threads;
+	struct perf_evsel *evsel;
+	struct perf_event_attr attr = {
+		.type	  = PERF_TYPE_SOFTWARE,
+		.config	  = PERF_COUNT_SW_TASK_CLOCK,
+		.disabled = 1,
+	};
+	int err;
+
+	threads = perf_thread_map__new_dummy();
+	__T("failed to create threads", threads);
+
+	perf_thread_map__set_pid(threads, 0, 0);
+
+	evsel = perf_evsel__new(&attr);
+	__T("failed to create evsel", evsel);
+
+	err = perf_evsel__open(evsel, NULL, threads);
+	__T("failed to open evsel", err == 0);
+
+	perf_evsel__read(evsel, 0, 0, &counts);
+	__T("failed to read value for evsel", counts.val == 0);
+
+	err = perf_evsel__enable(evsel);
+	__T("failed to enable evsel", err == 0);
+
+	perf_evsel__read(evsel, 0, 0, &counts);
+	__T("failed to read value for evsel", counts.val != 0);
+
+	err = perf_evsel__disable(evsel);
+	__T("failed to enable evsel", err == 0);
+
+	perf_evsel__close(evsel);
+	perf_evsel__delete(evsel);
+
+	perf_thread_map__put(threads);
+	return 0;
+}
+
 int main(int argc, char **argv)
 {
 	__T_START;
 
 	test_stat_cpu();
 	test_stat_thread();
+	test_stat_thread_enable();
 
 	__T_OK;
 	return 0;
author reviewer
#181 lore raw

PATCH 79/79 libperf: Initial documentation

In reply to Jiri Olsa

Adding initial drafts of documentation files,
hugely unfinished.

---
 tools/perf/lib/Documentation/Makefile         |   7 +
 tools/perf/lib/Documentation/man/libperf.rst  | 102 +++++++++++++++
 .../lib/Documentation/tutorial/tutorial.rst   | 123 ++++++++++++++++++
 3 files changed, 232 insertions(+)
 create mode 100644 tools/perf/lib/Documentation/Makefile
 create mode 100644 tools/perf/lib/Documentation/man/libperf.rst
 create mode 100644 tools/perf/lib/Documentation/tutorial/tutorial.rst
tools/perf/lib/Documentation/Makefile new file +7 -0
new file mode 100644
index 000000000000..586425a88795
@@ -0,0 +1,7 @@
+all:
+	rst2man man/libperf.rst > man/libperf.7
+	rst2pdf tutorial/tutorial.rst
+
+clean:
+	rm -f man/libperf.7
+	rm -f tutorial/tutorial.pdf
tools/perf/lib/Documentation/man/libperf.rst new file +102 -0

102 lines not on this page · raw message

tools/perf/lib/Documentation/tutorial/tutorial.rst new file +123 -0

123 lines not on this page · raw message

Signature · 1 line
2.21.0
#182 lore raw

[tip:perf/core] libperf: Initial documentation

libperf: Initial documentation
Commit-ID:  f4f48e9c1adb49f732ac0abc4b2513f2b62a10cb
Gitweb:     https://git.kernel.org/tip/f4f48e9c1adb49f732ac0abc4b2513f2b62a10cb
Author:     Jiri Olsa <[email protected]>
AuthorDate: Sun, 21 Jul 2019 13:25:06 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 29 Jul 2019 18:34:47 -0300

libperf: Initial documentation

Add initial drafts of documentation files, hugely unfinished.

---
 tools/perf/lib/Documentation/Makefile              |   7 ++
 tools/perf/lib/Documentation/man/libperf.rst       | 100 +++++++++++++++++
 tools/perf/lib/Documentation/tutorial/tutorial.rst | 123 +++++++++++++++++++++
 3 files changed, 230 insertions(+)
tools/perf/lib/Documentation/Makefile new file +7 -0
new file mode 100644
index 000000000000..586425a88795
@@ -0,0 +1,7 @@
+all:
+	rst2man man/libperf.rst > man/libperf.7
+	rst2pdf tutorial/tutorial.rst
+
+clean:
+	rm -f man/libperf.7
+	rm -f tutorial/tutorial.pdf
tools/perf/lib/Documentation/man/libperf.rst new file +100 -0

100 lines not on this page · raw message

tools/perf/lib/Documentation/tutorial/tutorial.rst new file +123 -0

123 lines not on this page · raw message

reviewer
#183 lore raw
In reply to Jiri Olsa

This is really helpful and thank you for taking the initiative! I've no real feedback other than to offer support.
We've been looking in this direction to avoid memory overhead in:
https://github.com/google/perf_data_converter
Some use cases:
1) streaming protobuf rather than perf.data files,
2) using libperf inside of a runtime with JIT for a symbolization story that can reduce the storage/memory overhead of the current 'perf record' and 'perf inject -j'. Something similar is done here:
https://github.com/jvm-profiling-tools/async-profiler/blob/936a9fea8dafc5d0674860d229a1b3d86d295e2f/src/perfEvents_linux.cpp
3) self profiling with dwarf based call graphs, to avoid stack samples being visible outside of the process which could be a security concern.

Most of our tooling is C++ rather than C, and we run into issues like tools/include/linux/list.h using 'new' as a variable name. The duplication of header files in tools/, the importance of -I precedence and the use of -include have been other build system gotchas - principally because there are so many files with exactly the same name. I don't know if in the reorganization into a library this can be simplified.

Thanks again,
Ian Rogers
Google

Quoted 384 lines · Jiri Olsa

hi,
we have long term goal to separate some of the perf functionality into library. This patchset is initial effort on separating some of the interface.

Currently only the basic counting interface is exported, it allows to:
- create cpu/threads maps
- create evlist/evsel objects
- add evsel objects into evlist
- open/close evlist/evsel objects
- enable/disable events
- read evsel counts

The initial effort was to have total separation of the objects from perf code, but it showed not to be a good way. The amount of changed code was too big with high chance for regressions, mainly because of the code embedding one of the above objects statically.

We took the other approach of sharing the objects/struct details within the perf and libperf code. This way we can keep perf functionality without any major changes and the libperf users are still separated from the object/struct details. We can move to total libperf's objects separation gradually in future.

You can check current interface/functionality in examples under:
tools/perf/lib/Documentation/tutorial

or check tests in here:

  $ cd tools/perf/lib && make tests
    LINK     test-cpumap-a
    LINK     test-threadmap-a
    LINK     test-evlist-a
    LINK     test-evsel-a
    LINK     test-cpumap-so
    LINK     test-threadmap-so
    LINK     test-evlist-so
    LINK     test-evsel-so
  running static:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK
  running dynamic:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK

The upcoming changes in the near future:
- move parse_events interface in, so we have the event parsing interface in the library together with the all events from tools/perf/pmu-events/arch
- add sampling interface with event mmap support and all the sampling events objects
- add user mmap interface to read counters
- more documentation and tutorial ;-)
- move under tools/lib after the interface is more stable-ish

Big kudos to BPF guys, because most of the infrastructure is 'borrowed' from libbpf library.. ;-)

It's also available in here:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/lib

I tested so far on x86, I still need to run it through s390/ppc/arm.

throughts? thanks,
jirka

Cc Daniel Borkmann <[email protected]>
Cc Alexei Starovoitov <[email protected]>
Cc Kan Liang <[email protected]>
Cc Song Liu <[email protected]>
Cc Steven Rostedt <[email protected]>
Cc Stephane Eranian <[email protected]>

---
Jiri Olsa (79):
perf tools: Move loaded out of struct perf_counts_values perf tools: Rename struct cpu_map to struct perf_cpu_map perf tools: Rename struct thread_map to struct perf_thread_map perf tools: Rename struct perf_evsel to struct evsel perf tools: Rename struct perf_evlist to struct evlist perf tools: Rename perf_evsel__init to evsel__init perf tools: Rename perf_evlist__init to evlist__init perf tools: Rename perf_evlist__new to evlist__new perf tools: Rename perf_evlist__delete to evlist__delete perf tools: Rename perf_evsel__delete to evsel__delete perf tools: Rename perf_evsel__new to evsel__new
perf tools: Rename perf_evlist__add to evlist__add perf tools: Rename perf_evlist__remove to evlist__remove perf tools: Rename perf_evsel__open to evsel__open perf tools: Rename perf_evsel__enable to evsel__enable perf tools: Rename perf_evsel__disable to evsel__disable perf tools: Rename perf_evsel__apply_filter to evsel__apply_filter perf tools: Rename perf_evsel__cpus to evsel__cpus perf tools: Rename perf_evlist__open to evlist__open perf tools: Rename perf_evlist__close to evlist__close perf tools: Rename perf_evlist__enable to evlist__enable perf tools: Rename perf_evlist__disable to evlist__disable
libperf: Make libperf.a part of the build
libperf: Add build version support
libperf: Add libperf in python.so compilation
libperf: Add perf/core.h header
libperf: Add debug output support
libperf: Add perf_cpu_map struct
libperf: Add perf_cpu_map__dummy_new function
libperf: Add perf_cpu_map__get/perf_cpu_map__put
libperf: Add perf_thread_map struct
libperf: Add perf_thread_map__new_dummy function
libperf: Add perf_thread_map__get/perf_thread_map__put
libperf: Add perf_evlist and perf_evsel structs
libperf: Include perf_evsel in evsel object
libperf: Include perf_evlist in evlist object
libperf: Add perf_evsel__init function
libperf: Add perf_evlist__init function
libperf: Add perf_evlist__add function
libperf: Add perf_evlist__remove function
libperf: Add nr_entries to perf_evlist
libperf: Add attr to perf_evsel
libperf: Add perf_cpu_map__new/perf_cpu_map__read functions
libperf: Move zalloc.o into libperf
libperf: Add perf_evlist__new function
libperf: Add perf_evsel__new function
libperf: Add perf_evlist__for_each_evsel macro
libperf: Add perf_evlist__delete function
libperf: Add perf_evsel__delete function
libperf: Add cpus to struct perf_evsel
libperf: Add own_cpus to struct perf_evsel
libperf: Add threads to struct perf_evsel
libperf: Add has_user_cpus to struct perf_evlist
libperf: Add cpus to struct perf_evlist
libperf: Add threads to struct perf_evlist
libperf: Add perf_evlist__set_maps function
libperf: Add xyarray object
libperf: Add fd array to struct perf_evsel
libperf: Add nr_members to struct perf_evsel
libperf: Add readn/writen function
libperf: Add perf_evsel__alloc_fd function
libperf: Add perf_evsel__open function
libperf: Add perf_evsel__close function
libperf: Add perf_evsel__read function
libperf: Add perf_evsel__enable/disable/apply_filter functions
libperf: Add perf_cpu_map__for_each_cpu macro
libperf: Add perf_evsel__cpus/threads functions
libperf: Add perf_evlist__open/close functions
libperf: Add perf_evlist__enable/disable functions
libperf: Add perf_evsel__attr functions
libperf: Add install targets
libperf: Add tests support
libperf: Add perf_cpu_map test
libperf: Add perf_thread_map test
libperf: Add perf_evlist test
libperf: Add perf_evsel tests
libperf: Add perf_evlist__enable/disable test
libperf: Add perf_evsel__enable/disable test
libperf: Initial documentation

 tools/perf/Makefile.config                         |    1 +
 tools/perf/Makefile.perf                           |   31 +-
 tools/perf/arch/arm/util/auxtrace.c                |    4 +-
 tools/perf/arch/arm/util/cs-etm.c                  |   26 +-
 tools/perf/arch/arm64/util/arm-spe.c               |    6 +-
 tools/perf/arch/powerpc/util/kvm-stat.c            |   12 +-
 tools/perf/arch/s390/util/auxtrace.c               |    8 +-
 tools/perf/arch/s390/util/kvm-stat.c               |    8 +-
 tools/perf/arch/x86/tests/intel-cqm.c              |    8 +-
 tools/perf/arch/x86/tests/perf-time-to-tsc.c       |   30 +-
 tools/perf/arch/x86/util/auxtrace.c                |   10 +-
 tools/perf/arch/x86/util/intel-bts.c               |   38 +-
 tools/perf/arch/x86/util/intel-pt.c                |   82 +-
 tools/perf/arch/x86/util/kvm-stat.c                |   12 +-
 tools/perf/bench/epoll-ctl.c                       |    7 +-
 tools/perf/bench/epoll-wait.c                      |    7 +-
 tools/perf/bench/futex-hash.c                      |    5 +-
 tools/perf/bench/futex-lock-pi.c                   |    7 +-
 tools/perf/bench/futex-requeue.c                   |    7 +-
 tools/perf/bench/futex-wake-parallel.c             |    6 +-
 tools/perf/bench/futex-wake.c                      |    7 +-
 tools/perf/builtin-annotate.c                      |   16 +-
 tools/perf/builtin-c2c.c                           |   10 +-
 tools/perf/builtin-diff.c                          |   20 +-
 tools/perf/builtin-evlist.c                        |    4 +-
 tools/perf/builtin-ftrace.c                        |   18 +-
 tools/perf/builtin-inject.c                        |   60 +-
 tools/perf/builtin-kmem.c                          |   24 +-
 tools/perf/builtin-kvm.c                           |   46 +-
 tools/perf/builtin-lock.c                          |   30 +-
 tools/perf/builtin-mem.c                           |    2 +-
 tools/perf/builtin-record.c                        |   50 +-
 tools/perf/builtin-report.c                        |   32 +-
 tools/perf/builtin-sched.c                         |   96 +-
 tools/perf/builtin-script.c                        |  167 +--
 tools/perf/builtin-stat.c                          |  135 +--
 tools/perf/builtin-timechart.c                     |   46 +-
 tools/perf/builtin-top.c                           |   71 +-
 tools/perf/builtin-trace.c                         |  180 +--
 tools/perf/lib/Build                               |   12 +
 tools/perf/lib/Documentation/Makefile              |    7 +
 tools/perf/lib/Documentation/man/libperf.rst       |  102 ++
 tools/perf/lib/Documentation/tutorial/tutorial.rst |  123 ++
 tools/perf/lib/Makefile                            |  158 +++
 tools/perf/lib/core.c                              |   34 +
 tools/perf/lib/cpumap.c                            |  239 ++++
 tools/perf/lib/evlist.c                            |  159 +++
 tools/perf/lib/evsel.c                             |  232 ++++
 tools/perf/lib/include/internal/cpumap.h           |   17 +
 tools/perf/lib/include/internal/evlist.h           |   50 +
 tools/perf/lib/include/internal/evsel.h            |   29 +
 tools/perf/lib/include/internal/lib.h              |   10 +
 tools/perf/lib/include/internal/tests.h            |   19 +
 tools/perf/lib/include/internal/threadmap.h        |   23 +
 .../perf/{util => lib/include/internal}/xyarray.h  |    6 +-
 tools/perf/lib/include/perf/core.h                 |   22 +
 tools/perf/lib/include/perf/cpumap.h               |   23 +
 tools/perf/lib/include/perf/evlist.h               |   35 +
 tools/perf/lib/include/perf/evsel.h                |   39 +
 tools/perf/lib/include/perf/threadmap.h            |   18 +
 tools/perf/lib/internal.h                          |   18 +
 tools/perf/lib/lib.c                               |   46 +
 tools/perf/lib/libperf.map                         |   40 +
 tools/perf/lib/libperf.pc.template                 |   11 +
 tools/perf/lib/tests/Makefile                      |   38 +
 tools/perf/lib/tests/test-cpumap.c                 |   21 +
 tools/perf/lib/tests/test-evlist.c                 |  186 +++
 tools/perf/lib/tests/test-evsel.c                  |  125 ++
 tools/perf/lib/tests/test-threadmap.c              |   21 +
 tools/perf/lib/threadmap.c                         |   81 ++
 tools/perf/lib/xyarray.c                           |   33 +
 tools/perf/tests/backward-ring-buffer.c            |   18 +-
 tools/perf/tests/bitmap.c                          |    5 +-
 tools/perf/tests/bpf.c                             |   12 +-
 tools/perf/tests/code-reading.c                    |   50 +-
 tools/perf/tests/cpumap.c                          |   21 +-
 tools/perf/tests/event-times.c                     |   81 +-
 tools/perf/tests/event_update.c                    |   13 +-
 tools/perf/tests/evsel-roundtrip-name.c            |   12 +-
 tools/perf/tests/evsel-tp-sched.c                  |    8 +-
 tools/perf/tests/hists_cumulate.c                  |   18 +-
 tools/perf/tests/hists_filter.c                    |   10 +-
 tools/perf/tests/hists_link.c                      |   10 +-
 tools/perf/tests/hists_output.c                    |   20 +-
 tools/perf/tests/keep-tracking.c                   |   44 +-
 tools/perf/tests/mem2node.c                        |    5 +-
 tools/perf/tests/mmap-basic.c                      |   28 +-
 tools/perf/tests/mmap-thread-lookup.c              |    4 +-
 tools/perf/tests/openat-syscall-all-cpus.c         |   18 +-
 tools/perf/tests/openat-syscall-tp-fields.c        |   14 +-
 tools/perf/tests/openat-syscall.c                  |   10 +-
 tools/perf/tests/parse-events.c                    | 1220 ++++++++++----------
 tools/perf/tests/parse-no-sample-id-all.c          |    6 +-
 tools/perf/tests/perf-record.c                     |   10 +-
 tools/perf/tests/sample-parsing.c                  |    8 +-
 tools/perf/tests/sw-clock.c                        |   33 +-
 tools/perf/tests/switch-tracking.c                 |   64 +-
 tools/perf/tests/task-exit.c                       |   35 +-
 tools/perf/tests/thread-map.c                      |   28 +-
 tools/perf/tests/time-utils-test.c                 |    2 +-
 tools/perf/tests/topology.c                        |    9 +-
 tools/perf/ui/browsers/annotate.c                  |   16 +-
 tools/perf/ui/browsers/hists.c                     |   54 +-
 tools/perf/ui/browsers/res_sample.c                |    4 +-
 tools/perf/ui/browsers/scripts.c                   |    6 +-
 tools/perf/ui/gtk/annotate.c                       |    8 +-
 tools/perf/ui/gtk/gtk.h                            |    8 +-
 tools/perf/ui/gtk/hists.c                          |    6 +-
 tools/perf/ui/hist.c                               |   16 +-
 tools/perf/util/Build                              |    6 -
 tools/perf/util/annotate.c                         |   42 +-
 tools/perf/util/annotate.h                         |   26 +-
 tools/perf/util/auxtrace.c                         |   28 +-
 tools/perf/util/auxtrace.h                         |   24 +-
 tools/perf/util/bpf-event.c                        |    2 +-
 tools/perf/util/bpf-event.h                        |    4 +-
 tools/perf/util/bpf-loader.c                       |   34 +-
 tools/perf/util/bpf-loader.h                       |   28 +-
 tools/perf/util/build-id.c                         |    2 +-
 tools/perf/util/build-id.h                         |    2 +-
 tools/perf/util/callchain.c                        |    2 +-
 tools/perf/util/callchain.h                        |    2 +-
 tools/perf/util/cgroup.c                           |   22 +-
 tools/perf/util/cgroup.h                           |    6 +-
 tools/perf/util/counts.c                           |   17 +-
 tools/perf/util/counts.h                           |   34 +-
 tools/perf/util/cpumap.c                           |  264 +----
 tools/perf/util/cpumap.h                           |   54 +-
 tools/perf/util/cputopo.c                          |   13 +-
 tools/perf/util/cs-etm.c                           |    4 +-
 tools/perf/util/data-convert-bt.c                  |   38 +-
 tools/perf/util/db-export.c                        |   10 +-
 tools/perf/util/db-export.h                        |   10 +-
 tools/perf/util/env.c                              |    2 +-
 tools/perf/util/env.h                              |    2 +-
 tools/perf/util/event.c                            |   30 +-
 tools/perf/util/event.h                            |   14 +-
 tools/perf/util/evlist.c                           |  607 +++++-----
 tools/perf/util/evlist.h                           |  215 ++--
 tools/perf/util/evsel.c                            |  496 ++++----
 tools/perf/util/evsel.h                            |  194 ++--
 tools/perf/util/evsel_fprintf.c                    |   16 +-
 tools/perf/util/header.c                           |  225 ++--
 tools/perf/util/header.h                           |   24 +-
 tools/perf/util/hist.c                             |   32 +-
 tools/perf/util/hist.h                             |   38 +-
 tools/perf/util/intel-bts.c                        |   22 +-
 tools/perf/util/intel-pt.c                         |   94 +-
 tools/perf/util/jitdump.c                          |    8 +-
 tools/perf/util/kvm-stat.h                         |   22 +-
 tools/perf/util/machine.c                          |   12 +-
 tools/perf/util/machine.h                          |    8 +-
 tools/perf/util/map.h                              |    2 +-
 tools/perf/util/metricgroup.c                      |   26 +-
 tools/perf/util/metricgroup.h                      |    6 +-
 tools/perf/util/mmap.c                             |    4 +-
 tools/perf/util/parse-events.c                     |  143 +--
 tools/perf/util/parse-events.h                     |    8 +-
 tools/perf/util/pmu.c                              |   15 +-
 tools/perf/util/pmu.h                              |    2 +-
 tools/perf/util/python-ext-sources                 |    2 -
 tools/perf/util/python.c                           |   73 +-
 tools/perf/util/record.c                           |   73 +-
 tools/perf/util/s390-cpumsf.c                      |    4 +-
 tools/perf/util/s390-sample-raw.c                  |    6 +-
 tools/perf/util/sample-raw.c                       |    2 +-
 tools/perf/util/sample-raw.h                       |    6 +-
 .../perf/util/scripting-engines/trace-event-perl.c |   14 +-
 .../util/scripting-engines/trace-event-python.c    |   40 +-
 tools/perf/util/session.c                          |   81 +-
 tools/perf/util/session.h                          |   12 +-
 tools/perf/util/setup.py                           |    3 +-
 tools/perf/util/sort.c                             |   60 +-
 tools/perf/util/sort.h                             |    6 +-
 tools/perf/util/stat-display.c                     |  112 +-
 tools/perf/util/stat-shadow.c                      |   70 +-
 tools/perf/util/stat.c                             |   64 +-
 tools/perf/util/stat.h                             |   35 +-
 tools/perf/util/svghelper.c                        |    7 +-
 tools/perf/util/thread_map.c                       |  131 +--
 tools/perf/util/thread_map.h                       |   58 +-
 tools/perf/util/tool.h                             |    8 +-
 tools/perf/util/top.c                              |   12 +-
 tools/perf/util/top.h                              |    8 +-
 tools/perf/util/trace-event-info.c                 |   14 +-
 tools/perf/util/trace-event-scripting.c            |    2 +-
 tools/perf/util/trace-event.h                      |    4 +-
 tools/perf/util/util.c                             |   40 -
 tools/perf/util/util.h                             |    4 +-
 189 files changed, 5313 insertions(+), 3819 deletions(-)
 create mode 100644 tools/perf/lib/Build
 create mode 100644 tools/perf/lib/Documentation/Makefile
 create mode 100644 tools/perf/lib/Documentation/man/libperf.rst
 create mode 100644 tools/perf/lib/Documentation/tutorial/tutorial.rst
 create mode 100644 tools/perf/lib/Makefile
 create mode 100644 tools/perf/lib/core.c
 create mode 100644 tools/perf/lib/cpumap.c
 create mode 100644 tools/perf/lib/evlist.c
 create mode 100644 tools/perf/lib/evsel.c
 create mode 100644 tools/perf/lib/include/internal/cpumap.h
 create mode 100644 tools/perf/lib/include/internal/evlist.h
 create mode 100644 tools/perf/lib/include/internal/evsel.h
 create mode 100644 tools/perf/lib/include/internal/lib.h
 create mode 100644 tools/perf/lib/include/internal/tests.h
 create mode 100644 tools/perf/lib/include/internal/threadmap.h
 rename tools/perf/{util => lib/include/internal}/xyarray.h (84%)
 create mode 100644 tools/perf/lib/include/perf/core.h
 create mode 100644 tools/perf/lib/include/perf/cpumap.h
 create mode 100644 tools/perf/lib/include/perf/evlist.h
 create mode 100644 tools/perf/lib/include/perf/evsel.h
 create mode 100644 tools/perf/lib/include/perf/threadmap.h
 create mode 100644 tools/perf/lib/internal.h
 create mode 100644 tools/perf/lib/lib.c
 create mode 100644 tools/perf/lib/libperf.map
 create mode 100644 tools/perf/lib/libperf.pc.template
 create mode 100644 tools/perf/lib/tests/Makefile
 create mode 100644 tools/perf/lib/tests/test-cpumap.c
 create mode 100644 tools/perf/lib/tests/test-evlist.c
 create mode 100644 tools/perf/lib/tests/test-evsel.c
 create mode 100644 tools/perf/lib/tests/test-threadmap.c
 create mode 100644 tools/perf/lib/threadmap.c
 create mode 100644 tools/perf/lib/xyarray.c
#184 lore raw
Quoted 6 lines · Ian Rogers

This is really helpful and thank you for taking the initiative! I've no real feedback other than to offer support.
We've been looking in this direction to avoid memory overhead in:
https://github.com/google/perf_data_converter
Some use cases:
1) streaming protobuf rather than perf.data files,

hum, we already have the CTF conversion support (perf data convert --to-ctf), perhaps we could add support for profile.proto, so you dont need special app

Quoted 4 lines

2) using libperf inside of a runtime with JIT for a symbolization story that can reduce the storage/memory overhead of the current 'perf record' and 'perf inject -j'. Something similar is done here:
https://github.com/jvm-profiling-tools/async-profiler/blob/936a9fea8dafc5d0674860d229a1b3d86d295e2f/src/perfEvents_linux.cpp

I think that once we have the mmap interface in place we can discuss some higher level interface that would help you

Quoted 3 lines

3) self profiling with dwarf based call graphs, to avoid stack samples being visible outside of the process which could be a security concern.

same as above, once we have mmap support I think this is one of the things we definitely want to add to libperf

Quoted 3 lines

Most of our tooling is C++ rather than C, and we run into issues like tools/include/linux/list.h using 'new' as a variable name. The

libperf has currently the full object separation, so outside users dont see its object struct's inners.. that should solve the 'new' issue

Quoted 5 lines

duplication of header files in tools/, the importance of -I precedence and the use of -include have been other build system gotchas - principally because there are so many files with exactly the same name. I don't know if in the reorganization into a library this can be simplified.

libperf will be public so the building should be hopefuly simpler and straightforward

thanks a lot for the feedback,
jirka

#185 lore raw
In reply to Jiri Olsa

Hi Jiri,

Quoted 7 lines · Jiri Olsa

hi,
we have long term goal to separate some of the perf functionality into library. This patchset is initial effort on separating some of the interface.

Quoted 8 lines

Currently only the basic counting interface is exported, it allows to:
- create cpu/threads maps
- create evlist/evsel objects
- add evsel objects into evlist
- open/close evlist/evsel objects
- enable/disable events
- read evsel counts

Based on my understanding, evsel and evlist are abstractions in perf utilities. I think most other tools that use perf UAPIs are not built based on these abstractions. I looked at a few internal tools. Most of them just uses sys_perf_event_open() and struct perf_event_attr. I am not sure whether these tools would adopt libperf, as libperf changes their existing concepts/abstractions.

Quoted 7 lines

The initial effort was to have total separation of the objects from perf code, but it showed not to be a good way. The amount of changed code was too big with high chance for regressions, mainly because of the code embedding one of the above objects statically.

Quoted 5 lines

We took the other approach of sharing the objects/struct details within the perf and libperf code. This way we can keep perf functionality without any major changes and the libperf users are still separated from the object/struct details. We can move to total libperf's objects separation gradually in future.

I found some duplicated logic between libperf and perf, for example, perf_evlist__open() and evlist__open(). Do we plan to merge them in the future?

Thanks,
Song

#186 lore raw
Quoted 18 lines · Song Liu

Hi Jiri,

Quoted 7 lines · Jiri Olsa

hi,
we have long term goal to separate some of the perf functionality into library. This patchset is initial effort on separating some of the interface.

Quoted 8 lines

Currently only the basic counting interface is exported, it allows to:
- create cpu/threads maps
- create evlist/evsel objects
- add evsel objects into evlist
- open/close evlist/evsel objects
- enable/disable events
- read evsel counts

Quoted 3 lines

Based on my understanding, evsel and evlist are abstractions in perf utilities. I think most other tools that use perf UAPIs are not built based on these abstractions. I looked at a few internal

AFAICS some abstraction is needed to carry on the needed stuff like mmaps, counts, group links, PMU details (type, cpus..)

Quoted 3 lines

tools. Most of them just uses sys_perf_event_open() and struct perf_event_attr. I am not sure whether these tools would adopt libperf, as libperf changes their existing concepts/abstractions.

well, besides that we wanted to do this separation for tools/* sake, I think that once libperf shares more interface on sampling and pmu events parsing, it will be considerable choice also for out of the tree tools

Quoted 13 lines
Quoted 7 lines

The initial effort was to have total separation of the objects from perf code, but it showed not to be a good way. The amount of changed code was too big with high chance for regressions, mainly because of the code embedding one of the above objects statically.

Quoted 5 lines

We took the other approach of sharing the objects/struct details within the perf and libperf code. This way we can keep perf functionality without any major changes and the libperf users are still separated from the object/struct details. We can move to total libperf's objects separation gradually in future.

Quoted 3 lines

I found some duplicated logic between libperf and perf, for example, perf_evlist__open() and evlist__open(). Do we plan to merge them in the future?

yea, as I wrote in the perf_evsel__open patch changelog:

It's a simplified version of evsel__open without fallback stuff. We can try to merge it in the future to libperf, but it has many glitches.

some of the API can be shared right away, some needs more changes and consideration

thanks,
jirka

#187 lore raw
Quoted 30 lines · Jiri Olsa
Quoted 18 lines · Song Liu

Hi Jiri,

Quoted 7 lines · Jiri Olsa

hi,
we have long term goal to separate some of the perf functionality into library. This patchset is initial effort on separating some of the interface.

Quoted 8 lines

Currently only the basic counting interface is exported, it allows to:
- create cpu/threads maps
- create evlist/evsel objects
- add evsel objects into evlist
- open/close evlist/evsel objects
- enable/disable events
- read evsel counts

Quoted 3 lines

Based on my understanding, evsel and evlist are abstractions in perf utilities. I think most other tools that use perf UAPIs are not built based on these abstractions. I looked at a few internal

AFAICS some abstraction is needed to carry on the needed stuff like mmaps, counts, group links, PMU details (type, cpus..)

Quoted 8 lines
Quoted 3 lines

tools. Most of them just uses sys_perf_event_open() and struct perf_event_attr. I am not sure whether these tools would adopt libperf, as libperf changes their existing concepts/abstractions.

well, besides that we wanted to do this separation for tools/* sake, I think that once libperf shares more interface on sampling and pmu events parsing, it will be considerable choice also for out of the tree tools

Yeah, in tree tools would benefit from it for sure. And they should also motivate out of the tree tools to use libperf.

Quoted 18 lines
Quoted 14 lines
Quoted 8 lines

The initial effort was to have total separation of the objects from perf code, but it showed not to be a good way. The amount of changed code was too big with high chance for regressions, mainly because of the code embedding one of the above objects statically.

Quoted 5 lines

We took the other approach of sharing the objects/struct details within the perf and libperf code. This way we can keep perf functionality without any major changes and the libperf users are still separated from the object/struct details. We can move to total libperf's objects separation gradually in future.

Quoted 3 lines

I found some duplicated logic between libperf and perf, for example, perf_evlist__open() and evlist__open(). Do we plan to merge them in the future?

Quoted 5 lines

yea, as I wrote in the perf_evsel__open patch changelog:

It's a simplified version of evsel__open without fallback stuff. We can try to merge it in the future to libperf, but it has many glitches.

I was reading the code in your git tree and missed the change log.

Thanks for the explanations.

Song

#188 lore raw
In reply to Song Liu

Em Wed, Jul 24, 2019 at 07:42:50AM +0000, Song Liu escreveu:

Quoted 15 lines
Quoted 6 lines · Jiri Olsa

we have long term goal to separate some of the perf functionality into library. This patchset is initial effort on separating some of the interface.

Quoted 8 lines

Currently only the basic counting interface is exported, it allows to:
- create cpu/threads maps
- create evlist/evsel objects
- add evsel objects into evlist
- open/close evlist/evsel objects
- enable/disable events
- read evsel counts

Quoted 6 lines

Based on my understanding, evsel and evlist are abstractions in perf utilities. I think most other tools that use perf UAPIs are not built based on these abstractions. I looked at a few internal tools. Most of them just uses sys_perf_event_open() and struct perf_event_attr. I am not sure whether these tools would adopt libperf, as libperf changes their existing concepts/abstractions.

Right, and for now we're just trying to have something that is not so tied to perf and could possibly be useful outside tools/perf/ when the need arises for whatever new tool or pre-existing one.

There are features there that may be interesting to use outside perf, time will tell.

Quoted 12 lines
Quoted 11 lines

The initial effort was to have total separation of the objects from perf code, but it showed not to be a good way. The amount of changed code was too big with high chance for regressions, mainly because of the code embedding one of the above objects statically.

We took the other approach of sharing the objects/struct details within the perf and libperf code. This way we can keep perf functionality without any major changes and the libperf users are still separated from the object/struct details. We can move to total libperf's objects separation gradually in future.

Quoted 3 lines

I found some duplicated logic between libperf and perf, for example, perf_evlist__open() and evlist__open(). Do we plan to merge them in the future?

He is just slowly moving things to a public libperf while keeping perf working, in the end the goal is to have as much stuff that is not super specific to some of the existing perf tools (tools/perf/builtin-*.c) in libperf as possible.

It is still early in this effort, that is why he is still leaving it in tools/perf/lib/ and not in tools/lib/perf/ :-)

- Arnaldo

#189 lore raw
Quoted 27 lines · Arnaldo Carvalho de Melo

Em Wed, Jul 24, 2019 at 07:42:50AM +0000, Song Liu escreveu:

Quoted 15 lines
Quoted 6 lines · Jiri Olsa

we have long term goal to separate some of the perf functionality into library. This patchset is initial effort on separating some of the interface.

Quoted 8 lines

Currently only the basic counting interface is exported, it allows to:
- create cpu/threads maps
- create evlist/evsel objects
- add evsel objects into evlist
- open/close evlist/evsel objects
- enable/disable events
- read evsel counts

Quoted 6 lines

Based on my understanding, evsel and evlist are abstractions in perf utilities. I think most other tools that use perf UAPIs are not built based on these abstractions. I looked at a few internal tools. Most of them just uses sys_perf_event_open() and struct perf_event_attr. I am not sure whether these tools would adopt libperf, as libperf changes their existing concepts/abstractions.

Quoted 6 lines

Right, and for now we're just trying to have something that is not so tied to perf and could possibly be useful outside tools/perf/ when the need arises for whatever new tool or pre-existing one.

There are features there that may be interesting to use outside perf, time will tell.

Thanks for the explanation. This is not an easy task. :)

Quoted 17 lines
Quoted 13 lines
Quoted 7 lines

The initial effort was to have total separation of the objects from perf code, but it showed not to be a good way. The amount of changed code was too big with high chance for regressions, mainly because of the code embedding one of the above objects statically.

Quoted 5 lines

We took the other approach of sharing the objects/struct details within the perf and libperf code. This way we can keep perf functionality without any major changes and the libperf users are still separated from the object/struct details. We can move to total libperf's objects separation gradually in future.

Quoted 3 lines

I found some duplicated logic between libperf and perf, for example, perf_evlist__open() and evlist__open(). Do we plan to merge them in the future?

Quoted 7 lines

He is just slowly moving things to a public libperf while keeping perf working, in the end the goal is to have as much stuff that is not super specific to some of the existing perf tools (tools/perf/builtin-*.c) in libperf as possible.

It is still early in this effort, that is why he is still leaving it in tools/perf/lib/ and not in tools/lib/perf/ :-)

I saw that discussion. It is a good strategy.

Thanks,
Song

#190 lore raw
In reply to Jiri Olsa

Em Sun, Jul 21, 2019 at 01:23:47PM +0200, Jiri Olsa escreveu:

Quoted 20 lines

hi,
we have long term goal to separate some of the perf functionality into library. This patchset is initial effort on separating some of the interface.

Currently only the basic counting interface is exported, it allows to:
- create cpu/threads maps
- create evlist/evsel objects
- add evsel objects into evlist
- open/close evlist/evsel objects
- enable/disable events
- read evsel counts

The initial effort was to have total separation of the objects from perf code, but it showed not to be a good way. The amount of changed code was too big with high chance for regressions, mainly because of the code embedding one of the above objects statically.

Quoted 8 lines

We took the other approach of sharing the objects/struct details within the perf and libperf code. This way we can keep perf functionality without any major changes and the libperf users are still separated from the object/struct details. We can move to total libperf's objects separation gradually in future.

You can check current interface/functionality in examples under:
tools/perf/lib/Documentation/tutorial

I've tested it in various distros and made fixes in the relevant csets to avoid breaking bisection, it builds everywhere I tested so far, except on fedora:rawhide, but that is something unrelated, a coincidence since I refreshed that container yesterday (one python hiccup and something else), I've made some changes to the docs adding some articles and adding some clarification about refcounts not necessarily destroying the object, just dropping a reference, pushed everything to tmp.perf/core and will do the whole container testing soon.

- Arnaldo

Quoted 354 lines

or check tests in here:

  $ cd tools/perf/lib && make tests
    LINK     test-cpumap-a
    LINK     test-threadmap-a
    LINK     test-evlist-a
    LINK     test-evsel-a
    LINK     test-cpumap-so
    LINK     test-threadmap-so
    LINK     test-evlist-so
    LINK     test-evsel-so
  running static:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK
  running dynamic:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK

The upcoming changes in the near future:
- move parse_events interface in, so we have the event parsing interface in the library together with the all events from tools/perf/pmu-events/arch
- add sampling interface with event mmap support and all the sampling events objects
- add user mmap interface to read counters
- more documentation and tutorial ;-)
- move under tools/lib after the interface is more stable-ish

Big kudos to BPF guys, because most of the infrastructure is 'borrowed' from libbpf library.. ;-)

It's also available in here:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/lib

I tested so far on x86, I still need to run it through s390/ppc/arm.

throughts? thanks,
jirka

Cc Daniel Borkmann <[email protected]>
Cc Alexei Starovoitov <[email protected]>
Cc Kan Liang <[email protected]>
Cc Song Liu <[email protected]>
Cc Steven Rostedt <[email protected]>
Cc Stephane Eranian <[email protected]>

---
Jiri Olsa (79):
perf tools: Move loaded out of struct perf_counts_values perf tools: Rename struct cpu_map to struct perf_cpu_map perf tools: Rename struct thread_map to struct perf_thread_map perf tools: Rename struct perf_evsel to struct evsel perf tools: Rename struct perf_evlist to struct evlist perf tools: Rename perf_evsel__init to evsel__init perf tools: Rename perf_evlist__init to evlist__init perf tools: Rename perf_evlist__new to evlist__new perf tools: Rename perf_evlist__delete to evlist__delete perf tools: Rename perf_evsel__delete to evsel__delete perf tools: Rename perf_evsel__new to evsel__new
perf tools: Rename perf_evlist__add to evlist__add perf tools: Rename perf_evlist__remove to evlist__remove perf tools: Rename perf_evsel__open to evsel__open perf tools: Rename perf_evsel__enable to evsel__enable perf tools: Rename perf_evsel__disable to evsel__disable perf tools: Rename perf_evsel__apply_filter to evsel__apply_filter perf tools: Rename perf_evsel__cpus to evsel__cpus perf tools: Rename perf_evlist__open to evlist__open perf tools: Rename perf_evlist__close to evlist__close perf tools: Rename perf_evlist__enable to evlist__enable perf tools: Rename perf_evlist__disable to evlist__disable
libperf: Make libperf.a part of the build
libperf: Add build version support
libperf: Add libperf in python.so compilation
libperf: Add perf/core.h header
libperf: Add debug output support
libperf: Add perf_cpu_map struct
libperf: Add perf_cpu_map__dummy_new function
libperf: Add perf_cpu_map__get/perf_cpu_map__put
libperf: Add perf_thread_map struct
libperf: Add perf_thread_map__new_dummy function
libperf: Add perf_thread_map__get/perf_thread_map__put
libperf: Add perf_evlist and perf_evsel structs
libperf: Include perf_evsel in evsel object
libperf: Include perf_evlist in evlist object
libperf: Add perf_evsel__init function
libperf: Add perf_evlist__init function
libperf: Add perf_evlist__add function
libperf: Add perf_evlist__remove function
libperf: Add nr_entries to perf_evlist
libperf: Add attr to perf_evsel
libperf: Add perf_cpu_map__new/perf_cpu_map__read functions
libperf: Move zalloc.o into libperf
libperf: Add perf_evlist__new function
libperf: Add perf_evsel__new function
libperf: Add perf_evlist__for_each_evsel macro
libperf: Add perf_evlist__delete function
libperf: Add perf_evsel__delete function
libperf: Add cpus to struct perf_evsel
libperf: Add own_cpus to struct perf_evsel
libperf: Add threads to struct perf_evsel
libperf: Add has_user_cpus to struct perf_evlist
libperf: Add cpus to struct perf_evlist
libperf: Add threads to struct perf_evlist
libperf: Add perf_evlist__set_maps function
libperf: Add xyarray object
libperf: Add fd array to struct perf_evsel
libperf: Add nr_members to struct perf_evsel
libperf: Add readn/writen function
libperf: Add perf_evsel__alloc_fd function
libperf: Add perf_evsel__open function
libperf: Add perf_evsel__close function
libperf: Add perf_evsel__read function
libperf: Add perf_evsel__enable/disable/apply_filter functions
libperf: Add perf_cpu_map__for_each_cpu macro
libperf: Add perf_evsel__cpus/threads functions
libperf: Add perf_evlist__open/close functions
libperf: Add perf_evlist__enable/disable functions
libperf: Add perf_evsel__attr functions
libperf: Add install targets
libperf: Add tests support
libperf: Add perf_cpu_map test
libperf: Add perf_thread_map test
libperf: Add perf_evlist test
libperf: Add perf_evsel tests
libperf: Add perf_evlist__enable/disable test
libperf: Add perf_evsel__enable/disable test
libperf: Initial documentation

 tools/perf/Makefile.config                         |    1 +
 tools/perf/Makefile.perf                           |   31 +-
 tools/perf/arch/arm/util/auxtrace.c                |    4 +-
 tools/perf/arch/arm/util/cs-etm.c                  |   26 +-
 tools/perf/arch/arm64/util/arm-spe.c               |    6 +-
 tools/perf/arch/powerpc/util/kvm-stat.c            |   12 +-
 tools/perf/arch/s390/util/auxtrace.c               |    8 +-
 tools/perf/arch/s390/util/kvm-stat.c               |    8 +-
 tools/perf/arch/x86/tests/intel-cqm.c              |    8 +-
 tools/perf/arch/x86/tests/perf-time-to-tsc.c       |   30 +-
 tools/perf/arch/x86/util/auxtrace.c                |   10 +-
 tools/perf/arch/x86/util/intel-bts.c               |   38 +-
 tools/perf/arch/x86/util/intel-pt.c                |   82 +-
 tools/perf/arch/x86/util/kvm-stat.c                |   12 +-
 tools/perf/bench/epoll-ctl.c                       |    7 +-
 tools/perf/bench/epoll-wait.c                      |    7 +-
 tools/perf/bench/futex-hash.c                      |    5 +-
 tools/perf/bench/futex-lock-pi.c                   |    7 +-
 tools/perf/bench/futex-requeue.c                   |    7 +-
 tools/perf/bench/futex-wake-parallel.c             |    6 +-
 tools/perf/bench/futex-wake.c                      |    7 +-
 tools/perf/builtin-annotate.c                      |   16 +-
 tools/perf/builtin-c2c.c                           |   10 +-
 tools/perf/builtin-diff.c                          |   20 +-
 tools/perf/builtin-evlist.c                        |    4 +-
 tools/perf/builtin-ftrace.c                        |   18 +-
 tools/perf/builtin-inject.c                        |   60 +-
 tools/perf/builtin-kmem.c                          |   24 +-
 tools/perf/builtin-kvm.c                           |   46 +-
 tools/perf/builtin-lock.c                          |   30 +-
 tools/perf/builtin-mem.c                           |    2 +-
 tools/perf/builtin-record.c                        |   50 +-
 tools/perf/builtin-report.c                        |   32 +-
 tools/perf/builtin-sched.c                         |   96 +-
 tools/perf/builtin-script.c                        |  167 +--
 tools/perf/builtin-stat.c                          |  135 +--
 tools/perf/builtin-timechart.c                     |   46 +-
 tools/perf/builtin-top.c                           |   71 +-
 tools/perf/builtin-trace.c                         |  180 +--
 tools/perf/lib/Build                               |   12 +
 tools/perf/lib/Documentation/Makefile              |    7 +
 tools/perf/lib/Documentation/man/libperf.rst       |  102 ++
 tools/perf/lib/Documentation/tutorial/tutorial.rst |  123 ++
 tools/perf/lib/Makefile                            |  158 +++
 tools/perf/lib/core.c                              |   34 +
 tools/perf/lib/cpumap.c                            |  239 ++++
 tools/perf/lib/evlist.c                            |  159 +++
 tools/perf/lib/evsel.c                             |  232 ++++
 tools/perf/lib/include/internal/cpumap.h           |   17 +
 tools/perf/lib/include/internal/evlist.h           |   50 +
 tools/perf/lib/include/internal/evsel.h            |   29 +
 tools/perf/lib/include/internal/lib.h              |   10 +
 tools/perf/lib/include/internal/tests.h            |   19 +
 tools/perf/lib/include/internal/threadmap.h        |   23 +
 .../perf/{util => lib/include/internal}/xyarray.h  |    6 +-
 tools/perf/lib/include/perf/core.h                 |   22 +
 tools/perf/lib/include/perf/cpumap.h               |   23 +
 tools/perf/lib/include/perf/evlist.h               |   35 +
 tools/perf/lib/include/perf/evsel.h                |   39 +
 tools/perf/lib/include/perf/threadmap.h            |   18 +
 tools/perf/lib/internal.h                          |   18 +
 tools/perf/lib/lib.c                               |   46 +
 tools/perf/lib/libperf.map                         |   40 +
 tools/perf/lib/libperf.pc.template                 |   11 +
 tools/perf/lib/tests/Makefile                      |   38 +
 tools/perf/lib/tests/test-cpumap.c                 |   21 +
 tools/perf/lib/tests/test-evlist.c                 |  186 +++
 tools/perf/lib/tests/test-evsel.c                  |  125 ++
 tools/perf/lib/tests/test-threadmap.c              |   21 +
 tools/perf/lib/threadmap.c                         |   81 ++
 tools/perf/lib/xyarray.c                           |   33 +
 tools/perf/tests/backward-ring-buffer.c            |   18 +-
 tools/perf/tests/bitmap.c                          |    5 +-
 tools/perf/tests/bpf.c                             |   12 +-
 tools/perf/tests/code-reading.c                    |   50 +-
 tools/perf/tests/cpumap.c                          |   21 +-
 tools/perf/tests/event-times.c                     |   81 +-
 tools/perf/tests/event_update.c                    |   13 +-
 tools/perf/tests/evsel-roundtrip-name.c            |   12 +-
 tools/perf/tests/evsel-tp-sched.c                  |    8 +-
 tools/perf/tests/hists_cumulate.c                  |   18 +-
 tools/perf/tests/hists_filter.c                    |   10 +-
 tools/perf/tests/hists_link.c                      |   10 +-
 tools/perf/tests/hists_output.c                    |   20 +-
 tools/perf/tests/keep-tracking.c                   |   44 +-
 tools/perf/tests/mem2node.c                        |    5 +-
 tools/perf/tests/mmap-basic.c                      |   28 +-
 tools/perf/tests/mmap-thread-lookup.c              |    4 +-
 tools/perf/tests/openat-syscall-all-cpus.c         |   18 +-
 tools/perf/tests/openat-syscall-tp-fields.c        |   14 +-
 tools/perf/tests/openat-syscall.c                  |   10 +-
 tools/perf/tests/parse-events.c                    | 1220 ++++++++++----------
 tools/perf/tests/parse-no-sample-id-all.c          |    6 +-
 tools/perf/tests/perf-record.c                     |   10 +-
 tools/perf/tests/sample-parsing.c                  |    8 +-
 tools/perf/tests/sw-clock.c                        |   33 +-
 tools/perf/tests/switch-tracking.c                 |   64 +-
 tools/perf/tests/task-exit.c                       |   35 +-
 tools/perf/tests/thread-map.c                      |   28 +-
 tools/perf/tests/time-utils-test.c                 |    2 +-
 tools/perf/tests/topology.c                        |    9 +-
 tools/perf/ui/browsers/annotate.c                  |   16 +-
 tools/perf/ui/browsers/hists.c                     |   54 +-
 tools/perf/ui/browsers/res_sample.c                |    4 +-
 tools/perf/ui/browsers/scripts.c                   |    6 +-
 tools/perf/ui/gtk/annotate.c                       |    8 +-
 tools/perf/ui/gtk/gtk.h                            |    8 +-
 tools/perf/ui/gtk/hists.c                          |    6 +-
 tools/perf/ui/hist.c                               |   16 +-
 tools/perf/util/Build                              |    6 -
 tools/perf/util/annotate.c                         |   42 +-
 tools/perf/util/annotate.h                         |   26 +-
 tools/perf/util/auxtrace.c                         |   28 +-
 tools/perf/util/auxtrace.h                         |   24 +-
 tools/perf/util/bpf-event.c                        |    2 +-
 tools/perf/util/bpf-event.h                        |    4 +-
 tools/perf/util/bpf-loader.c                       |   34 +-
 tools/perf/util/bpf-loader.h                       |   28 +-
 tools/perf/util/build-id.c                         |    2 +-
 tools/perf/util/build-id.h                         |    2 +-
 tools/perf/util/callchain.c                        |    2 +-
 tools/perf/util/callchain.h                        |    2 +-
 tools/perf/util/cgroup.c                           |   22 +-
 tools/perf/util/cgroup.h                           |    6 +-
 tools/perf/util/counts.c                           |   17 +-
 tools/perf/util/counts.h                           |   34 +-
 tools/perf/util/cpumap.c                           |  264 +----
 tools/perf/util/cpumap.h                           |   54 +-
 tools/perf/util/cputopo.c                          |   13 +-
 tools/perf/util/cs-etm.c                           |    4 +-
 tools/perf/util/data-convert-bt.c                  |   38 +-
 tools/perf/util/db-export.c                        |   10 +-
 tools/perf/util/db-export.h                        |   10 +-
 tools/perf/util/env.c                              |    2 +-
 tools/perf/util/env.h                              |    2 +-
 tools/perf/util/event.c                            |   30 +-
 tools/perf/util/event.h                            |   14 +-
 tools/perf/util/evlist.c                           |  607 +++++-----
 tools/perf/util/evlist.h                           |  215 ++--
 tools/perf/util/evsel.c                            |  496 ++++----
 tools/perf/util/evsel.h                            |  194 ++--
 tools/perf/util/evsel_fprintf.c                    |   16 +-
 tools/perf/util/header.c                           |  225 ++--
 tools/perf/util/header.h                           |   24 +-
 tools/perf/util/hist.c                             |   32 +-
 tools/perf/util/hist.h                             |   38 +-
 tools/perf/util/intel-bts.c                        |   22 +-
 tools/perf/util/intel-pt.c                         |   94 +-
 tools/perf/util/jitdump.c                          |    8 +-
 tools/perf/util/kvm-stat.h                         |   22 +-
 tools/perf/util/machine.c                          |   12 +-
 tools/perf/util/machine.h                          |    8 +-
 tools/perf/util/map.h                              |    2 +-
 tools/perf/util/metricgroup.c                      |   26 +-
 tools/perf/util/metricgroup.h                      |    6 +-
 tools/perf/util/mmap.c                             |    4 +-
 tools/perf/util/parse-events.c                     |  143 +--
 tools/perf/util/parse-events.h                     |    8 +-
 tools/perf/util/pmu.c                              |   15 +-
 tools/perf/util/pmu.h                              |    2 +-
 tools/perf/util/python-ext-sources                 |    2 -
 tools/perf/util/python.c                           |   73 +-
 tools/perf/util/record.c                           |   73 +-
 tools/perf/util/s390-cpumsf.c                      |    4 +-
 tools/perf/util/s390-sample-raw.c                  |    6 +-
 tools/perf/util/sample-raw.c                       |    2 +-
 tools/perf/util/sample-raw.h                       |    6 +-
 .../perf/util/scripting-engines/trace-event-perl.c |   14 +-
 .../util/scripting-engines/trace-event-python.c    |   40 +-
 tools/perf/util/session.c                          |   81 +-
 tools/perf/util/session.h                          |   12 +-
 tools/perf/util/setup.py                           |    3 +-
 tools/perf/util/sort.c                             |   60 +-
 tools/perf/util/sort.h                             |    6 +-
 tools/perf/util/stat-display.c                     |  112 +-
 tools/perf/util/stat-shadow.c                      |   70 +-
 tools/perf/util/stat.c                             |   64 +-
 tools/perf/util/stat.h                             |   35 +-
 tools/perf/util/svghelper.c                        |    7 +-
 tools/perf/util/thread_map.c                       |  131 +--
 tools/perf/util/thread_map.h                       |   58 +-
 tools/perf/util/tool.h                             |    8 +-
 tools/perf/util/top.c                              |   12 +-
 tools/perf/util/top.h                              |    8 +-
 tools/perf/util/trace-event-info.c                 |   14 +-
 tools/perf/util/trace-event-scripting.c            |    2 +-
 tools/perf/util/trace-event.h                      |    4 +-
 tools/perf/util/util.c                             |   40 -
 tools/perf/util/util.h                             |    4 +-
 189 files changed, 5313 insertions(+), 3819 deletions(-)
 create mode 100644 tools/perf/lib/Build
 create mode 100644 tools/perf/lib/Documentation/Makefile
 create mode 100644 tools/perf/lib/Documentation/man/libperf.rst
 create mode 100644 tools/perf/lib/Documentation/tutorial/tutorial.rst
 create mode 100644 tools/perf/lib/Makefile
 create mode 100644 tools/perf/lib/core.c
 create mode 100644 tools/perf/lib/cpumap.c
 create mode 100644 tools/perf/lib/evlist.c
 create mode 100644 tools/perf/lib/evsel.c
 create mode 100644 tools/perf/lib/include/internal/cpumap.h
 create mode 100644 tools/perf/lib/include/internal/evlist.h
 create mode 100644 tools/perf/lib/include/internal/evsel.h
 create mode 100644 tools/perf/lib/include/internal/lib.h
 create mode 100644 tools/perf/lib/include/internal/tests.h
 create mode 100644 tools/perf/lib/include/internal/threadmap.h
 rename tools/perf/{util => lib/include/internal}/xyarray.h (84%)
 create mode 100644 tools/perf/lib/include/perf/core.h
 create mode 100644 tools/perf/lib/include/perf/cpumap.h
 create mode 100644 tools/perf/lib/include/perf/evlist.h
 create mode 100644 tools/perf/lib/include/perf/evsel.h
 create mode 100644 tools/perf/lib/include/perf/threadmap.h
 create mode 100644 tools/perf/lib/internal.h
 create mode 100644 tools/perf/lib/lib.c
 create mode 100644 tools/perf/lib/libperf.map
 create mode 100644 tools/perf/lib/libperf.pc.template
 create mode 100644 tools/perf/lib/tests/Makefile
 create mode 100644 tools/perf/lib/tests/test-cpumap.c
 create mode 100644 tools/perf/lib/tests/test-evlist.c
 create mode 100644 tools/perf/lib/tests/test-evsel.c
 create mode 100644 tools/perf/lib/tests/test-threadmap.c
 create mode 100644 tools/perf/lib/threadmap.c
 create mode 100644 tools/perf/lib/xyarray.c
Signature · 1 line
- Arnaldo
Acked-by on the v1 series
#191 lore raw
In reply to Jiri Olsa
Quoted 63 lines · Jiri Olsa

hi,
we have long term goal to separate some of the perf functionality into library. This patchset is initial effort on separating some of the interface.

Currently only the basic counting interface is exported, it allows to:
- create cpu/threads maps
- create evlist/evsel objects
- add evsel objects into evlist
- open/close evlist/evsel objects
- enable/disable events
- read evsel counts

The initial effort was to have total separation of the objects from perf code, but it showed not to be a good way. The amount of changed code was too big with high chance for regressions, mainly because of the code embedding one of the above objects statically.

We took the other approach of sharing the objects/struct details within the perf and libperf code. This way we can keep perf functionality without any major changes and the libperf users are still separated from the object/struct details. We can move to total libperf's objects separation gradually in future.

You can check current interface/functionality in examples under:
tools/perf/lib/Documentation/tutorial

or check tests in here:

  $ cd tools/perf/lib && make tests
    LINK     test-cpumap-a
    LINK     test-threadmap-a
    LINK     test-evlist-a
    LINK     test-evsel-a
    LINK     test-cpumap-so
    LINK     test-threadmap-so
    LINK     test-evlist-so
    LINK     test-evsel-so
  running static:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK
  running dynamic:
  - running test-cpumap.c...OK
  - running test-threadmap.c...OK
  - running test-evlist.c...OK
  - running test-evsel.c...OK

The upcoming changes in the near future:
- move parse_events interface in, so we have the event parsing interface in the library together with the all events from tools/perf/pmu-events/arch
- add sampling interface with event mmap support and all the sampling events objects
- add user mmap interface to read counters
- more documentation and tutorial ;-)
- move under tools/lib after the interface is more stable-ish

Big kudos to BPF guys, because most of the infrastructure is 'borrowed' from libbpf library.. ;-)

Quoted 9 lines

It's also available in here:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/lib

I tested so far on x86, I still need to run it through s390/ppc/arm.

throughts? thanks,
jirka

Some API for reading Perf record trace could be valuable extensions for the library. Also at some point public API will, probably, need some versioning.

~Alexey

Quoted 312 lines
Cc Daniel Borkmann <[email protected]>
Cc Alexei Starovoitov <[email protected]>
Cc Kan Liang <[email protected]>
Cc Song Liu <[email protected]>
Cc Steven Rostedt <[email protected]>
Cc Stephane Eranian <[email protected]>

---
Jiri Olsa (79):
perf tools: Move loaded out of struct perf_counts_values perf tools: Rename struct cpu_map to struct perf_cpu_map perf tools: Rename struct thread_map to struct perf_thread_map perf tools: Rename struct perf_evsel to struct evsel perf tools: Rename struct perf_evlist to struct evlist perf tools: Rename perf_evsel__init to evsel__init perf tools: Rename perf_evlist__init to evlist__init perf tools: Rename perf_evlist__new to evlist__new perf tools: Rename perf_evlist__delete to evlist__delete perf tools: Rename perf_evsel__delete to evsel__delete perf tools: Rename perf_evsel__new to evsel__new
perf tools: Rename perf_evlist__add to evlist__add perf tools: Rename perf_evlist__remove to evlist__remove perf tools: Rename perf_evsel__open to evsel__open perf tools: Rename perf_evsel__enable to evsel__enable perf tools: Rename perf_evsel__disable to evsel__disable perf tools: Rename perf_evsel__apply_filter to evsel__apply_filter perf tools: Rename perf_evsel__cpus to evsel__cpus perf tools: Rename perf_evlist__open to evlist__open perf tools: Rename perf_evlist__close to evlist__close perf tools: Rename perf_evlist__enable to evlist__enable perf tools: Rename perf_evlist__disable to evlist__disable
libperf: Make libperf.a part of the build
libperf: Add build version support
libperf: Add libperf in python.so compilation
libperf: Add perf/core.h header
libperf: Add debug output support
libperf: Add perf_cpu_map struct
libperf: Add perf_cpu_map__dummy_new function
libperf: Add perf_cpu_map__get/perf_cpu_map__put
libperf: Add perf_thread_map struct
libperf: Add perf_thread_map__new_dummy function
libperf: Add perf_thread_map__get/perf_thread_map__put
libperf: Add perf_evlist and perf_evsel structs
libperf: Include perf_evsel in evsel object
libperf: Include perf_evlist in evlist object
libperf: Add perf_evsel__init function
libperf: Add perf_evlist__init function
libperf: Add perf_evlist__add function
libperf: Add perf_evlist__remove function
libperf: Add nr_entries to perf_evlist
libperf: Add attr to perf_evsel
libperf: Add perf_cpu_map__new/perf_cpu_map__read functions
libperf: Move zalloc.o into libperf
libperf: Add perf_evlist__new function
libperf: Add perf_evsel__new function
libperf: Add perf_evlist__for_each_evsel macro
libperf: Add perf_evlist__delete function
libperf: Add perf_evsel__delete function
libperf: Add cpus to struct perf_evsel
libperf: Add own_cpus to struct perf_evsel
libperf: Add threads to struct perf_evsel
libperf: Add has_user_cpus to struct perf_evlist
libperf: Add cpus to struct perf_evlist
libperf: Add threads to struct perf_evlist
libperf: Add perf_evlist__set_maps function
libperf: Add xyarray object
libperf: Add fd array to struct perf_evsel
libperf: Add nr_members to struct perf_evsel
libperf: Add readn/writen function
libperf: Add perf_evsel__alloc_fd function
libperf: Add perf_evsel__open function
libperf: Add perf_evsel__close function
libperf: Add perf_evsel__read function
libperf: Add perf_evsel__enable/disable/apply_filter functions
libperf: Add perf_cpu_map__for_each_cpu macro
libperf: Add perf_evsel__cpus/threads functions
libperf: Add perf_evlist__open/close functions
libperf: Add perf_evlist__enable/disable functions
libperf: Add perf_evsel__attr functions
libperf: Add install targets
libperf: Add tests support
libperf: Add perf_cpu_map test
libperf: Add perf_thread_map test
libperf: Add perf_evlist test
libperf: Add perf_evsel tests
libperf: Add perf_evlist__enable/disable test
libperf: Add perf_evsel__enable/disable test
libperf: Initial documentation

 tools/perf/Makefile.config                         |    1 +
 tools/perf/Makefile.perf                           |   31 +-
 tools/perf/arch/arm/util/auxtrace.c                |    4 +-
 tools/perf/arch/arm/util/cs-etm.c                  |   26 +-
 tools/perf/arch/arm64/util/arm-spe.c               |    6 +-
 tools/perf/arch/powerpc/util/kvm-stat.c            |   12 +-
 tools/perf/arch/s390/util/auxtrace.c               |    8 +-
 tools/perf/arch/s390/util/kvm-stat.c               |    8 +-
 tools/perf/arch/x86/tests/intel-cqm.c              |    8 +-
 tools/perf/arch/x86/tests/perf-time-to-tsc.c       |   30 +-
 tools/perf/arch/x86/util/auxtrace.c                |   10 +-
 tools/perf/arch/x86/util/intel-bts.c               |   38 +-
 tools/perf/arch/x86/util/intel-pt.c                |   82 +-
 tools/perf/arch/x86/util/kvm-stat.c                |   12 +-
 tools/perf/bench/epoll-ctl.c                       |    7 +-
 tools/perf/bench/epoll-wait.c                      |    7 +-
 tools/perf/bench/futex-hash.c                      |    5 +-
 tools/perf/bench/futex-lock-pi.c                   |    7 +-
 tools/perf/bench/futex-requeue.c                   |    7 +-
 tools/perf/bench/futex-wake-parallel.c             |    6 +-
 tools/perf/bench/futex-wake.c                      |    7 +-
 tools/perf/builtin-annotate.c                      |   16 +-
 tools/perf/builtin-c2c.c                           |   10 +-
 tools/perf/builtin-diff.c                          |   20 +-
 tools/perf/builtin-evlist.c                        |    4 +-
 tools/perf/builtin-ftrace.c                        |   18 +-
 tools/perf/builtin-inject.c                        |   60 +-
 tools/perf/builtin-kmem.c                          |   24 +-
 tools/perf/builtin-kvm.c                           |   46 +-
 tools/perf/builtin-lock.c                          |   30 +-
 tools/perf/builtin-mem.c                           |    2 +-
 tools/perf/builtin-record.c                        |   50 +-
 tools/perf/builtin-report.c                        |   32 +-
 tools/perf/builtin-sched.c                         |   96 +-
 tools/perf/builtin-script.c                        |  167 +--
 tools/perf/builtin-stat.c                          |  135 +--
 tools/perf/builtin-timechart.c                     |   46 +-
 tools/perf/builtin-top.c                           |   71 +-
 tools/perf/builtin-trace.c                         |  180 +--
 tools/perf/lib/Build                               |   12 +
 tools/perf/lib/Documentation/Makefile              |    7 +
 tools/perf/lib/Documentation/man/libperf.rst       |  102 ++
 tools/perf/lib/Documentation/tutorial/tutorial.rst |  123 ++
 tools/perf/lib/Makefile                            |  158 +++
 tools/perf/lib/core.c                              |   34 +
 tools/perf/lib/cpumap.c                            |  239 ++++
 tools/perf/lib/evlist.c                            |  159 +++
 tools/perf/lib/evsel.c                             |  232 ++++
 tools/perf/lib/include/internal/cpumap.h           |   17 +
 tools/perf/lib/include/internal/evlist.h           |   50 +
 tools/perf/lib/include/internal/evsel.h            |   29 +
 tools/perf/lib/include/internal/lib.h              |   10 +
 tools/perf/lib/include/internal/tests.h            |   19 +
 tools/perf/lib/include/internal/threadmap.h        |   23 +
 .../perf/{util => lib/include/internal}/xyarray.h  |    6 +-
 tools/perf/lib/include/perf/core.h                 |   22 +
 tools/perf/lib/include/perf/cpumap.h               |   23 +
 tools/perf/lib/include/perf/evlist.h               |   35 +
 tools/perf/lib/include/perf/evsel.h                |   39 +
 tools/perf/lib/include/perf/threadmap.h            |   18 +
 tools/perf/lib/internal.h                          |   18 +
 tools/perf/lib/lib.c                               |   46 +
 tools/perf/lib/libperf.map                         |   40 +
 tools/perf/lib/libperf.pc.template                 |   11 +
 tools/perf/lib/tests/Makefile                      |   38 +
 tools/perf/lib/tests/test-cpumap.c                 |   21 +
 tools/perf/lib/tests/test-evlist.c                 |  186 +++
 tools/perf/lib/tests/test-evsel.c                  |  125 ++
 tools/perf/lib/tests/test-threadmap.c              |   21 +
 tools/perf/lib/threadmap.c                         |   81 ++
 tools/perf/lib/xyarray.c                           |   33 +
 tools/perf/tests/backward-ring-buffer.c            |   18 +-
 tools/perf/tests/bitmap.c                          |    5 +-
 tools/perf/tests/bpf.c                             |   12 +-
 tools/perf/tests/code-reading.c                    |   50 +-
 tools/perf/tests/cpumap.c                          |   21 +-
 tools/perf/tests/event-times.c                     |   81 +-
 tools/perf/tests/event_update.c                    |   13 +-
 tools/perf/tests/evsel-roundtrip-name.c            |   12 +-
 tools/perf/tests/evsel-tp-sched.c                  |    8 +-
 tools/perf/tests/hists_cumulate.c                  |   18 +-
 tools/perf/tests/hists_filter.c                    |   10 +-
 tools/perf/tests/hists_link.c                      |   10 +-
 tools/perf/tests/hists_output.c                    |   20 +-
 tools/perf/tests/keep-tracking.c                   |   44 +-
 tools/perf/tests/mem2node.c                        |    5 +-
 tools/perf/tests/mmap-basic.c                      |   28 +-
 tools/perf/tests/mmap-thread-lookup.c              |    4 +-
 tools/perf/tests/openat-syscall-all-cpus.c         |   18 +-
 tools/perf/tests/openat-syscall-tp-fields.c        |   14 +-
 tools/perf/tests/openat-syscall.c                  |   10 +-
 tools/perf/tests/parse-events.c                    | 1220 ++++++++++----------
 tools/perf/tests/parse-no-sample-id-all.c          |    6 +-
 tools/perf/tests/perf-record.c                     |   10 +-
 tools/perf/tests/sample-parsing.c                  |    8 +-
 tools/perf/tests/sw-clock.c                        |   33 +-
 tools/perf/tests/switch-tracking.c                 |   64 +-
 tools/perf/tests/task-exit.c                       |   35 +-
 tools/perf/tests/thread-map.c                      |   28 +-
 tools/perf/tests/time-utils-test.c                 |    2 +-
 tools/perf/tests/topology.c                        |    9 +-
 tools/perf/ui/browsers/annotate.c                  |   16 +-
 tools/perf/ui/browsers/hists.c                     |   54 +-
 tools/perf/ui/browsers/res_sample.c                |    4 +-
 tools/perf/ui/browsers/scripts.c                   |    6 +-
 tools/perf/ui/gtk/annotate.c                       |    8 +-
 tools/perf/ui/gtk/gtk.h                            |    8 +-
 tools/perf/ui/gtk/hists.c                          |    6 +-
 tools/perf/ui/hist.c                               |   16 +-
 tools/perf/util/Build                              |    6 -
 tools/perf/util/annotate.c                         |   42 +-
 tools/perf/util/annotate.h                         |   26 +-
 tools/perf/util/auxtrace.c                         |   28 +-
 tools/perf/util/auxtrace.h                         |   24 +-
 tools/perf/util/bpf-event.c                        |    2 +-
 tools/perf/util/bpf-event.h                        |    4 +-
 tools/perf/util/bpf-loader.c                       |   34 +-
 tools/perf/util/bpf-loader.h                       |   28 +-
 tools/perf/util/build-id.c                         |    2 +-
 tools/perf/util/build-id.h                         |    2 +-
 tools/perf/util/callchain.c                        |    2 +-
 tools/perf/util/callchain.h                        |    2 +-
 tools/perf/util/cgroup.c                           |   22 +-
 tools/perf/util/cgroup.h                           |    6 +-
 tools/perf/util/counts.c                           |   17 +-
 tools/perf/util/counts.h                           |   34 +-
 tools/perf/util/cpumap.c                           |  264 +----
 tools/perf/util/cpumap.h                           |   54 +-
 tools/perf/util/cputopo.c                          |   13 +-
 tools/perf/util/cs-etm.c                           |    4 +-
 tools/perf/util/data-convert-bt.c                  |   38 +-
 tools/perf/util/db-export.c                        |   10 +-
 tools/perf/util/db-export.h                        |   10 +-
 tools/perf/util/env.c                              |    2 +-
 tools/perf/util/env.h                              |    2 +-
 tools/perf/util/event.c                            |   30 +-
 tools/perf/util/event.h                            |   14 +-
 tools/perf/util/evlist.c                           |  607 +++++-----
 tools/perf/util/evlist.h                           |  215 ++--
 tools/perf/util/evsel.c                            |  496 ++++----
 tools/perf/util/evsel.h                            |  194 ++--
 tools/perf/util/evsel_fprintf.c                    |   16 +-
 tools/perf/util/header.c                           |  225 ++--
 tools/perf/util/header.h                           |   24 +-
 tools/perf/util/hist.c                             |   32 +-
 tools/perf/util/hist.h                             |   38 +-
 tools/perf/util/intel-bts.c                        |   22 +-
 tools/perf/util/intel-pt.c                         |   94 +-
 tools/perf/util/jitdump.c                          |    8 +-
 tools/perf/util/kvm-stat.h                         |   22 +-
 tools/perf/util/machine.c                          |   12 +-
 tools/perf/util/machine.h                          |    8 +-
 tools/perf/util/map.h                              |    2 +-
 tools/perf/util/metricgroup.c                      |   26 +-
 tools/perf/util/metricgroup.h                      |    6 +-
 tools/perf/util/mmap.c                             |    4 +-
 tools/perf/util/parse-events.c                     |  143 +--
 tools/perf/util/parse-events.h                     |    8 +-
 tools/perf/util/pmu.c                              |   15 +-
 tools/perf/util/pmu.h                              |    2 +-
 tools/perf/util/python-ext-sources                 |    2 -
 tools/perf/util/python.c                           |   73 +-
 tools/perf/util/record.c                           |   73 +-
 tools/perf/util/s390-cpumsf.c                      |    4 +-
 tools/perf/util/s390-sample-raw.c                  |    6 +-
 tools/perf/util/sample-raw.c                       |    2 +-
 tools/perf/util/sample-raw.h                       |    6 +-
 .../perf/util/scripting-engines/trace-event-perl.c |   14 +-
 .../util/scripting-engines/trace-event-python.c    |   40 +-
 tools/perf/util/session.c                          |   81 +-
 tools/perf/util/session.h                          |   12 +-
 tools/perf/util/setup.py                           |    3 +-
 tools/perf/util/sort.c                             |   60 +-
 tools/perf/util/sort.h                             |    6 +-
 tools/perf/util/stat-display.c                     |  112 +-
 tools/perf/util/stat-shadow.c                      |   70 +-
 tools/perf/util/stat.c                             |   64 +-
 tools/perf/util/stat.h                             |   35 +-
 tools/perf/util/svghelper.c                        |    7 +-
 tools/perf/util/thread_map.c                       |  131 +--
 tools/perf/util/thread_map.h                       |   58 +-
 tools/perf/util/tool.h                             |    8 +-
 tools/perf/util/top.c                              |   12 +-
 tools/perf/util/top.h                              |    8 +-
 tools/perf/util/trace-event-info.c                 |   14 +-
 tools/perf/util/trace-event-scripting.c            |    2 +-
 tools/perf/util/trace-event.h                      |    4 +-
 tools/perf/util/util.c                             |   40 -
 tools/perf/util/util.h                             |    4 +-
 189 files changed, 5313 insertions(+), 3819 deletions(-)
 create mode 100644 tools/perf/lib/Build
 create mode 100644 tools/perf/lib/Documentation/Makefile
 create mode 100644 tools/perf/lib/Documentation/man/libperf.rst
 create mode 100644 tools/perf/lib/Documentation/tutorial/tutorial.rst
 create mode 100644 tools/perf/lib/Makefile
 create mode 100644 tools/perf/lib/core.c
 create mode 100644 tools/perf/lib/cpumap.c
 create mode 100644 tools/perf/lib/evlist.c
 create mode 100644 tools/perf/lib/evsel.c
 create mode 100644 tools/perf/lib/include/internal/cpumap.h
 create mode 100644 tools/perf/lib/include/internal/evlist.h
 create mode 100644 tools/perf/lib/include/internal/evsel.h
 create mode 100644 tools/perf/lib/include/internal/lib.h
 create mode 100644 tools/perf/lib/include/internal/tests.h
 create mode 100644 tools/perf/lib/include/internal/threadmap.h
 rename tools/perf/{util => lib/include/internal}/xyarray.h (84%)
 create mode 100644 tools/perf/lib/include/perf/core.h
 create mode 100644 tools/perf/lib/include/perf/cpumap.h
 create mode 100644 tools/perf/lib/include/perf/evlist.h
 create mode 100644 tools/perf/lib/include/perf/evsel.h
 create mode 100644 tools/perf/lib/include/perf/threadmap.h
 create mode 100644 tools/perf/lib/internal.h
 create mode 100644 tools/perf/lib/lib.c
 create mode 100644 tools/perf/lib/libperf.map
 create mode 100644 tools/perf/lib/libperf.pc.template
 create mode 100644 tools/perf/lib/tests/Makefile
 create mode 100644 tools/perf/lib/tests/test-cpumap.c
 create mode 100644 tools/perf/lib/tests/test-evlist.c
 create mode 100644 tools/perf/lib/tests/test-evsel.c
 create mode 100644 tools/perf/lib/tests/test-threadmap.c
 create mode 100644 tools/perf/lib/threadmap.c
 create mode 100644 tools/perf/lib/xyarray.c