Skip to contentSkip to conversation

compress/zlib: fix coverity warning

PATCH Applied Adam Dybkowski 3 participants 3 messages Jul 24, 2019 – Jul 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 compress/zlib: fix coverity warning

Add missing return after setting the error status in case of invalid flush_flag in the operation.
The issue was found by the coverity scan as the fin_flush variable, not initialized in such case, was used later in the flow.

CID 340859: Uninitialized variables (UNINIT)

Fixes c7b436ec95fd ("compress/zlib: support burst enqueue/dequeue")
---
 drivers/compress/zlib/zlib_pmd.c | 1 +
 1 file changed, 1 insertion(+)
drivers/compress/zlib/zlib_pmd.c +1 -0
index 5a4d47d4d..19f9200c2 100644
@@ -30,6 +30,7 @@ process_zlib_deflate(struct rte_comp_op *op, z_stream *strm)
 	default:
 		op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
 		ZLIB_PMD_ERR("Invalid flush value\n");
+		return;
 	}
 
 	if (unlikely(!strm)) {
Signature · 1 line
2.17.1
#1 lore raw

Including Sunila, the zlib PMD maintainer.

Quoted 35 lines

-----Original Message-----
From: Dybkowski, AdamX
Sent: Wednesday, July 24, 2019 9:43 AM
To: [email protected]; Trahe, Fiona <[email protected]>; [email protected]
Cc: Dybkowski, AdamX <[email protected]>
Subject: [PATCH] compress/zlib: fix coverity warning

Add missing return after setting the error status in case of invalid flush_flag in the operation.
The issue was found by the coverity scan as the fin_flush variable, not initialized in such case, was used later in the flow.

CID 340859: Uninitialized variables (UNINIT)

Fixes c7b436ec95fd ("compress/zlib: support burst enqueue/dequeue")
---
 drivers/compress/zlib/zlib_pmd.c | 1 +
 1 file changed, 1 insertion(+)
drivers/compress/zlib/zlib_pmd.c +1 -1
index 5a4d47d4d..19f9200c2 100644
@@ -30,6 +30,7 @@ process_zlib_deflate(struct rte_comp_op *op, z_stream *strm)
 	default:
 		op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
 		ZLIB_PMD_ERR("Invalid flush value\n");
+		return;
 	}
 
 	if (unlikely(!strm)) {
--

2.17.1

Applied
#2 lore raw
In reply to Adam Dybkowski
Quoted 6 lines

Add missing return after setting the error status in case of invalid flush_flag in the operation.
The issue was found by the coverity scan as the fin_flush variable, not initialized in such case, was used later in the flow.

Quoted 6 lines

CID 340859: Uninitialized variables (UNINIT)

Fixes c7b436ec95fd ("compress/zlib: support burst enqueue/dequeue")

---

Applied to dpdk-next-crypto

Thanks.