Skip to contentSkip to conversation

marvell wireless: cleanup -- make error values consistent

PATCH In review Pavel Machek 2 participants 3 messages Jul 24, 2019 – Aug 6, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 marvell wireless: cleanup -- make error values consistent

Surrounding code uses -ERRNO as a result, so don't pass plain -1.

drivers/net/wireless/marvell/mwifiex/scan.c +1 -1
index 0d6d417..ddf75a5 100644
@@ -1243,7 +1243,7 @@ int mwifiex_update_bss_desc_with_ie(struct mwifiex_adapter *adapter,
 			mwifiex_dbg(adapter, ERROR,
 				    "err: InterpretIE: in processing\t"
 				    "IE, bytes left < IE length\n");
-			return -1;
+			return -EINVAL;
 		}
 		switch (element_id) {
 		case WLAN_EID_SSID:
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 3 lines · Pavel Machek

Surrounding code uses -ERRNO as a result, so don't pass plain -1.

The title prefix should be "mwifiex:", I'll fix that.

Signature · 3 lines
https://patchwork.kernel.org/patch/11056525/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to Pavel Machek
Quoted 3 lines · Pavel Machek

Surrounding code uses -ERRNO as a result, so don't pass plain -1.

For some reason patchwork (or my patchwork script) didn't like this patch:

Failed to apply the patch: ['git', 'am', '-s', '-3'] failed: 128 Patch is empty. Was it split wrong?

So I applied this manually:

6334dea8880a mwifiex: make error values consistent in mwifiex_update_bss_desc_with_ie()

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches