Add board support for iMX8QXP AI_ML board
Subsystems (3)
v4 cover Add board support for iMX8QXP AI_ML board
Hello,
This patchset adds initial board support for iMX8QXP AI_ML board from Einfochips. This board is one of the Consumer Edition and AI boards of the 96Boards family.
This initial supports contains following peripherals which are tested and known to work:
1. Debug serial via UART2
2. SD card
3. Ethernet
Thanks,
Mani
Note: This patchset depends on the below cleanup patches submitted:
[U-Boot,1/2] arm: imx8: factor out uart init code [U-Boot,2/2] arm: imx8: don't duplicate build_info()
Changes in v4:
* Incorporated review comments from Fabio.
Changes in v3:
* Incorporated review comments from Fabio. Major change is switching to distro_boot.
* Added Reviewed-by tag from Peng Fan.
Changes in v2:
* Rebased the patches on top of following patches:
[U-Boot,1/2] arm: imx8: factor out uart init code [U-Boot,2/2] arm: imx8: don't duplicate build_info()
Manivannan Sadhasivam (2):
arm: dts: Add devicetree support for iMXQXP AI_ML board
board: Add support for iMX8QXP AI_ML board
arch/arm/dts/Makefile | 1 + arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi | 117 +++++++++++ arch/arm/dts/fsl-imx8qxp-ai_ml.dts | 181 ++++++++++++++++++ arch/arm/mach-imx/imx8/Kconfig | 6 + board/einfochips/imx8qxp_ai_ml/Kconfig | 12 ++ board/einfochips/imx8qxp_ai_ml/MAINTAINERS | 6 + board/einfochips/imx8qxp_ai_ml/Makefile | 8 + board/einfochips/imx8qxp_ai_ml/README | 49 +++++ .../einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c | 117 +++++++++++ board/einfochips/imx8qxp_ai_ml/imximage.cfg | 24 +++ board/einfochips/imx8qxp_ai_ml/spl.c | 49 +++++ configs/imx8qxp_ai_ml_defconfig | 83 ++++++++ include/configs/imx8qxp_ai_ml.h | 104 ++++++++++ 13 files changed, 757 insertions(+) create mode 100644 arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi create mode 100644 arch/arm/dts/fsl-imx8qxp-ai_ml.dts create mode 100644 board/einfochips/imx8qxp_ai_ml/Kconfig create mode 100644 board/einfochips/imx8qxp_ai_ml/MAINTAINERS create mode 100644 board/einfochips/imx8qxp_ai_ml/Makefile create mode 100644 board/einfochips/imx8qxp_ai_ml/README create mode 100644 board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c create mode 100644 board/einfochips/imx8qxp_ai_ml/imximage.cfg create mode 100644 board/einfochips/imx8qxp_ai_ml/spl.c create mode 100644 configs/imx8qxp_ai_ml_defconfig create mode 100644 include/configs/imx8qxp_ai_ml.h
Signature · 1 line
2.17.1
PATCH v4 1/2 arm: dts: Add devicetree support for iMXQXP AI_ML board
Add devicetree support for iMXQXP AI_ML board from Einfochips.
--- arch/arm/dts/Makefile | 1 + arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi | 117 +++++++++++++ arch/arm/dts/fsl-imx8qxp-ai_ml.dts | 181 +++++++++++++++++++++ 3 files changed, 299 insertions(+) create mode 100644 arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi create mode 100644 arch/arm/dts/fsl-imx8qxp-ai_ml.dts
arch/arm/dts/Makefile +1 -0
@@ -614,6 +614,7 @@ dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb dtb-$(CONFIG_ARCH_IMX8) += \ fsl-imx8qm-apalis.dtb \ fsl-imx8qm-mek.dtb \ + fsl-imx8qxp-ai_ml.dtb \ fsl-imx8qxp-colibri.dtb \ fsl-imx8qxp-mek.dtb
arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi new file +117 -0
117 lines not on this page · raw message
arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +181 -0
181 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v4 1/2 arm: dts: Add devicetree support for iMXQXP AI_ML board
Quoted 16 lines · On Fri, 19 Jul 2019 12:27:42 +0530 Manivannan Sadhasivam…
Add devicetree support for iMXQXP
AI_MLboard from Einfochips.Signed-off-by: Manivannan Sadhasivam
<[email protected]> ---arch/arm/dts/Makefile | 1 + arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi | 117 +++++++++++++ arch/arm/dts/fsl-imx8qxp-ai_ml.dts | 181 +++++++++++++++++++++ 3 files changed, 299 insertions(+) create mode 100644 arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi create mode 100644 arch/arm/dts/fsl-imx8qxp-ai_ml.dtsarch/arm/dts/Makefile +0
-0
arch/arm/dts/Makefile dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb · line 620
Quoted 7 lines
arch/arm/dts/Makefile +1
-0@@ -614,6 +614,7 @@ dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb dtb-$(CONFIG_ARCH_IMX8) += \ fsl-imx8qm-apalis.dtb \ fsl-imx8qm-mek.dtb \ + fsl-imx8qxp-ai_ml.dtb \ fsl-imx8qxp-colibri.dtb \ fsl-imx8qxp-mek.dtb
Just out of curiosity - why ARM8 devices from iMX have dtb naming convention starting from 'fsl-' ?
With other boards we strive to have 'imx6q-'*.dts, 'imx53-'*.dts, etc?
Quoted 347 lines
(quoted diff) +0
-0
b/arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsinew file mode 100644 index 0000000000..3ca53bb945arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi new file +117
-0@@ -0,0 +1,117 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2019 Linaro Ltd. + */ + +&{/imx8qx-pm} { + + u-boot,dm-spl; +}; + +&mu { + u-boot,dm-spl; +}; + +&clk { + u-boot,dm-spl; +}; + +&iomuxc { + u-boot,dm-spl; +}; + +&pd_lsio { + u-boot,dm-spl; +}; + +&pd_lsio_gpio0 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio1 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio2 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio3 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio4 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio5 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio6 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio7 { + u-boot,dm-spl; +}; + +&pd_conn { + u-boot,dm-spl; +}; + +&pd_conn_sdch0 { + u-boot,dm-spl; +}; + +&pd_conn_sdch1 { + u-boot,dm-spl; +}; + +&pd_conn_sdch2 { + u-boot,dm-spl; +}; + +&gpio0 { + u-boot,dm-spl; +}; + +&gpio1 { + u-boot,dm-spl; +}; + +&gpio2 { + u-boot,dm-spl; +}; + +&gpio3 { + u-boot,dm-spl; +}; + +&gpio4 { + u-boot,dm-spl; +}; + +&gpio5 { + u-boot,dm-spl; +}; + +&gpio6 { + u-boot,dm-spl; +}; + +&gpio7 { + u-boot,dm-spl; +}; + +&lpuart2 { + u-boot,dm-spl; +}; + +&usdhc1 { + u-boot,dm-spl; +}; + +&usdhc2 { + u-boot,dm-spl; +};(quoted diff) +0
-0
b/arch/arm/dts/fsl-imx8qxp-ai_ml.dtsnew file mode 100644 index 0000000000..aa85caaff5arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +17
-0@@ -0,0 +1,181 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2018 Einfochips + * Copyright 2019 Linaro Ltd. + */ + +/dts-v1/; + +#include "fsl-imx8qxp.dtsi" +#include "fsl-imx8qxp-ai_ml-u-boot.dtsi" + +/ { + model = "Einfochips i.MX8QXP AI_ML"; + compatible = "einfochips,imx8qxp-ai_ml", "fsl,imx8qxp"; + + chosen { + bootargs = "console=ttyLP2,115200earlycon=lpuart32,0x5a080000,115200";
arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +88
-0+ stdout-path = &lpuart2; + }; + + memory at 80000000 { + device_type = "memory"; + reg = <0x00000000 0x80000000 0 0x80000000>; + }; +}; + +&lpuart0 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpuart0>; + status = "okay"; +}; + +&lpuart1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpuart1>; + status = "okay"; +}; + +&lpuart2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpuart2>; + status = "okay"; +}; + +&lpuart3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpuart3>; + status = "okay"; +}; + +&fec1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_fec1>; + phy-mode = "rgmii"; + phy-handle = <ðphy0>; + fsl,ar8031-phy-fixup; + fsl,magic-packet; + phy-reset-gpios = <&gpio4 14 GPIO_ACTIVE_LOW>; + phy-reset-duration = <10>; + phy-reset-post-delay = <150>; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy0: ethernet-phy at 0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0>; + }; + }; +}; + +/* LS-I2C1 */ +&i2c1 { + #address-cells = <1>; + #size-cells = <0>; + clock-frequency = <100000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpi2c1>; + status = "okay"; +}; + +&usdhc1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc1>; + bus-width = <4>; + no-sd; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; +}; + +&usdhc2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc2>; + bus-width = <4>; + cd-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; + status = "okay"; +}; + +&iomuxc { + pinctrl_fec1: fec1grp { + fsl,pins = < +
SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENETB0_PAD0x000014a0
+SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENETB1_PAD0x000014a0
+SC_P_ENET0_MDC_CONN_ENET0_MDC0x06000020
+SC_P_ENET0_MDIO_CONN_ENET0_MDIO0x06000020
+SC_P_ENET0_RGMII_TX_CTL_CONN_ENET0_RGMII_TX_CTL0x06000020
+SC_P_ENET0_RGMII_TXC_CONN_ENET0_RGMII_TXC0x06000020
+SC_P_ENET0_RGMII_TXD0_CONN_ENET0_RGMII_TXD00x06000020
+SC_P_ENET0_RGMII_TXD1_CONN_ENET0_RGMII_TXD10x06000020
+SC_P_ENET0_RGMII_TXD2_CONN_ENET0_RGMII_TXD20x06000020
+SC_P_ENET0_RGMII_TXD3_CONN_ENET0_RGMII_TXD30x06000020
+SC_P_ENET0_RGMII_RXC_CONN_ENET0_RGMII_RXC0x06000020
+SC_P_ENET0_RGMII_RX_CTL_CONN_ENET0_RGMII_RX_CTL0x06000020
+SC_P_ENET0_RGMII_RXD0_CONN_ENET0_RGMII_RXD00x06000020
+SC_P_ENET0_RGMII_RXD1_CONN_ENET0_RGMII_RXD10x06000020
+SC_P_ENET0_RGMII_RXD2_CONN_ENET0_RGMII_RXD20x06000020
+SC_P_ENET0_RGMII_RXD3_CONN_ENET0_RGMII_RXD30x06000020arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_lpi2c1: lpi2c1grp { + fsl,pins = < +
SC_P_USB_SS3_TC1_ADMA_I2C1_SCL0x06000021
+SC_P_USB_SS3_TC3_ADMA_I2C1_SDA0x06000021arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_lpuart0: lpuart0grp { + fsl,pins = < +
SC_P_UART0_RX_ADMA_UART0_RX0X06000020
+SC_P_UART0_TX_ADMA_UART0_TX0X06000020arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_lpuart1: lpuart1grp { + fsl,pins = < +
SC_P_UART1_RX_ADMA_UART1_RX0X06000020
+SC_P_UART1_TX_ADMA_UART1_TX0X06000020arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_lpuart2: lpuart2grp { + fsl,pins = < +
SC_P_UART2_RX_ADMA_UART2_RX0X06000020
+SC_P_UART2_TX_ADMA_UART2_TX0X06000020arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_lpuart3: lpuart3grp { + fsl,pins = < +
SC_P_FLEXCAN2_RX_ADMA_UART3_RX0X06000020
+SC_P_FLEXCAN2_TX_ADMA_UART3_TX0X06000020arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_usdhc1: usdhc1grp { + fsl,pins = < +
SC_P_EMMC0_CLK_CONN_EMMC0_CLK0x06000041
+SC_P_EMMC0_CMD_CONN_EMMC0_CMD0x00000021
+SC_P_EMMC0_DATA0_CONN_EMMC0_DATA00x00000021
+SC_P_EMMC0_DATA1_CONN_EMMC0_DATA10x00000021
+SC_P_EMMC0_DATA2_CONN_EMMC0_DATA20x00000021
+SC_P_EMMC0_DATA3_CONN_EMMC0_DATA30x00000021arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_usdhc2: usdhc2grp { + fsl,pins = < +
SC_P_USDHC1_CLK_CONN_USDHC1_CLK0x06000041
+SC_P_USDHC1_CMD_CONN_USDHC1_CMD0x00000021
+SC_P_USDHC1_DATA0_CONN_USDHC1_DATA00x00000021
+SC_P_USDHC1_DATA1_CONN_USDHC1_DATA10x00000021
+SC_P_USDHC1_DATA2_CONN_USDHC1_DATA20x00000021
+SC_P_USDHC1_DATA3_CONN_USDHC1_DATA30x00000021
+SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT0x00000021
arch/arm/dts/fsl-imx8qxp-ai_ml.dts line 129
Quoted 3 lines
arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +3
-0+ >; + }; +};
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190724/06ea4f6f/attachment.sig>
PATCH v4 1/2 arm: dts: Add devicetree support for iMXQXP AI_ML board
Quoted 32 lines
Subject: Re: [U-Boot] [PATCH v4 1/2] arm: dts: Add devicetree support for iMXQXP
AI_MLboardQuoted 16 lines · On Fri, 19 Jul 2019 12:27:42 +0530 Manivannan Sadhasivam…
Add devicetree support for iMXQXP
AI_MLboard from Einfochips.Signed-off-by: Manivannan Sadhasivam
<[email protected]> ---arch/arm/dts/Makefile | 1 + arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi | 117 +++++++++++++ arch/arm/dts/fsl-imx8qxp-ai_ml.dts | 181 +++++++++++++++++++++ 3 files changed, 299 insertions(+) create mode 100644 arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi create mode 100644 arch/arm/dts/fsl-imx8qxp-ai_ml.dtsarch/arm/dts/Makefile index renamed from arch/arm/dts/Makefile +0
-0
e6680e5e98..7834a158da100644arch/arm/dts/Makefile dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb · line 620
Quoted 7 lines
arch/arm/dts/Makefile +1
-0@@ -614,6 +614,7 @@ dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb dtb-$(CONFIG_ARCH_IMX8) += \ fsl-imx8qm-apalis.dtb \ fsl-imx8qm-mek.dtb \ + fsl-imx8qxp-ai_ml.dtb \ fsl-imx8qxp-colibri.dtb \ fsl-imx8qxp-mek.dtbReviewed-by Lukasz Majewski <[email protected]>
Quoted 4 lines
Just out of curiosity - why ARM8 devices from iMX have dtb naming convention starting from 'fsl-' ?
With other boards we strive to have 'imx6q-'*.dts, 'imx53-'*.dts, etc?
When initially upstreaming i.MX8 to U-Boot, the dts was reused from downstream, because Linux upstream still not have that device tree.
When Linux i.MX8 device tree stable, we need to migrate to use Linux dts without fsl- prefix.
Currently It is under some restructure for long time and missed i.MX8QM support.
Regards,
Peng.
Quoted 366 lines
Quoted 251 lines
(quoted diff) +0
-0
b/arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsinew file mode 100644 index 0000000000..3ca53bb945arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi new file +117
-0@@ -0,0 +1,117 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2019 Linaro Ltd. + */ + +&{/imx8qx-pm} { + + u-boot,dm-spl; +}; + +&mu { + u-boot,dm-spl; +}; + +&clk { + u-boot,dm-spl; +}; + +&iomuxc { + u-boot,dm-spl; +}; + +&pd_lsio { + u-boot,dm-spl; +}; + +&pd_lsio_gpio0 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio1 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio2 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio3 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio4 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio5 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio6 { + u-boot,dm-spl; +}; + +&pd_lsio_gpio7 { + u-boot,dm-spl; +}; + +&pd_conn { + u-boot,dm-spl; +}; + +&pd_conn_sdch0 { + u-boot,dm-spl; +}; + +&pd_conn_sdch1 { + u-boot,dm-spl; +}; + +&pd_conn_sdch2 { + u-boot,dm-spl; +}; + +&gpio0 { + u-boot,dm-spl; +}; + +&gpio1 { + u-boot,dm-spl; +}; + +&gpio2 { + u-boot,dm-spl; +}; + +&gpio3 { + u-boot,dm-spl; +}; + +&gpio4 { + u-boot,dm-spl; +}; + +&gpio5 { + u-boot,dm-spl; +}; + +&gpio6 { + u-boot,dm-spl; +}; + +&gpio7 { + u-boot,dm-spl; +}; + +&lpuart2 { + u-boot,dm-spl; +}; + +&usdhc1 { + u-boot,dm-spl; +}; + +&usdhc2 { + u-boot,dm-spl; +};(quoted diff) +0
-0
b/arch/arm/dts/fsl-imx8qxp-ai_ml.dtsnew file mode 100644 index 0000000000..aa85caaff5arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +17
-0@@ -0,0 +1,181 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2018 Einfochips + * Copyright 2019 Linaro Ltd. + */ + +/dts-v1/; + +#include "fsl-imx8qxp.dtsi" +#include "fsl-imx8qxp-ai_ml-u-boot.dtsi" + +/ { + model = "Einfochips i.MX8QXP AI_ML"; + compatible = "einfochips,imx8qxp-ai_ml", "fsl,imx8qxp"; + + chosen { + bootargs = "console=ttyLP2,115200earlycon=lpuart32,0x5a080000,115200";
arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +88
-0+ stdout-path = &lpuart2; + }; + + memory at 80000000 { + device_type = "memory"; + reg = <0x00000000 0x80000000 0 0x80000000>; + }; +}; + +&lpuart0 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpuart0>; + status = "okay"; +}; + +&lpuart1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpuart1>; + status = "okay"; +}; + +&lpuart2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpuart2>; + status = "okay"; +}; + +&lpuart3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpuart3>; + status = "okay"; +}; + +&fec1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_fec1>; + phy-mode = "rgmii"; + phy-handle = <ðphy0>; + fsl,ar8031-phy-fixup; + fsl,magic-packet; + phy-reset-gpios = <&gpio4 14 GPIO_ACTIVE_LOW>; + phy-reset-duration = <10>; + phy-reset-post-delay = <150>; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy0: ethernet-phy at 0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0>; + }; + }; +}; + +/* LS-I2C1 */ +&i2c1 { + #address-cells = <1>; + #size-cells = <0>; + clock-frequency = <100000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpi2c1>; + status = "okay"; +}; + +&usdhc1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc1>; + bus-width = <4>; + no-sd; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; +}; + +&usdhc2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc2>; + bus-width = <4>; + cd-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; + status = "okay"; +}; + +&iomuxc { + pinctrl_fec1: fec1grp { + fsl,pins = < +
SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENETB0_PAD0x000014a0
+SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENETB1_PAD0x000014a0
+SC_P_ENET0_MDC_CONN_ENET0_MDC0x06000020
+SC_P_ENET0_MDIO_CONN_ENET0_MDIO0x06000020
+SC_P_ENET0_RGMII_TX_CTL_CONN_ENET0_RGMII_TX_CTL0x06000020
+SC_P_ENET0_RGMII_TXC_CONN_ENET0_RGMII_TXC0x06000020
+SC_P_ENET0_RGMII_TXD0_CONN_ENET0_RGMII_TXD00x06000020
+SC_P_ENET0_RGMII_TXD1_CONN_ENET0_RGMII_TXD10x06000020Quoted 8 lines
+
SC_P_ENET0_RGMII_TXD2_CONN_ENET0_RGMII_TXD20x06000020
+SC_P_ENET0_RGMII_TXD3_CONN_ENET0_RGMII_TXD30x06000020
+SC_P_ENET0_RGMII_RXC_CONN_ENET0_RGMII_RXC0x06000020
+SC_P_ENET0_RGMII_RX_CTL_CONN_ENET0_RGMII_RX_CTL0x06000020Quoted 89 lines
+
SC_P_ENET0_RGMII_RXD0_CONN_ENET0_RGMII_RXD00x06000020
+SC_P_ENET0_RGMII_RXD1_CONN_ENET0_RGMII_RXD10x06000020
+SC_P_ENET0_RGMII_RXD2_CONN_ENET0_RGMII_RXD20x06000020
+SC_P_ENET0_RGMII_RXD3_CONN_ENET0_RGMII_RXD30x06000020arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_lpi2c1: lpi2c1grp { + fsl,pins = < +
SC_P_USB_SS3_TC1_ADMA_I2C1_SCL0x06000021
+SC_P_USB_SS3_TC3_ADMA_I2C1_SDA0x06000021arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_lpuart0: lpuart0grp { + fsl,pins = < +
SC_P_UART0_RX_ADMA_UART0_RX0X06000020
+SC_P_UART0_TX_ADMA_UART0_TX0X06000020arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_lpuart1: lpuart1grp { + fsl,pins = < +
SC_P_UART1_RX_ADMA_UART1_RX0X06000020
+SC_P_UART1_TX_ADMA_UART1_TX0X06000020arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_lpuart2: lpuart2grp { + fsl,pins = < +
SC_P_UART2_RX_ADMA_UART2_RX0X06000020
+SC_P_UART2_TX_ADMA_UART2_TX0X06000020arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_lpuart3: lpuart3grp { + fsl,pins = < +
SC_P_FLEXCAN2_RX_ADMA_UART3_RX0X06000020
+SC_P_FLEXCAN2_TX_ADMA_UART3_TX0X06000020arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_usdhc1: usdhc1grp { + fsl,pins = < +
SC_P_EMMC0_CLK_CONN_EMMC0_CLK0x06000041
+SC_P_EMMC0_CMD_CONN_EMMC0_CMD0x00000021
+SC_P_EMMC0_DATA0_CONN_EMMC0_DATA00x00000021
+SC_P_EMMC0_DATA1_CONN_EMMC0_DATA10x00000021
+SC_P_EMMC0_DATA2_CONN_EMMC0_DATA20x00000021
+SC_P_EMMC0_DATA3_CONN_EMMC0_DATA30x00000021arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +6
-0+ >; + }; + + pinctrl_usdhc2: usdhc2grp { + fsl,pins = < +
SC_P_USDHC1_CLK_CONN_USDHC1_CLK0x06000041
+SC_P_USDHC1_CMD_CONN_USDHC1_CMD0x00000021
+SC_P_USDHC1_DATA0_CONN_USDHC1_DATA00x00000021
+SC_P_USDHC1_DATA1_CONN_USDHC1_DATA10x00000021
+SC_P_USDHC1_DATA2_CONN_USDHC1_DATA20x00000021
+SC_P_USDHC1_DATA3_CONN_USDHC1_DATA30x00000021
+SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT0x00000021arch/arm/dts/fsl-imx8qxp-ai_ml.dts line 129
Quoted 3 lines
arch/arm/dts/fsl-imx8qxp-ai_ml.dts new file +3
-0+ >; + }; +};Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de
PATCH v4 2/2 board: Add support for iMX8QXP AI_ML board
In reply to Manivannan SadhasivamThis commit adds initial board support for iMX8QXP AI_ML board from Einfochips. This board is one of the 96Boards Consumer Edition and AI boards of the 96Boards family based on i.MX8QXP SoC from NXP/Freescale.
This initial supports contains following peripherals which are tested and known to work:
1. Debug serial via UART2
2. SD card
3. Ethernet
More information about this board can be found in arrow website:
https://www.arrow.com/en/products/imx8-ai-ml/arrow-development-tools
--- arch/arm/mach-imx/imx8/Kconfig | 6 + board/einfochips/imx8qxp_ai_ml/Kconfig | 12 ++ board/einfochips/imx8qxp_ai_ml/MAINTAINERS | 6 + board/einfochips/imx8qxp_ai_ml/Makefile | 8 ++ board/einfochips/imx8qxp_ai_ml/README | 49 ++++++++ .../einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c | 117 ++++++++++++++++++ board/einfochips/imx8qxp_ai_ml/imximage.cfg | 24 ++++ board/einfochips/imx8qxp_ai_ml/spl.c | 49 ++++++++ configs/imx8qxp_ai_ml_defconfig | 83 +++++++++++++ include/configs/imx8qxp_ai_ml.h | 104 ++++++++++++++++ 10 files changed, 458 insertions(+) create mode 100644 board/einfochips/imx8qxp_ai_ml/Kconfig create mode 100644 board/einfochips/imx8qxp_ai_ml/MAINTAINERS create mode 100644 board/einfochips/imx8qxp_ai_ml/Makefile create mode 100644 board/einfochips/imx8qxp_ai_ml/README create mode 100644 board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c create mode 100644 board/einfochips/imx8qxp_ai_ml/imximage.cfg create mode 100644 board/einfochips/imx8qxp_ai_ml/spl.c create mode 100644 configs/imx8qxp_ai_ml_defconfig create mode 100644 include/configs/imx8qxp_ai_ml.h
arch/arm/mach-imx/imx8/Kconfig +6 -0
@@ -37,6 +37,11 @@ config TARGET_COLIBRI_IMX8X select BOARD_LATE_INIT select IMX8QXP +config TARGET_IMX8QXP_AI_ML + bool "Support i.MX8QXP AI_ML board" + select BOARD_LATE_INIT + select IMX8QXP + config TARGET_IMX8QM_MEK bool "Support i.MX8QM MEK board" select BOARD_LATE_INIT
@@ -49,6 +54,7 @@ config TARGET_IMX8QXP_MEK endchoice +source "board/einfochips/imx8qxp_ai_ml/Kconfig" source "board/freescale/imx8qm_mek/Kconfig" source "board/freescale/imx8qxp_mek/Kconfig" source "board/toradex/apalis-imx8/Kconfig"
board/einfochips/imx8qxp_ai_ml/Kconfig new file +12 -0
@@ -0,0 +1,12 @@ +if TARGET_IMX8QXP_AI_ML + +config SYS_BOARD + default "imx8qxp_ai_ml" + +config SYS_VENDOR + default "einfochips" + +config SYS_CONFIG_NAME + default "imx8qxp_ai_ml" + +endif
board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file +6 -0
@@ -0,0 +1,6 @@ +i.MX8QXP AI_ML BOARD +M: Manivannan Sadhasivam <[email protected]> +S: Maintained +F: board/einfochips/imx8qxp_ai_ml/ +F: include/configs/imx8qxp_ai_ml.h +F: configs/imx8qxp_ai_ml_defconfig
board/einfochips/imx8qxp_ai_ml/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# +# Copyright 2019 Linaro Ltd. +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-y += imx8qxp_ai_ml.o +obj-$(CONFIG_SPL_BUILD) += spl.o
board/einfochips/imx8qxp_ai_ml/README new file +49 -0
49 lines not on this page · raw message
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +117 -0
117 lines not on this page · raw message
board/einfochips/imx8qxp_ai_ml/imximage.cfg new file +24 -0
@@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2018 NXP + * + * Refer doc/README.imx8image for more details about how-to configure + * and create imx8image boot image + */ + +#define __ASSEMBLY__ + +/* Boot from SD, sector size 0x400 */ +BOOT_FROM SD 0x400 +/* SoC type IMX8QX */ +SOC_TYPE IMX8QX +/* Append seco container image */ +APPEND mx8qx-ahab-container.img +/* Create the 2nd container */ +CONTAINER +/* Add scfw image with exec attribute */ +IMAGE SCU mx8qx-aiml-scfw-tcm.bin +/* Add ATF image with exec attribute */ +IMAGE A35 bl31.bin 0x80000000 +/* Add U-Boot image with load attribute */ +DATA A35 u-boot-dtb.bin 0x80020000
board/einfochips/imx8qxp_ai_ml/spl.c new file +49 -0
49 lines not on this page · raw message
configs/imx8qxp_ai_ml_defconfig new file +83 -0
83 lines not on this page · raw message
include/configs/imx8qxp_ai_ml.h new file +104 -0
104 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v4 2/2 board: Add support for iMX8QXP AI_ML board
Hi Manivannan,
board/einfochips/imx8qxp_ai_ml/README
Quoted 111 lines
This commit adds initial board support for iMX8QXP
AI_MLboard from Einfochips. This board is one of the 96Boards Consumer Edition and AI boards of the 96Boards family based on i.MX8QXP SoC from NXP/Freescale.This initial supports contains following peripherals which are tested and known to work:
1. Debug serial via UART2
2. SD card
3. EthernetMore information about this board can be found in arrow website:
https://www.arrow.com/en/products/imx8-ai-ml/arrow-development-toolsSigned-off-by: Manivannan Sadhasivam
<[email protected]> ---arch/arm/mach-imx/imx8/Kconfig | 6 + board/einfochips/imx8qxp_ai_ml/Kconfig | 12 ++ board/einfochips/imx8qxp_ai_ml/MAINTAINERS | 6 + board/einfochips/imx8qxp_ai_ml/Makefile | 8 ++ board/einfochips/imx8qxp_ai_ml/README | 49 ++++++++ .../einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c | 117 ++++++++++++++++++ board/einfochips/imx8qxp_ai_ml/imximage.cfg | 24 ++++ board/einfochips/imx8qxp_ai_ml/spl.c | 49 ++++++++ configs/imx8qxp_ai_ml_defconfig | 83 +++++++++++++ include/configs/imx8qxp_ai_ml.h | 104 ++++++++++++++++ 10 files changed, 458 insertions(+) create mode 100644 board/einfochips/imx8qxp_ai_ml/Kconfig create mode 100644 board/einfochips/imx8qxp_ai_ml/MAINTAINERS create mode 100644 board/einfochips/imx8qxp_ai_ml/Makefile create mode 100644 board/einfochips/imx8qxp_ai_ml/README create mode 100644 board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c create mode 100644 board/einfochips/imx8qxp_ai_ml/imximage.cfg create mode 100644 board/einfochips/imx8qxp_ai_ml/spl.c create mode 100644 configs/imx8qxp_ai_ml_defconfig create mode 100644 include/configs/imx8qxp_ai_ml.h(quoted diff) +0
-0b/arch/arm/mach-imx/imx8/Kconfig index
bbe323d5ca..cec21f8dd2100644arch/arm/mach-imx/imx8/Kconfig +6
-0@@ -37,6 +37,11 @@ config TARGET_COLIBRI_IMX8X select BOARD_LATE_INIT select IMX8QXP +config TARGET_IMX8QXP_AI_ML + bool "Support i.MX8QXP AI_ML board" + select BOARD_LATE_INIT + select IMX8QXP + config TARGET_IMX8QM_MEK bool "Support i.MX8QM MEK board" select BOARD_LATE_INIT@@ -49,6 +54,7 @@ config TARGET_IMX8QXP_MEK endchoice +source "board/einfochips/imx8qxp_ai_ml/Kconfig" source "board/freescale/imx8qm_mek/Kconfig" source "board/freescale/imx8qxp_mek/Kconfig" source "board/toradex/apalis-imx8/Kconfig"(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/Kconfig new file mode 100644 index 0000000000..697a831013
board/einfochips/imx8qxp_ai_ml/Kconfig new file +12
-0@@ -0,0 +1,12 @@ +if TARGET_IMX8QXP_AI_ML + +config SYS_BOARD + default "imx8qxp_ai_ml" + +config SYS_VENDOR + default "einfochips" + +config SYS_CONFIG_NAME + default "imx8qxp_ai_ml" + +endif(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file mode 100644 index 0000000000..add0bd9431
board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file +6
-0@@ -0,0 +1,6 @@ +i.MX8QXP AI_ML BOARD +M: Manivannan Sadhasivam <[email protected]> +S: Maintained +F: board/einfochips/imx8qxp_ai_ml/ +F: include/configs/imx8qxp_ai_ml.h +F: configs/imx8qxp_ai_ml_defconfig(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/Makefile new file mode 100644 index 0000000000..e08774dc6e
board/einfochips/imx8qxp_ai_ml/Makefile new file +8
-0@@ -0,0 +1,8 @@ +# +# Copyright 2019 Linaro Ltd. +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-y += imx8qxp_ai_ml.o +obj-$(CONFIG_SPL_BUILD) += spl.o(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/README new file mode 100644 index 0000000000..488920580f
board/einfochips/imx8qxp_ai_ml/README new file +0
-0
Thank you for preparing the README file, appreciated :-).
Quoted 84 lines
board/einfochips/imx8qxp_ai_ml/README new file +17
-0@@ -0,0 +1,49 @@ +U-Boot for the Einfochips i.MX8QXP AI_ML board + +Quick Start +=========== + +- Get and Build the ARM Trusted firmware +- Get scfw_tcm.bin and ahab-container.img +- Build U-Boot +- Flash the binary into the SD card +- Boot + +Get and Build the ARM Trusted firmware +====================================== + +$ git clone https://source.codeaurora.org/external/imx/imx-atf +$ cd imx-atf/ +$ git checkout origin/imx_4.9.88_imx8qxp_beta2 -bimx_4.9.88_imx8qxp_beta2 +$ make PLAT=imx8qxp bl31
board/einfochips/imx8qxp_ai_ml/README new file +5
-0+ +Get scfw_tcm.bin and ahab-container.img +======================================= + +$ wgethttps://raw.githubusercontent.com/96boards-ai-ml/binaries/master/mx8qx-aiml-scfw-tcm.bin
+$ wget
https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.1.bin +$ chmod +x firmware-imx-8.1.bin +$ ./firmware-imx-8.1.bin +board/einfochips/imx8qxp_ai_ml/README new file +22
-0+Copy the following binaries to U-Boot folder: + +$ cp imx-atf/build/imx8qxp/release/bl31.bin . +$ cp firmware-imx-8.1/firmware/seco/mx8qx-ahab-container.img . + +Build U-Boot +============ + +$ make imx8qxp_ai_ml_defconfig +$ make u-boot-dtb.imx + +Flash the binary into the SD card +================================= + +Burn the u-boot-dtb.imx binary to SD card offset 32KB: + +$ sudo dd if=u-boot-dtb.imx of=/dev/sd[x] bs=1024 seek=32 + +Boot +==== + +Set Boot switch SW2: 1100.(quoted diff) +0
-0
b/board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.cnew file mode 100644 index 0000000000..e7632524a0board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +21
-0@@ -0,0 +1,117 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright 2018 NXP +* Copyright 2019 Linaro Ltd. +*/ + +#include <common.h> +#include <errno.h> +#include <linux/libfdt.h> +#include <environment.h> +#include <fsl_esdhc.h> +#include <asm/io.h> +#include <asm/arch/clock.h> +#include <asm/arch/sci/sci.h> +#include <asm/arch/imx8-pins.h> +#include <asm/arch/iomux.h> +#include <asm/arch/sys_proto.h> + +DECLARE_GLOBAL_DATA_PTR ; + +#define UART_PAD_CTRL ((SC_PAD_CONFIG_OUT_IN <<
PADRING_CONFIG_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_ISO_OFF <<PADRING_LPCONFIG_SHIFT )| \
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_28FDSOI_DSE_DV_HIGH <<
PADRING_DSE_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_28FDSOI_PS_PU <<
PADRING_PULL_SHIFT)) +
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 29
Quoted 4 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +4
-0+static iomux_cfg_t uart2_pads[] = { +SC_P_UART2_RX |MUX_PAD_CTRL (UART_PAD_CTRL ), +SC_P_UART2_TX |MUX_PAD_CTRL (UART_PAD_CTRL ), +};
As fair as I see - the uart could be configured via DTS (by using the pinmux driver) as this is the U-Boot proper file.
Quoted 20 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +4
-0+ +static void setup_iomux_uart (void ) +{ + imx8_iomux_setup_multiple_pads(uart2_pads,
ARRAY_SIZE(uart2_pads)); +}board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +15
-0+ +int board_early_init_f (void ) +{ +sc_pm_clock_rate_t rate =SC_80MHZ ; +int ret; + +/* Set UART2 clock root to 80 MHz */ + ret =sc_pm_setup_uart (SC_R_UART_2 , rate); +if (ret) +return ret; + +setup_iomux_uart (); + +return 0 ; +}
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 59
Quoted 10 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +10
-0+ +#if IS_ENABLED (CONFIG_DM_GPIO ) +static void board_gpio_init (void ) +{ +/* TODO */ +} +#else +static inline void board_gpio_init (void ) {} +#endif +
I'm wondering if the above function is needed?
Quoted 24 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +24
-0+#if IS_ENABLED (CONFIG_FEC_MXC ) +#include <miiphy.h> + +int board_phy_config (struct phy_device *phydev) +{ +phy_write (phydev,MDIO_DEVAD_NONE ,0x1d ,0x1f ); +phy_write (phydev,MDIO_DEVAD_NONE ,0x1e ,0x8 ); + +phy_write (phydev,MDIO_DEVAD_NONE ,0x1d ,0x05 ); +phy_write (phydev,MDIO_DEVAD_NONE ,0x1e ,0x100 ); + +if (phydev->drv->config) + phydev->drv->config (phydev); + +return 0 ; +} +#endif + +int checkboard (void ) +{ +puts ("Board: iMX8QXP AI_ML\n" ); + +build_info (); +print_bootinfo ();
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 93
Quoted 10 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +10
-0+ +return 0 ; +} + +int board_init (void ) +{ +board_gpio_init (); + +return 0 ; +}
Here you call the empty board_gpio_init().
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 100
Quoted 7 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +7
-0+ +/* Board specific reset that is system reset */ + +void reset_cpu (ulong addr) +{ +/* TODO */ +}
Maybe you could use the SYSRESET driver from the outset? It internally uses WDT for reset.
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 112
Quoted 12 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +12
-0+ +#ifdef CONFIG_OF_BOARD_SETUP +int ft_board_setup (void *blob,bd_t *bd) +{ +return 0 ; +} +#endif + +int board_mmc_get_env_dev (int devno) +{ +return devno; +}
This (the device and its instance) could be set in Kconfig.
Quoted 58 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +5
-0+ +int board_late_init (void ) +{ +return 0 ; +}(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/imximage.cfg new file mode 100644 index 0000000000..4fc5ade313
board/einfochips/imx8qxp_ai_ml/imximage.cfg new file +24
-0@@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2018 NXP + * + * Refer doc/README.imx8image for more details about how-to configure + * and create imx8image boot image + */ + +#define __ASSEMBLY__ + +/* Boot from SD, sector size 0x400 */ +BOOT_FROM SD 0x400 +/* SoC type IMX8QX */ +SOC_TYPE IMX8QX +/* Append seco container image */ +APPEND mx8qx-ahab-container.img +/* Create the 2nd container */ +CONTAINER +/* Add scfw image with exec attribute */ +IMAGE SCU mx8qx-aiml-scfw-tcm.bin +/* Add ATF image with exec attribute */ +IMAGE A35 bl31.bin 0x80000000 +/* Add U-Boot image with load attribute */ +DATA A35 u-boot-dtb.bin 0x80020000(quoted diff) +0
-0
b/board/einfochips/imx8qxp_ai_ml/spl.cnew file mode 100644 index 0000000000..63581eeaafboard/einfochips/imx8qxp_ai_ml/spl.c new file +17
-0@@ -0,0 +1,49 @@ +/* +* Copyright 2018 NXP +* +* SPDX-License-Identifier: GPL-2.0+ +*/ + +#include <common.h> +#include <dm.h> +#include <spl.h> +#include <dm/uclass.h> +#include <dm/device.h> +#include <dm/uclass-internal.h> +#include <dm/device-internal.h> +#include <dm/lists.h> + +DECLARE_GLOBAL_DATA_PTR ; +
board/einfochips/imx8qxp_ai_ml/spl.c line 27
Quoted 10 lines
board/einfochips/imx8qxp_ai_ml/spl.c new file +10
-0+void spl_board_init (void ) +{ +struct udevice *dev; + +uclass_find_first_device (UCLASS_MISC , &dev); + +for (; dev;uclass_find_next_device (&dev)) { +if (device_probe (dev)) +continue ; + }
What devices needs to be initialized in that way ?
Quoted 145 lines
board/einfochips/imx8qxp_ai_ml/spl.c new file +22
-0+ +arch_cpu_init (); + +board_early_init_f (); + +timer_init (); + +preloader_console_init (); + +puts ("Normal Boot\n" ); +} + +void board_init_f (ulong dummy) +{ +/* Clear global data */ +memset ((void *)gd,0 ,sizeof (gd_t)); + +/* Clear the BSS. */ +memset (__bss_start,0 , __bss_end - __bss_start); + +board_init_r (NULL ,0 ); +}(quoted diff) +0
-0b/configs/imx8qxp_ai_ml_defconfig new file mode 100644 index 0000000000..e20a0c783e
configs/imx8qxp_ai_ml_defconfig new file +83
-0@@ -0,0 +1,83 @@ +CONFIG_ARM=y +CONFIG_ARCH_IMX8=y +CONFIG_SYS_TEXT_BASE=0x80020000 +CONFIG_DISTRO_DEFAULTS=y +CONFIG_SPL_GPIO_SUPPORT=y +CONFIG_SPL_LIBCOMMON_SUPPORT=y +CONFIG_SPL_LIBGENERIC_SUPPORT=y +CONFIG_SYS_MALLOC_F_LEN=0x4000 +CONFIG_TARGET_IMX8QXP_AI_ML=y +CONFIG_SPL_MMC_SUPPORT=y +CONFIG_SPL_SERIAL_SUPPORT=y +CONFIG_SPL_DRIVERS_MISC_SUPPORT=y +CONFIG_NR_DRAM_BANKS=4 +CONFIG_SPL=y +CONFIG_FIT=y +CONFIG_SPL_LOAD_FIT=y +CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/einfochips/imx8qxp_ai_ml/imximage.cfg" +CONFIG_BOOTDELAY=3 +CONFIG_LOG=y +CONFIG_SPL_BOARD_INIT=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y +CONFIG_SPL_SEPARATE_BSS=y +CONFIG_SPL_POWER_SUPPORT=y +CONFIG_SPL_POWER_DOMAIN=y +CONFIG_SPL_WATCHDOG_SUPPORT=y +CONFIG_HUSH_PARSER=y +CONFIG_CMD_CPU=y +# CONFIG_CMD_IMPORTENV is not set +CONFIG_CMD_CLK=y +CONFIG_CMD_DM=y +CONFIG_CMD_FUSE=y +CONFIG_CMD_GPIO=y +CONFIG_CMD_GPT=y +CONFIG_CMD_I2C=y +CONFIG_CMD_MMC=y +CONFIG_CMD_DHCP=y +CONFIG_CMD_MII=y +CONFIG_CMD_PING=y +CONFIG_CMD_CACHE=y +CONFIG_CMD_EXT4=y +CONFIG_CMD_EXT4_WRITE=y +CONFIG_CMD_FAT=y +CONFIG_FAT_WRITE=y +CONFIG_CMD_FS_GENERIC=y +CONFIG_SPL_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qxp-ai_ml" +CONFIG_ENV_IS_IN_MMC=y +CONFIG_SPL_DM=y +CONFIG_SPL_CLK=y +CONFIG_CLK_IMX8=y +CONFIG_CPU=y +CONFIG_DM_GPIO=y +CONFIG_MXC_GPIO=y +CONFIG_DM_I2C=y +CONFIG_SYS_I2C_IMX_LPI2C=y +CONFIG_MISC=y +CONFIG_DM_MMC=y +CONFIG_FSL_ESDHC=y +CONFIG_PHYLIB=y +CONFIG_PHY_ADDR_ENABLE=y +CONFIG_PHY_ATHEROS=y +CONFIG_DM_ETH=y +CONFIG_NET_RANDOM_ETHADDR=y +CONFIG_PHY_GIGE=y +CONFIG_FEC_MXC_SHARE_MDIO=y +CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 +CONFIG_FEC_MXC=y +CONFIG_MII=y +CONFIG_PINCTRL=y +CONFIG_SPL_PINCTRL=y +CONFIG_PINCTRL_IMX8=y +CONFIG_POWER_DOMAIN=y +CONFIG_IMX8_POWER_DOMAIN=y +CONFIG_DM_REGULATOR=y +CONFIG_SPL_DM_REGULATOR=y +CONFIG_DM_REGULATOR_FIXED=y +CONFIG_DM_REGULATOR_GPIO=y +CONFIG_SPL_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +CONFIG_FSL_LPUART=y +CONFIG_SPL_TINY_MEMSET=y +# CONFIG_EFI_LOADER is not set(quoted diff) +0
-0
b/include/configs/imx8qxp_ai_ml.hnew file mode 100644 index 0000000000..dd31189845include/configs/imx8qxp_ai_ml.h new file +14
-0@@ -0,0 +1,104 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright 2018 NXP +* Copyright 2019 Linaro Ltd. +*/ + +#ifndef __IMX8QXP_AI_ML_H +#define __IMX8QXP_AI_ML_H + +#include <linux/sizes.h> +#include <asm/arch/imx-regs.h> + +#ifdef CONFIG_SPL_BUILD +#define CONFIG_SPL_MAX_SIZE (124 *1024) +#define
CONFIG_SYS_MONITOR_LEN
(1024 * 1024) +#defineCONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTORinclude/configs/imx8qxp_ai_ml.h new file +4
-0+#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 0x250 +#define CONFIG_SYS_MMCSD_FS_BOOT_PARTITION 0 + +#define
CONFIG_SPL_LDSCRIPT"arch/arm/cpu/armv8/u-boot-spl.lds"
+#defineCONFIG_SPL_STACK0x013E000+#defineCONFIG_SPL_BSS_START_ADDR0x00128000+#defineCONFIG_SPL_BSS_MAX_SIZE0x1000/* 4 KB */
+#defineCONFIG_SYS_SPL_MALLOC_START0x00120000+#defineCONFIG_SYS_SPL_MALLOC_SIZE0x3000/* 12 KB */ +#defineCONFIG_SERIAL_LPUART_BASE0x5a080000+#defineCONFIG_MALLOC_F_ADDR0x00120000+
include/configs/imx8qxp_ai_ml.h line 33
Quoted 5 lines
include/configs/imx8qxp_ai_ml.h new file +5
-0+#define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE + +#define CONFIG_SPL_ABORT_ON_RAW_IMAGE + +#define CONFIG_OF_EMBED
I'm not sure if the OF_EMBED is not deprecated ... and replaced by OF_SEPARATED.
include/configs/imx8qxp_ai_ml.h line 38
Quoted 5 lines
include/configs/imx8qxp_ai_ml.h new file +5
-0+#endif + +#define CONFIG_REMAKE_ELF + +#define CONFIG_BOARD_EARLY_INIT_F
This could be set in Kconfig, IIRC
Quoted 42 lines
include/configs/imx8qxp_ai_ml.h new file +29
-0+ +/* Flat Device Tree Definitions */ +#define CONFIG_OF_BOARD_SETUP + +#define CONFIG_FSL_USDHC + +#define CONFIG_ENV_OVERWRITE + +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define BOOT_TARGET_DEVICES (func) \ + func(MMC, mmc, 1) \ + func(DHCP, dhcp, na) + +#include <config_distro_bootcmd.h> +/* Initial environment variables */ +#define CONFIG_EXTRA_ENV_SETTINGS \ + "console=ttyLP2 earlycon\0" \ + "fdt_addr_r=0x83000000\0" \ + "kernel_addr_r=0x81000000\0" \ + "ramdisk_addr_r=0x94400000\0" \ + "scriptaddr=0x89000000\0" \ + "fdtfile=imx8qxp-ai_ml.dtb\0" \ + "fdt_high=0xffffffffffffffff\0" \ + "image=Image\0" \ + "initrd_addr=0x83800000\0" \ + "initrd_high=0xffffffffffffffff\0" \ + "netargs=setenv bootargs console=${console},${baudrate} " \ + "root=/dev/nfs ip=dhcpnfsroot=${serverip}:${nfsroot},v3,tcp" \
include/configs/imx8qxp_ai_ml.h new file +2
-0+"\0" \ + "nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp${fdt_addr} " \
include/configs/imx8qxp_ai_ml.h new file +1
-0+ "imx8qxp-ai_ml/${fdt_file}; booti ${loadaddr} -${fdt_addr}\0" \
include/configs/imx8qxp_ai_ml.h new file +7
-0+ BOOTENV + +/* Link Definitions */ +#define CONFIG_LOADADDR 0x80280000 + +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR +
include/configs/imx8qxp_ai_ml.h line 87
Quoted 10 lines
include/configs/imx8qxp_ai_ml.h new file +10
-0+#define CONFIG_SYS_INIT_SP_ADDR 0x80200000 + +/* Default environment is in SD */ +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_OFFSET (64 * SZ_64K) + +/* USDHC2 is the SD card interface */ +#define CONFIG_SYS_MMC_ENV_DEV 1/* USDHC2 */ +#define CONFIG_SYS_FSL_USDHC_NUM 2 +
Some of those env setting defines as well as eMMC ones could be set now in Kconfig.
include/configs/imx8qxp_ai_ml.h
Quoted 7 lines
include/configs/imx8qxp_ai_ml.h new file +2
-0+/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN ((CONFIG_ENV_SIZE + (32* 1024)) * 1024) +
include/configs/imx8qxp_ai_ml.h new file +4
-0+#define CONFIG_SYS_SDRAM_BASE 0x80000000 +#define PHYS_SDRAM_1 0x80000000 +#define PHYS_SDRAM_2 0x880000000 +#define PHYS_SDRAM_1_SIZE SZ_2G/* 2
Please fix this file globally, to use "SZ_XX" instead of magic numbers.
include/configs/imx8qxp_ai_ml.h line 104
Quoted 10 lines
GB */ +#define
PHYS_SDRAM_2_SIZE0x00000000/*
0 GB */ +include/configs/imx8qxp_ai_ml.h new file +8
-0+/* Generic Timer Definitions */ +#define COUNTER_FREQUENCY 8000000/* 8MHz */ + +/* Networking */ +#define CONFIG_FEC_XCV_TYPE RGMII +#define FEC_QUIRK_ENET_MAC + +#endif /* __IMX8QXP_AI_ML_H */
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190724/1f8ae3f9/attachment.sig>
PATCH v4 2/2 board: Add support for iMX8QXP AI_ML board
Hi Lukasz,
Thanks for the review!
Quoted 199 lines · Lukasz Majewski
Hi Manivannan,
board/einfochips/imx8qxp_ai_ml/README
Quoted 111 lines
This commit adds initial board support for iMX8QXP
AI_MLboard from Einfochips. This board is one of the 96Boards Consumer Edition and AI boards of the 96Boards family based on i.MX8QXP SoC from NXP/Freescale.This initial supports contains following peripherals which are tested and known to work:
1. Debug serial via UART2
2. SD card
3. EthernetMore information about this board can be found in arrow website:
https://www.arrow.com/en/products/imx8-ai-ml/arrow-development-toolsSigned-off-by: Manivannan Sadhasivam
<[email protected]> ---arch/arm/mach-imx/imx8/Kconfig | 6 + board/einfochips/imx8qxp_ai_ml/Kconfig | 12 ++ board/einfochips/imx8qxp_ai_ml/MAINTAINERS | 6 + board/einfochips/imx8qxp_ai_ml/Makefile | 8 ++ board/einfochips/imx8qxp_ai_ml/README | 49 ++++++++ .../einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c | 117 ++++++++++++++++++ board/einfochips/imx8qxp_ai_ml/imximage.cfg | 24 ++++ board/einfochips/imx8qxp_ai_ml/spl.c | 49 ++++++++ configs/imx8qxp_ai_ml_defconfig | 83 +++++++++++++ include/configs/imx8qxp_ai_ml.h | 104 ++++++++++++++++ 10 files changed, 458 insertions(+) create mode 100644 board/einfochips/imx8qxp_ai_ml/Kconfig create mode 100644 board/einfochips/imx8qxp_ai_ml/MAINTAINERS create mode 100644 board/einfochips/imx8qxp_ai_ml/Makefile create mode 100644 board/einfochips/imx8qxp_ai_ml/README create mode 100644 board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c create mode 100644 board/einfochips/imx8qxp_ai_ml/imximage.cfg create mode 100644 board/einfochips/imx8qxp_ai_ml/spl.c create mode 100644 configs/imx8qxp_ai_ml_defconfig create mode 100644 include/configs/imx8qxp_ai_ml.h(quoted diff) +0
-0b/arch/arm/mach-imx/imx8/Kconfig index
bbe323d5ca..cec21f8dd2100644arch/arm/mach-imx/imx8/Kconfig +6
-0@@ -37,6 +37,11 @@ config TARGET_COLIBRI_IMX8X select BOARD_LATE_INIT select IMX8QXP +config TARGET_IMX8QXP_AI_ML + bool "Support i.MX8QXP AI_ML board" + select BOARD_LATE_INIT + select IMX8QXP + config TARGET_IMX8QM_MEK bool "Support i.MX8QM MEK board" select BOARD_LATE_INIT@@ -49,6 +54,7 @@ config TARGET_IMX8QXP_MEK endchoice +source "board/einfochips/imx8qxp_ai_ml/Kconfig" source "board/freescale/imx8qm_mek/Kconfig" source "board/freescale/imx8qxp_mek/Kconfig" source "board/toradex/apalis-imx8/Kconfig"(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/Kconfig new file mode 100644 index 0000000000..697a831013
board/einfochips/imx8qxp_ai_ml/Kconfig new file +12
-0@@ -0,0 +1,12 @@ +if TARGET_IMX8QXP_AI_ML + +config SYS_BOARD + default "imx8qxp_ai_ml" + +config SYS_VENDOR + default "einfochips" + +config SYS_CONFIG_NAME + default "imx8qxp_ai_ml" + +endif(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file mode 100644 index 0000000000..add0bd9431
board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file +6
-0@@ -0,0 +1,6 @@ +i.MX8QXP AI_ML BOARD +M: Manivannan Sadhasivam <[email protected]> +S: Maintained +F: board/einfochips/imx8qxp_ai_ml/ +F: include/configs/imx8qxp_ai_ml.h +F: configs/imx8qxp_ai_ml_defconfig(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/Makefile new file mode 100644 index 0000000000..e08774dc6e
board/einfochips/imx8qxp_ai_ml/Makefile new file +8
-0@@ -0,0 +1,8 @@ +# +# Copyright 2019 Linaro Ltd. +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-y += imx8qxp_ai_ml.o +obj-$(CONFIG_SPL_BUILD) += spl.o(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/README new file mode 100644 index 0000000000..488920580f
board/einfochips/imx8qxp_ai_ml/README new file +0
-0Thank you for preparing the README file, appreciated :-).
Quoted 83 lines
board/einfochips/imx8qxp_ai_ml/README new file +17
-0@@ -0,0 +1,49 @@ +U-Boot for the Einfochips i.MX8QXP AI_ML board + +Quick Start +=========== + +- Get and Build the ARM Trusted firmware +- Get scfw_tcm.bin and ahab-container.img +- Build U-Boot +- Flash the binary into the SD card +- Boot + +Get and Build the ARM Trusted firmware +====================================== + +$ git clone https://source.codeaurora.org/external/imx/imx-atf +$ cd imx-atf/ +$ git checkout origin/imx_4.9.88_imx8qxp_beta2 -bimx_4.9.88_imx8qxp_beta2 +$ make PLAT=imx8qxp bl31
board/einfochips/imx8qxp_ai_ml/README new file +5
-0+ +Get scfw_tcm.bin and ahab-container.img +======================================= + +$ wgethttps://raw.githubusercontent.com/96boards-ai-ml/binaries/master/mx8qx-aiml-scfw-tcm.bin
+$ wget
https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.1.bin +$ chmod +x firmware-imx-8.1.bin +$ ./firmware-imx-8.1.bin +board/einfochips/imx8qxp_ai_ml/README new file +22
-0+Copy the following binaries to U-Boot folder: + +$ cp imx-atf/build/imx8qxp/release/bl31.bin . +$ cp firmware-imx-8.1/firmware/seco/mx8qx-ahab-container.img . + +Build U-Boot +============ + +$ make imx8qxp_ai_ml_defconfig +$ make u-boot-dtb.imx + +Flash the binary into the SD card +================================= + +Burn the u-boot-dtb.imx binary to SD card offset 32KB: + +$ sudo dd if=u-boot-dtb.imx of=/dev/sd[x] bs=1024 seek=32 + +Boot +==== + +Set Boot switch SW2: 1100.(quoted diff) +0
-0
b/board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.cnew file mode 100644 index 0000000000..e7632524a0board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +21
-0@@ -0,0 +1,117 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright 2018 NXP +* Copyright 2019 Linaro Ltd. +*/ + +#include <common.h> +#include <errno.h> +#include <linux/libfdt.h> +#include <environment.h> +#include <fsl_esdhc.h> +#include <asm/io.h> +#include <asm/arch/clock.h> +#include <asm/arch/sci/sci.h> +#include <asm/arch/imx8-pins.h> +#include <asm/arch/iomux.h> +#include <asm/arch/sys_proto.h> + +DECLARE_GLOBAL_DATA_PTR ; + +#define UART_PAD_CTRL ((SC_PAD_CONFIG_OUT_IN <<
PADRING_CONFIG_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_ISO_OFF <<PADRING_LPCONFIG_SHIFT )| \
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_28FDSOI_DSE_DV_HIGH <<
PADRING_DSE_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_28FDSOI_PS_PU <<
Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 29
Quoted 5 lines
PADRING_PULL_SHIFT)) +board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +4
-0+static iomux_cfg_t uart2_pads[] = { +SC_P_UART2_RX |MUX_PAD_CTRL (UART_PAD_CTRL ), +SC_P_UART2_TX |MUX_PAD_CTRL (UART_PAD_CTRL ), +};As fair as I see - the uart could be configured via DTS (by using the pinmux driver) as this is the U-Boot proper file.
Agree, this is not needed.
Quoted 24 lines
Quoted 24 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +4
-0+ +static void setup_iomux_uart (void ) +{ + imx8_iomux_setup_multiple_pads(uart2_pads,
ARRAY_SIZE(uart2_pads)); +}board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +19
-0+ +int board_early_init_f (void ) +{ +sc_pm_clock_rate_t rate =SC_80MHZ ; +int ret; + +/* Set UART2 clock root to 80 MHz */ + ret =sc_pm_setup_uart (SC_R_UART_2 , rate); +if (ret) +return ret; + +setup_iomux_uart (); + +return 0 ; +} + +#if IS_ENABLED (CONFIG_DM_GPIO ) +static void board_gpio_init (void ) +{
Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 59
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +6
-0+ /* TODO */ +} +#else +static inline void board_gpio_init (void ) {} +#endif +I'm wondering if the above function is needed?
I thought about keeping this as I may add some gpio configurations in future. But, yeah I can remove it now and add once needed.
Quoted 28 lines
Quoted 28 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +28
-0+#if IS_ENABLED (CONFIG_FEC_MXC ) +#include <miiphy.h> + +int board_phy_config (struct phy_device *phydev) +{ +phy_write (phydev,MDIO_DEVAD_NONE ,0x1d ,0x1f ); +phy_write (phydev,MDIO_DEVAD_NONE ,0x1e ,0x8 ); + +phy_write (phydev,MDIO_DEVAD_NONE ,0x1d ,0x05 ); +phy_write (phydev,MDIO_DEVAD_NONE ,0x1e ,0x100 ); + +if (phydev->drv->config) + phydev->drv->config (phydev); + +return 0 ; +} +#endif + +int checkboard (void ) +{ +puts ("Board: iMX8QXP AI_ML\n" ); + +build_info (); +print_bootinfo (); + +return 0 ; +} +
Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 93
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +6
-0+int board_init (void ) +{ +board_gpio_init (); + +return 0 ; +}Here you call the empty
board_gpio_init().
As per above comment, I'll remove it.
Quoted 11 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 100
Quoted 7 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +7
-0+ +/* Board specific reset that is system reset */ + +void reset_cpu (ulong addr) +{ +/* TODO */ +}Maybe you could use the SYSRESET driver from the outset? It internally uses WDT for reset.
Hmm, looks like there is no watchdog driver for imx8qxp yet.
Quoted 6 lines
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +6
-0+ +#ifdef CONFIG_OF_BOARD_SETUP +int ft_board_setup (void *blob,bd_t *bd) +{ +return 0 ; +}
Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 112
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +6
-0+#endif + +int board_mmc_get_env_dev (int devno) +{ +return devno; +}This (the device and its instance) could be set in
Kconfig.
Ack.
Quoted 62 lines
Quoted 62 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +5
-0+ +int board_late_init (void ) +{ +return 0 ; +}(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/imximage.cfg new file mode 100644 index 0000000000..4fc5ade313
board/einfochips/imx8qxp_ai_ml/imximage.cfg new file +24
-0@@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2018 NXP + * + * Refer doc/README.imx8image for more details about how-to configure + * and create imx8image boot image + */ + +#define __ASSEMBLY__ + +/* Boot from SD, sector size 0x400 */ +BOOT_FROM SD 0x400 +/* SoC type IMX8QX */ +SOC_TYPE IMX8QX +/* Append seco container image */ +APPEND mx8qx-ahab-container.img +/* Create the 2nd container */ +CONTAINER +/* Add scfw image with exec attribute */ +IMAGE SCU mx8qx-aiml-scfw-tcm.bin +/* Add ATF image with exec attribute */ +IMAGE A35 bl31.bin 0x80000000 +/* Add U-Boot image with load attribute */ +DATA A35 u-boot-dtb.bin 0x80020000(quoted diff) +0
-0
b/board/einfochips/imx8qxp_ai_ml/spl.cnew file mode 100644 index 0000000000..63581eeaafboard/einfochips/imx8qxp_ai_ml/spl.c new file +21
-0@@ -0,0 +1,49 @@ +/* +* Copyright 2018 NXP +* +* SPDX-License-Identifier: GPL-2.0+ +*/ + +#include <common.h> +#include <dm.h> +#include <spl.h> +#include <dm/uclass.h> +#include <dm/device.h> +#include <dm/uclass-internal.h> +#include <dm/device-internal.h> +#include <dm/lists.h> + +DECLARE_GLOBAL_DATA_PTR ; + +void spl_board_init (void ) +{ +struct udevice *dev; +
Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/spl.c line 27
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/spl.c new file +6
-0+uclass_find_first_device (UCLASS_MISC , &dev); + +for (; dev;uclass_find_next_device (&dev)) { +if (device_probe (dev)) +continue ; + }What devices needs to be initialized in that way ?
Mostly SCU but it is not needed, so I'll remove it.
Quoted 145 lines
Quoted 145 lines
board/einfochips/imx8qxp_ai_ml/spl.c new file +22
-0+ +arch_cpu_init (); + +board_early_init_f (); + +timer_init (); + +preloader_console_init (); + +puts ("Normal Boot\n" ); +} + +void board_init_f (ulong dummy) +{ +/* Clear global data */ +memset ((void *)gd,0 ,sizeof (gd_t)); + +/* Clear the BSS. */ +memset (__bss_start,0 , __bss_end - __bss_start); + +board_init_r (NULL ,0 ); +}(quoted diff) +0
-0b/configs/imx8qxp_ai_ml_defconfig new file mode 100644 index 0000000000..e20a0c783e
configs/imx8qxp_ai_ml_defconfig new file +83
-0@@ -0,0 +1,83 @@ +CONFIG_ARM=y +CONFIG_ARCH_IMX8=y +CONFIG_SYS_TEXT_BASE=0x80020000 +CONFIG_DISTRO_DEFAULTS=y +CONFIG_SPL_GPIO_SUPPORT=y +CONFIG_SPL_LIBCOMMON_SUPPORT=y +CONFIG_SPL_LIBGENERIC_SUPPORT=y +CONFIG_SYS_MALLOC_F_LEN=0x4000 +CONFIG_TARGET_IMX8QXP_AI_ML=y +CONFIG_SPL_MMC_SUPPORT=y +CONFIG_SPL_SERIAL_SUPPORT=y +CONFIG_SPL_DRIVERS_MISC_SUPPORT=y +CONFIG_NR_DRAM_BANKS=4 +CONFIG_SPL=y +CONFIG_FIT=y +CONFIG_SPL_LOAD_FIT=y +CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/einfochips/imx8qxp_ai_ml/imximage.cfg" +CONFIG_BOOTDELAY=3 +CONFIG_LOG=y +CONFIG_SPL_BOARD_INIT=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y +CONFIG_SPL_SEPARATE_BSS=y +CONFIG_SPL_POWER_SUPPORT=y +CONFIG_SPL_POWER_DOMAIN=y +CONFIG_SPL_WATCHDOG_SUPPORT=y +CONFIG_HUSH_PARSER=y +CONFIG_CMD_CPU=y +# CONFIG_CMD_IMPORTENV is not set +CONFIG_CMD_CLK=y +CONFIG_CMD_DM=y +CONFIG_CMD_FUSE=y +CONFIG_CMD_GPIO=y +CONFIG_CMD_GPT=y +CONFIG_CMD_I2C=y +CONFIG_CMD_MMC=y +CONFIG_CMD_DHCP=y +CONFIG_CMD_MII=y +CONFIG_CMD_PING=y +CONFIG_CMD_CACHE=y +CONFIG_CMD_EXT4=y +CONFIG_CMD_EXT4_WRITE=y +CONFIG_CMD_FAT=y +CONFIG_FAT_WRITE=y +CONFIG_CMD_FS_GENERIC=y +CONFIG_SPL_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qxp-ai_ml" +CONFIG_ENV_IS_IN_MMC=y +CONFIG_SPL_DM=y +CONFIG_SPL_CLK=y +CONFIG_CLK_IMX8=y +CONFIG_CPU=y +CONFIG_DM_GPIO=y +CONFIG_MXC_GPIO=y +CONFIG_DM_I2C=y +CONFIG_SYS_I2C_IMX_LPI2C=y +CONFIG_MISC=y +CONFIG_DM_MMC=y +CONFIG_FSL_ESDHC=y +CONFIG_PHYLIB=y +CONFIG_PHY_ADDR_ENABLE=y +CONFIG_PHY_ATHEROS=y +CONFIG_DM_ETH=y +CONFIG_NET_RANDOM_ETHADDR=y +CONFIG_PHY_GIGE=y +CONFIG_FEC_MXC_SHARE_MDIO=y +CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 +CONFIG_FEC_MXC=y +CONFIG_MII=y +CONFIG_PINCTRL=y +CONFIG_SPL_PINCTRL=y +CONFIG_PINCTRL_IMX8=y +CONFIG_POWER_DOMAIN=y +CONFIG_IMX8_POWER_DOMAIN=y +CONFIG_DM_REGULATOR=y +CONFIG_SPL_DM_REGULATOR=y +CONFIG_DM_REGULATOR_FIXED=y +CONFIG_DM_REGULATOR_GPIO=y +CONFIG_SPL_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +CONFIG_FSL_LPUART=y +CONFIG_SPL_TINY_MEMSET=y +# CONFIG_EFI_LOADER is not set(quoted diff) +0
-0
b/include/configs/imx8qxp_ai_ml.hnew file mode 100644 index 0000000000..dd31189845include/configs/imx8qxp_ai_ml.h new file +14
-0@@ -0,0 +1,104 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright 2018 NXP +* Copyright 2019 Linaro Ltd. +*/ + +#ifndef __IMX8QXP_AI_ML_H +#define __IMX8QXP_AI_ML_H + +#include <linux/sizes.h> +#include <asm/arch/imx-regs.h> + +#ifdef CONFIG_SPL_BUILD +#define CONFIG_SPL_MAX_SIZE (124 *1024) +#define
CONFIG_SYS_MONITOR_LEN
(1024 * 1024) +#defineCONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTORinclude/configs/imx8qxp_ai_ml.h new file +4
-0+#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 0x250 +#define CONFIG_SYS_MMCSD_FS_BOOT_PARTITION 0 + +#define
CONFIG_SPL_LDSCRIPT"arch/arm/cpu/armv8/u-boot-spl.lds"
+#defineCONFIG_SPL_STACK0x013E000+#defineCONFIG_SPL_BSS_START_ADDR0x00128000+#defineCONFIG_SPL_BSS_MAX_SIZE0x1000/* 4 KB */
+#defineCONFIG_SYS_SPL_MALLOC_START0x00120000+#defineCONFIG_SYS_SPL_MALLOC_SIZE0x3000/* 12 KB */ +#defineCONFIG_SERIAL_LPUART_BASE0x5a080000+#defineCONFIG_MALLOC_F_ADDR0x00120000+
Quoted 9 lines
include/configs/imx8qxp_ai_ml.h line 33
Quoted 5 lines
include/configs/imx8qxp_ai_ml.h new file +5
-0+#define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE + +#define CONFIG_SPL_ABORT_ON_RAW_IMAGE + +#define CONFIG_OF_EMBED I'm not sure if the
OF_EMBEDis not deprecated ... and replaced byOF_SEPARATED.
I'm not sure about this. I don't see any such information.
Quoted 8 lines
include/configs/imx8qxp_ai_ml.h line 38
Quoted 5 lines
include/configs/imx8qxp_ai_ml.h new file +5
-0+#endif + +#define CONFIG_REMAKE_ELF + +#define CONFIG_BOARD_EARLY_INIT_F This could be set in
Kconfig, IIRC
Ack.
Quoted 47 lines
Quoted 47 lines
include/configs/imx8qxp_ai_ml.h new file +29
-0+ +/* Flat Device Tree Definitions */ +#define CONFIG_OF_BOARD_SETUP + +#define CONFIG_FSL_USDHC + +#define CONFIG_ENV_OVERWRITE + +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define BOOT_TARGET_DEVICES (func) \ + func(MMC, mmc, 1) \ + func(DHCP, dhcp, na) + +#include <config_distro_bootcmd.h> +/* Initial environment variables */ +#define CONFIG_EXTRA_ENV_SETTINGS \ + "console=ttyLP2 earlycon\0" \ + "fdt_addr_r=0x83000000\0" \ + "kernel_addr_r=0x81000000\0" \ + "ramdisk_addr_r=0x94400000\0" \ + "scriptaddr=0x89000000\0" \ + "fdtfile=imx8qxp-ai_ml.dtb\0" \ + "fdt_high=0xffffffffffffffff\0" \ + "image=Image\0" \ + "initrd_addr=0x83800000\0" \ + "initrd_high=0xffffffffffffffff\0" \ + "netargs=setenv bootargs console=${console},${baudrate} " \ + "root=/dev/nfs ip=dhcpnfsroot=${serverip}:${nfsroot},v3,tcp" \
include/configs/imx8qxp_ai_ml.h new file +2
-0+"\0" \ + "nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp${fdt_addr} " \
include/configs/imx8qxp_ai_ml.h new file +1
-0+ "imx8qxp-ai_ml/${fdt_file}; booti ${loadaddr} -${fdt_addr}\0" \
include/configs/imx8qxp_ai_ml.h new file +12
-0+ BOOTENV + +/* Link Definitions */ +#define CONFIG_LOADADDR 0x80280000 + +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR + +#define CONFIG_SYS_INIT_SP_ADDR 0x80200000 + +/* Default environment is in SD */ +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_OFFSET (64 * SZ_64K)
Quoted 9 lines
include/configs/imx8qxp_ai_ml.h line 87
Quoted 5 lines
include/configs/imx8qxp_ai_ml.h new file +5
-0+ +/* USDHC2 is the SD card interface */ +#define CONFIG_SYS_MMC_ENV_DEV 1/* USDHC2 */ +#define CONFIG_SYS_FSL_USDHC_NUM 2 +Some of those env setting defines as well as eMMC ones could be set now in
Kconfig.
Can you please specify those? I don't see these defines used in Kconfig.
Quoted 10 lines
include/configs/imx8qxp_ai_ml.h
Quoted 7 lines
include/configs/imx8qxp_ai_ml.h new file +2
-0+/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN ((CONFIG_ENV_SIZE + (32* 1024)) * 1024) +
include/configs/imx8qxp_ai_ml.h new file +4
-0+#define CONFIG_SYS_SDRAM_BASE 0x80000000 +#define PHYS_SDRAM_1 0x80000000 +#define PHYS_SDRAM_2 0x880000000 +#define PHYS_SDRAM_1_SIZE SZ_2G/* 2 Please fix this file globally, to use "
SZ_XX" instead of magic numbers.
Ack.
Thanks,
Mani
Quoted 23 lines
include/configs/imx8qxp_ai_ml.h line 104
Quoted 10 lines
GB */ +#define
PHYS_SDRAM_2_SIZE0x00000000/*
0 GB */ +include/configs/imx8qxp_ai_ml.h new file +8
-0+/* Generic Timer Definitions */ +#define COUNTER_FREQUENCY 8000000/* 8MHz */ + +/* Networking */ +#define CONFIG_FEC_XCV_TYPE RGMII +#define FEC_QUIRK_ENET_MAC + +#endif /* __IMX8QXP_AI_ML_H */ Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
PATCH v4 2/2 board: Add support for iMX8QXP AI_ML board
Hi Manivannan,
Quoted 250 lines
Hi Lukasz,
Thanks for the review!
Quoted 199 lines · Lukasz Majewski
Hi Manivannan,
board/einfochips/imx8qxp_ai_ml/README
Quoted 111 lines
This commit adds initial board support for iMX8QXP
AI_MLboard from Einfochips. This board is one of the 96Boards Consumer Edition and AI boards of the 96Boards family based on i.MX8QXP SoC from NXP/Freescale.This initial supports contains following peripherals which are tested and known to work:
1. Debug serial via UART2
2. SD card
3. EthernetMore information about this board can be found in arrow website:
https://www.arrow.com/en/products/imx8-ai-ml/arrow-development-toolsSigned-off-by: Manivannan Sadhasivam
<[email protected]> ---arch/arm/mach-imx/imx8/Kconfig | 6 + board/einfochips/imx8qxp_ai_ml/Kconfig | 12 ++ board/einfochips/imx8qxp_ai_ml/MAINTAINERS | 6 + board/einfochips/imx8qxp_ai_ml/Makefile | 8 ++ board/einfochips/imx8qxp_ai_ml/README | 49 ++++++++ .../einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c | 117++++++++++++++++++ board/einfochips/imx8qxp_ai_ml/imximage.cfg |
24 ++++board/einfochips/imx8qxp_ai_ml/spl.c| 49
++++++++ configs/imx8qxp_ai_ml_defconfig | 83
+++++++++++++include/configs/imx8qxp_ai_ml.h| 104
++++++++++++++++ 10 files changed, 458 insertions(+)create mode 100644 board/einfochips/imx8qxp_ai_ml/Kconfig create mode 100644 board/einfochips/imx8qxp_ai_ml/MAINTAINERS create mode 100644 board/einfochips/imx8qxp_ai_ml/Makefile create mode 100644 board/einfochips/imx8qxp_ai_ml/README create mode 100644 board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c create mode 100644 board/einfochips/imx8qxp_ai_ml/imximage.cfg create mode 100644 board/einfochips/imx8qxp_ai_ml/spl.c create mode 100644 configs/imx8qxp_ai_ml_defconfig create mode 100644 include/configs/imx8qxp_ai_ml.h(quoted diff) +0
-0b/arch/arm/mach-imx/imx8/Kconfig index
bbe323d5ca..cec21f8dd2100644 --- a/arch/arm/mach-imx/imx8/Kconfig
+++ b/arch/arm/mach-imx/imx8/Kconfigarch/arm/mach-imx/imx8/Kconfig +6
-0@@ -37,6 +37,11 @@ config TARGET_COLIBRI_IMX8X select BOARD_LATE_INIT select IMX8QXP +config TARGET_IMX8QXP_AI_ML + bool "Support i.MX8QXP AI_ML board" + select BOARD_LATE_INIT + select IMX8QXP + config TARGET_IMX8QM_MEK bool "Support i.MX8QM MEK board" select BOARD_LATE_INIT@@ -49,6 +54,7 @@ config TARGET_IMX8QXP_MEK endchoice +source "board/einfochips/imx8qxp_ai_ml/Kconfig" source "board/freescale/imx8qm_mek/Kconfig" source "board/freescale/imx8qxp_mek/Kconfig" source "board/toradex/apalis-imx8/Kconfig"(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/Kconfig new file mode 100644 index 0000000000..697a831013
board/einfochips/imx8qxp_ai_ml/Kconfig new file +12
-0@@ -0,0 +1,12 @@ +if TARGET_IMX8QXP_AI_ML + +config SYS_BOARD + default "imx8qxp_ai_ml" + +config SYS_VENDOR + default "einfochips" + +config SYS_CONFIG_NAME + default "imx8qxp_ai_ml" + +endif(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file mode 100644 index 0000000000..add0bd9431
board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file +2
-0@@ -0,0 +1,6 @@ +i.MX8QXP AI_ML BOARD +M: Manivannan Sadhasivam<[email protected]> +S: Maintained
board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file +3
-0+F: board/einfochips/imx8qxp_ai_ml/ +F: include/configs/imx8qxp_ai_ml.h +F: configs/imx8qxp_ai_ml_defconfig(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/Makefile new file mode 100644 index 0000000000..e08774dc6e
board/einfochips/imx8qxp_ai_ml/Makefile new file +8
-0@@ -0,0 +1,8 @@ +# +# Copyright 2019 Linaro Ltd. +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-y += imx8qxp_ai_ml.o +obj-$(CONFIG_SPL_BUILD) += spl.o(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/README new file mode 100644 index 0000000000..488920580f
board/einfochips/imx8qxp_ai_ml/README new file +0
-0Thank you for preparing the README file, appreciated :-).
Quoted 83 lines
board/einfochips/imx8qxp_ai_ml/README new file +17
-0@@ -0,0 +1,49 @@ +U-Boot for the Einfochips i.MX8QXP AI_ML board + +Quick Start +=========== + +- Get and Build the ARM Trusted firmware +- Get scfw_tcm.bin and ahab-container.img +- Build U-Boot +- Flash the binary into the SD card +- Boot + +Get and Build the ARM Trusted firmware +====================================== + +$ git clone https://source.codeaurora.org/external/imx/imx-atf +$ cd imx-atf/ +$ git checkout origin/imx_4.9.88_imx8qxp_beta2 -bimx_4.9.88_imx8qxp_beta2 +$ make PLAT=imx8qxp bl31
board/einfochips/imx8qxp_ai_ml/README new file +5
-0+ +Get scfw_tcm.bin and ahab-container.img +======================================= + +$ wgethttps://raw.githubusercontent.com/96boards-ai-ml/binaries/master/mx8qx-aiml-scfw-tcm.bin
+$ wget
https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.1.bin +$ chmod +x firmware-imx-8.1.bin +$ ./firmware-imx-8.1.bin +board/einfochips/imx8qxp_ai_ml/README new file +22
-0+Copy the following binaries to U-Boot folder: + +$ cp imx-atf/build/imx8qxp/release/bl31.bin . +$ cp firmware-imx-8.1/firmware/seco/mx8qx-ahab-container.img . + +Build U-Boot +============ + +$ make imx8qxp_ai_ml_defconfig +$ make u-boot-dtb.imx + +Flash the binary into the SD card +================================= + +Burn the u-boot-dtb.imx binary to SD card offset 32KB: + +$ sudo dd if=u-boot-dtb.imx of=/dev/sd[x] bs=1024 seek=32 + +Boot +==== + +Set Boot switch SW2: 1100.(quoted diff) +0
-0
b/board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.cnew file mode 100644 index 0000000000..e7632524a0board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +21
-0@@ -0,0 +1,117 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright 2018 NXP +* Copyright 2019 Linaro Ltd. +*/ + +#include <common.h> +#include <errno.h> +#include <linux/libfdt.h> +#include <environment.h> +#include <fsl_esdhc.h> +#include <asm/io.h> +#include <asm/arch/clock.h> +#include <asm/arch/sci/sci.h> +#include <asm/arch/imx8-pins.h> +#include <asm/arch/iomux.h> +#include <asm/arch/sys_proto.h> + +DECLARE_GLOBAL_DATA_PTR ; + +#define UART_PAD_CTRL ((SC_PAD_CONFIG_OUT_IN <<
PADRING_CONFIG_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_ISO_OFF <<
PADRING_LPCONFIG_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_28FDSOI_DSE_DV_HIGH <<
PADRING_DSE_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_28FDSOI_PS_PU <<Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 29
Quoted 5 lines
PADRING_PULL_SHIFT)) +board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +4
-0+static iomux_cfg_t uart2_pads[] = { +SC_P_UART2_RX |MUX_PAD_CTRL (UART_PAD_CTRL ), +SC_P_UART2_TX |MUX_PAD_CTRL (UART_PAD_CTRL ), +};As fair as I see - the uart could be configured via DTS (by using the pinmux driver) as this is the U-Boot proper file.
Agree, this is not needed.
Quoted 24 lines
Quoted 24 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +4
-0+ +static void setup_iomux_uart (void ) +{ + imx8_iomux_setup_multiple_pads(uart2_pads,
ARRAY_SIZE(uart2_pads)); +}board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +19
-0+ +int board_early_init_f (void ) +{ +sc_pm_clock_rate_t rate =SC_80MHZ ; +int ret; + +/* Set UART2 clock root to 80 MHz */ + ret =sc_pm_setup_uart (SC_R_UART_2 , rate); +if (ret) +return ret; + +setup_iomux_uart (); + +return 0 ; +} + +#if IS_ENABLED (CONFIG_DM_GPIO ) +static void board_gpio_init (void ) +{Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 59
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +6
-0+ /* TODO */ +} +#else +static inline void board_gpio_init (void ) {} +#endif +I'm wondering if the above function is needed?
Quoted 2 lines
I thought about keeping this as I may add some gpio configurations in future. But, yeah I can remove it now and add once needed.
The general rule is to avoid adding any dead (i.e. not used) code to the main line.
The practical reason for it is to have the code base as small as possible. Moreover, the patch, which adds this board is rather large, so in that way we make it smaller.
This code shall be added when you introduce the GPIO needed for this board.
Quoted 53 lines
Quoted 29 lines
Quoted 29 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +28
-0+#if IS_ENABLED (CONFIG_FEC_MXC ) +#include <miiphy.h> + +int board_phy_config (struct phy_device *phydev) +{ +phy_write (phydev,MDIO_DEVAD_NONE ,0x1d ,0x1f ); +phy_write (phydev,MDIO_DEVAD_NONE ,0x1e ,0x8 ); + +phy_write (phydev,MDIO_DEVAD_NONE ,0x1d ,0x05 ); +phy_write (phydev,MDIO_DEVAD_NONE ,0x1e ,0x100 ); + +if (phydev->drv->config) + phydev->drv->config (phydev); + +return 0 ; +} +#endif + +int checkboard (void ) +{ +puts ("Board: iMX8QXP AI_ML\n" ); + +build_info (); +print_bootinfo (); + +return 0 ; +} +Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 93
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +6
-0+int board_init (void ) +{ +board_gpio_init (); + +return 0 ; +}Here you call the empty
board_gpio_init().As per above comment, I'll remove it.
Quoted 11 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 100
Quoted 7 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +7
-0+ +/* Board specific reset that is system reset */ + +void reset_cpu (ulong addr) +{ +/* TODO */ +}Maybe you could use the SYSRESET driver from the outset? It internally uses WDT for reset.
Quoted 1 line
Hmm, looks like there is no watchdog driver for imx8qxp yet.
If I may ask - how do you plan to reset the board? On most i.MX boards the reset is done by triggering the WDT.
Quoted 92 lines
Quoted 16 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 112
Quoted 13 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +12
-0+ +#ifdef CONFIG_OF_BOARD_SETUP +int ft_board_setup (void *blob,bd_t *bd) +{ +return 0 ; +} +#endif + +int board_mmc_get_env_dev (int devno) +{ +return devno; +}This (the device and its instance) could be set in
Kconfig.Ack.
Quoted 63 lines
Quoted 63 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +5
-0+ +int board_late_init (void ) +{ +return 0 ; +}(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/imximage.cfg new file mode 100644 index 0000000000..4fc5ade313
board/einfochips/imx8qxp_ai_ml/imximage.cfg new file +5
-0@@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2018 NXP + * + * Refer doc/README.imx8image for more details about how-toconfigure
+ * and create imx8image boot image
+ */board/einfochips/imx8qxp_ai_ml/imximage.cfg new file +17
-0+ +#define __ASSEMBLY__ + +/* Boot from SD, sector size 0x400 */ +BOOT_FROM SD 0x400 +/* SoC type IMX8QX */ +SOC_TYPE IMX8QX +/* Append seco container image */ +APPEND mx8qx-ahab-container.img +/* Create the 2nd container */ +CONTAINER +/* Add scfw image with exec attribute */ +IMAGE SCU mx8qx-aiml-scfw-tcm.bin +/* Add ATF image with exec attribute */ +IMAGE A35 bl31.bin 0x80000000 +/* Add U-Boot image with load attribute */ +DATA A35 u-boot-dtb.bin 0x80020000(quoted diff) +0
-0
b/board/einfochips/imx8qxp_ai_ml/spl.cnew file mode 100644 index 0000000000..63581eeaafboard/einfochips/imx8qxp_ai_ml/spl.c new file +21
-0@@ -0,0 +1,49 @@ +/* +* Copyright 2018 NXP +* +* SPDX-License-Identifier: GPL-2.0+ +*/ + +#include <common.h> +#include <dm.h> +#include <spl.h> +#include <dm/uclass.h> +#include <dm/device.h> +#include <dm/uclass-internal.h> +#include <dm/device-internal.h> +#include <dm/lists.h> + +DECLARE_GLOBAL_DATA_PTR ; + +void spl_board_init (void ) +{ +struct udevice *dev; +Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/spl.c line 27
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/spl.c new file +6
-0+uclass_find_first_device (UCLASS_MISC , &dev); + +for (; dev;uclass_find_next_device (&dev)) { +if (device_probe (dev)) +continue ; + }What devices needs to be initialized in that way ?
Quoted 1 line
Mostly SCU but it is not needed, so I'll remove it.
Ok.
Quoted 156 lines
Quoted 146 lines
Quoted 146 lines
board/einfochips/imx8qxp_ai_ml/spl.c new file +22
-0+ +arch_cpu_init (); + +board_early_init_f (); + +timer_init (); + +preloader_console_init (); + +puts ("Normal Boot\n" ); +} + +void board_init_f (ulong dummy) +{ +/* Clear global data */ +memset ((void *)gd,0 ,sizeof (gd_t)); + +/* Clear the BSS. */ +memset (__bss_start,0 , __bss_end - __bss_start); + +board_init_r (NULL ,0 ); +}(quoted diff) +0
-0b/configs/imx8qxp_ai_ml_defconfig new file mode 100644 index 0000000000..e20a0c783e
configs/imx8qxp_ai_ml_defconfig new file +83
-0@@ -0,0 +1,83 @@ +CONFIG_ARM=y +CONFIG_ARCH_IMX8=y +CONFIG_SYS_TEXT_BASE=0x80020000 +CONFIG_DISTRO_DEFAULTS=y +CONFIG_SPL_GPIO_SUPPORT=y +CONFIG_SPL_LIBCOMMON_SUPPORT=y +CONFIG_SPL_LIBGENERIC_SUPPORT=y +CONFIG_SYS_MALLOC_F_LEN=0x4000 +CONFIG_TARGET_IMX8QXP_AI_ML=y +CONFIG_SPL_MMC_SUPPORT=y +CONFIG_SPL_SERIAL_SUPPORT=y +CONFIG_SPL_DRIVERS_MISC_SUPPORT=y +CONFIG_NR_DRAM_BANKS=4 +CONFIG_SPL=y +CONFIG_FIT=y +CONFIG_SPL_LOAD_FIT=y +CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/einfochips/imx8qxp_ai_ml/imximage.cfg" +CONFIG_BOOTDELAY=3 +CONFIG_LOG=y +CONFIG_SPL_BOARD_INIT=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y +CONFIG_SPL_SEPARATE_BSS=y +CONFIG_SPL_POWER_SUPPORT=y +CONFIG_SPL_POWER_DOMAIN=y +CONFIG_SPL_WATCHDOG_SUPPORT=y +CONFIG_HUSH_PARSER=y +CONFIG_CMD_CPU=y +# CONFIG_CMD_IMPORTENV is not set +CONFIG_CMD_CLK=y +CONFIG_CMD_DM=y +CONFIG_CMD_FUSE=y +CONFIG_CMD_GPIO=y +CONFIG_CMD_GPT=y +CONFIG_CMD_I2C=y +CONFIG_CMD_MMC=y +CONFIG_CMD_DHCP=y +CONFIG_CMD_MII=y +CONFIG_CMD_PING=y +CONFIG_CMD_CACHE=y +CONFIG_CMD_EXT4=y +CONFIG_CMD_EXT4_WRITE=y +CONFIG_CMD_FAT=y +CONFIG_FAT_WRITE=y +CONFIG_CMD_FS_GENERIC=y +CONFIG_SPL_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qxp-ai_ml" +CONFIG_ENV_IS_IN_MMC=y +CONFIG_SPL_DM=y +CONFIG_SPL_CLK=y +CONFIG_CLK_IMX8=y +CONFIG_CPU=y +CONFIG_DM_GPIO=y +CONFIG_MXC_GPIO=y +CONFIG_DM_I2C=y +CONFIG_SYS_I2C_IMX_LPI2C=y +CONFIG_MISC=y +CONFIG_DM_MMC=y +CONFIG_FSL_ESDHC=y +CONFIG_PHYLIB=y +CONFIG_PHY_ADDR_ENABLE=y +CONFIG_PHY_ATHEROS=y +CONFIG_DM_ETH=y +CONFIG_NET_RANDOM_ETHADDR=y +CONFIG_PHY_GIGE=y +CONFIG_FEC_MXC_SHARE_MDIO=y +CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 +CONFIG_FEC_MXC=y +CONFIG_MII=y +CONFIG_PINCTRL=y +CONFIG_SPL_PINCTRL=y +CONFIG_PINCTRL_IMX8=y +CONFIG_POWER_DOMAIN=y +CONFIG_IMX8_POWER_DOMAIN=y +CONFIG_DM_REGULATOR=y +CONFIG_SPL_DM_REGULATOR=y +CONFIG_DM_REGULATOR_FIXED=y +CONFIG_DM_REGULATOR_GPIO=y +CONFIG_SPL_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +CONFIG_FSL_LPUART=y +CONFIG_SPL_TINY_MEMSET=y +# CONFIG_EFI_LOADER is not set(quoted diff) +0
-0
b/include/configs/imx8qxp_ai_ml.hnew file mode 100644 index 0000000000..dd31189845include/configs/imx8qxp_ai_ml.h new file +14
-0@@ -0,0 +1,104 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright 2018 NXP +* Copyright 2019 Linaro Ltd. +*/ + +#ifndef __IMX8QXP_AI_ML_H +#define __IMX8QXP_AI_ML_H + +#include <linux/sizes.h> +#include <asm/arch/imx-regs.h> + +#ifdef CONFIG_SPL_BUILD +#define CONFIG_SPL_MAX_SIZE (124 *1024) +#define
CONFIG_SYS_MONITOR_LEN
(1024 * 1024) +#defineCONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR+#defineCONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR0x250+#defineCONFIG_SYS_MMCSD_FS_BOOT_PARTITION0include/configs/imx8qxp_ai_ml.h new file +2
-0+ +#define
CONFIG_SPL_LDSCRIPT
"arch/arm/cpu/armv8/u-boot-spl.lds" +#defineCONFIG_SPL_STACK0x013E000+#defineCONFIG_SPL_BSS_START_ADDR0x00128000+#defineCONFIG_SPL_BSS_MAX_SIZE0x1000/* 4 KB */
+#defineCONFIG_SYS_SPL_MALLOC_START0x00120000+#defineCONFIG_SYS_SPL_MALLOC_SIZE0x3000/* 12 KB */
+#defineCONFIG_SERIAL_LPUART_BASE0x5a080000+#defineQuoted 9 lines
include/configs/imx8qxp_ai_ml.h line 33
Quoted 5 lines
CONFIG_MALLOC_F_ADDR0x00120000+ +#defineCONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE+include/configs/imx8qxp_ai_ml.h new file +3
-0+#define CONFIG_SPL_ABORT_ON_RAW_IMAGE + +#define CONFIG_OF_EMBED I'm not sure if the
OF_EMBEDis not deprecated ... and replaced byOF_SEPARATED.
Quoted 1 line
I'm not sure about this. I don't see any such information.
There was a u-boot ML discussion about OF_EMBED deprecation.
https://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=*&q=OF_EMBED&archive=both&delegate=
Also please see:
https://www.chromium.org/developers/u-boot
Quoted 71 lines
Quoted 9 lines
include/configs/imx8qxp_ai_ml.h line 38
Quoted 6 lines
include/configs/imx8qxp_ai_ml.h new file +5
-0+#endif + +#define CONFIG_REMAKE_ELF + +#define CONFIG_BOARD_EARLY_INIT_F This could be set in
Kconfig, IIRCAck.
Quoted 49 lines
Quoted 49 lines
include/configs/imx8qxp_ai_ml.h new file +17
-0+ +/* Flat Device Tree Definitions */ +#define CONFIG_OF_BOARD_SETUP + +#define CONFIG_FSL_USDHC + +#define CONFIG_ENV_OVERWRITE + +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define BOOT_TARGET_DEVICES (func) \ + func(MMC, mmc, 1) \ + func(DHCP, dhcp, na) + +#include <config_distro_bootcmd.h> +/* Initial environment variables */ +#define CONFIG_EXTRA_ENV_SETTINGS \
include/configs/imx8qxp_ai_ml.h new file +11
-0+"console=ttyLP2 earlycon\0" \ +"fdt_addr_r=0x83000000\0" \ +"kernel_addr_r=0x81000000\0" \ +"ramdisk_addr_r=0x94400000\0" \ +"scriptaddr=0x89000000\0" \ +"fdtfile=imx8qxp-ai_ml.dtb\0" \ +"fdt_high=0xffffffffffffffff\0" \ +"image=Image\0" \ +"initrd_addr=0x83800000\0" \ +"initrd_high=0xffffffffffffffff\0" \ + "netargs=setenv bootargs console=${console},${baudrate}" \
include/configs/imx8qxp_ai_ml.h new file +1
-0+ "root=/dev/nfs ip=dhcpnfsroot=${serverip}:${nfsroot},v3,tcp" \
include/configs/imx8qxp_ai_ml.h new file +2
-0+"\0" \ + "nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp${fdt_addr} " \
include/configs/imx8qxp_ai_ml.h new file +1
-0+ "imx8qxp-ai_ml/${fdt_file}; booti ${loadaddr} -${fdt_addr}\0" \
include/configs/imx8qxp_ai_ml.h new file +12
-0+ BOOTENV + +/* Link Definitions */ +#define CONFIG_LOADADDR 0x80280000 + +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR + +#define CONFIG_SYS_INIT_SP_ADDR 0x80200000 + +/* Default environment is in SD */ +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_OFFSET (64 * SZ_64K)Quoted 9 lines
include/configs/imx8qxp_ai_ml.h line 87
Quoted 5 lines
include/configs/imx8qxp_ai_ml.h new file +5
-0+ +/* USDHC2 is the SD card interface */ +#define CONFIG_SYS_MMC_ENV_DEV 1/* USDHC2 */ +#define CONFIG_SYS_FSL_USDHC_NUM 2 +Some of those env setting defines as well as eMMC ones could be set now in
Kconfig.
Quoted 2 lines
Can you please specify those? I don't see these defines used in
Kconfig.
The best (and simplest) way is to just check if the corresponding CONFIG_* option is already moved (ported) to Kconfig. For example ENV_SIZE and ENV_OFFSET are.
Quoted 14 lines
Quoted 13 lines
Quoted 10 lines
include/configs/imx8qxp_ai_ml.h new file +2
-0+/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN ((CONFIG_ENV_SIZE +(32
* 1024)) * 1024) +include/configs/imx8qxp_ai_ml.h new file +4
-0+#define CONFIG_SYS_SDRAM_BASE 0x80000000 +#define PHYS_SDRAM_1 0x80000000 +#define PHYS_SDRAM_2 0x880000000 +#define PHYS_SDRAM_1_SIZE SZ_2G/* 2
Please fix this file globally, to use "
SZ_XX" instead of magic numbers.
Quoted 31 lines
Ack.
Thanks,
ManiQuoted 24 lines
include/configs/imx8qxp_ai_ml.h line 104
Quoted 10 lines
GB */ +#define
PHYS_SDRAM_2_SIZE0x00000000
/* 0 GB */ +include/configs/imx8qxp_ai_ml.h new file +2
-0+/* Generic Timer Definitions */ +#define COUNTER_FREQUENCY 8000000/* 8MHz */ +
include/configs/imx8qxp_ai_ml.h new file +5
-0+/* Networking */ +#define CONFIG_FEC_XCV_TYPE RGMII +#define FEC_QUIRK_ENET_MAC + +#endif /* __IMX8QXP_AI_ML_H */ Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190815/d1115cb6/attachment.sig>
PATCH v4 2/2 board: Add support for iMX8QXP AI_ML board
Hi Lukasz,
Quoted 258 lines · Lukasz Majewski
Hi Manivannan,
Quoted 250 lines
Hi Lukasz,
Thanks for the review!
Quoted 199 lines · Lukasz Majewski
Hi Manivannan,
board/einfochips/imx8qxp_ai_ml/README
Quoted 111 lines
This commit adds initial board support for iMX8QXP
AI_MLboard from Einfochips. This board is one of the 96Boards Consumer Edition and AI boards of the 96Boards family based on i.MX8QXP SoC from NXP/Freescale.This initial supports contains following peripherals which are tested and known to work:
1. Debug serial via UART2
2. SD card
3. EthernetMore information about this board can be found in arrow website:
https://www.arrow.com/en/products/imx8-ai-ml/arrow-development-toolsSigned-off-by: Manivannan Sadhasivam
<[email protected]> ---arch/arm/mach-imx/imx8/Kconfig | 6 + board/einfochips/imx8qxp_ai_ml/Kconfig | 12 ++ board/einfochips/imx8qxp_ai_ml/MAINTAINERS | 6 + board/einfochips/imx8qxp_ai_ml/Makefile | 8 ++ board/einfochips/imx8qxp_ai_ml/README | 49 ++++++++ .../einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c | 117++++++++++++++++++ board/einfochips/imx8qxp_ai_ml/imximage.cfg |
24 ++++board/einfochips/imx8qxp_ai_ml/spl.c| 49
++++++++ configs/imx8qxp_ai_ml_defconfig | 83
+++++++++++++include/configs/imx8qxp_ai_ml.h| 104
++++++++++++++++ 10 files changed, 458 insertions(+)create mode 100644 board/einfochips/imx8qxp_ai_ml/Kconfig create mode 100644 board/einfochips/imx8qxp_ai_ml/MAINTAINERS create mode 100644 board/einfochips/imx8qxp_ai_ml/Makefile create mode 100644 board/einfochips/imx8qxp_ai_ml/README create mode 100644 board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c create mode 100644 board/einfochips/imx8qxp_ai_ml/imximage.cfg create mode 100644 board/einfochips/imx8qxp_ai_ml/spl.c create mode 100644 configs/imx8qxp_ai_ml_defconfig create mode 100644 include/configs/imx8qxp_ai_ml.h(quoted diff) +0
-0b/arch/arm/mach-imx/imx8/Kconfig index
bbe323d5ca..cec21f8dd2100644 --- a/arch/arm/mach-imx/imx8/Kconfig
+++ b/arch/arm/mach-imx/imx8/Kconfigarch/arm/mach-imx/imx8/Kconfig +6
-0@@ -37,6 +37,11 @@ config TARGET_COLIBRI_IMX8X select BOARD_LATE_INIT select IMX8QXP +config TARGET_IMX8QXP_AI_ML + bool "Support i.MX8QXP AI_ML board" + select BOARD_LATE_INIT + select IMX8QXP + config TARGET_IMX8QM_MEK bool "Support i.MX8QM MEK board" select BOARD_LATE_INIT@@ -49,6 +54,7 @@ config TARGET_IMX8QXP_MEK endchoice +source "board/einfochips/imx8qxp_ai_ml/Kconfig" source "board/freescale/imx8qm_mek/Kconfig" source "board/freescale/imx8qxp_mek/Kconfig" source "board/toradex/apalis-imx8/Kconfig"(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/Kconfig new file mode 100644 index 0000000000..697a831013
board/einfochips/imx8qxp_ai_ml/Kconfig new file +12
-0@@ -0,0 +1,12 @@ +if TARGET_IMX8QXP_AI_ML + +config SYS_BOARD + default "imx8qxp_ai_ml" + +config SYS_VENDOR + default "einfochips" + +config SYS_CONFIG_NAME + default "imx8qxp_ai_ml" + +endif(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file mode 100644 index 0000000000..add0bd9431
board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file +2
-0@@ -0,0 +1,6 @@ +i.MX8QXP AI_ML BOARD +M: Manivannan Sadhasivam<[email protected]> +S: Maintained
board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file +3
-0+F: board/einfochips/imx8qxp_ai_ml/ +F: include/configs/imx8qxp_ai_ml.h +F: configs/imx8qxp_ai_ml_defconfig(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/Makefile new file mode 100644 index 0000000000..e08774dc6e
board/einfochips/imx8qxp_ai_ml/Makefile new file +8
-0@@ -0,0 +1,8 @@ +# +# Copyright 2019 Linaro Ltd. +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-y += imx8qxp_ai_ml.o +obj-$(CONFIG_SPL_BUILD) += spl.o(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/README new file mode 100644 index 0000000000..488920580f
board/einfochips/imx8qxp_ai_ml/README new file +0
-0Thank you for preparing the README file, appreciated :-).
Quoted 83 lines
board/einfochips/imx8qxp_ai_ml/README new file +17
-0@@ -0,0 +1,49 @@ +U-Boot for the Einfochips i.MX8QXP AI_ML board + +Quick Start +=========== + +- Get and Build the ARM Trusted firmware +- Get scfw_tcm.bin and ahab-container.img +- Build U-Boot +- Flash the binary into the SD card +- Boot + +Get and Build the ARM Trusted firmware +====================================== + +$ git clone https://source.codeaurora.org/external/imx/imx-atf +$ cd imx-atf/ +$ git checkout origin/imx_4.9.88_imx8qxp_beta2 -bimx_4.9.88_imx8qxp_beta2 +$ make PLAT=imx8qxp bl31
board/einfochips/imx8qxp_ai_ml/README new file +5
-0+ +Get scfw_tcm.bin and ahab-container.img +======================================= + +$ wgethttps://raw.githubusercontent.com/96boards-ai-ml/binaries/master/mx8qx-aiml-scfw-tcm.bin
+$ wget
https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.1.bin +$ chmod +x firmware-imx-8.1.bin +$ ./firmware-imx-8.1.bin +board/einfochips/imx8qxp_ai_ml/README new file +22
-0+Copy the following binaries to U-Boot folder: + +$ cp imx-atf/build/imx8qxp/release/bl31.bin . +$ cp firmware-imx-8.1/firmware/seco/mx8qx-ahab-container.img . + +Build U-Boot +============ + +$ make imx8qxp_ai_ml_defconfig +$ make u-boot-dtb.imx + +Flash the binary into the SD card +================================= + +Burn the u-boot-dtb.imx binary to SD card offset 32KB: + +$ sudo dd if=u-boot-dtb.imx of=/dev/sd[x] bs=1024 seek=32 + +Boot +==== + +Set Boot switch SW2: 1100.(quoted diff) +0
-0
b/board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.cnew file mode 100644 index 0000000000..e7632524a0board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +21
-0@@ -0,0 +1,117 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright 2018 NXP +* Copyright 2019 Linaro Ltd. +*/ + +#include <common.h> +#include <errno.h> +#include <linux/libfdt.h> +#include <environment.h> +#include <fsl_esdhc.h> +#include <asm/io.h> +#include <asm/arch/clock.h> +#include <asm/arch/sci/sci.h> +#include <asm/arch/imx8-pins.h> +#include <asm/arch/iomux.h> +#include <asm/arch/sys_proto.h> + +DECLARE_GLOBAL_DATA_PTR ; + +#define UART_PAD_CTRL ((SC_PAD_CONFIG_OUT_IN <<
PADRING_CONFIG_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_ISO_OFF <<
PADRING_LPCONFIG_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_28FDSOI_DSE_DV_HIGH <<
PADRING_DSE_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_28FDSOI_PS_PU <<Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 29
Quoted 5 lines
PADRING_PULL_SHIFT)) +board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +4
-0+static iomux_cfg_t uart2_pads[] = { +SC_P_UART2_RX |MUX_PAD_CTRL (UART_PAD_CTRL ), +SC_P_UART2_TX |MUX_PAD_CTRL (UART_PAD_CTRL ), +};As fair as I see - the uart could be configured via DTS (by using the pinmux driver) as this is the U-Boot proper file.
Agree, this is not needed.
Quoted 24 lines
Quoted 24 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +4
-0+ +static void setup_iomux_uart (void ) +{ + imx8_iomux_setup_multiple_pads(uart2_pads,
ARRAY_SIZE(uart2_pads)); +}board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +19
-0+ +int board_early_init_f (void ) +{ +sc_pm_clock_rate_t rate =SC_80MHZ ; +int ret; + +/* Set UART2 clock root to 80 MHz */ + ret =sc_pm_setup_uart (SC_R_UART_2 , rate); +if (ret) +return ret; + +setup_iomux_uart (); + +return 0 ; +} + +#if IS_ENABLED (CONFIG_DM_GPIO ) +static void board_gpio_init (void ) +{Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 59
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +6
-0+ /* TODO */ +} +#else +static inline void board_gpio_init (void ) {} +#endif +I'm wondering if the above function is needed?
Quoted 2 lines
I thought about keeping this as I may add some gpio configurations in future. But, yeah I can remove it now and add once needed.
The general rule is to avoid adding any dead (i.e. not used) code to the main line.
Quoted 7 lines
The practical reason for it is to have the code base as small as possible. Moreover, the patch, which adds this board is rather large, so in that way we make it smaller.
This code shall be added when you introduce the GPIO needed for this board.
Okay, thanks for the info!
Quoted 53 lines
Quoted 53 lines
Quoted 29 lines
Quoted 29 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +28
-0+#if IS_ENABLED (CONFIG_FEC_MXC ) +#include <miiphy.h> + +int board_phy_config (struct phy_device *phydev) +{ +phy_write (phydev,MDIO_DEVAD_NONE ,0x1d ,0x1f ); +phy_write (phydev,MDIO_DEVAD_NONE ,0x1e ,0x8 ); + +phy_write (phydev,MDIO_DEVAD_NONE ,0x1d ,0x05 ); +phy_write (phydev,MDIO_DEVAD_NONE ,0x1e ,0x100 ); + +if (phydev->drv->config) + phydev->drv->config (phydev); + +return 0 ; +} +#endif + +int checkboard (void ) +{ +puts ("Board: iMX8QXP AI_ML\n" ); + +build_info (); +print_bootinfo (); + +return 0 ; +} +Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 93
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +6
-0+int board_init (void ) +{ +board_gpio_init (); + +return 0 ; +}Here you call the empty
board_gpio_init().As per above comment, I'll remove it.
Quoted 11 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 100
Quoted 7 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +7
-0+ +/* Board specific reset that is system reset */ + +void reset_cpu (ulong addr) +{ +/* TODO */ +}Maybe you could use the SYSRESET driver from the outset? It internally uses WDT for reset.
Quoted 5 lines
Quoted 1 line
Hmm, looks like there is no watchdog driver for imx8qxp yet.
If I may ask - how do you plan to reset the board? On most i.MX boards the reset is done by triggering the WDT.
For i.MX8 boards, there is no reset support in u-boot. So I'll bank on the NXP folks to add it :-) On the linux side, we have the watchdog driver which will do SMC call to trigger reset.
Quoted 252 lines
Quoted 92 lines
Quoted 16 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 112
Quoted 13 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +12
-0+ +#ifdef CONFIG_OF_BOARD_SETUP +int ft_board_setup (void *blob,bd_t *bd) +{ +return 0 ; +} +#endif + +int board_mmc_get_env_dev (int devno) +{ +return devno; +}This (the device and its instance) could be set in
Kconfig.Ack.
Quoted 63 lines
Quoted 63 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +5
-0+ +int board_late_init (void ) +{ +return 0 ; +}(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/imximage.cfg new file mode 100644 index 0000000000..4fc5ade313
board/einfochips/imx8qxp_ai_ml/imximage.cfg new file +5
-0@@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2018 NXP + * + * Refer doc/README.imx8image for more details about how-toconfigure
+ * and create imx8image boot image
+ */board/einfochips/imx8qxp_ai_ml/imximage.cfg new file +17
-0+ +#define __ASSEMBLY__ + +/* Boot from SD, sector size 0x400 */ +BOOT_FROM SD 0x400 +/* SoC type IMX8QX */ +SOC_TYPE IMX8QX +/* Append seco container image */ +APPEND mx8qx-ahab-container.img +/* Create the 2nd container */ +CONTAINER +/* Add scfw image with exec attribute */ +IMAGE SCU mx8qx-aiml-scfw-tcm.bin +/* Add ATF image with exec attribute */ +IMAGE A35 bl31.bin 0x80000000 +/* Add U-Boot image with load attribute */ +DATA A35 u-boot-dtb.bin 0x80020000(quoted diff) +0
-0
b/board/einfochips/imx8qxp_ai_ml/spl.cnew file mode 100644 index 0000000000..63581eeaafboard/einfochips/imx8qxp_ai_ml/spl.c new file +21
-0@@ -0,0 +1,49 @@ +/* +* Copyright 2018 NXP +* +* SPDX-License-Identifier: GPL-2.0+ +*/ + +#include <common.h> +#include <dm.h> +#include <spl.h> +#include <dm/uclass.h> +#include <dm/device.h> +#include <dm/uclass-internal.h> +#include <dm/device-internal.h> +#include <dm/lists.h> + +DECLARE_GLOBAL_DATA_PTR ; + +void spl_board_init (void ) +{ +struct udevice *dev; +Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/spl.c line 27
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/spl.c new file +6
-0+uclass_find_first_device (UCLASS_MISC , &dev); + +for (; dev;uclass_find_next_device (&dev)) { +if (device_probe (dev)) +continue ; + }What devices needs to be initialized in that way ?
Quoted 1 line
Mostly SCU but it is not needed, so I'll remove it.
Ok.
Quoted 156 lines
Quoted 155 lines
Quoted 148 lines
board/einfochips/imx8qxp_ai_ml/spl.c new file +22
-0+ +arch_cpu_init (); + +board_early_init_f (); + +timer_init (); + +preloader_console_init (); + +puts ("Normal Boot\n" ); +} + +void board_init_f (ulong dummy) +{ +/* Clear global data */ +memset ((void *)gd,0 ,sizeof (gd_t)); + +/* Clear the BSS. */ +memset (__bss_start,0 , __bss_end - __bss_start); + +board_init_r (NULL ,0 ); +}(quoted diff) +0
-0b/configs/imx8qxp_ai_ml_defconfig new file mode 100644 index 0000000000..e20a0c783e
configs/imx8qxp_ai_ml_defconfig new file +83
-0@@ -0,0 +1,83 @@ +CONFIG_ARM=y +CONFIG_ARCH_IMX8=y +CONFIG_SYS_TEXT_BASE=0x80020000 +CONFIG_DISTRO_DEFAULTS=y +CONFIG_SPL_GPIO_SUPPORT=y +CONFIG_SPL_LIBCOMMON_SUPPORT=y +CONFIG_SPL_LIBGENERIC_SUPPORT=y +CONFIG_SYS_MALLOC_F_LEN=0x4000 +CONFIG_TARGET_IMX8QXP_AI_ML=y +CONFIG_SPL_MMC_SUPPORT=y +CONFIG_SPL_SERIAL_SUPPORT=y +CONFIG_SPL_DRIVERS_MISC_SUPPORT=y +CONFIG_NR_DRAM_BANKS=4 +CONFIG_SPL=y +CONFIG_FIT=y +CONFIG_SPL_LOAD_FIT=y +CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/einfochips/imx8qxp_ai_ml/imximage.cfg" +CONFIG_BOOTDELAY=3 +CONFIG_LOG=y +CONFIG_SPL_BOARD_INIT=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y +CONFIG_SPL_SEPARATE_BSS=y +CONFIG_SPL_POWER_SUPPORT=y +CONFIG_SPL_POWER_DOMAIN=y +CONFIG_SPL_WATCHDOG_SUPPORT=y +CONFIG_HUSH_PARSER=y +CONFIG_CMD_CPU=y +# CONFIG_CMD_IMPORTENV is not set +CONFIG_CMD_CLK=y +CONFIG_CMD_DM=y +CONFIG_CMD_FUSE=y +CONFIG_CMD_GPIO=y +CONFIG_CMD_GPT=y +CONFIG_CMD_I2C=y +CONFIG_CMD_MMC=y +CONFIG_CMD_DHCP=y +CONFIG_CMD_MII=y +CONFIG_CMD_PING=y +CONFIG_CMD_CACHE=y +CONFIG_CMD_EXT4=y +CONFIG_CMD_EXT4_WRITE=y +CONFIG_CMD_FAT=y +CONFIG_FAT_WRITE=y +CONFIG_CMD_FS_GENERIC=y +CONFIG_SPL_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qxp-ai_ml" +CONFIG_ENV_IS_IN_MMC=y +CONFIG_SPL_DM=y +CONFIG_SPL_CLK=y +CONFIG_CLK_IMX8=y +CONFIG_CPU=y +CONFIG_DM_GPIO=y +CONFIG_MXC_GPIO=y +CONFIG_DM_I2C=y +CONFIG_SYS_I2C_IMX_LPI2C=y +CONFIG_MISC=y +CONFIG_DM_MMC=y +CONFIG_FSL_ESDHC=y +CONFIG_PHYLIB=y +CONFIG_PHY_ADDR_ENABLE=y +CONFIG_PHY_ATHEROS=y +CONFIG_DM_ETH=y +CONFIG_NET_RANDOM_ETHADDR=y +CONFIG_PHY_GIGE=y +CONFIG_FEC_MXC_SHARE_MDIO=y +CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 +CONFIG_FEC_MXC=y +CONFIG_MII=y +CONFIG_PINCTRL=y +CONFIG_SPL_PINCTRL=y +CONFIG_PINCTRL_IMX8=y +CONFIG_POWER_DOMAIN=y +CONFIG_IMX8_POWER_DOMAIN=y +CONFIG_DM_REGULATOR=y +CONFIG_SPL_DM_REGULATOR=y +CONFIG_DM_REGULATOR_FIXED=y +CONFIG_DM_REGULATOR_GPIO=y +CONFIG_SPL_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +CONFIG_FSL_LPUART=y +CONFIG_SPL_TINY_MEMSET=y +# CONFIG_EFI_LOADER is not set(quoted diff) +0
-0
b/include/configs/imx8qxp_ai_ml.hnew file mode 100644 index 0000000000..dd31189845include/configs/imx8qxp_ai_ml.h new file +14
-0@@ -0,0 +1,104 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright 2018 NXP +* Copyright 2019 Linaro Ltd. +*/ + +#ifndef __IMX8QXP_AI_ML_H +#define __IMX8QXP_AI_ML_H + +#include <linux/sizes.h> +#include <asm/arch/imx-regs.h> + +#ifdef CONFIG_SPL_BUILD +#define CONFIG_SPL_MAX_SIZE (124 *1024) +#define
CONFIG_SYS_MONITOR_LEN
(1024 * 1024) +#defineCONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR+#defineCONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR0x250+#defineCONFIG_SYS_MMCSD_FS_BOOT_PARTITION0include/configs/imx8qxp_ai_ml.h new file +2
-0+ +#define
CONFIG_SPL_LDSCRIPT
"arch/arm/cpu/armv8/u-boot-spl.lds" +#defineCONFIG_SPL_STACK0x013E000+#defineCONFIG_SPL_BSS_START_ADDR0x00128000+#defineCONFIG_SPL_BSS_MAX_SIZE0x1000/* 4 KB */
+#defineCONFIG_SYS_SPL_MALLOC_START0x00120000+#defineCONFIG_SYS_SPL_MALLOC_SIZE0x3000/* 12 KB */
+#defineCONFIG_SERIAL_LPUART_BASE0x5a080000+#defineCONFIG_MALLOC_F_ADDR0x00120000+ +#defineCONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE+include/configs/imx8qxp_ai_ml.h line 33
Quoted 3 lines
include/configs/imx8qxp_ai_ml.h new file +3
-0+#define CONFIG_SPL_ABORT_ON_RAW_IMAGE + +#define CONFIG_OF_EMBED I'm not sure if the
OF_EMBEDis not deprecated ... and replaced byOF_SEPARATED.
Quoted 8 lines
Quoted 1 line
I'm not sure about this. I don't see any such information.
There was a u-boot ML discussion about
OF_EMBEDdeprecation.
https://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=*&q=OF_EMBED&archive=both&delegate=Also please see:
https://www.chromium.org/developers/u-boot
Okay, thanks for the pointer.
Quoted 71 lines
Quoted 71 lines
Quoted 9 lines
include/configs/imx8qxp_ai_ml.h line 38
Quoted 6 lines
include/configs/imx8qxp_ai_ml.h new file +5
-0+#endif + +#define CONFIG_REMAKE_ELF + +#define CONFIG_BOARD_EARLY_INIT_F This could be set in
Kconfig, IIRCAck.
Quoted 58 lines
Quoted 44 lines
include/configs/imx8qxp_ai_ml.h new file +17
-0+ +/* Flat Device Tree Definitions */ +#define CONFIG_OF_BOARD_SETUP + +#define CONFIG_FSL_USDHC + +#define CONFIG_ENV_OVERWRITE + +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define BOOT_TARGET_DEVICES (func) \ + func(MMC, mmc, 1) \ + func(DHCP, dhcp, na) + +#include <config_distro_bootcmd.h> +/* Initial environment variables */ +#define CONFIG_EXTRA_ENV_SETTINGS \
include/configs/imx8qxp_ai_ml.h new file +11
-0+"console=ttyLP2 earlycon\0" \ +"fdt_addr_r=0x83000000\0" \ +"kernel_addr_r=0x81000000\0" \ +"ramdisk_addr_r=0x94400000\0" \ +"scriptaddr=0x89000000\0" \ +"fdtfile=imx8qxp-ai_ml.dtb\0" \ +"fdt_high=0xffffffffffffffff\0" \ +"image=Image\0" \ +"initrd_addr=0x83800000\0" \ +"initrd_high=0xffffffffffffffff\0" \ + "netargs=setenv bootargs console=${console},${baudrate}" \
include/configs/imx8qxp_ai_ml.h new file +1
-0+ "root=/dev/nfs ip=dhcpnfsroot=${serverip}:${nfsroot},v3,tcp" \
include/configs/imx8qxp_ai_ml.h new file +2
-0+"\0" \ + "nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp${fdt_addr} " \
include/configs/imx8qxp_ai_ml.h new file +1
-0+ "imx8qxp-ai_ml/${fdt_file}; booti ${loadaddr} -${fdt_addr}\0" \
include/configs/imx8qxp_ai_ml.h new file +7
-0+ BOOTENV + +/* Link Definitions */ +#define CONFIG_LOADADDR 0x80280000 + +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR +include/configs/imx8qxp_ai_ml.h line 87
Quoted 10 lines
include/configs/imx8qxp_ai_ml.h new file +10
-0+#define CONFIG_SYS_INIT_SP_ADDR 0x80200000 + +/* Default environment is in SD */ +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_OFFSET (64 * SZ_64K) + +/* USDHC2 is the SD card interface */ +#define CONFIG_SYS_MMC_ENV_DEV 1/* USDHC2 */ +#define CONFIG_SYS_FSL_USDHC_NUM 2 +Some of those env setting defines as well as eMMC ones could be set now in
Kconfig.
Quoted 7 lines
Quoted 2 lines
Can you please specify those? I don't see these defines used in
Kconfig.The best (and simplest) way is to just check if the corresponding CONFIG_* option is already moved (ported) to
Kconfig. For exampleENV_SIZEandENV_OFFSETare.
Yeah, I see it now that couple of boards are using it. Will do the same.
Thanks,
Mani
Quoted 57 lines
Quoted 14 lines
Quoted 13 lines
Quoted 10 lines
include/configs/imx8qxp_ai_ml.h new file +2
-0+/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN ((CONFIG_ENV_SIZE +(32
* 1024)) * 1024) +include/configs/imx8qxp_ai_ml.h new file +4
-0+#define CONFIG_SYS_SDRAM_BASE 0x80000000 +#define PHYS_SDRAM_1 0x80000000 +#define PHYS_SDRAM_2 0x880000000 +#define PHYS_SDRAM_1_SIZE SZ_2G/* 2
Please fix this file globally, to use "
SZ_XX" instead of magic numbers.Quoted 31 lines
Ack.
Thanks,
ManiQuoted 24 lines
include/configs/imx8qxp_ai_ml.h line 104
Quoted 10 lines
GB */ +#define
PHYS_SDRAM_2_SIZE0x00000000
/* 0 GB */ +include/configs/imx8qxp_ai_ml.h new file +2
-0+/* Generic Timer Definitions */ +#define COUNTER_FREQUENCY 8000000/* 8MHz */ +
include/configs/imx8qxp_ai_ml.h new file +5
-0+/* Networking */ +#define CONFIG_FEC_XCV_TYPE RGMII +#define FEC_QUIRK_ENET_MAC + +#endif /* __IMX8QXP_AI_ML_H */ Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.deBest regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
PATCH v4 2/2 board: Add support for iMX8QXP AI_ML board
Quoted 329 lines · On Thu, 15 Aug 2019 13:46:30 +0530 Manivannan Sadhasivam…
Hi Lukasz,
Quoted 261 lines · Lukasz Majewski
Hi Manivannan,
Quoted 253 lines
Hi Lukasz,
Thanks for the review!
Quoted 202 lines · Lukasz Majewski
Hi Manivannan,
board/einfochips/imx8qxp_ai_ml/README
Quoted 114 lines
This commit adds initial board support for iMX8QXP
AI_MLboard from Einfochips. This board is one of the 96Boards Consumer Edition and AI boards of the 96Boards family based on i.MX8QXP SoC from NXP/Freescale.This initial supports contains following peripherals which are tested and known to work:
1. Debug serial via UART2
2. SD card
3. EthernetMore information about this board can be found in arrow website:
https://www.arrow.com/en/products/imx8-ai-ml/arrow-development-toolsSigned-off-by: Manivannan Sadhasivam
<[email protected]> ---arch/arm/mach-imx/imx8/Kconfig | 6 + board/einfochips/imx8qxp_ai_ml/Kconfig | 12 ++ board/einfochips/imx8qxp_ai_ml/MAINTAINERS | 6 + board/einfochips/imx8qxp_ai_ml/Makefile | 8 ++ board/einfochips/imx8qxp_ai_ml/README | 49 ++++++++ .../einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c | 117 ++++++++++++++++++ board/einfochips/imx8qxp_ai_ml/imximage.cfg | 24 ++++ board/einfochips/imx8qxp_ai_ml/spl.c | 49 ++++++++ configs/imx8qxp_ai_ml_defconfig | 83+++++++++++++
include/configs/imx8qxp_ai_ml.h|
104 ++++++++++++++++ 10 files changed, 458 insertions(+) create mode 100644 board/einfochips/imx8qxp_ai_ml/Kconfig create mode 100644 board/einfochips/imx8qxp_ai_ml/MAINTAINERS create mode 100644 board/einfochips/imx8qxp_ai_ml/Makefile create mode 100644 board/einfochips/imx8qxp_ai_ml/README create mode 100644board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.ccreate mode 100644 board/einfochips/imx8qxp_ai_ml/imximage.cfg create mode 100644board/einfochips/imx8qxp_ai_ml/spl.ccreate mode 100644 configs/imx8qxp_ai_ml_defconfig create mode 100644include/configs/imx8qxp_ai_ml.h(quoted diff) +0
-0b/arch/arm/mach-imx/imx8/Kconfig index
bbe323d5ca..cec21f8dd2100644 --- a/arch/arm/mach-imx/imx8/Kconfig
+++ b/arch/arm/mach-imx/imx8/Kconfigarch/arm/mach-imx/imx8/Kconfig +6
-0@@ -37,6 +37,11 @@ config TARGET_COLIBRI_IMX8X select BOARD_LATE_INIT select IMX8QXP +config TARGET_IMX8QXP_AI_ML + bool "Support i.MX8QXP AI_ML board" + select BOARD_LATE_INIT + select IMX8QXP + config TARGET_IMX8QM_MEK bool "Support i.MX8QM MEK board" select BOARD_LATE_INIT@@ -49,6 +54,7 @@ config TARGET_IMX8QXP_MEK endchoice +source "board/einfochips/imx8qxp_ai_ml/Kconfig" source "board/freescale/imx8qm_mek/Kconfig" source "board/freescale/imx8qxp_mek/Kconfig" source "board/toradex/apalis-imx8/Kconfig"(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/Kconfig new file mode 100644 index 0000000000..697a831013
board/einfochips/imx8qxp_ai_ml/Kconfig new file +12
-0@@ -0,0 +1,12 @@ +if TARGET_IMX8QXP_AI_ML + +config SYS_BOARD + default "imx8qxp_ai_ml" + +config SYS_VENDOR + default "einfochips" + +config SYS_CONFIG_NAME + default "imx8qxp_ai_ml" + +endif(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file mode 100644 index 0000000000..add0bd9431
board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file +2
-0@@ -0,0 +1,6 @@ +i.MX8QXP AI_ML BOARD +M: Manivannan Sadhasivam<[email protected]> +S: Maintained
board/einfochips/imx8qxp_ai_ml/MAINTAINERS new file +3
-0+F: board/einfochips/imx8qxp_ai_ml/ +F: include/configs/imx8qxp_ai_ml.h +F: configs/imx8qxp_ai_ml_defconfig(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/Makefile new file mode 100644 index 0000000000..e08774dc6e
board/einfochips/imx8qxp_ai_ml/Makefile new file +8
-0@@ -0,0 +1,8 @@ +# +# Copyright 2019 Linaro Ltd. +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-y += imx8qxp_ai_ml.o +obj-$(CONFIG_SPL_BUILD) += spl.o(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/README new file mode 100644 index 0000000000..488920580f
board/einfochips/imx8qxp_ai_ml/README new file +0
-0Thank you for preparing the README file, appreciated :-).
Quoted 83 lines
board/einfochips/imx8qxp_ai_ml/README new file +15
-0@@ -0,0 +1,49 @@ +U-Boot for the Einfochips i.MX8QXP AI_ML board + +Quick Start +=========== + +- Get and Build the ARM Trusted firmware +- Get scfw_tcm.bin and ahab-container.img +- Build U-Boot +- Flash the binary into the SD card +- Boot + +Get and Build the ARM Trusted firmware +====================================== + +$ git clonehttps://source.codeaurora.org/external/imx/imx-atf +$ cd imx-atf/ +$ git checkout origin/imx_4.9.88_imx8qxp_beta2 -b imx_4.9.88_imx8qxp_beta2 +$ make PLAT=imx8qxp bl31
board/einfochips/imx8qxp_ai_ml/README new file +5
-0+ +Get scfw_tcm.bin and ahab-container.img +======================================= + +$ wgethttps://raw.githubusercontent.com/96boards-ai-ml/binaries/master/mx8qx-aiml-scfw-tcm.bin
+$ wget
https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.1.bin
+$ chmod +x firmware-imx-8.1.bin +$ ./firmware-imx-8.1.bin +board/einfochips/imx8qxp_ai_ml/README new file +4
-0+Copy the following binaries to U-Boot folder: + +$ cp imx-atf/build/imx8qxp/release/bl31.bin . +$ cp firmware-imx-8.1/firmware/seco/mx8qx-ahab-container.img. +
board/einfochips/imx8qxp_ai_ml/README new file +17
-0+Build U-Boot +============ + +$ make imx8qxp_ai_ml_defconfig +$ make u-boot-dtb.imx + +Flash the binary into the SD card +================================= + +Burn the u-boot-dtb.imx binary to SD card offset 32KB: + +$ sudo dd if=u-boot-dtb.imx of=/dev/sd[x] bs=1024 seek=32 + +Boot +==== + +Set Boot switch SW2: 1100.(quoted diff) +0
-0
b/board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.cnew file mode 100644 index 0000000000..e7632524a0board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +21
-0@@ -0,0 +1,117 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright 2018 NXP +* Copyright 2019 Linaro Ltd. +*/ + +#include <common.h> +#include <errno.h> +#include <linux/libfdt.h> +#include <environment.h> +#include <fsl_esdhc.h> +#include <asm/io.h> +#include <asm/arch/clock.h> +#include <asm/arch/sci/sci.h> +#include <asm/arch/imx8-pins.h> +#include <asm/arch/iomux.h> +#include <asm/arch/sys_proto.h> + +DECLARE_GLOBAL_DATA_PTR ; + +#define UART_PAD_CTRL ((SC_PAD_CONFIG_OUT_IN <<
PADRING_CONFIG_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_ISO_OFF <<
PADRING_LPCONFIG_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_28FDSOI_DSE_DV_HIGH <<
PADRING_DSE_SHIFT) | \board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +1
-0+ (SC_PAD_28FDSOI_PS_PU <<Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 29
Quoted 5 lines
PADRING_PULL_SHIFT)) +board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +4
-0+static iomux_cfg_t uart2_pads[] = { +SC_P_UART2_RX |MUX_PAD_CTRL (UART_PAD_CTRL ), +SC_P_UART2_TX |MUX_PAD_CTRL (UART_PAD_CTRL ), +};As fair as I see - the uart could be configured via DTS (by using the pinmux driver) as this is the U-Boot proper file.
Agree, this is not needed.
Quoted 24 lines
Quoted 24 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +4
-0+ +static void setup_iomux_uart (void ) +{ + imx8_iomux_setup_multiple_pads(uart2_pads,
ARRAY_SIZE(uart2_pads)); +}board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +19
-0+ +int board_early_init_f (void ) +{ +sc_pm_clock_rate_t rate =SC_80MHZ ; +int ret; + +/* Set UART2 clock root to 80 MHz */ + ret =sc_pm_setup_uart (SC_R_UART_2 , rate); +if (ret) +return ret; + +setup_iomux_uart (); + +return 0 ; +} + +#if IS_ENABLED (CONFIG_DM_GPIO ) +static void board_gpio_init (void ) +{Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 59
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +6
-0+ /* TODO */ +} +#else +static inline void board_gpio_init (void ) {} +#endif +I'm wondering if the above function is needed?
Quoted 2 lines
I thought about keeping this as I may add some gpio configurations in future. But, yeah I can remove it now and add once needed.
The general rule is to avoid adding any dead (i.e. not used) code to the main line.
Quoted 7 lines
The practical reason for it is to have the code base as small as possible. Moreover, the patch, which adds this board is rather large, so in that way we make it smaller.
This code shall be added when you introduce the GPIO needed for this board.
Okay, thanks for the info!
Quoted 55 lines
Quoted 54 lines
Quoted 29 lines
Quoted 29 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +28
-0+#if IS_ENABLED (CONFIG_FEC_MXC ) +#include <miiphy.h> + +int board_phy_config (struct phy_device *phydev) +{ +phy_write (phydev,MDIO_DEVAD_NONE ,0x1d ,0x1f ); +phy_write (phydev,MDIO_DEVAD_NONE ,0x1e ,0x8 ); + +phy_write (phydev,MDIO_DEVAD_NONE ,0x1d ,0x05 ); +phy_write (phydev,MDIO_DEVAD_NONE ,0x1e ,0x100 ); + +if (phydev->drv->config) + phydev->drv->config (phydev); + +return 0 ; +} +#endif + +int checkboard (void ) +{ +puts ("Board: iMX8QXP AI_ML\n" ); + +build_info (); +print_bootinfo (); + +return 0 ; +} +Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 93
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +6
-0+int board_init (void ) +{ +board_gpio_init (); + +return 0 ; +}Here you call the empty
board_gpio_init().As per above comment, I'll remove it.
Quoted 11 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 100
Quoted 7 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +7
-0+ +/* Board specific reset that is system reset */ + +void reset_cpu (ulong addr) +{ +/* TODO */ +}Maybe you could use the SYSRESET driver from the outset? It internally uses WDT for reset.
Hmm, looks like there is no watchdog driver for imx8qxp yet.
Quoted 7 lines
Quoted 3 lines
If I may ask - how do you plan to reset the board? On most i.MX boards the reset is done by triggering the WDT.
For i.MX8 boards, there is no reset support in u-boot. So I'll bank on the NXP folks to add it :-) On the linux side, we have the watchdog driver which will do SMC call to trigger reset.
Then please state in the commit message that the 'reset' is not working (at least via WDT).
Quoted 343 lines
Quoted 253 lines
Quoted 93 lines
Quoted 17 lines
Quoted 4 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +2
-0+ +#ifdef CONFIG_OF_BOARD_SETUP board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c line 112
Quoted 10 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +10
-0+int ft_board_setup (void *blob,bd_t *bd) +{ +return 0 ; +} +#endif + +int board_mmc_get_env_dev (int devno) +{ +return devno; +}This (the device and its instance) could be set in
Kconfig.Ack.
Quoted 63 lines
Quoted 63 lines
board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c new file +5
-0+ +int board_late_init (void ) +{ +return 0 ; +}(quoted diff) +0
-0b/board/einfochips/imx8qxp_ai_ml/imximage.cfg new file mode 100644 index 0000000000..4fc5ade313
board/einfochips/imx8qxp_ai_ml/imximage.cfg new file +5
-0@@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2018 NXP + * + * Refer doc/README.imx8image for more details about how-toconfigure
+ * and create imx8image boot image
+ */board/einfochips/imx8qxp_ai_ml/imximage.cfg new file +17
-0+ +#define __ASSEMBLY__ + +/* Boot from SD, sector size 0x400 */ +BOOT_FROM SD 0x400 +/* SoC type IMX8QX */ +SOC_TYPE IMX8QX +/* Append seco container image */ +APPEND mx8qx-ahab-container.img +/* Create the 2nd container */ +CONTAINER +/* Add scfw image with exec attribute */ +IMAGE SCU mx8qx-aiml-scfw-tcm.bin +/* Add ATF image with exec attribute */ +IMAGE A35 bl31.bin 0x80000000 +/* Add U-Boot image with load attribute */ +DATA A35 u-boot-dtb.bin 0x80020000(quoted diff) +0
-0
b/board/einfochips/imx8qxp_ai_ml/spl.cnew file mode 100644 index 0000000000..63581eeaafboard/einfochips/imx8qxp_ai_ml/spl.c new file +21
-0@@ -0,0 +1,49 @@ +/* +* Copyright 2018 NXP +* +* SPDX-License-Identifier: GPL-2.0+ +*/ + +#include <common.h> +#include <dm.h> +#include <spl.h> +#include <dm/uclass.h> +#include <dm/device.h> +#include <dm/uclass-internal.h> +#include <dm/device-internal.h> +#include <dm/lists.h> + +DECLARE_GLOBAL_DATA_PTR ; + +void spl_board_init (void ) +{ +struct udevice *dev; +Quoted 9 lines
board/einfochips/imx8qxp_ai_ml/spl.c line 27
Quoted 6 lines
board/einfochips/imx8qxp_ai_ml/spl.c new file +6
-0+uclass_find_first_device (UCLASS_MISC , &dev); + +for (; dev;uclass_find_next_device (&dev)) { +if (device_probe (dev)) +continue ; + }What devices needs to be initialized in that way ?
Quoted 1 line
Mostly SCU but it is not needed, so I'll remove it.
Ok.
Quoted 156 lines
Quoted 155 lines
Quoted 146 lines
board/einfochips/imx8qxp_ai_ml/spl.c new file +22
-0+ +arch_cpu_init (); + +board_early_init_f (); + +timer_init (); + +preloader_console_init (); + +puts ("Normal Boot\n" ); +} + +void board_init_f (ulong dummy) +{ +/* Clear global data */ +memset ((void *)gd,0 ,sizeof (gd_t)); + +/* Clear the BSS. */ +memset (__bss_start,0 , __bss_end - __bss_start); + +board_init_r (NULL ,0 ); +}(quoted diff) +0
-0b/configs/imx8qxp_ai_ml_defconfig new file mode 100644 index 0000000000..e20a0c783e
configs/imx8qxp_ai_ml_defconfig new file +83
-0@@ -0,0 +1,83 @@ +CONFIG_ARM=y +CONFIG_ARCH_IMX8=y +CONFIG_SYS_TEXT_BASE=0x80020000 +CONFIG_DISTRO_DEFAULTS=y +CONFIG_SPL_GPIO_SUPPORT=y +CONFIG_SPL_LIBCOMMON_SUPPORT=y +CONFIG_SPL_LIBGENERIC_SUPPORT=y +CONFIG_SYS_MALLOC_F_LEN=0x4000 +CONFIG_TARGET_IMX8QXP_AI_ML=y +CONFIG_SPL_MMC_SUPPORT=y +CONFIG_SPL_SERIAL_SUPPORT=y +CONFIG_SPL_DRIVERS_MISC_SUPPORT=y +CONFIG_NR_DRAM_BANKS=4 +CONFIG_SPL=y +CONFIG_FIT=y +CONFIG_SPL_LOAD_FIT=y +CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/einfochips/imx8qxp_ai_ml/imximage.cfg" +CONFIG_BOOTDELAY=3 +CONFIG_LOG=y +CONFIG_SPL_BOARD_INIT=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y +CONFIG_SPL_SEPARATE_BSS=y +CONFIG_SPL_POWER_SUPPORT=y +CONFIG_SPL_POWER_DOMAIN=y +CONFIG_SPL_WATCHDOG_SUPPORT=y +CONFIG_HUSH_PARSER=y +CONFIG_CMD_CPU=y +# CONFIG_CMD_IMPORTENV is not set +CONFIG_CMD_CLK=y +CONFIG_CMD_DM=y +CONFIG_CMD_FUSE=y +CONFIG_CMD_GPIO=y +CONFIG_CMD_GPT=y +CONFIG_CMD_I2C=y +CONFIG_CMD_MMC=y +CONFIG_CMD_DHCP=y +CONFIG_CMD_MII=y +CONFIG_CMD_PING=y +CONFIG_CMD_CACHE=y +CONFIG_CMD_EXT4=y +CONFIG_CMD_EXT4_WRITE=y +CONFIG_CMD_FAT=y +CONFIG_FAT_WRITE=y +CONFIG_CMD_FS_GENERIC=y +CONFIG_SPL_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qxp-ai_ml" +CONFIG_ENV_IS_IN_MMC=y +CONFIG_SPL_DM=y +CONFIG_SPL_CLK=y +CONFIG_CLK_IMX8=y +CONFIG_CPU=y +CONFIG_DM_GPIO=y +CONFIG_MXC_GPIO=y +CONFIG_DM_I2C=y +CONFIG_SYS_I2C_IMX_LPI2C=y +CONFIG_MISC=y +CONFIG_DM_MMC=y +CONFIG_FSL_ESDHC=y +CONFIG_PHYLIB=y +CONFIG_PHY_ADDR_ENABLE=y +CONFIG_PHY_ATHEROS=y +CONFIG_DM_ETH=y +CONFIG_NET_RANDOM_ETHADDR=y +CONFIG_PHY_GIGE=y +CONFIG_FEC_MXC_SHARE_MDIO=y +CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 +CONFIG_FEC_MXC=y +CONFIG_MII=y +CONFIG_PINCTRL=y +CONFIG_SPL_PINCTRL=y +CONFIG_PINCTRL_IMX8=y +CONFIG_POWER_DOMAIN=y +CONFIG_IMX8_POWER_DOMAIN=y +CONFIG_DM_REGULATOR=y +CONFIG_SPL_DM_REGULATOR=y +CONFIG_DM_REGULATOR_FIXED=y +CONFIG_DM_REGULATOR_GPIO=y +CONFIG_SPL_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +CONFIG_FSL_LPUART=y +CONFIG_SPL_TINY_MEMSET=y +# CONFIG_EFI_LOADER is not set(quoted diff) +0
-0
b/include/configs/imx8qxp_ai_ml.hnew file mode 100644 index 0000000000..dd31189845include/configs/imx8qxp_ai_ml.h new file +14
-0@@ -0,0 +1,104 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright 2018 NXP +* Copyright 2019 Linaro Ltd. +*/ + +#ifndef __IMX8QXP_AI_ML_H +#define __IMX8QXP_AI_ML_H + +#include <linux/sizes.h> +#include <asm/arch/imx-regs.h> + +#ifdef CONFIG_SPL_BUILD +#define CONFIG_SPL_MAX_SIZE (124 * 1024) +#define
CONFIG_SYS_MONITOR_LEN(1024 * 1024) +#defineCONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR+#defineCONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR0x250+#defineCONFIG_SYS_MMCSD_FS_BOOT_PARTITION0 +
+#defineCONFIG_SPL_LDSCRIPT"arch/arm/cpu/armv8/u-boot-spl.lds" +#defineCONFIG_SPL_STACK0x013E000+#defineCONFIG_SPL_BSS_START_ADDR0x00128000+#defineCONFIG_SPL_BSS_MAX_SIZE0x1000/* 4 KB
*/ +#defineCONFIG_SYS_SPL_MALLOC_START0x00120000
+#defineCONFIG_SYS_SPL_MALLOC_SIZE0x3000/*
12 KB */ +#defineCONFIG_SERIAL_LPUART_BASE0x5a080000include/configs/imx8qxp_ai_ml.h line 33
Quoted 5 lines
include/configs/imx8qxp_ai_ml.h new file +5
-0+#define CONFIG_MALLOC_F_ADDR 0x00120000 + +#define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE + +#define CONFIG_SPL_ABORT_ON_RAW_IMAGE + +#define CONFIG_OF_EMBED I'm not sure if the
OF_EMBEDis not deprecated ... and replaced byOF_SEPARATED.Quoted 8 lines
Quoted 1 line
I'm not sure about this. I don't see any such information.
There was a u-boot ML discussion about
OF_EMBEDdeprecation.
https://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=*&q=OF_EMBED&archive=both&delegate=Also please see:
https://www.chromium.org/developers/u-bootOkay, thanks for the pointer.
Quoted 71 lines
Quoted 71 lines
Quoted 9 lines
include/configs/imx8qxp_ai_ml.h line 38
Quoted 6 lines
include/configs/imx8qxp_ai_ml.h new file +5
-0+#endif + +#define CONFIG_REMAKE_ELF + +#define CONFIG_BOARD_EARLY_INIT_F This could be set in
Kconfig, IIRCAck.
Quoted 58 lines
Quoted 52 lines
include/configs/imx8qxp_ai_ml.h new file +17
-0+ +/* Flat Device Tree Definitions */ +#define CONFIG_OF_BOARD_SETUP + +#define CONFIG_FSL_USDHC + +#define CONFIG_ENV_OVERWRITE + +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define BOOT_TARGET_DEVICES (func) \ + func(MMC, mmc, 1) \ + func(DHCP, dhcp, na) + +#include <config_distro_bootcmd.h> +/* Initial environment variables */ +#define CONFIG_EXTRA_ENV_SETTINGS \
include/configs/imx8qxp_ai_ml.h new file +11
-0+"console=ttyLP2 earlycon\0" \ +"fdt_addr_r=0x83000000\0" \ +"kernel_addr_r=0x81000000\0" \ +"ramdisk_addr_r=0x94400000\0" \ +"scriptaddr=0x89000000\0" \ +"fdtfile=imx8qxp-ai_ml.dtb\0" \ +"fdt_high=0xffffffffffffffff\0" \ +"image=Image\0" \ +"initrd_addr=0x83800000\0" \ +"initrd_high=0xffffffffffffffff\0" \ + "netargs=setenv bootargsconsole=${console},${baudrate} " \
include/configs/imx8qxp_ai_ml.h new file +1
-0+ "root=/dev/nfs ip=dhcpnfsroot=${serverip}:${nfsroot},v3,tcp" \
include/configs/imx8qxp_ai_ml.h new file +2
-0+"\0" \ + "nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp${fdt_addr} " \
include/configs/imx8qxp_ai_ml.h new file +1
-0+ "imx8qxp-ai_ml/${fdt_file}; booti${loadaddr} - ${fdt_addr}\0" \
include/configs/imx8qxp_ai_ml.h new file +15
-0+ BOOTENV + +/* Link Definitions */ +#define CONFIG_LOADADDR 0x80280000 + +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR + +#define CONFIG_SYS_INIT_SP_ADDR 0x80200000 + +/* Default environment is in SD */ +#define CONFIG_ENV_SIZE 0x1000 +#define CONFIG_ENV_OFFSET (64 * SZ_64K) + +/* USDHC2 is the SD card interface */ +#define CONFIG_SYS_MMC_ENV_DEV 1/* USDHC2 Quoted 2 lines
*/ +#define
CONFIG_SYS_FSL_USDHC_NUM2
+Some of those env setting defines as well as eMMC ones could be set now in
Kconfig.Quoted 7 lines
Quoted 2 lines
Can you please specify those? I don't see these defines used in
Kconfig.The best (and simplest) way is to just check if the corresponding CONFIG_* option is already moved (ported) to
Kconfig. For exampleENV_SIZEandENV_OFFSETare.
Quoted 66 lines
Yeah, I see it now that couple of boards are using it. Will do the same.
Thanks,
ManiQuoted 58 lines
Quoted 14 lines
Quoted 13 lines
Quoted 10 lines
include/configs/imx8qxp_ai_ml.h new file +2
-0+/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN ((
CONFIG_ENV_SIZE+ (32
* 1024)) * 1024) +include/configs/imx8qxp_ai_ml.h new file +4
-0+#define CONFIG_SYS_SDRAM_BASE 0x80000000 +#define PHYS_SDRAM_1 0x80000000 +#define PHYS_SDRAM_2 0x880000000 +#define PHYS_SDRAM_1_SIZE SZ_2G/* 2Please fix this file globally, to use "
SZ_XX" instead of magic numbers.Quoted 31 lines
Ack.
Thanks,
ManiQuoted 24 lines
include/configs/imx8qxp_ai_ml.h line 104
Quoted 10 lines
GB */ +#define
PHYS_SDRAM_2_SIZE0x00000000
/* 0 GB */ +include/configs/imx8qxp_ai_ml.h new file +2
-0+/* Generic Timer Definitions */ +#define COUNTER_FREQUENCY 8000000/* 8MHz */ +
include/configs/imx8qxp_ai_ml.h new file +5
-0+/* Networking */ +#define CONFIG_FEC_XCV_TYPE RGMII +#define FEC_QUIRK_ENET_MAC + +#endif /* __IMX8QXP_AI_ML_H */ Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax:
(+49)-8142-66989-80 Email: lukma at denx.deBest regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190815/5f7b718d/attachment.sig>
v4 cover Add board support for iMX8QXP AI_ML board
In reply to Manivannan SadhasivamHi Manivannan,
Quoted 6 lines
Hello,
This patchset adds initial board support for iMX8QXP
AI_MLboard from Einfochips. This board is one of the Consumer Edition and AI boards of the 96Boards family.
Quoted 7 lines
This initial supports contains following peripherals which are tested and known to work:
1. Debug serial via UART2
2. SD card
3. Ethernet
Please paste the output when u-boot boots for this board (from the SPL banner to Linux booting).
Quoted 44 lines
Thanks,
ManiNote: This patchset depends on the below cleanup patches submitted:
[U-Boot,1/2] arm: imx8: factor out uart init code [U-Boot,2/2] arm: imx8: don't duplicatebuild_info()Changes in v4:
* Incorporated review comments from Fabio.
Changes in v3:
* Incorporated review comments from Fabio. Major change is switching to
distro_boot.
* Added Reviewed-by tag from Peng Fan.Changes in v2:
* Rebased the patches on top of following patches:
[U-Boot,1/2] arm: imx8: factor out uart init code [U-Boot,2/2] arm: imx8: don't duplicatebuild_info()Manivannan Sadhasivam (2):
arm: dts: Add devicetree support for iMXQXPAI_MLboard
board: Add support for iMX8QXPAI_MLboardarch/arm/dts/Makefile | 1 + arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi | 117 +++++++++++ arch/arm/dts/fsl-imx8qxp-ai_ml.dts | 181 ++++++++++++++++++ arch/arm/mach-imx/imx8/Kconfig | 6 + board/einfochips/imx8qxp_ai_ml/Kconfig | 12 ++ board/einfochips/imx8qxp_ai_ml/MAINTAINERS | 6 + board/einfochips/imx8qxp_ai_ml/Makefile | 8 + board/einfochips/imx8qxp_ai_ml/README | 49 +++++ .../einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c | 117 +++++++++++ board/einfochips/imx8qxp_ai_ml/imximage.cfg | 24 +++ board/einfochips/imx8qxp_ai_ml/spl.c | 49 +++++ configs/imx8qxp_ai_ml_defconfig | 83 ++++++++ include/configs/imx8qxp_ai_ml.h | 104 ++++++++++ 13 files changed, 757 insertions(+) create mode 100644 arch/arm/dts/fsl-imx8qxp-ai_ml-u-boot.dtsi create mode 100644 arch/arm/dts/fsl-imx8qxp-ai_ml.dts create mode 100644 board/einfochips/imx8qxp_ai_ml/Kconfig
Quoted 9 lines
create mode 100644 board/einfochips/imx8qxp_ai_ml/MAINTAINERS create mode 100644 board/einfochips/imx8qxp_ai_ml/Makefile create mode 100644 board/einfochips/imx8qxp_ai_ml/README create mode 100644 board/einfochips/imx8qxp_ai_ml/imx8qxp_ai_ml.c create mode 100644 board/einfochips/imx8qxp_ai_ml/imximage.cfg create mode 100644 board/einfochips/imx8qxp_ai_ml/spl.c create mode 100644 configs/imx8qxp_ai_ml_defconfig create mode 100644 include/configs/imx8qxp_ai_ml.h
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190724/7c8b64df/attachment.sig>