Skip to contentSkip to conversation

net/ipv4: cleanup error condition testing

PATCH Applied Pavel Machek 2 participants 2 messages Jul 24, 2019

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

PATCH 1/1 net/ipv4: cleanup error condition testing

Cleanup testing for error condition.

Signed-off-by Pavel Machek <[email protected]>
net/ipv4/inet_fragment.c +1 -1
index d666756..a999451 100644
@@ -331,7 +331,7 @@ struct inet_frag_queue *inet_frag_find(struct fqdir *fqdir, void *key)
 	prev = rhashtable_lookup(&fqdir->rhashtable, key, fqdir->f->rhash_params);
 	if (!prev)
 		fq = inet_frag_create(fqdir, key, &prev);
-	if (prev && !IS_ERR(prev)) {
+	if (!IS_ERR_OR_NULL(prev)) {
 		fq = prev;
 		if (!refcount_inc_not_zero(&fq->refcnt))
 			fq = NULL;
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html