Skip to contentSkip to conversation

meta-oe: Inherit gnomebase instead of gnome

PATCH Superseded Adrian Bunk 2 participants 6 messages Jul 23, 2019 – Jul 28, 2019

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 meta-oe: Inherit gnomebase instead of gnome

The gnome class pulls in usually unwanted dependencies like gconf.

---
 meta-oe/recipes-gnome/atk/atkmm_2.28.0.bb                | 2 +-
 meta-oe/recipes-gnome/vte9/vte9.inc                      | 2 +-
 meta-oe/recipes-graphics/gimp/gimp_2.8.22.bb             | 3 ++-
 meta-oe/recipes-multimedia/pulseaudio/pavucontrol_4.0.bb | 4 ++--
 meta-oe/recipes-support/pidgin/gmime_3.2.3.bb            | 2 +-
 5 files changed, 7 insertions(+), 6 deletions(-)
meta-oe/recipes-gnome/atk/atkmm_2.28.0.bb +1 -1
index 63f4f09ba..e587e2a10 100644
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1 \
 
 DEPENDS = "atk glibmm"
 
-inherit distro_features_check gnome autotools pkgconfig
+inherit distro_features_check gnomebase autotools pkgconfig
 
 REQUIRED_DISTRO_FEATURES = "x11"
 
meta-oe/recipes-gnome/vte9/vte9.inc +1 -1
index 206c430da..d860d44e2 100644
@@ -8,7 +8,7 @@ RDEPENDS_libvte = "vte-termcap"
 GNOMEBN = "vte"
 S = "${WORKDIR}/vte-${PV}"
 
-inherit gnome gtk-doc distro_features_check upstream-version-is-even gobject-introspection
+inherit gnomebase gtk-doc distro_features_check upstream-version-is-even gobject-introspection
 ANY_OF_DISTRO_FEATURES = "${GTK2DISTROFEATURES}"
 
 EXTRA_OECONF = "--disable-python"
meta-oe/recipes-graphics/gimp/gimp_2.8.22.bb +2 -1
index 943986e77..1d64910fd 100644
@@ -8,6 +8,7 @@ DEPENDS = " \
     gdk-pixbuf-native \
     intltool-native \
     libxslt-native \
+    dbus-glib \
     gtk+ \
     babl \
     gegl \
@@ -24,7 +25,7 @@ DEPENDS = " \
 "
 DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'libxmu libxpm', '', d)}"
 
-inherit distro_features_check gnome gtk-doc
+inherit distro_features_check gnomebase gtk-icon-cache gtk-doc
 
 REQUIRED_DISTRO_FEATURES = "x11"
 
meta-oe/recipes-multimedia/pulseaudio/pavucontrol_4.0.bb +2 -2
index 6a8274405..421ea9d5c 100644
@@ -2,9 +2,9 @@ DESCRIPTION = "PulseAudio Volume Control (pavucontrol) is a simple GTK based vol
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe"
 
-DEPENDS = "intltool-native gtkmm3 libcanberra pulseaudio"
+DEPENDS = "intltool-native gtk+3-native gtkmm3 libcanberra pulseaudio"
 
-inherit gnome distro_features_check
+inherit gnomebase distro_features_check
 
 REQUIRED_DISTRO_FEATURES = "x11"
 
meta-oe/recipes-support/pidgin/gmime_3.2.3.bb +1 -1
index 8c6f0b010..bce89bec8 100644
@@ -4,7 +4,7 @@ DESCRIPTION = "Runtime libraries for parsing and creating MIME mail"
 SECTION = "libs"
 DEPENDS = "glib-2.0 zlib"
 
-inherit gnome autotools gobject-introspection
+inherit gnomebase autotools gobject-introspection
 
 SRC_URI += "file://iconv-detect.h \
             file://nodolt.patch"
Signature · 1 line
2.17.1
#1 lore raw

This causes
https://errors.yoctoproject.org/Errors/Details/253988/
maybe due to atkmm change is exposing another missing inherit
gnome-system-monitor -> gtkmm3 -> atkmm

Quoted 96 lines · Adrian Bunk

The gnome class pulls in usually unwanted dependencies like gconf.

---
 meta-oe/recipes-gnome/atk/atkmm_2.28.0.bb                | 2 +-
 meta-oe/recipes-gnome/vte9/vte9.inc                      | 2 +-
 meta-oe/recipes-graphics/gimp/gimp_2.8.22.bb             | 3 ++-
 meta-oe/recipes-multimedia/pulseaudio/pavucontrol_4.0.bb | 4 ++--
 meta-oe/recipes-support/pidgin/gmime_3.2.3.bb            | 2 +-
 5 files changed, 7 insertions(+), 6 deletions(-)
meta-oe/recipes-gnome/atk/atkmm_2.28.0.bb +1 -1
index 63f4f09ba..e587e2a10 100644
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1 \
 
 DEPENDS = "atk glibmm"
 
-inherit distro_features_check gnome autotools pkgconfig
+inherit distro_features_check gnomebase autotools pkgconfig
 
 REQUIRED_DISTRO_FEATURES = "x11"
 
meta-oe/recipes-gnome/vte9/vte9.inc +1 -1
index 206c430da..d860d44e2 100644
@@ -8,7 +8,7 @@ RDEPENDS_libvte = "vte-termcap"
 GNOMEBN = "vte"
 S = "${WORKDIR}/vte-${PV}"
 
-inherit gnome gtk-doc distro_features_check upstream-version-is-even gobject-introspection
+inherit gnomebase gtk-doc distro_features_check upstream-version-is-even gobject-introspection
 ANY_OF_DISTRO_FEATURES = "${GTK2DISTROFEATURES}"
 
 EXTRA_OECONF = "--disable-python"
meta-oe/recipes-graphics/gimp/gimp_2.8.22.bb +2 -1
index 943986e77..1d64910fd 100644
@@ -8,6 +8,7 @@ DEPENDS = " \
     gdk-pixbuf-native \
     intltool-native \
     libxslt-native \
+    dbus-glib \
     gtk+ \
     babl \
     gegl \
@@ -24,7 +25,7 @@ DEPENDS = " \
 "
 DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'libxmu libxpm', '', d)}"
 
-inherit distro_features_check gnome gtk-doc
+inherit distro_features_check gnomebase gtk-icon-cache gtk-doc
 
 REQUIRED_DISTRO_FEATURES = "x11"
 
meta-oe/recipes-multimedia/pulseaudio/pavucontrol_4.0.bb +2 -2
index 6a8274405..421ea9d5c 100644
@@ -2,9 +2,9 @@ DESCRIPTION = "PulseAudio Volume Control (pavucontrol) is a simple GTK based vol
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe"
 
-DEPENDS = "intltool-native gtkmm3 libcanberra pulseaudio"
+DEPENDS = "intltool-native gtk+3-native gtkmm3 libcanberra pulseaudio"
 
-inherit gnome distro_features_check
+inherit gnomebase distro_features_check
 
 REQUIRED_DISTRO_FEATURES = "x11"
 
meta-oe/recipes-support/pidgin/gmime_3.2.3.bb +1 -2
index 8c6f0b010..bce89bec8 100644
@@ -4,7 +4,7 @@ DESCRIPTION = "Runtime libraries for parsing and creating MIME mail"
 SECTION = "libs"
 DEPENDS = "glib-2.0 zlib"
 
-inherit gnome autotools gobject-introspection
+inherit gnomebase autotools gobject-introspection
 
 SRC_URI += "file://iconv-detect.h \
             file://nodolt.patch"
--

2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw
Quoted 4 lines · Khem Raj

This causes
https://errors.yoctoproject.org/Errors/Details/253988/
maybe due to atkmm change is exposing another missing inherit
gnome-system-monitor -> gtkmm3 -> atkmm

Does gnome-system-monitor build for you with musl without my patches applied? It doesn't for me.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 8 lines · Adrian Bunk
Quoted 4 lines · Khem Raj

This causes
https://errors.yoctoproject.org/Errors/Details/253988/
maybe due to atkmm change is exposing another missing inherit
gnome-system-monitor -> gtkmm3 -> atkmm

Does gnome-system-monitor build for you with musl without my patches applied? It doesn't for me.

Yes it did and build again after reverting there is a chance of race condition but this package has not failed before

Quoted 12 lines

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

#4 lore raw
Quoted 11 lines · Khem Raj
Quoted 7 lines · Adrian Bunk
Quoted 4 lines · Khem Raj

This causes
https://errors.yoctoproject.org/Errors/Details/253988/
maybe due to atkmm change is exposing another missing inherit
gnome-system-monitor -> gtkmm3 -> atkmm

Quoted 6 lines
Quoted 2 lines

Does gnome-system-monitor build for you with musl without my patches applied? It doesn't for me.

Yes it did and build again after reverting there is a chance of race condition but this package has not failed before

a simple rebuild is successful with the patch as well.

#5 lore raw
In reply to Khem Raj
Quoted 8 lines · Khem Raj
Quoted 6 lines · Adrian Bunk
Quoted 4 lines · Khem Raj

This causes
https://errors.yoctoproject.org/Errors/Details/253988/
maybe due to atkmm change is exposing another missing inherit
gnome-system-monitor -> gtkmm3 -> atkmm

Quoted 5 lines
Quoted 2 lines

Does gnome-system-monitor build for you with musl without my patches applied? It doesn't for me.

Yes it did and build again after reverting there is a chance of race condition but this package has not failed before

My musl build failure was actually an undeclared dependency on polkit, I'll send a patch for that.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed