Skip to contentSkip to conversation

pidfd: Add warning if exit_state is 0 during notification

PATCH In review Joel Fernandes (Google) 2 participants 2 messages Jul 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pidfd: Add warning if exit_state is 0 during notification

Previously a condition got missed where the pidfd waiters are awakened before the exit_state gets set. This can result in a missed notification
[1] and the polling thread waiting forever.

It is fixed now, however it would be nice to avoid this kind of issue going unnoticed in the future. So just add a warning to catch it in the future.

[1] https://lore.kernel.org/lkml/[email protected]/

---
 kernel/signal.c | 1 +
 1 file changed, 1 insertion(+)
kernel/signal.c +1 -0
index 91b789dd6e72..349f5a67f100 100644
@@ -1885,6 +1885,7 @@ static void do_notify_pidfd(struct task_struct *task)
 {
 	struct pid *pid;
 
+	WARN_ON(task->exit_state == 0);
 	pid = task_pid(task);
 	wake_up_all(&pid->wait_pidfd);
 }
Signature · 1 line
2.22.0.657.g960e92d24f-goog
Reviewed-by on v1 1/1
#1 lore raw
Quoted 29 lines · Joel Fernandes (Google)

Previously a condition got missed where the pidfd waiters are awakened before the exit_state gets set. This can result in a missed notification
[1] and the polling thread waiting forever.

It is fixed now, however it would be nice to avoid this kind of issue going unnoticed in the future. So just add a warning to catch it in the future.

[1]
https://lore.kernel.org/lkml/[email protected]/

---
kernel/signal.c | 1 +

1 file changed, 1 insertion(+)
kernel/signal.c +1 -0
index 91b789dd6e72..349f5a67f100 100644
@@ -1885,6 +1885,7 @@ static void do_notify_pidfd(struct task_struct
 *task)
 {
 	struct pid *pid;
 
+	WARN_ON(task->exit_state == 0);
 	pid = task_pid(task);
 	wake_up_all(&pid->wait_pidfd);
Quoted 1 line

}

Makes sense to me.
I'm picking this up unless someone sees a problem with this patch.