Skip to contentSkip to conversation

remoteproc: Fix potential build issues with SPL remoteproc

PATCH New Suman Anna 4 participants 4 messages Jul 19, 2019 – Jul 24, 2019

lore
Share & tools
lore

Suman Anna

author
#0 lore raw

PATCH 1/1 remoteproc: Fix potential build issues with SPL remoteproc

The rproc uclass driver can either be built with SPL_REMOTEPROC or REMOTEPROC, but the function prototypes in remoteproc.h are defined only when CONFIG_REMOTEPROC is defined. This can cause build issues in SPL if CONFIG_REMOTEPROC is not selected.

Fix this by replacing the existing precompiler macro usage with CONFIG_IS_ENABLED.

Fixes ddf56bc7e3ef ("drivers: Introduce a simplified remoteproc framework")
---
 include/remoteproc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/remoteproc.h +1 -1
index a59dba84810f..6be737d8d119 100644
@@ -77,7 +77,7 @@ struct dm_rproc_ops {
 /* Accessor */
 #define rproc_get_ops(dev) ((struct dm_rproc_ops *)(dev)->driver->ops)
 
-#ifdef CONFIG_REMOTEPROC
+#if CONFIG_IS_ENABLED(REMOTEPROC)
 /**
  * rproc_init() - Initialize all bound remote proc devices
  *
Signature · 1 line
2.22.0
#1 lore raw

PATCH 1/1 remoteproc: Fix potential build issues with SPL remoteproc

Quoted 30 lines · Suman Anna

The rproc uclass driver can either be built with SPL_REMOTEPROC or REMOTEPROC, but the function prototypes in remoteproc.h are defined only when CONFIG_REMOTEPROC is defined. This can cause build issues in SPL if CONFIG_REMOTEPROC is not selected.

Fix this by replacing the existing precompiler macro usage with CONFIG_IS_ENABLED.

Fixes ddf56bc7e3ef ("drivers: Introduce a simplified remoteproc framework")
---
 include/remoteproc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/remoteproc.h +1 -1
index a59dba84810f..6be737d8d119 100644
@@ -77,7 +77,7 @@ struct dm_rproc_ops {
 /* Accessor */
 #define rproc_get_ops(dev) ((struct dm_rproc_ops *)(dev)->driver->ops)
 
-#ifdef CONFIG_REMOTEPROC
+#if CONFIG_IS_ENABLED(REMOTEPROC)
 /**
  * rproc_init() - Initialize all bound remote proc devices
  *
Signature · 1 line
2.22.0

Aaah.. Thanks..

Signature · 2 lines
Regards,
Nishanth Menon
#2 lore raw

PATCH 1/1 remoteproc: Fix potential build issues with SPL remoteproc

In reply to Suman Anna
Quoted 10 lines · Suman Anna

The rproc uclass driver can either be built with SPL_REMOTEPROC or REMOTEPROC, but the function prototypes in remoteproc.h are defined only when CONFIG_REMOTEPROC is defined. This can cause build issues in SPL if CONFIG_REMOTEPROC is not selected.

Fix this by replacing the existing precompiler macro usage with CONFIG_IS_ENABLED.

Fixes ddf56bc7e3ef ("drivers: Introduce a simplified remoteproc framework")

Thanks and regards,
Lokesh

#3 lore raw

PATCH 1/1 remoteproc: Fix potential build issues with SPL remoteproc

In reply to Suman Anna
Quoted 5 lines · Suman Anna

The rproc uclass driver can either be built with SPL_REMOTEPROC or REMOTEPROC, but the function prototypes in remoteproc.h are defined only when CONFIG_REMOTEPROC is defined. This can cause build issues in SPL if CONFIG_REMOTEPROC is not selected.

Quoted 7 lines

Fix this by replacing the existing precompiler macro usage with CONFIG_IS_ENABLED.

Fixes ddf56bc7e3ef ("drivers: Introduce a simplified remoteproc framework")

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190724/88f2daf2/attachment.sig>