Skip to contentSkip to conversation

Fix uninitialized variable in ipmb_dev_int.c

PATCH Applied Asmaa Mnebhi 2 participants 3 messages Jul 24, 2019 IPMI

lore
Share & tools
lore
#0 lore raw

cover Fix uninitialized variable in ipmb_dev_int.c

ret at line 112 of ipmb_dev_int.c is uninitialized which results in a warning during build regressions.

This warning was reported during regression/improvement testing led by Geert Uytterhoeven for v5.3-rc1.

Asmaa Mnebhi (1):
Fix uninitialized variable in ipmb_dev_int.c

 drivers/char/ipmi/ipmb_dev_int.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.1.2
#1 lore raw

PATCH 1/1 Fix uninitialized variable in ipmb_dev_int.c

ret at line 112 of ipmb_dev_int.c is uninitialized which results in a warning during build regressions. This warning was found by build regression/improvement testing for v5.3-rc1.

Reported-by build regression/improvement testing for v5.3-rc1.
Fixes 51bd6f291583 ("Add support for IPMB driver")
---
 drivers/char/ipmi/ipmb_dev_int.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/ipmi/ipmb_dev_int.c +1 -1
index 5720433..285e0b8 100644
@@ -76,7 +76,7 @@ static ssize_t ipmb_read(struct file *file, char __user *buf, size_t count,
 	struct ipmb_dev *ipmb_dev = to_ipmb_dev(file);
 	struct ipmb_request_elem *queue_elem;
 	struct ipmb_msg msg;
-	ssize_t ret;
+	ssize_t ret = 0;
 
 	memset(&msg, 0, sizeof(msg));
 
Signature · 1 line
2.1.2
#2 lore raw
Quoted 4 lines · Asmaa Mnebhi

ret at line 112 of ipmb_dev_int.c is uninitialized which results in a warning during build regressions. This warning was found by build regression/improvement testing for v5.3-rc1.

Applied, thanks for sticking with it :).

-corey

Quoted 24 lines
Reported-by build regression/improvement testing for v5.3-rc1.
Fixes 51bd6f291583 ("Add support for IPMB driver")
---
 drivers/char/ipmi/ipmb_dev_int.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/ipmi/ipmb_dev_int.c +1 -1
index 5720433..285e0b8 100644
@@ -76,7 +76,7 @@ static ssize_t ipmb_read(struct file *file, char __user *buf, size_t count,
 	struct ipmb_dev *ipmb_dev = to_ipmb_dev(file);
 	struct ipmb_request_elem *queue_elem;
 	struct ipmb_msg msg;
-	ssize_t ret;
+	ssize_t ret = 0;
 
 	memset(&msg, 0, sizeof(msg));
 
Signature · 1 line
2.1.2