ALSA: echoaudio: Replace kmalloc + memcpy with kmemdup
PATCH 1/1 ALSA: echoaudio: Replace kmalloc + memcpy with kmemdup
Instead of using kmalloc + memcpy, use kmemdup
to simplify the code.
Signed-off-by Chuhong Yuan <[email protected]>
--- sound/pci/echoaudio/echoaudio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
sound/pci/echoaudio/echoaudio.c +2 -3
@@ -2189,11 +2189,10 @@ static int snd_echo_resume(struct device *dev)u32 pipe_alloc_mask;int err; - commpage_bak =kmalloc (sizeof (*commpage),GFP_KERNEL ); + commpage = chip->comm_page; + commpage_bak =kmemdup (commpage,sizeof (*commpage),GFP_KERNEL );if (commpage_bak ==NULL )return -ENOMEM ; - commpage = chip->comm_page; -memcpy (commpage_bak, commpage,sizeof (*commpage)); err =init_hw (chip, chip->pci->device, chip->pci->subsystem_device);if (err <0 ) {
Signature · 1 line
2.20.1
Takashi Iwai
AppliedQuoted 5 lines · Chuhong Yuan
Instead of using kmalloc + memcpy, use kmemdup
to simplify the code.Signed-off-by Chuhong Yuan <[email protected]>
Applied, thanks.
Takashi