extcon: max77693: Add extra IRQF_ONESHOT
Subsystems (2)
PATCH 1/1 extcon: max77693: Add extra IRQF_ONESHOT
Do not fire irq again until thread done
This issue was found by code inspection
Coccicheck irqf_oneshot.cocci
--- drivers/extcon/extcon-max77693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon-max77693.c +1 -1
@@ -1142,7 +1142,7 @@ static int max77693_muic_probe(struct platform_device *pdev) ret =devm_request_threaded_irq (&pdev->dev, virq,NULL , max77693_muic_irq_handler, -IRQF_NO_SUSPEND , +IRQF_NO_SUSPEND |IRQF_ONESHOT , muic_irq->name, info);if (ret) { dev_err(&pdev->dev,
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerQuoted 4 lines · Vasyl Gomonovych
Do not fire irq again until thread done
This issue was found by code inspection
Coccicheckirqf_oneshot.cocci
Rationale does not look convincing. Do you fix real problem or just automatic fix from coccinelle? If the latter, then it looks wrong. This is virtual IRQ so no need for oneshot. The hardware IRQ has oneshot set. Otherwise please provide slightly more specific rationale for this commit.
Best regards,
Krzysztof
Quoted 22 lines
Signed-off-by Vasyl Gomonovych <[email protected]>--- drivers/extcon/extcon-max77693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/extcon/extcon-max77693.c +1
-2@@ -1142,7 +1142,7 @@ static int max77693_muic_probe(struct platform_device *pdev) ret =devm_request_threaded_irq (&pdev->dev, virq,NULL , max77693_muic_irq_handler, -IRQF_NO_SUSPEND , +IRQF_NO_SUSPEND |IRQF_ONESHOT , muic_irq->name, info);if (ret) { dev_err(&pdev->dev, --2.17.1
Sorry, my bad, I have missed disabling place, and positive feedback for max in other thread and push me to send it.
Quoted 39 lines · Krzysztof Kozlowski
Quoted 4 lines · Vasyl Gomonovych
Do not fire irq again until thread done
This issue was found by code inspection
Coccicheckirqf_oneshot.cocciRationale does not look convincing. Do you fix real problem or just automatic fix from coccinelle? If the latter, then it looks wrong. This is virtual IRQ so no need for oneshot. The hardware IRQ has oneshot set. Otherwise please provide slightly more specific rationale for this commit.
Best regards,
KrzysztofQuoted 22 lines
Signed-off-by Vasyl Gomonovych <[email protected]>--- drivers/extcon/extcon-max77693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/extcon/extcon-max77693.c +1
-2@@ -1142,7 +1142,7 @@ static int max77693_muic_probe(struct platform_device *pdev) ret =devm_request_threaded_irq (&pdev->dev, virq,NULL , max77693_muic_irq_handler, -IRQF_NO_SUSPEND , +IRQF_NO_SUSPEND |IRQF_ONESHOT , muic_irq->name, info);if (ret) { dev_err(&pdev->dev, --2.17.1
Signature · 1 line
Доброї вам пори дня.