extcon: max14577: Add irq mask IRQ_ONESHOT
Subsystems (2)
PATCH 1/1 extcon: max14577: Add irq mask IRQ_ONESHOT
Do not fire irq again until thread done
This issue was found by code inspection
Coccicheck irqf_oneshot.cocci
Signed-off-by Vasyl Gomonovych <[email protected]>
--- drivers/extcon/extcon-max14577.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon-max14577.c +1 -1
@@ -698,7 +698,7 @@ static int max14577_muic_probe(struct platform_device *pdev) ret =devm_request_threaded_irq (&pdev->dev, virq,NULL , max14577_muic_irq_handler, -IRQF_NO_SUSPEND , +IRQF_NO_SUSPEND |IRQF_ONESHOT , muic_irq->name, info);if (ret) { dev_err(&pdev->dev,
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerQuoted 4 lines · Vasyl Gomonovych
Do not fire irq again until thread done
This issue was found by code inspection
Coccicheckirqf_oneshot.cocci
The same as in max77693 - this is virtual IRQ so no need for oneshot. The hardware IRQ has oneshot set. Otherwise please provide slightly more specific rationale for this commit.
Best regards,
Krzysztof
Quoted 22 lines
Signed-off-by Vasyl Gomonovych <[email protected]>--- drivers/extcon/extcon-max14577.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/extcon/extcon-max14577.c +1
-2@@ -698,7 +698,7 @@ static int max14577_muic_probe(struct platform_device *pdev) ret =devm_request_threaded_irq (&pdev->dev, virq,NULL , max14577_muic_irq_handler, -IRQF_NO_SUSPEND , +IRQF_NO_SUSPEND |IRQF_ONESHOT , muic_irq->name, info);if (ret) { dev_err(&pdev->dev, --2.17.1