Skip to contentSkip to conversation

mmc: sdhci-pltfm: Use devm_platform_ioremap_resource() to simplify code

PATCH In review Jisheng Zhang 2 participants 2 messages Jul 25, 2019

Subsystems (2)
MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver
lore
Share & tools
lore

Jisheng Zhang

author
#0 lore raw

PATCH 1/1 mmc: sdhci-pltfm: Use devm_platform_ioremap_resource() to simplify code

devm_platform_ioremap_resource() wraps platform_get_resource() and devm_ioremap_resource() in a single helper, let's use that helper to simplify the code.

Signed-off-by Jisheng Zhang <[email protected]>
---
 drivers/mmc/host/sdhci-pltfm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/mmc/host/sdhci-pltfm.c +1 -3
index d268b3b8850a..11ecff9e998d 100644
@@ -118,12 +118,10 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
 				    size_t priv_size)
 {
 	struct sdhci_host *host;
-	struct resource *iomem;
 	void __iomem *ioaddr;
 	int irq, ret;
 
-	iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	ioaddr = devm_ioremap_resource(&pdev->dev, iomem);
+	ioaddr = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(ioaddr)) {
 		ret = PTR_ERR(ioaddr);
 		goto err;
Signature · 1 line
2.22.0
#1 lore raw
Quoted 6 lines · Jisheng Zhang

devm_platform_ioremap_resource() wraps platform_get_resource() and devm_ioremap_resource() in a single helper, let's use that helper to simplify the code.

Signed-off-by Jisheng Zhang <[email protected]>

Applied for next, thanks!

Kind regards
Uffe

Quoted 25 lines
---
 drivers/mmc/host/sdhci-pltfm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/mmc/host/sdhci-pltfm.c +1 -4
index d268b3b8850a..11ecff9e998d 100644
@@ -118,12 +118,10 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
                                    size_t priv_size)
 {
        struct sdhci_host *host;
-       struct resource *iomem;
        void __iomem *ioaddr;
        int irq, ret;
 
-       iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       ioaddr = devm_ioremap_resource(&pdev->dev, iomem);
+       ioaddr = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(ioaddr)) {
                ret = PTR_ERR(ioaddr);
                goto err;
--

2.22.0