cxgb4: remove unused c4iw_match_device
PATCH 2/2 cxgb4: remove unused c4iw_match_device
match_device handler is no longer needed after latest device binding changes.
--- providers/cxgb4/dev.c | 41 ----------------------------------------- 1 file changed, 41 deletions(-)
providers/cxgb4/dev.c +0 -41
@@ -403,46 +403,6 @@ void dump_state(void)*/ int c4iw_abi_version =1 ; -static bool c4iw_device_match (struct verbs_sysfs_dev *sysfs_dev) -{ -char value[32 ], *cp; -unsigned int fw_maj, fw_min; - -/* Rely on the core code to match PCI devices */ -if (!sysfs_dev->match) -return false; - -/* -* Verify that the firmware major number matches. Major number -* mismatches are fatal. Minor number mismatches are tolerated. -*/ -if (ibv_get_fw_ver (value,sizeof (value), sysfs_dev)) -return false; - - cp =strtok (value+1 ,"." ); -sscanf (cp,"%i" , &fw_maj); - cp =strtok (NULL ,"." ); -sscanf (cp,"%i" , &fw_min); - -if ((signed int )fw_maj <FW_MAJ ) { -fprintf (stderr,"libcxgb4: Fatal firmware version mismatch. " -"Firmware major number is %u and libcxgb4 needs %u.\n" , - fw_maj,FW_MAJ ); -fflush (stderr); -return false; - } - -DBGLOG ("libcxgb4" ); - -if ((signed int )fw_min <FW_MIN ) { -PDBG ("libcxgb4: non-fatal firmware version mismatch. " -"Firmware minor number is %u and libcxgb4 needs %u.\n" , - fw_min,FW_MIN ); -fflush (stderr); - } -return true; -} -static struct verbs_device *c4iw_device_alloc (struct verbs_sysfs_dev *sysfs_dev) {struct c4iw_dev *dev;
@@ -498,7 +458,6 @@ static const struct verbs_device_ops c4iw_dev_ops = { .match_min_abi_version = 0, .match_max_abi_version = INT_MAX, .match_table = hca_table, - .match_device = c4iw_device_match, .alloc_device = c4iw_device_alloc, .uninit_device = c4iw_uninit_device, .alloc_context = c4iw_alloc_context,
Signature · 1 line
2.18.0.232.gb7bd9486b055
Quoted 6 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after latest device binding changes.Signed-off-by Potnuri Bharat Teja <[email protected]>--- providers/cxgb4/dev.c | 41 ----------------------------------------- 1 file changed, 41 deletions(-)
Do you know if we can also drop the same code in cxgb3?
Jason
Quoted 9 lines · Jason Gunthorpe
Quoted 6 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after latest device binding changes.Signed-off-by Potnuri Bharat Teja <[email protected]>--- providers/cxgb4/dev.c | 41 ----------------------------------------- 1 file changed, 41 deletions(-)Do you know if we can also drop the same code in cxgb3?
Can we simply remove cxgb3?
Thanks
Quoted 2 lines
Jason
Quoted 4 lines · Leon Romanovsky
Quoted 3 lines · Jason Gunthorpe
Quoted 2 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after latest device binding changes.
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Potnuri Bharat Teja <[email protected]>--- providers/cxgb4/dev.c | 41 ----------------------------------------- 1 file changed, 41 deletions(-)Do you know if we can also drop the same code in cxgb3?
Can we simply remove cxgb3?
I am in talks with the people here. I'll confirm it soon.
Quoted 4 lines
Thanks
Quoted 2 lines
Jason
Quoted 10 lines · Potnuri Bharat Teja
Quoted 9 lines · Leon Romanovsky
Quoted 8 lines · Jason Gunthorpe
Quoted 6 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after latest device binding changes.Signed-off-by Potnuri Bharat Teja <[email protected]>--- providers/cxgb4/dev.c | 41 ----------------------------------------- 1 file changed, 41 deletions(-)
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Do you know if we can also drop the same code in cxgb3?
Can we simply remove cxgb3?
I am in talks with the people here. I'll confirm it soon.
Hi Jason/Doug/Leon,
Chelsio is fine with removing cxgb3.
Thanks,
Bharat.
Quoted 13 lines · Potnuri Bharat Teja
Quoted 12 lines · Potnuri Bharat Teja
Quoted 11 lines · Leon Romanovsky
Quoted 9 lines · Jason Gunthorpe
Quoted 6 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after latest device binding changes.Signed-off-by Potnuri Bharat Teja <[email protected]>--- providers/cxgb4/dev.c | 41 ----------------------------------------- 1 file changed, 41 deletions(-)Do you know if we can also drop the same code in cxgb3?
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Can we simply remove cxgb3?
I am in talks with the people here. I'll confirm it soon.
Hi Jason/Doug/Leon,
Chelsio is fine with removing cxgb3.
Thanks a lot.
Quoted 2 lines
Thanks,
Bharat.
Quoted 17 lines · Leon Romanovsky
Quoted 16 lines · Potnuri Bharat Teja
Quoted 15 lines · Potnuri Bharat Teja
Quoted 13 lines · Leon Romanovsky
Quoted 9 lines · Jason Gunthorpe
Quoted 6 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after latest device binding changes.Signed-off-by Potnuri Bharat Teja <[email protected]>--- providers/cxgb4/dev.c | 41 ----------------------------------------- 1 file changed, 41 deletions(-)Do you know if we can also drop the same code in cxgb3?
Can we simply remove cxgb3?
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
I am in talks with the people here. I'll confirm it soon.
Hi Jason/Doug/Leon,
Chelsio is fine with removing cxgb3.Thanks a lot.
Which parts of cxgb3 can we remove? RDMA, scsi, net or everything?
Thanks
Quoted 3 lines
Quoted 3 lines
Thanks,
Bharat.
Quoted 18 lines · Leon Romanovsky
Quoted 17 lines · Leon Romanovsky
Quoted 16 lines · Potnuri Bharat Teja
Quoted 15 lines · Potnuri Bharat Teja
Quoted 13 lines · Leon Romanovsky
Quoted 9 lines · Jason Gunthorpe
Quoted 6 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after latest device binding changes.Signed-off-by Potnuri Bharat Teja <[email protected]>--- providers/cxgb4/dev.c | 41 ----------------------------------------- 1 file changed, 41 deletions(-)Do you know if we can also drop the same code in cxgb3?
Can we simply remove cxgb3?
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
I am in talks with the people here. I'll confirm it soon.
Hi Jason/Doug/Leon,
Chelsio is fine with removing cxgb3.Thanks a lot.
Which parts of cxgb3 can we remove? RDMA, scsi, net or everything?
I can only say RDMA. For net and scsi parts of cxgb3, the corresponding maintainers might request for their removal.
Should I send a patch removing RDMA cxgb3?
Thanks.
Quoted 24 lines · Potnuri Bharat Teja
Quoted 23 lines · Leon Romanovsky
Quoted 22 lines · Leon Romanovsky
Quoted 20 lines · Potnuri Bharat Teja
Quoted 10 lines · Potnuri Bharat Teja
Quoted 9 lines · Leon Romanovsky
Quoted 8 lines · Jason Gunthorpe
Quoted 6 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after latest device binding changes.Signed-off-by Potnuri Bharat Teja <[email protected]>--- providers/cxgb4/dev.c | 41 ----------------------------------------- 1 file changed, 41 deletions(-)Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Do you know if we can also drop the same code in cxgb3?
Can we simply remove cxgb3?
I am in talks with the people here. I'll confirm it soon.
Hi Jason/Doug/Leon,
Chelsio is fine with removing cxgb3.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Thanks a lot.
Which parts of cxgb3 can we remove? RDMA, scsi, net or everything?
I can only say RDMA. For net and scsi parts of cxgb3, the corresponding maintainers might request for their removal.
Should I send a patch removing RDMA cxgb3?
It will be the best variant.
Thanks
Quoted 2 lines
Thanks.
Quoted 38 lines · Leon Romanovsky
Quoted 37 lines · Potnuri Bharat Teja
Quoted 34 lines · Leon Romanovsky
Quoted 25 lines · Leon Romanovsky
Quoted 23 lines · Potnuri Bharat Teja
Quoted 21 lines · Potnuri Bharat Teja
Quoted 18 lines · Leon Romanovsky
Quoted 5 lines · Jason Gunthorpe
Quoted 3 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after latest device binding changes.Quoted 8 lines
Quoted 6 lines
Signed-off-by Potnuri Bharat Teja <[email protected]Quoted 1 line
--- providers/cxgb4/dev.c | 41 -------------------------- --------------- 1 file changed, 41 deletions(-)Do you know if we can also drop the same code in cxgb3?
Can we simply remove cxgb3?
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
I am in talks with the people here. I'll confirm it soon.
Hi Jason/Doug/Leon,
Chelsio is fine with removing cxgb3.Thanks a lot.
Which parts of cxgb3 can we remove? RDMA, scsi, net or everything?
Quoted 10 lines
Quoted 4 lines
I can only say RDMA. For net and scsi parts of cxgb3, the corresponding
maintainers might request for their removal. Should I send a patch removing RDMA cxgb3?It will be the best variant.
Thanks
Quoted 1 line
Thanks.
I'm not entirely sure that I want it removed yet. The cxgb3 isn't the most stellar device, but it will do 40GBit/s. That's still a very respectable speed (unlike say mthca that was mostly 10GBit/s with only a short run of 20GBit/s devices before it switched over to mlx4). So a cxgb3 based home system is still something very usable. Are we sure we want to remove this?
Signature · 3 lines
Doug Ledford <[email protected]> GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Quoted 48 lines · Doug Ledford
Quoted 47 lines · Leon Romanovsky
Quoted 33 lines · Potnuri Bharat Teja
Quoted 31 lines · Leon Romanovsky
Quoted 30 lines · Leon Romanovsky
Quoted 27 lines · Potnuri Bharat Teja
Quoted 16 lines · Potnuri Bharat Teja
Quoted 14 lines · Leon Romanovsky
Quoted 12 lines · Jason Gunthorpe
Quoted 9 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after latest device binding changes.Signed-off-by Potnuri Bharat Teja <[email protected]Quoted 1 line
--- providers/cxgb4/dev.c | 41 -------------------------- --------------- 1 file changed, 41 deletions(-)Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Do you know if we can also drop the same code in cxgb3?
Can we simply remove cxgb3?
I am in talks with the people here. I'll confirm it soon.
Hi Jason/Doug/Leon,
Chelsio is fine with removing cxgb3.Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Thanks a lot.
Which parts of cxgb3 can we remove? RDMA, scsi, net or everything?
I can only say RDMA. For net and scsi parts of cxgb3, the corresponding
maintainers might request for their removal. Should I send a patch removing RDMA cxgb3?It will be the best variant.
Thanks
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Thanks.
I'm not entirely sure that I want it removed yet. The cxgb3 isn't the most stellar device, but it will do 40GBit/s. That's still a very respectable speed (unlike say mthca that was mostly 10GBit/s with only a short run of 20GBit/s devices before it switched over to mlx4). So a cxgb3 based home system is still something very usable. Are we sure we want to remove this?
I'm sceptical that such home users (who want RDMA part of cxgb3) exist.
My stake here is to remove as much as possible not-maintained driver to simplify overall maintenance effort.
Thanks
Quoted 5 lines
--
Doug Ledford <[email protected]>GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 74 lines · Potnuri Bharat Teja
Quoted 61 lines · Doug Ledford
Quoted 49 lines · Leon Romanovsky
Quoted 47 lines · Potnuri Bharat Teja
Quoted 43 lines · Leon Romanovsky
Quoted 31 lines · Leon Romanovsky
Quoted 28 lines · Potnuri Bharat Teja
Quoted 26 lines · Potnuri Bharat Teja
Quoted 23 lines · Leon Romanovsky
Quoted 15 lines · Jason Gunthorpe
Quoted 11 lines · Potnuri Bharat Teja
match_devicehandler is no longer needed after
latest
device binding changes.Signed-off-by: Potnuri Bharat Teja <
[email protected]--- providers/cxgb4/dev.c | 41 ---------------------- ---- --------------- 1 file changed, 41 deletions(-)Quoted 2 lines
Do you know if we can also drop the same code in
cxgb3?Can we simply remove cxgb3?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
I am in talks with the people here. I'll confirm it soon.
Hi Jason/Doug/Leon,
Chelsio is fine with removing cxgb3.Thanks a lot.
Which parts of cxgb3 can we remove? RDMA, scsi, net or everything?
Quoted 10 lines
Quoted 4 lines
I can only say RDMA. For net and scsi parts of cxgb3, the corresponding
maintainers might request for their removal. Should I send a patch removing RDMA cxgb3?It will be the best variant.
Thanks
Quoted 1 line
Thanks.
Quoted 10 lines
I'm not entirely sure that I want it removed yet. The cxgb3 isn't the
most stellar device, but it will do 40GBit/s. That's still a very respectable speed (unlike say mthca that was mostly 10GBit/s with only a
short run of 20GBit/s devices before it switched over to mlx4). So a
cxgb3 based home system is still something very usable. Are we sure we
want to remove this?
Quoted 14 lines
Hi Doug,
Thanks for the suggestion. I took this discussion forward assuming that we
need to remove drivers which are not/least maintained. T3 adapters have
reached end of life long ago. Most of the times I see some features/changes
regressing due to cxgb3's limited support. based on all these I have put this
proposal of removing cxgb3 in front of the team at Chelsio. They are okay with
removing it.
I now doubt if I missed something. Do you think otherwise? BTW cxgb3 has supported speed is 1/10 Gbps.
[ Adding the list back in because I don't want to have to repeat this ]
I could have sworn we have 40Gig cxgb3 hardware in our lab, but it appears I was wrong. If we had it, it's been pulled and what's left is all 10GigE stuff.
I did a quick search on EBay (which is where I know a lot of people go to get dirt cheap prices on stuff like old cards to build their home networks with) and it didn't really turn up much in the way of cxgb3 gear. There was plenty of gear that would use the cxgb4 driver instead. So, I'm more on board with removing this driver now.
Signature · 3 lines
Doug Ledford <[email protected]> GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Quoted 5 lines · Doug Ledford
I did a quick search on EBay (which is where I know a lot of people go to get dirt cheap prices on stuff like old cards to build their home networks with) and it didn't really turn up much in the way of cxgb3 gear. There was plenty of gear that would use the cxgb4 driver instead. So, I'm more on board with removing this driver now.
I dislike the cxgb3 driver mostly because it is substantially similer to the cxgb4 driver and every fix has to be done twice.
So lets drop it
Jason