Skip to contentSkip to conversation

video: Demote panel timing not found error message

PATCH In review Thierry Reding 3 participants 5 messages Jul 26, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: Demote panel timing not found error message

From: Thierry Reding <[email protected]>

Failing to find a panel-timing node is not an error in all cases, so do not output an error message in that case. Instead turn it into a debug message and make the drivers that care about it output an error message of their own.

---
 drivers/gpu/drm/panel/panel-lvds.c | 4 +++-
 drivers/video/fbdev/amba-clcd.c    | 4 +++-
 drivers/video/of_display_timing.c  | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/panel/panel-lvds.c +3 -1
index 1ec57d0806a8..7fcb3527c788 100644
@@ -147,8 +147,10 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds)
 	int ret;
 
 	ret = of_get_display_timing(np, "panel-timing", &timing);
-	if (ret < 0)
+	if (ret < 0) {
+		dev_err(lvds->dev, "%pOF: could not find panel timing\n", np);
 		return ret;
+	}
 
 	videomode_from_timing(&timing, &lvds->video_mode);
 
drivers/video/fbdev/amba-clcd.c +3 -1
index 89324e42a033..13df898a3481 100644
@@ -561,8 +561,10 @@ static int clcdfb_of_get_dpi_panel_mode(struct device_node *node,
 	struct videomode video;
 
 	err = of_get_display_timing(node, "panel-timing", &timing);
-	if (err)
+	if (err) {
+		pr_err("%pOF: could not find panel timing\n", node);
 		return err;
+	}
 
 	videomode_from_timing(&timing, &video);
 
drivers/video/of_display_timing.c +1 -1
index f5c1c469c0af..9385b518349f 100644
@@ -125,7 +125,7 @@ int of_get_display_timing(const struct device_node *np, const char *name,
 
 	timing_np = of_get_child_by_name(np, name);
 	if (!timing_np) {
-		pr_err("%pOF: could not find node '%s'\n", np, name);
+		pr_debug("%pOF: could not find node '%s'\n", np, name);
 		return -ENOENT;
 	}
 
Signature · 1 line
2.22.0
#1 lore raw

Hi Thierry.

Quoted 6 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Failing to find a panel-timing node is not an error in all cases, so do not output an error message in that case. Instead turn it into a debug message and make the drivers that care about it output an error message of their own.

This is more or less the same as already implmented by Douglas here:
https://patchwork.kernel.org/cover/11053243/

Doug's has an extra bug-fix that we shall not miss.

I am waiting for feedback from Bartlomiej before proceeding. I guess he is on holiday somewhere and will return soon.

Sam

Quoted 60 lines
---
 drivers/gpu/drm/panel/panel-lvds.c | 4 +++-
 drivers/video/fbdev/amba-clcd.c    | 4 +++-
 drivers/video/of_display_timing.c  | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/panel/panel-lvds.c +3 -1
index 1ec57d0806a8..7fcb3527c788 100644
@@ -147,8 +147,10 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds)
 	int ret;
 
 	ret = of_get_display_timing(np, "panel-timing", &timing);
-	if (ret < 0)
+	if (ret < 0) {
+		dev_err(lvds->dev, "%pOF: could not find panel timing\n", np);
 		return ret;
+	}
 
 	videomode_from_timing(&timing, &lvds->video_mode);
 
drivers/video/fbdev/amba-clcd.c +3 -1
index 89324e42a033..13df898a3481 100644
@@ -561,8 +561,10 @@ static int clcdfb_of_get_dpi_panel_mode(struct device_node *node,
 	struct videomode video;
 
 	err = of_get_display_timing(node, "panel-timing", &timing);
-	if (err)
+	if (err) {
+		pr_err("%pOF: could not find panel timing\n", node);
 		return err;
+	}
 
 	videomode_from_timing(&timing, &video);
 
drivers/video/of_display_timing.c +1 -1
index f5c1c469c0af..9385b518349f 100644
@@ -125,7 +125,7 @@ int of_get_display_timing(const struct device_node *np, const char *name,
 
 	timing_np = of_get_child_by_name(np, name);
 	if (!timing_np) {
-		pr_err("%pOF: could not find node '%s'\n", np, name);
+		pr_debug("%pOF: could not find node '%s'\n", np, name);
 		return -ENOENT;
 	}
 
Signature · 6 lines
2.22.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw

Hi Sam,

Quoted 10 lines · Sam Ravnborg

Hi Thierry.

Quoted 6 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Failing to find a panel-timing node is not an error in all cases, so do not output an error message in that case. Instead turn it into a debug message and make the drivers that care about it output an error message of their own.

Quoted 6 lines

This is more or less the same as already implmented by Douglas here:
https://patchwork.kernel.org/cover/11053243/

Doug's has an extra bug-fix that we shall not miss.

I am waiting for feedback from Bartlomiej before proceeding.

The patchset is in drm-misc-next tree now.

Quoted 1 line

I guess he is on holiday somewhere and will return soon.

I wish it was the case. ;-)

I've just been busy with other things (the patchset has been posted just few days ago and the issue addressed is not critical).

PS When I go on holidays I set automatic out of office reply and also announce it on the mailing-list (for longer holidays).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Quoted 55 lines

Sam

Quoted 53 lines
---
 drivers/gpu/drm/panel/panel-lvds.c | 4 +++-
 drivers/video/fbdev/amba-clcd.c    | 4 +++-
 drivers/video/of_display_timing.c  | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/panel/panel-lvds.c +3 -1
index 1ec57d0806a8..7fcb3527c788 100644
@@ -147,8 +147,10 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds)
 	int ret;
 
 	ret = of_get_display_timing(np, "panel-timing", &timing);
-	if (ret < 0)
+	if (ret < 0) {
+		dev_err(lvds->dev, "%pOF: could not find panel timing\n", np);
 		return ret;
+	}
 
 	videomode_from_timing(&timing, &lvds->video_mode);
 
drivers/video/fbdev/amba-clcd.c +3 -1
index 89324e42a033..13df898a3481 100644
@@ -561,8 +561,10 @@ static int clcdfb_of_get_dpi_panel_mode(struct device_node *node,
 	struct videomode video;
 
 	err = of_get_display_timing(node, "panel-timing", &timing);
-	if (err)
+	if (err) {
+		pr_err("%pOF: could not find panel timing\n", node);
 		return err;
+	}
 
 	videomode_from_timing(&timing, &video);
 
drivers/video/of_display_timing.c +1 -1
index f5c1c469c0af..9385b518349f 100644
@@ -125,7 +125,7 @@ int of_get_display_timing(const struct device_node *np, const char *name,
 
 	timing_np = of_get_child_by_name(np, name);
 	if (!timing_np) {
-		pr_err("%pOF: could not find node '%s'\n", np, name);
+		pr_debug("%pOF: could not find node '%s'\n", np, name);
 		return -ENOENT;
 	}
 
Quoted 2 lines
Quoted 2 lines
Signature · 1 line
2.22.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

Hi Bartlomiej Zolnierkiewicz

Quoted 19 lines

Hi Sam,

Quoted 15 lines · Sam Ravnborg

Hi Thierry.

Quoted 6 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Failing to find a panel-timing node is not an error in all cases, so do not output an error message in that case. Instead turn it into a debug message and make the drivers that care about it output an error message of their own.

This is more or less the same as already implmented by Douglas here:
https://patchwork.kernel.org/cover/11053243/

Doug's has an extra bug-fix that we shall not miss.

Quoted 7 lines
Quoted 1 line

I am waiting for feedback from Bartlomiej before proceeding.

The patchset is in drm-misc-next tree now.

Quoted 1 line

I guess he is on holiday somewhere and will return soon.

I wish it was the case. ;-)

Well, too hot here for work atm. But the farmers are happy.

Can you maybe find time to respond to this patch:
https://lists.freedesktop.org/archives/dri-devel/2019-July/228051.html

It already got ack from backligt people, but as it touches fbdev your feedback is required too.

Thanks,

Sam

#4 lore raw
Quoted 26 lines · Sam Ravnborg

Hi Bartlomiej Zolnierkiewicz

Quoted 25 lines

Hi Sam,

Quoted 10 lines · Sam Ravnborg

Hi Thierry.

Quoted 6 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Failing to find a panel-timing node is not an error in all cases, so do not output an error message in that case. Instead turn it into a debug message and make the drivers that care about it output an error message of their own.

Quoted 6 lines

This is more or less the same as already implmented by Douglas here:
https://patchwork.kernel.org/cover/11053243/

Doug's has an extra bug-fix that we shall not miss.

I am waiting for feedback from Bartlomiej before proceeding.

The patchset is in drm-misc-next tree now.

Quoted 1 line

I guess he is on holiday somewhere and will return soon.

Quoted 8 lines
Quoted 1 line

I wish it was the case. ;-)

Well, too hot here for work atm. But the farmers are happy.

Can you maybe find time to respond to this patch:
https://lists.freedesktop.org/archives/dri-devel/2019-July/228051.html

It already got ack from backligt people, but as it touches fbdev your feedback is required too.

LGTM. I've just posted my ACK in the reply to the patch.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel