arm64: smp: Mark expected switch fall-through
PATCH 3/3 arm64: smp: Mark expected switch fall-through
When fall-through warnings was enabled by default the following warning was starting to show up:
In file included from ../include/linux/kernel.h:15,
from ../include/linux/list.h:9,
from ../include/linux/kobject.h:19,
from ../include/linux/of.h:17,
from ../include/linux/irqdomain.h:35,
from ../include/linux/acpi.h:13,
from ../arch/arm64/kernel/smp.c:9:../arch/arm64/kernel/smp.c: In function ‘__cpu_up’:../include/linux/printk.h:302:2: warning: this statement may fall
through [-Wimplicit-fallthrough=]
printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~../arch/arm64/kernel/smp.c:156:4: note: in expansion of macro ‘pr_crit’
pr_crit("CPU%u: may not have shut down cleanly\n", cpu);
^~~~~~~../arch/arm64/kernel/smp.c:157:3: note: here
case CPU_STUCK_IN_KERNEL:
^~~~
Rework so that the compiler doesn't warn about fall-through.
Fixes d93512ef0f0e ("Makefile: Globally enable fall-through warning")
Signed-off-by Anders Roxell <[email protected]>
--- arch/arm64/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kernel/smp.c +1 -1
@@ -152,8 +152,8 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)pr_crit ("CPU%u: died during early boot\n" , cpu);break ; } -/* Fall through */ pr_crit ("CPU%u: may not have shut down cleanly\n" , cpu); +/* Fall through */ case CPU_STUCK_IN_KERNEL :pr_crit ("CPU%u: is stuck in kernel\n" , cpu);if (status &CPU_STUCK_REASON_52_BIT_VA )
Signature · 1 line
2.20.1