vhost: disable metadata prefetch optimization
Subsystems (5)
Michael S. Tsirkin
maintainerPATCH 1/1 vhost: disable metadata prefetch optimization
This seems to cause guest and host memory corruption. Disable for now until we get a better handle on that.
---
I put this in linux-next, we'll re-enable if we can fix the outstanding issues in a short order.
drivers/vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vhost/vhost.h +1 -1
@@ -96,7 +96,7 @@ struct vhost_uaddr { };#if defined(CONFIG_MMU_NOTIFIER ) &&ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE ==0 -#define VHOST_ARCH_CAN_ACCEL_UACCESS 1 +#define VHOST_ARCH_CAN_ACCEL_UACCESS 0#else #define VHOST_ARCH_CAN_ACCEL_UACCESS 0#endif
Signature · 1 line
MST
Quoted 8 lines · Michael S. Tsirkin
This seems to cause guest and host memory corruption. Disable for now until we get a better handle on that.
Signed-off-by Michael S. Tsirkin <[email protected]>---
I put this in linux-next, we'll re-enable if we can fix the outstanding issues in a short order.
Btw, is this more suitable to e.g revert the 842aa64eddacd23adc6ecdbc69cb2030bec47122 and let syzbot fuzz more on the current code?
I think we won't accept that patch eventually, so I suspect what syzbot reports today is a false positives.
Thanks
Quoted 9 lines
drivers/vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vhost/vhost.h +0
-0
drivers/vhost/vhost.h struct vhost_uaddr { · line 102
Quoted 8 lines
drivers/vhost/vhost.h +1
-1@@ -96,7 +96,7 @@ struct vhost_uaddr { };#if defined(CONFIG_MMU_NOTIFIER ) &&ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE ==0 -#define VHOST_ARCH_CAN_ACCEL_UACCESS 1 +#define VHOST_ARCH_CAN_ACCEL_UACCESS 0#else #define VHOST_ARCH_CAN_ACCEL_UACCESS 0#endif
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 8 lines · Michael S. Tsirkin
This seems to cause guest and host memory corruption. Disable for now until we get a better handle on that.
Signed-off-by Michael S. Tsirkin <[email protected]>---
I put this in linux-next, we'll re-enable if we can fix the outstanding issues in a short order.
Btw, is this more suitable to e.g revert the 842aa64eddacd23adc6ecdbc69cb2030bec47122 and let syzbot fuzz more on the current code?
I think we won't accept that patch eventually, so I suspect what syzbot reports today is a false positives.
Thanks
Quoted 17 lines
drivers/vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vhost/vhost.h +1
-1@@ -96,7 +96,7 @@ struct vhost_uaddr { };#if defined(CONFIG_MMU_NOTIFIER ) &&ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE ==0 -#define VHOST_ARCH_CAN_ACCEL_UACCESS 1 +#define VHOST_ARCH_CAN_ACCEL_UACCESS 0#else #define VHOST_ARCH_CAN_ACCEL_UACCESS 0#endif
Michael S. Tsirkin
maintainerQuoted 8 lines · Jason Wang
Quoted 6 lines · Michael S. Tsirkin
This seems to cause guest and host memory corruption. Disable for now until we get a better handle on that.
Signed-off-by Michael S. Tsirkin <[email protected]>---
Quoted 6 lines
Quoted 2 lines
I put this in linux-next, we'll re-enable if we can fix the outstanding issues in a short order.
Btw, is this more suitable to e.g revert the
842aa64eddacd23adc6ecdbc69cb2030bec47122
Yes I did that too.
Quoted 2 lines
and let syzbot fuzz more on the
current code?
Current metadata direct access code is known to corrupt guest and host memory - I don't feel we need more fuzzing.
Quoted 3 lines
I think we won't accept that patch eventually, so I suspect what syzbot reports today is a false positives.
Today's reports are real, it's a bug in my patch. But I reverted it - the below is an easier way to make sure at least linux-next is stable for everyone.
Quoted 8 lines
Thanks
Quoted 4 lines
drivers/vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines
drivers/vhost/vhost.h struct vhost_uaddr { · line 101
Quoted 12 lines
drivers/vhost/vhost.h +1
-1@@ -96,7 +96,7 @@ struct vhost_uaddr { };#if defined(CONFIG_MMU_NOTIFIER ) &&ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE ==0 -#define VHOST_ARCH_CAN_ACCEL_UACCESS 1 +#define VHOST_ARCH_CAN_ACCEL_UACCESS 0#else #define VHOST_ARCH_CAN_ACCEL_UACCESS 0#endif
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Michael S. Tsirkin
maintainerQuoted 8 lines · Jason Wang
Quoted 6 lines · Michael S. Tsirkin
This seems to cause guest and host memory corruption. Disable for now until we get a better handle on that.
Signed-off-by Michael S. Tsirkin <[email protected]>---
Quoted 6 lines
Quoted 2 lines
I put this in linux-next, we'll re-enable if we can fix the outstanding issues in a short order.
Btw, is this more suitable to e.g revert the
842aa64eddacd23adc6ecdbc69cb2030bec47122
Yes I did that too.
Quoted 2 lines
and let syzbot fuzz more on the
current code?
Current metadata direct access code is known to corrupt guest and host memory - I don't feel we need more fuzzing.
Quoted 3 lines
I think we won't accept that patch eventually, so I suspect what syzbot reports today is a false positives.
Today's reports are real, it's a bug in my patch. But I reverted it - the below is an easier way to make sure at least linux-next is stable for everyone.
Quoted 20 lines
Thanks
Quoted 16 lines
drivers/vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vhost/vhost.h +1
-1@@ -96,7 +96,7 @@ struct vhost_uaddr { };#if defined(CONFIG_MMU_NOTIFIER ) &&ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE ==0 -#define VHOST_ARCH_CAN_ACCEL_UACCESS 1 +#define VHOST_ARCH_CAN_ACCEL_UACCESS 0#else #define VHOST_ARCH_CAN_ACCEL_UACCESS 0#endif