Skip to contentSkip to conversation

tools/libxl: Add iothread support for COLO

PATCH Superseded Zhang Chen 2 participants 2 messages Jul 26, 2019

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Zhang Chen

author
#0 lore raw

PATCH v3 1/1 tools/libxl: Add iothread support for COLO

From: Zhang Chen <[email protected]>

Xen COLO and KVM COLO shared lots of code in Qemu.
The colo-compare object in Qemu now requires an 'iothread' property since QEMU 2.11.

Detail:
https://wiki.qemu.org/Features/COLO

---
 tools/libxl/libxl_dm.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
tools/libxl/libxl_dm.c +4 -1
index f4fc96415d..4b029d6c8e 100644
@@ -1635,7 +1635,10 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
                         nics[i].colo_compare_notify_dev) {
                         flexarray_append(dm_args, "-object");
                         flexarray_append(dm_args,
-                           GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s",
+                           GCSPRINTF("iothread,id=colo-compare-iothread-1"));
+                        flexarray_append(dm_args, "-object");
+                        flexarray_append(dm_args,
+                           GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s,iothread=colo-compare-iothread-1",
                                      nics[i].colo_compare_pri_in,
                                      nics[i].colo_compare_sec_in,
                                      nics[i].colo_compare_out,
Signature · 7 lines
2.17.GIT


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v3 1/1
#1 lore raw
Quoted 18 lines · Zhang Chen

From: Zhang Chen <[email protected]>

Xen COLO and KVM COLO shared lots of code in Qemu.
The colo-compare object in Qemu now requires an 'iothread' property since QEMU 2.11.

Detail:
https://wiki.qemu.org/Features/COLO

---
 tools/libxl/libxl_dm.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
tools/libxl/libxl_dm.c +0 -0
index f4fc96415d..4b029d6c8e 100644

tools/libxl/libxl_dm.c static int libxl__build_device_model_args_new(libxl__gc *gc, · line 1638

Quoted 5 lines
tools/libxl/libxl_dm.c +1 -1
@@ -1635,7 +1635,10 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
                         nics[i].colo_compare_notify_dev) {
                         flexarray_append(dm_args, "-object");
                         flexarray_append(dm_args,
-                           GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s",
+                           GCSPRINTF("iothread,id=colo-compare-iothread-1"));

You don't need GCSPRINTF here anymore ;-), in fact, it doesn't build with it. With that fix:

Thanks,

Signature · 6 lines
Anthony PERARD

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel